[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Aug 29 01:12:44 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Signed Off |Failed QA
--- Comment #37 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick,
starting with a first code review here:
1) There seem to be a few lines doubled up in AddIssue now:
$item->{'issues'}++;
if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) {
UpdateTotalIssues($item->{'biblionumber'}, 1);
}
$item->{'issues'}++;
if ( C4::Context->preference('UpdateTotalIssuesOnCirc') ) {
UpdateTotalIssues( $item->{'biblionumber'}, 1 );
}
2) This line is a change of behaviour: Before the change was dependent on the
system preference - now it will always happen?
- CartToShelf( $itemnumber ) if (
C4::Context->preference("ReturnToShelvingCart") );
+ CartToShelf( $itemnumber ) if ( $item->{'location'} eq 'CART' &&
$item->{'permanent_location'} ne 'CART' );
3) ReturnToShelvingCart is removed from the code, but the system preference is
not deleted in the database update.
4) koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js contains strings -
those can not be translated (js files can't be in general)
5) Tests are failing for me (run within koha-shell in kohadevbox):
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ perl
t/db_dependent/Circulation/issue.t
Global symbol "$item" requires explicit package name at
/home/vagrant/kohaclone/C4/Items.pm line 635.
Global symbol "$item" requires explicit package name at
/home/vagrant/kohaclone/C4/Items.pm line 635.
Can you please take a look?
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list