[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

--- Comment #67 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Nick, it's much more better, but there is something wrong.
The change to C4::Members::GetBorrowersToExpunge is not consistent: we expect
the subroutine behaves the same for patron list than for other params.
For instance, the category_code != 'S' and the guarantor tests are not done if
patron list is passed.
Moreover, it's not obvious that the patron_list_id is independent from other
params.
I'd say you should join the patron_list_patrons when the param is given.
There is also a lack of tests.

-- 
You are receiving this mail because:
You are watching all bug changes.