[Koha-bugs] [Bug 15739] Saving a new printer profile does not work
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Feb 4 03:49:36 CET 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15739
Chris Nighswonger <cnighswonger at foundations.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |In Discussion
--- Comment #1 from Chris Nighswonger <cnighswonger at foundations.edu> ---
Granted the error trapping here and feedback to the user leaves much to be
desired, however, the behavior is as expected. Looking here:
http://tinyurl.com/z3t845z
will show that what we do is run a parameter check when asked to create a new
Profile object. If all required parameters are not passed in, rather than
returning a new object, -1 is returned which causes the attempt to invoke the
save method to fail.
Its old code, and I never go back to adding proper error trapping. It really
should not return -1 in any case.
In light of that, this bug should probably be closed RESOLVED WORKSFORME and
another opened which addresses error trapping in the labels/patroncards code in
general.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list