[Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Jan 8 19:31:16 CET 2016
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133
Kyle M Hall <kyle at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #46167|0 |1
is obsolete| |
--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 46452
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46452&action=edit
Bug 14133: Print notices should be generated with the print template
If the overdue notice to send is an email or a SMS and the patron does
not provided such information, a print notice is generated.
But it will be generated with the email or sms template, which is not
useful, especially in the SMS case.
The template to use should be the print one.
Test plan:
0/ Does not apply this patch and Correctly define the overdue rules to generate
an overdue notice to the message_queue table.
Check email + SMS
1/ Define an email address and a SMS number for a patron
2/ Generate the overdue notices (misc/cronjobs/overdue_notices.pl [-t])
3/ 2 notices should have been generated:
mtt=email with the email template used
mtt=sms with the sms template used
4/ Truncate the message_queue table
5/ Remove the email address and repeat 2
6/ Only 1 notice should have been generated:
mtt=print with the email template used
7/ Truncate the message_queue table
8/ Remove the sms alert number and repeat 2
9/ 2 notices should have been generated:
mtt=print with the email template used (or sms I suppose)
10/ Apply this patch and repeat previous steps.
The print notices should be generated with the print template.
IMPORTANT NOTE: This test plan does not take into account the notices
generated for the staff ("These messages were not sent directly to the
patrons."). However the behavior will also change, the print template
will be used in all cases. Is it what we want?
Signed-off-by: Chris <chris at bigballofwax.co.nz>
Seems fine by me
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
The IMPORTANT NOTE change makes sense to me.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list