[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Jun 24 19:32:44 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006
--- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 52852
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52852&action=edit
Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport
The code in raw_transport includes setting a $SIG{ALRM}, but did not
use it. For consistency, we add an alarm statement here.
Similarly, we add the "three strikes" to raw_transport just as
telnet_transport does. Note that raw_transport still responds to other
requests, but will exit if there is no valid login within three
attempts. (If we want more restrictions, add them later?)
Test plan:
[1] Start sip session with telnet on raw port 6001.
Wait until it times out (probably the default 60 seconds).
[2] Change SIPconfig.xml: set timeout=5 for service port 6001.
Restart SIP and start another telnet 6001 session.
Did it timeout within 5 seconds?
[3] Start another 6001 session. Give three wrong requests or false
login attempts. Does the connection close?
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list