From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:08:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:08:18 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:08:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:08:20 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 --- Comment #8 from Jesse Weaver --- Created attachment 48480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48480&action=edit Bug 14659: (QA followup) show cardnumber for existing borrowers This would be incorrectly hidden when autoMemberNum is on. Jonathan, I believe this was probably the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:10:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:10:04 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14659 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:10:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:10:04 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:10:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:10:48 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:11:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:11:48 +0000 Subject: [Koha-bugs] [Bug 15942] add search box to top of SMS page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15942 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 15865 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:11:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:11:48 +0000 Subject: [Koha-bugs] [Bug 15865] Standard header search form missing from SMS cellular providers page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15865 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #4 from Owen Leonard --- *** Bug 15942 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:12:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:12:38 +0000 Subject: [Koha-bugs] [Bug 15943] SMS missing from admin sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15943 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 15864 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:12:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:12:38 +0000 Subject: [Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Owen Leonard --- *** Bug 15943 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:19:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:19:00 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #14 from Katrin Fischer --- I think there is something odd about the display - the result list seems to display all 264, while the detail view does only display one/some? But... totally unrelated to this patch - which works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:21:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:21:45 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:21:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:21:48 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47677|0 |1 is obsolete| | Attachment #47700|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 48481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48481&action=edit [SIGNED OFF] Bug 14304: RDA: Intranet display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for 264 for bug 14198 and reflect the Zebra indexing 'Provider' in detail page for Intranet. Test plan 1) Update zebra index if no Provider: index exist 2) Do a search by Provider: 3) Goto detail page for a record with 264 4) Look that there no display link for 264 field. 5) Apply the patch 6) Reload the page, notice about the link, click the link an confirm the new index Provider works fine 7) Test with multiple records with 260 and 264, if you prefer follow test plan for bug 14734 8) Access an RCAA2 record just with 260 field 9) Notice that 260 has been updated with Provider index too. NOTE: The intention of Provider index -according with documentation- is to collect multiples fields including 260, 264, 270, and 257 Sponsored-by: Universidad de El Salvador Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:22:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:22:17 +0000 Subject: [Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304 --- Comment #16 from Katrin Fischer --- Created attachment 48482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48482&action=edit [SIGNED OFF] Bug 14304: RDA: OPAC display link in XSLT for 264 field to reflect Zebra indexing This patch add display link in XSLT for field 264/bug 14198 and reflect the Zebra index 'Provider' in detail page for OPAC screen. To test: follow previous test plan Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:24:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:24:03 +0000 Subject: [Koha-bugs] [Bug 15944] New: Fix visibility of 'Place hold' links in the OPAC Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15944 Bug ID: 15944 Summary: Fix visibility of 'Place hold' links in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The 'place holds' link in the OPAC result list should only be visible, if a logged in user can actually place a hold. (see bug 5786 for some discussion). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:24:43 +0000 Subject: [Koha-bugs] [Bug 14792] Fix visibility check for 'place holds' link in OPAC result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14792 --- Comment #1 from Katrin Fischer --- *** Bug 15944 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:24:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:24:43 +0000 Subject: [Koha-bugs] [Bug 15944] Fix visibility of 'Place hold' links in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15944 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Forgot I already filed this... *** This bug has been marked as a duplicate of bug 14792 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 00:30:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 29 Feb 2016 23:30:34 +0000 Subject: [Koha-bugs] [Bug 15448] Suppressed items show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Can you share a bit more about your configuration? What's the exact entry in opachiddenitems? Does it work on the detail page? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 01:13:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 00:13:03 +0000 Subject: [Koha-bugs] [Bug 15945] New: Not redirected back to original page after login Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15945 Bug ID: 15945 Summary: Not redirected back to original page after login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org The changes in bug 15005 mean that you are no longer redirected to your original page after you log in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 01:13:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 00:13:03 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15945 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 02:08:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 01:08:25 +0000 Subject: [Koha-bugs] [Bug 15674] 'Show/hide columns' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 02:08:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 01:08:28 +0000 Subject: [Koha-bugs] [Bug 15674] 'Show/hide columns' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48428|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia --- Created attachment 48483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48483&action=edit [SIGNED-OFF] Bug 15674: Make "Column visibility" translatable The "Column visibility" text button was not translatable, now it is. Test plan: 1/ Update the template for a given language and translate the "Column visibility" string 2/ Go on admin/currency.pl => The string should be translated. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 03:25:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 02:25:10 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 03:26:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 02:26:28 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #1 from Mason James --- (In reply to Katrin Fischer from comment #0) > I did a quick test with the TrackClicks preference and it appears to break > URLs with multiple parameters? The second URL parameter is cut of for the > links I looked at: > > Without TrackClicks: > http://?identifier=1003033849-9-1373538128402- > 3&field=ALLEGROID > > With TrackClicks set to track anonymously: > > URL visible in the OPAC: > https:///cgi-bin/koha/tracklinks.pl?uri= > http://?identifier=1003033849-9-1373538128402- > 3&field=ALLEGROID;biblionumber=2647 > > URL it tries to access: > http://?identifier=1003033849-9-1373538128402-3 > ... will result in an error message in this case as an important bit is > missing. Oops, I just bumped into this too. I'll take a look now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 03:26:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 02:26:47 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 04:34:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 03:34:06 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #2 from Mason James --- Created attachment 48484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48484&action=edit Bug 14441 - TrackClicks cuts off/breaks URLs to test... 1/ set TrackClicks syspref to 'track' 2/ add a problematic multipart url to an item's 'url' field example url: http://foo.corg?key1=val1&key2=val2 3/ test url in opac-detail.pl - url is corrupt 4/ apply patch - url is corrct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 04:37:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 03:37:44 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48484|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 04:48:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 03:48:35 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 04:48:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 03:48:38 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #3 from Mason James --- Created attachment 48485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48485&action=edit Bug 14441 - TrackClicks cuts off/breaks URLs to test... 1/ set TrackClicks syspref to 'track' 2/ add a problematic multipart url to an item's 'url' field example url: http://foo.corg?key1=val1&key2=val2 3/ test url in opac-detail.pl - url is corrupt 4/ apply patch - url is corrct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 04:49:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 03:49:14 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 05:08:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 04:08:21 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #4 from Mason James --- Comment on attachment 48484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48484 Bug 14441 - TrackClicks cuts off/breaks URLs oops -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 05:26:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 04:26:26 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://devs.bywatersolution | |s.com/projects/enable-emoji | |-support-tags/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 07:17:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 06:17:49 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 07:34:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 06:34:16 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #22 from Josef Moravec --- Sorry, it was unintented, bad bug number :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 07:37:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 06:37:54 +0000 Subject: [Koha-bugs] [Bug 14435] The table saved_reports is never populated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435 --- Comment #23 from Katrin Fischer --- Can't count how often I mistype bug numbers... :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 07:45:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 06:45:09 +0000 Subject: [Koha-bugs] [Bug 15674] 'Show/hide columns' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- The QA tool is complaining :( FAIL koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc FAIL forbidden patterns forbidden pattern: simple-quote string (line 29) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 08:03:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 07:03:57 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #5 from Katrin Fischer --- Hm, I tested with 856 first, which is still broken, but this is a first partial fix. My test was with a search URL from the Koha OPAC: http://localhost:8080/cgi-bin/koha/catalogue/search.pl?idx=kw&q=der&sort_by=relevance_dsc&limit=su-to:Zeitschrift (kw: der and limit to one of the topic subjects) It will work for items with the patch, but not for the regular URL field in the bibliographic record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 08:05:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 07:05:51 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48485|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 48486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48486&action=edit [SIGNED OFF] Bug 14441 - TrackClicks cuts off/breaks URLs to test... 1/ set TrackClicks syspref to 'track' 2/ add a problematic multipart url to an item's 'url' field example url: http://foo.corg?key1=val1&key2=val2 3/ test url in opac-detail.pl - url is corrupt 4/ apply patch - url is corrct Signed-off-by: Katrin Fischer Only fixes the item URLs - a follow-up for the URLs in the bibliographic record (856 for MARC21) is still needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 08:05:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 07:05:48 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 08:23:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 07:23:47 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #7 from Katrin Fischer --- Fixing the URL encoding in the XSLT template is looking to be a lot harder, then fixing the problem in the templates :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:17:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:17:58 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:20:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:20:52 +0000 Subject: [Koha-bugs] [Bug 15945] Not redirected back to original page after login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15945 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 15816 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:20:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:20:52 +0000 Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m --- Comment #2 from Jonathan Druart --- *** Bug 15945 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:21:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:21:27 +0000 Subject: [Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816 [Bug 15816] Timeout login redirects to home page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:21:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:21:27 +0000 Subject: [Koha-bugs] [Bug 15816] Timeout login redirects to home page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:36:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:36:54 +0000 Subject: [Koha-bugs] [Bug 15674] 'Show/hide columns' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:36:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:36:57 +0000 Subject: [Koha-bugs] [Bug 15674] 'Show/hide columns' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 --- Comment #9 from Jonathan Druart --- Created attachment 48487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48487&action=edit Bug 15674: Use double-quote instead of simple-quote -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:54:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:54:03 +0000 Subject: [Koha-bugs] [Bug 15926] Item search fields admin missing help file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 09:54:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 08:54:06 +0000 Subject: [Koha-bugs] [Bug 15926] Item search fields admin missing help file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48410|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48488&action=edit Bug 15926: Add help for item search fields admin This patch will add the missing help file to the item search fields admin page. To test: * Go to administration > Item search fields * Click Help * Confirm help is there and correct. Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:12:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 09:12:57 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion --- Comment #3 from Jonathan Druart --- I am not sure about this patch: There are some other places where the string is hardcoded, at least: catalogue/moredetail.tt 77 [% IF ( ITEM_DAT.itemlost ) %]Lost[% END %] 78 [% IF ( ITEM_DAT.damaged ) %]Damaged[% END %] 79 [% IF ( ITEM_DAT.withdrawn ) %]Withdrawn[% END %] catalogue/detail.tt 662 [% IF ( item.withdrawn ) %] 663 Withdrawn 664 [% END %] And using the AV, the string is no longer translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:55:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 09:55:59 +0000 Subject: [Koha-bugs] [Bug 14753] Show accession date on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:56:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 09:56:02 +0000 Subject: [Koha-bugs] [Bug 14753] Show accession date on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48407|0 |1 is obsolete| | Attachment #48408|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 48489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48489&action=edit Bug 14753 - Show accession date on checkin This patch adds the dateaccessioned column fro an item to the display on returns.pl. The column is added with a CSS class for easy selection. To test: Check in some items Note date accessioned is not shown Apply patch Refresh page Check in some items See the added column 'Date acquired' Sponsored by: North Central Regional Library (ncrl.org) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:56:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 09:56:07 +0000 Subject: [Koha-bugs] [Bug 14753] Show accession date on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 --- Comment #15 from Jonathan Druart --- Created attachment 48490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48490&action=edit Bug 14753 - Use columns configuration for checkins table This patch adds the ability to configrue the visible columns on the check in screen. To test with both patches: 1 - Check in an item 2 - Note there is no 'Date acquired' column 3 - Apply patches 4 - Note there is still no 'Date acquired' column 5 - Note that there is now a "Show / hide columns" button 6 - Verify that you can check the box and view the 'Date acquired' column 7 - Verify that showing/hiding columns works (it will not carry over between items due to page reload) 8 - Verify that changes from the 'Configure columns' section of Administration hold between checkins Sponsored by: North Central Regional Library (ncrl.org) Signed-off-by: Marc V?ron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:56:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 09:56:12 +0000 Subject: [Koha-bugs] [Bug 14753] Show accession date on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 --- Comment #16 from Jonathan Druart --- Created attachment 48491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48491&action=edit Bug 14753: Add the "page" parameter in the yml file checkedintable is on the returns page Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:56:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 09:56:20 +0000 Subject: [Koha-bugs] [Bug 14753] Show accession date on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 --- Comment #18 from Jonathan Druart --- Created attachment 48493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48493&action=edit Bug 14753: Improve the table display - thead should contain a tr - use a correct dom for the table Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 10:56:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 09:56:16 +0000 Subject: [Koha-bugs] [Bug 14753] Show accession date on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 --- Comment #17 from Jonathan Druart --- Created attachment 48492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48492&action=edit Bug 14753: Use the KohaDates plugin to display dates Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:01:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:01:44 +0000 Subject: [Koha-bugs] [Bug 15946] New: Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15946 Bug ID: 15946 Summary: Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org For OAI-PMH we need to declare an header for the format MARCXML This header uses links to Library of Congress site. Those links are not well written, this error gives you problem with OAI-PMH validators like http://validator.oaipmh.com/. The problem is present in 3.22 and 3.20 also. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:05:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:05:55 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion --- Comment #6 from Jonathan Druart --- > - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384). Could you please revert this change? Before this patch, we had a validation on the MARC field values, now we don't. What happens if we enter 10 instead of 010, does it still work? I think we should add a validation on this form, but it's outside the scope of this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:06:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:06:22 +0000 Subject: [Koha-bugs] [Bug 15384] Items search fields: Change pull downs to input fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15887 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:06:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:06:22 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15384 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:06:46 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11425 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 [Bug 11425] Search form for items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:06:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:06:46 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 [Bug 15887] Revise layout and behavior of item search fields management -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:07:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:07:04 +0000 Subject: [Koha-bugs] [Bug 11425] Search form for items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15384 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15384 [Bug 15384] Items search fields: Change pull downs to input fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:07:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:07:04 +0000 Subject: [Koha-bugs] [Bug 15384] Items search fields: Change pull downs to input fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15384 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11425 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 [Bug 11425] Search form for items -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:07:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:07:49 +0000 Subject: [Koha-bugs] [Bug 15926] Item search fields admin missing help file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|3.20 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:28:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:28:09 +0000 Subject: [Koha-bugs] [Bug 15915] when creating a new child account the pop up guarantor_search.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15915 --- Comment #3 from Christophe Croullebois --- Hello Katrin, strange, for me too, of course I have cleaned my cache, but Julian from Biblibre on my ask try also, and for him it was ok. I'll try to change my BDD and find where is the issue. Thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:50:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:50:15 +0000 Subject: [Koha-bugs] [Bug 15946] Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15946 --- Comment #1 from Zeno Tajoli --- Created attachment 48494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48494&action=edit Fix for master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:50:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:50:46 +0000 Subject: [Koha-bugs] [Bug 15946] Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15946 --- Comment #2 from Zeno Tajoli --- Created attachment 48495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48495&action=edit Fix for 3.22 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:50:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:50:59 +0000 Subject: [Koha-bugs] [Bug 15946] Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15946 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:51:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:51:57 +0000 Subject: [Koha-bugs] [Bug 15946] Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15946 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:52:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:52:40 +0000 Subject: [Koha-bugs] [Bug 15946] Broken link to LoC in MARCXML declaration for OAI-PMH ListMetadataFormats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15946 --- Comment #3 from Zeno Tajoli --- This path fixes the value of xml schema variable and the link to Library of Congress. For Dublin Core format those values are defined in UNIMARCslim2OAIDC.xsl and MARC21slim2OAIDC.xsl. For MARCXML those values are writte into the code To test it: 1)Setup OAI-PMH 2)Test the site inserting the BaseURL into http://validator.oaipmh.com 3)See the problem with ListMetadataFormats [link: http://validator.oaipmh.com/#ListMetadataFormats] 4)Insert the patch 5)See the problem is over -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:54:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:54:44 +0000 Subject: [Koha-bugs] [Bug 15915] when creating a new child account the pop up guarantor_search.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15915 --- Comment #4 from Jonathan Druart --- Check the JS console and the Koha logs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 11:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 10:55:34 +0000 Subject: [Koha-bugs] [Bug 15915] when creating a new child account the pop up guarantor_search.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15915 --- Comment #5 from Katrin Fischer --- One of those annoying bugs... that don't happen to everyone. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:01:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:01:10 +0000 Subject: [Koha-bugs] [Bug 15939] modification logs view now silently defaults to only current day's actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:01:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:01:13 +0000 Subject: [Koha-bugs] [Bug 15939] modification logs view now silently defaults to only current day's actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 --- Comment #1 from Jonathan Druart --- Created attachment 48496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48496&action=edit Bug 15939: Action logs - Do not default dates to today When accessing the modification logs from a link that does not explicitly set the to and from dates (e.g., from patron or bib details), no results are displayed unless the object had an action occur during the current day. This is a side-effect of commit 5dceb851 for bug 13813. Test plan: - View the modification logs of a record which has already been modified (/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=XXX) => Without this patch, you won't see any logs (unless you have modified the record today) => With this patch, the behavior is the same as prior bug 13813 (you can check in 3.20.x), you will see all logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:01:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:01:26 +0000 Subject: [Koha-bugs] [Bug 15939] modification logs view now silently defaults to only current day's actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:07:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:07:52 +0000 Subject: [Koha-bugs] [Bug 12544] Send scheduled reports as an attachment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hblancoca at gmail.com --- Comment #9 from Jonathan Druart --- *** Bug 15917 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:07:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:07:52 +0000 Subject: [Koha-bugs] [Bug 15917] runreport.pl can not attach in email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15917 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Humberto, bug 12544 has been pushed to 3.23.x and will be in the next stable release: 3.24. Enhancements are not backported to stable branches. *** This bug has been marked as a duplicate of bug 12544 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:12:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:12:59 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |enhancement --- Comment #1 from Jonathan Druart --- I think "start with" has already been the default behavior. If you want to change that, you can do it using JS or you will need to add a new syspref. That is not a bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:20:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:20:49 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 --- Comment #2 from Nick Clemens --- (In reply to Jonathan Druart from comment #1) > I think "start with" has already been the default behavior. > That is not a bug. The other option is to remain with start with, but split terms. The change from a single result to no results on a full name search 'firstname lastname' is a bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:28:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:28:10 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #7 from Jonathan Druart --- I cannot apply this patch, bug 14694 needs a rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:31:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:31:21 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48141|0 |1 is obsolete| | --- Comment #2 from Alex Arnaud --- Created attachment 48497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48497&action=edit Bug 15832 - Fix items split-up in pendingreserves.tt Test plna: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - libraries filter should not contain duplicate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 12:31:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 11:31:45 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:07:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:07:34 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47176|0 |1 is obsolete| | Attachment #47177|0 |1 is obsolete| | Attachment #47866|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 48498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48498&action=edit Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:07:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:07:41 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #19 from Kyle M Hall --- Created attachment 48499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48499&action=edit Bug 14757 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:07:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:07:44 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #20 from Kyle M Hall --- Created attachment 48500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48500&action=edit Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it behind a syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:14:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:14:23 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:14:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:14:26 +0000 Subject: [Koha-bugs] [Bug 14441] TrackClicks cuts off/breaks URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14441 --- Comment #8 from Jonathan Druart --- Created attachment 48501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48501&action=edit Bug 14441: TrackClicks cuts off/breaks URLs (XSLT) Same test plan as previous patch, but for opac defail and result using the XSLT views. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:26:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:26:36 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15252 --- Comment #3 from Jonathan Druart --- See bug 15252. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:26:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:26:36 +0000 Subject: [Koha-bugs] [Bug 15252] Patron search on start with does not work with several terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15252 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15930 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:29:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:29:38 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 --- Comment #4 from Jonathan Druart --- (On the way, something to fix: members/member.tt 470 ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 13:40:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 12:40:58 +0000 Subject: [Koha-bugs] [Bug 14664] Harvesting records of an non-existent set, instead of an error return all the records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14664 U?ur Bulgan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ugurbulgan at sdu.edu.tr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:11:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:11:59 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Jonathan Druart --- t/db_dependent/Circulation/Renewal.t (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 7 tests but ran 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:14:10 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47562|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 48502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48502&action=edit Bug 15721: About page does not display Apache version This patch changes about.pl to get version information from C4::Context where applicable and fixes missing display of the Apache version e.g. for Apache/2.2.22 To test: - Without patch, open about page in staff client - Remember contents of tab 'Server information' (e.g. make a screenshot) - Apply patch - Verify, that the About page displays the same information as before rsp. additionally displays Apache version if it was missing without patch. Signed-off-by: Hector Castro Works as described Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:14:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:14:18 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48250|0 |1 is obsolete| | --- Comment #12 from Tom?s Cohen Arazi --- Created attachment 48503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48503&action=edit Bug 15721: (followup) Add apache2ctl to C4::Context::get_versions See comment #6 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:14:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:14:28 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 --- Comment #13 from Tom?s Cohen Arazi --- Created attachment 48504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48504&action=edit Bug 15721: (QA followup) pick the most probable first Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:14:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:14:39 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:14:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:14:46 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:26:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:26:33 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:26:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:26:37 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48376|0 |1 is obsolete| | Attachment #48377|0 |1 is obsolete| | Attachment #48480|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 48505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48505&action=edit Bug 14659: Allow patrons to enter card number and patron category on OPAC registration page Test plan: 1. Open OPAC self-registration page while logged out. 2. Note that cardnumber and categorycode are not shown. 3. Remove cardnumber and categorycode from PatronSelfRegistrationBorrowerUnwantedField. 4. Enable autoMemberNum. 5. Reload self-registration page, note that categorycode now shows. 6. Disable autoMemberNum. 7. Reload self-registration page, note that cardnumber now shows. 8. Try saving a patron with an existing cardnumber; this should fail and explain why. 9. Set CardnumberLength, and verify that those length restrictions are enforced. 10. Verify that patron can be created with custom categorycode and cardnumber. Signed-off-by: Michael Sauers Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:26:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:26:41 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 --- Comment #10 from Jonathan Druart --- Created attachment 48506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48506&action=edit Bug 14659: (QA followup) switch to using Koha::Patron::Categories Also, fix a nonsensically switched IF/ELSE. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:26:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:26:46 +0000 Subject: [Koha-bugs] [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 --- Comment #11 from Jonathan Druart --- Created attachment 48507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48507&action=edit Bug 14659: (QA followup) show cardnumber for existing borrowers This would be incorrectly hidden when autoMemberNum is on. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:45:41 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 --- Comment #7 from Owen Leonard --- (In reply to Jonathan Druart from comment #6) > > - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384). > > I think we should add a validation on this form, but it's outside the scope > of this patch. I think you're right that I'm pushing the limit on scope here, but I wonder if it isn't better for now to allow free entry on the form fields given the fact that in its current state there are some entries which cannot be made at all? Cait's comment on Bug 15384: > the subfield list is missing capital letters as often used for > additional item fields. If that doesn't sound like a good enough reason I'm happy to revise the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:47:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:47:29 +0000 Subject: [Koha-bugs] [Bug 15939] modification logs view now silently defaults to only current day's actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:47:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:47:32 +0000 Subject: [Koha-bugs] [Bug 15939] modification logs view now silently defaults to only current day's actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48496|0 |1 is obsolete| | --- Comment #2 from Galen Charlton --- Created attachment 48508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48508&action=edit Bug 15939: Action logs - Do not default dates to today When accessing the modification logs from a link that does not explicitly set the to and from dates (e.g., from patron or bib details), no results are displayed unless the object had an action occur during the current day. This is a side-effect of commit 5dceb851 for bug 13813. Test plan: - View the modification logs of a record which has already been modified (/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=XXX) => Without this patch, you won't see any logs (unless you have modified the record today) => With this patch, the behavior is the same as prior bug 13813 (you can check in 3.20.x), you will see all logs Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:51:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:51:04 +0000 Subject: [Koha-bugs] [Bug 15947] New: SIPILS.t should be moved to t/db_dependent Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Bug ID: 15947 Summary: SIPILS.t should be moved to t/db_dependent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: gmcharlt at gmail.com QA Contact: gmcharlt at gmail.com t/SIPILS.t, which was added in bug 15479, requires an active koha-conf.xml to pass, and consequently should be moved to t/db_dependent. This required patching around in order to build the 3.22.4 Debian packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:51:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:51:15 +0000 Subject: [Koha-bugs] [Bug 15947] SIPILS.t should be moved to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:53:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:53:27 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46440|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 48509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48509&action=edit Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match of ISSNs with or without hyphens. It uses Business::ISSN in order to follow the use of Business::ISBN and allow for validation of ISSNs To test: 1 - Find a record in your system with an ISSN (or add one) 2 - Stage a record containing the same ISSN but lacking a hyphen 3 - Matching on ISSN should find 0 matches 4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import 5 - Matching should find 0 6 - Apply patch 7 - Update datbase and install Business::ISSN 8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no change 9 - Set AggressiveMatchOnISSN as do and repeat original test 10 - You should find a match 11 - prove t/Koha.t - all tests pass Sponsored by North Central Regional Library System (NCRL) www.ncrl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:53:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:53:31 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46159|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 48510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48510&action=edit Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN This is an optional follow up depending on community opinion. While copying over the code form the ISBN portion I noticed that with aggressive matching enabled invalid ISBNs (and hence ISSNs) were being stripped from the record. I think in the case of a library exporting records, making changes, and reimporting they would expect to get a match on ISSN or ISBN whether or not the number is valid. This patch changes the subroutine to return the original ISSN in the case of it being invalid. To test: With first patch only export a record with an invalid ISSN and reimport with AggressiveMatchOnISSN enabled and match on ISSN - you should not get a match Apply this patch reimport the file and you should find a match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:55:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:55:21 +0000 Subject: [Koha-bugs] [Bug 15947] SIPILS.t should be moved to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 14:55:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 13:55:24 +0000 Subject: [Koha-bugs] [Bug 15947] SIPILS.t should be moved to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 --- Comment #1 from Galen Charlton --- Created attachment 48511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48511&action=edit Bug 15947: move SIPILS.t to DB-dependent test directory SIPILS.t requires an active koha-conf.xml to pass, and consequently is moved to t/db_dependent so that 'make test' can succeed. To test ------- [1] Unset KOHA_CONF and either do a make test or a prove -v t/SIPILS.t. Note that the tests fail. [2] Apply the patch and run make test again; this time, the test suite should pass. [3] Verify that with KOHA_CONF *set*, prove -v t/db_dependent/SIPILS.t passes. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:05:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:05:05 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #4 from Owen Leonard --- (In reply to Jonathan Druart from comment #3) > There are some other places where the string is hardcoded, at least: Those sound like issues which could be addressed in other bug reports. > And using the AV, the string is no longer translatable. True, but isn't that what we live with every time we use an authorized value? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:11:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:11:06 +0000 Subject: [Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to 'editable in OPAC' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #19 from Jonathan Druart --- It does not seem to work correctly, I'd like to get another signoff on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:13:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:13:09 +0000 Subject: [Koha-bugs] [Bug 15915] when creating a new child account the pop up guarantor_search.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15915 --- Comment #6 from Owen Leonard --- I think this is Bug 15916. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:17:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:17:19 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 --- Comment #1 from Owen Leonard --- Created attachment 48512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48512&action=edit Bug 15941 - The template for cloning circulation and fine rules says "issuing rules" The template for cloning circulation and fine rules should use the phrase "circulation and fine rules" instead of "issuing rules." Also changed: Added "Cancel" link to return the user to the circulation and fine rules page. To test, navigate directly to /cgi-bin/koha/admin/clone-rules.pl. The page title, breadcrumbs, and heading should all use the phrase "circulation and fine rules." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:17:17 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:24:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:24:50 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48509|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 48513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48513&action=edit Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match of ISSNs with or without hyphens. It uses Business::ISSN in order to follow the use of Business::ISBN and allow for validation of ISSNs To test: 1 - Find a record in your system with an ISSN (or add one) 2 - Stage a record containing the same ISSN but lacking a hyphen 3 - Matching on ISSN should find 0 matches 4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import 5 - Matching should find 0 6 - Apply patch 7 - Update datbase and install Business::ISSN 8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no change 9 - Set AggressiveMatchOnISSN as do and repeat original test 10 - You should find a match 11 - prove t/Koha.t - all tests pass Sponsored by North Central Regional Library System (NCRL) www.ncrl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:24:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:24:55 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48510|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 48514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48514&action=edit Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN This is an optional follow up depending on community opinion. While copying over the code form the ISBN portion I noticed that with aggressive matching enabled invalid ISBNs (and hence ISSNs) were being stripped from the record. I think in the case of a library exporting records, making changes, and reimporting they would expect to get a match on ISSN or ISBN whether or not the number is valid. This patch changes the subroutine to return the original ISSN in the case of it being invalid. To test: With first patch only export a record with an invalid ISSN and reimport with AggressiveMatchOnISSN enabled and match on ISSN - you should not get a match Apply this patch reimport the file and you should find a match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:26:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:26:34 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #5 from Jonathan Druart --- (In reply to Owen Leonard from comment #4) > (In reply to Jonathan Druart from comment #3) > > > There are some other places where the string is hardcoded, at least: > > Those sound like issues which could be addressed in other bug reports. I personally think we should fix all of them at the same time. > > And using the AV, the string is no longer translatable. > > True, but isn't that what we live with every time we use an authorized value? Yes, but for these 3 ones I am pretty sure everybody keeps the default value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:30:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:30:00 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 --- Comment #8 from Jonathan Druart --- (In reply to Owen Leonard from comment #7) > Cait's comment on Bug 15384: > > > the subfield list is missing capital letters as often used for > > additional item fields. > > If that doesn't sound like a good enough reason I'm happy to revise the > patch. The main reason to move it to its own bug report is that the fix could be backported to stable branches. If it is embedded to this patch (enh), it won't be easy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:33:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:33:57 +0000 Subject: [Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #6 from Owen Leonard --- (In reply to Jonathan Druart from comment #5) > I personally think we should fix all of them at the same time. I'd be happy to submit a follow-up for moredetail.tt and detail.tt. > Yes, but for these 3 ones I am pretty sure everybody keeps the default value. This bug exists because we use more than just the default value for lost, and damaged and we want to see those locally-defined values. Bug 11280 shows that there was a need for withdrawn to be the same. > catalogue/detail.tt > 662 [% IF ( item.withdrawn ) %] > 663 Withdrawn > 664 [% END %] catalogue/detail.tt already shows the authorized value description for lost and damaged. That it doesn't do so for withdrawn is a bug which should have been fixed by Bug 11280. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:51:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:51:22 +0000 Subject: [Koha-bugs] [Bug 14758] Re-engineer Talking Tech support in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Kyle M Hall --- This course of action would result in the loss of functionality. I will have to find an alternative approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:51:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:51:22 +0000 Subject: [Koha-bugs] [Bug 15279] Deprecate bespoke syntax for Slips and Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 Bug 15279 depends on bug 14758, which changed state. Bug 14758 Summary: Re-engineer Talking Tech support in Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:52:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:52:00 +0000 Subject: [Koha-bugs] [Bug 14758] Re-engineer Talking Tech support in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14757 | Blocks|15279 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 [Bug 15279] Deprecate bespoke syntax for Slips and Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:52:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:52:00 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14758 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 [Bug 14758] Re-engineer Talking Tech support in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:52:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:52:00 +0000 Subject: [Koha-bugs] [Bug 15279] Deprecate bespoke syntax for Slips and Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15279 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14758 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758 [Bug 14758] Re-engineer Talking Tech support in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:53:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:53:30 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 1 15:53:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Mar 2016 14:53:32 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48335|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 48515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48515&action=edit Bug 15887: Revise layout and behavior of item search fields management This patch adds some JavaScript to the item search fields management page so that the add form is not displayed by default. This simplifies the interface and makes it more consistent with other similar interfaces. Also changed in this patch: - Changing instances of "Items search fields" to "Item search fields." - Correct form structure to use ordered list - Add "required" classes and enable built-in JS form validation. - Add explicitly labeled "Choose" options to s. - Add missing ids to form fields (labels don't work without them). - Correct classes of message and alert dialogs. - Add JS confirmation of deletions. - Convert MARC tag and subfield dropdowns to regular inputs (Bug 15384). To test, apply the patch and go to Administration. - Confirm that the "Item search fields" link is correct. - Follow the link and confirm that the list of existing fields is shown by default, or a message saying there are no existing fields. - Click the "New search field" button and confirm that it displays the entry form. - Confirm that submitting an empty form does not work. - Confirm that clicking the "Cancel" link correctly hides the form. - Confirm that submitting valid data works correctly. - In the table of existing item search fields, confirm that the "Edit" button works correctly. - Confirm that submitting edits works correctly. - In the table of existing item search fields, confirm that clicking "Delete" highlights the row in question and a confirmation dialog appears. - Test both canceling and confirming deletion. Signed-off-by: Hector Castro Works as described. JSHint OK, koha-qa OK. Revision per QA: Undid the change making tag and subfield inputs text fields. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:07:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:07:24 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #195 from Jonathan Druart --- I have let some works to be done in comments 100-102 (see also Robin's kanban). It's not ready for production at all and people are waiting for this for 5 years now. It will be very weird not to provide something a bit more complete. The development is inactive for 6 months, and Robin has left the Koha project. We need a plan... The "let's push that and wait for people to open bug reports and enhancement requests" approach sounds a bit risky. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:08:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:08:42 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #196 from Chris Cormack --- Not as risky as making one massive bug that will never get pushed because it is too big to test properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:22:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:22:24 +0000 Subject: [Koha-bugs] [Bug 15718] Need more information for items that don't successfully batch checkout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15718 --- Comment #10 from Jonathan Druart --- (In reply to Heather Braum from comment #9) > Jonathan, > > Just tried to test batch checkout on BibLibre's sandbox #8 for bug 15920 > like you asked, and i?m getting this error, ?Software error: > > No branchcode argument passed to Koha::Calendar->new at > /home/koha/src/C4/Circulation.pm line 3528 > For help, please send mail to the webmaster (webmaster at test8-sandbox), > giving this error message and the time and date of the error.? It seems that at least 1 item does not have a holdingbranch defined, it's another bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:23:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:23:43 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #197 from Mirko Tietgen --- I think we should try to get it in and explicitly mark it as experimental. That would give interested (non-dev) parties the chance to try it and give feedback. I have spoken to a lot of people about Koha recently, and being able to test ES during their evaluation of the system would likely help some of them to make a decision in favour of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:29:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:29:15 +0000 Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48320|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 48540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48540&action=edit Bug 15888 - Syndetics Reviews preference should not enable LibraryThing reviews To test: 1 - Enable Syndetics Reviews without a LibraryThing ID 2 - Check page source and note you have a stanza for LTFL tabbed reveiws 3 - Apply patch 4 - Reload page and note LTFL tabbed reviews are not present 5 - Enter a LibraryThing ID and not the tab is restored. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:29:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:29:12 +0000 Subject: [Koha-bugs] [Bug 15888] Syndetics Reviews preference should not enable LibraryThing reviews In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15888 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:36:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:36:14 +0000 Subject: [Koha-bugs] [Bug 15350] DBIx::Class Startup speed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 --- Comment #4 from Jonathan Druart --- (In reply to Jesse Weaver from comment #3) > Created attachment 48519 [details] [review] > Bug 15350: Cache loaded DBIx::Class schema classes > > This separates the Koha::Schema creation into two stages: > > 1) The loading of the schemas themselves, which is done upon import of > Koha::Database. This requires moving the import of Koha::Schema from > an on-demand `require` to just a `use`; most everything in Koha uses > C4::Context, which will indirectly end up calling > Koha::Database->schema->new anyway, so this was no longer saving > anything. Yes, I totally agree. This was previously done when our Plack implementation was not considered stable and we did not want to load the schema everywhere. Now we want. > 2) The actual database connection, which is done by cloning the schema > created above and adding a database connection. I am not sure about this change, the Koha::Schema->connect will load all the classes (see Koha::Schema: 12 __PACKAGE__->load_namespaces;). > Note that this saves time only when a Plack-based Koha needs to create > a database connection, which is usually only the case for a new worker. > > Unscientific timings before patch: > * First load of koha2marclinks.pl on a new worker: 0.70 seconds > * Each load after: 0.17 seconds > > After patch: > * First load: 0.31 seconds > * Each load after: 0.17 seconds Are you sure it's brought by the ->clone call or just the move from require to use? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:38:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:38:25 +0000 Subject: [Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47738|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 48541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48541&action=edit Bug 15755: Display default item type as "All" in circ rules Bug 15354 did not fix correctly the issue with the item type display. The default item type '*' should be "All", at the moment nothing is displayed in the column. Test plan: 1/ Define a rule for default item types (All/*) and for specific item types. 2/ Translate some item type descriptions used in previous step 3/ Default item type should be "All" and correct translations should be displayed. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:38:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:38:23 +0000 Subject: [Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 09:58:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 08:58:02 +0000 Subject: [Koha-bugs] [Bug 15937] Batch checkout buggy behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937 --- Comment #1 from Jonathan Druart --- (In reply to H?ctor Eduardo Castro Avalos from comment #0) > For damaged items the warning message is not displayed, and Koha let to > checkout the item as shown in the image. > This is the behavior for normal checkouts, there is no alert. > I notice about a buggy behavior in this functionallity, for example the > program let to checkout the first item available without confirm the > checkout message, for example, Maxwell's handbook was borrowed/renewed to > this patron every time in which I repeat the process. > > When the process end, you will presented with this table > (), one > items was checked-out and the others wasn't, but the message is not clear > whether those items was checked out or not. No information means "everything went fine", when you get a red alert it's "checkout impossible". > Another thing that I could observe is: if circ policies only allow an > specific number e.g. two checkouts and two renews of an item the module > doesn't let to checkout if patron has one or more checkouts and the message > displayed for the program is not clear; If MaxFine is set affect in the > checkouts and don't let us checkout as show in the previous image, and as > before, the message doesn't provide an adequate information. What's the message displayed? What do you suggest? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 10:07:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 09:07:28 +0000 Subject: [Koha-bugs] [Bug 15825] Patron lists does not show tools menu sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15825 Francesca changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |francescalamoore at gmail.com CC| |francescalamoore at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:02:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 10:02:39 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #198 from Katrin Fischer --- We should avoid to repeat the Solr problem - I think part of the problem was that it was not production ready when included in Koha and I'd hate to see us get stuck in a similar way with ES. I think some good information/documentation about what works and what works not (yet) would be good. I am thinking about a wiki page - with more end user oriented information - which system preferences are supported, why does a search x result in y...(FAQ?), how to configure in the GUI, and fill in any gaps while testing. I could start a page, but will need help filling in the information and also to get ES running on my computer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:16:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 10:16:34 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #199 from Jonathan Druart --- I would like to get other opinions on the discussion on comment 38 and comment 39 about the idea to reuse existing search scripts and templates. IMO it will be a mess in a near future: 1/ we will want to implement things for ES, not supported by Zebra 2/ at some point the features already implemented for Zebra won't be available for ES => We will have to write switch (if se=='es' {} elsif se == 'zebra') everywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:18:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 10:18:37 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #200 from Jonathan Druart --- And I would also like to know who has already looked at the ES implementation and get their feedbacks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 11:34:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 10:34:45 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #20 from Josef Moravec --- Created attachment 48542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48542&action=edit Bug 14168 - Followup: make module WWW::YouTube::Download required Module C4::HTML5Media is used in detail.pl, so if you don't have installled module for YouTube, you get an internal server error. This patch make module WWW::YouTube::Download required and adds it to package dependencies Test plan: 1. Don't have installed module WWW::YouTube:Download, neither package libwww-youtube-download-perl 2. Try to access biblio detail in staff client (detail.pl) - you'll be presented withh internal server error 3. Check the About page -> Perl modules, the WWW::YouTube::Download should be reported as missing optional 4. Apply the patch 5. Check the About page -> Perl modules, the WWW::YouTube::Download should now be reported as missing required 6. Create and install debian package, the libwww-youtube-download-perl should be the dependency and so installed with koha-common package (use apt-get install -f, if neccessery) 7. Check the About page -> Perl modules, the WWW::YouTube::Download should now be reported as Module current 8. Try to access biblio detail in staff client (detail.pl) - it should be display, no error now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 12:30:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 11:30:04 +0000 Subject: [Koha-bugs] [Bug 15954] New: Availability issue after entering 856 electronic links Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15954 Bug ID: 15954 Summary: Availability issue after entering 856 electronic links Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: willem at cfce.org.za QA Contact: testopia at bugs.koha-community.org When I've entered a biblio and item, the page opac-search.pl reflects correctly the Availability of the object (ie. Copies available at xxx). However, as soon as I add 856 field info about electronic accessibility, the availability info disappears. Still, after clicking on the specific item, opac-detail.pl shows the availability of items correctly. I can also still filter on availability in opac-search.pl, although it doesn't show that the things are available, it correctly filters the available items. It doesn't occur as a known issue. Am I the first person with this problem? I'm using koha 3.00 Thanks, Willem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 12:37:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 11:37:44 +0000 Subject: [Koha-bugs] [Bug 15874] koha-dump should provide a way to exclude any database table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15874 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 12:52:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 11:52:50 +0000 Subject: [Koha-bugs] [Bug 11285] Vocabulary disambiguation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285 --- Comment #23 from Josef Moravec --- I faced up another ambigous term: "Order" in acquisition "Order" as sort order - modification templates (and maybe more) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:03:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 12:03:09 +0000 Subject: [Koha-bugs] [Bug 15955] New: Tuning function 'New child record' fro Unimarc Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Bug ID: 15955 Summary: Tuning function 'New child record' fro Unimarc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:06:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 12:06:30 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' fro Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Small patch --- Comment #1 from Zeno Tajoli --- This bug is only for Unimarc. When you create a son record with the funcion 'New child record' and EasyAnalitics is off, in Unimarc we tring to insert the value of ediction field (205$a) in subfield $a of 461. This is wrong. Inf fact in 461 is not possible to insert ediction value. This is possible only in MARC21, not in UNIMARC standard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:38:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 12:38:15 +0000 Subject: [Koha-bugs] [Bug 15956] New: Rearranging some SIP unit tests (test without SIP server) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Bug ID: 15956 Summary: Rearranging some SIP unit tests (test without SIP server) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: m.de.rooy at rijksmuseum.nl QA Contact: gmcharlt at gmail.com This report is a follow-up for bug 13871 and bug 15947. The two tests SIP_ILS.t and SIPILS.t (what's in a name) will be broken into a few more specific tests. Will add tests for handling Patron Status request and Patron Info request too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:38:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 12:38:48 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |m.de.rooy at rijksmuseum.nl Status|NEW |ASSIGNED Patch complexity|--- |Small patch Depends on| |15947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 [Bug 15947] SIPILS.t should be moved to t/db_dependent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:38:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 12:38:48 +0000 Subject: [Koha-bugs] [Bug 15947] SIPILS.t should be moved to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 [Bug 15956] Rearranging some SIP unit tests (test without SIP server) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 12:39:29 +0000 Subject: [Koha-bugs] [Bug 15947] SIPILS.t should be moved to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 --- Comment #4 from Marcel de Rooy --- Will add a follow-up under new report: bug 15956. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:51:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 12:51:01 +0000 Subject: [Koha-bugs] [Bug 15954] Availability issue after entering 856 electronic links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15954 --- Comment #1 from Owen Leonard --- Can you please verify Koha's version number by going to the "About" page in the staff client? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 13:52:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 12:52:16 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Tuning function 'New child |Tuning function 'New child |record' fro Unimarc |record' for Unimarc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:04:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 13:04:58 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 --- Comment #2 from Zeno Tajoli --- Created attachment 48543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48543&action=edit New child record patch Unimarc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:05:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 13:05:58 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Zeno Tajoli --- To Test: 1)Check to have EasyAnalyticalRecords on 'off' 2)Check to use UNIMARC 3)Create a record with data in 200$a (title), 205$a (ediction), 700 (author) 215$a(Place), 215$d(date) 4)From those record create a child using 'New'->'New child record' 5)See the values in 461 tag: You can see that in 461$a there is the value of 205$a from father This is wrong, you need to have the value of 700 $a and $b from father record. 6)Appy the patch 7)Redo 4-5 8)Now 461 is good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:47:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 13:47:08 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 --- Comment #1 from Marcel de Rooy --- Created attachment 48544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48544&action=edit Bug 15956: Rearranging some SIP unit tests The original SIP_ILS.t is split up into SIP/Patron.t and SIP/Transaction.t. The assumption on a hardcoded existing and non-existing card number is replaced by adding and deleting a card number (:patron) with TestBuilder. Test plan: Run SIP/Patron.t Run SIP/Transaction.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:47:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 13:47:11 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 --- Comment #2 from Marcel de Rooy --- Created attachment 48545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48545&action=edit Bug 15956: Remove warn from handle_patron_status Removes a warn and some commented warns. Test plan: Nothing to do here. Will be covered later by additional unit test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 14:47:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 13:47:15 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 --- Comment #3 from Marcel de Rooy --- Created attachment 48546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48546&action=edit Bug 15956: Move SIPILS.t to SIP/ILS.t Move the file. Some trivial (cosmetic) edits: whitespace, comments. Test plan: Run SIP/ILS.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:01:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 14:01:54 +0000 Subject: [Koha-bugs] [Bug 15957] New: Move AO in Patron Status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15957 Bug ID: 15957 Summary: Move AO in Patron Status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:04:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 14:04:51 +0000 Subject: [Koha-bugs] [Bug 15954] Availability issue after entering 856 electronic links In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15954 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from Owen Leonard --- > 3.00.01.005 I'm sorry, that version of Koha is much much too old for us to be able to help you with it. The latest stable versions of Koha are years ahead of that, and you should try to upgrade as soon as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 15:36:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 14:36:38 +0000 Subject: [Koha-bugs] [Bug 15935] Provide koha-cleanup-database command for package install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15935 Ian Palko changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Ian Palko --- (In reply to Katrin Fischer from comment #1) > Hi Ian, > > koha-cleanup-database is supposed to be run as a daily cronjob and normally > not run manually. If you look into your cronjob configuration you can change > the options it's run with to fit your library's needs and clean up the > z39.50 imported records regularly. > > There is also a tool that helps to run any of the scripts from command line > - it sets up all the right environment variables for you: > https://wiki.koha-community.org/wiki/ > Commands_provided_by_the_Debian_packages#koha-shell Katrin, Thanks for the information. Somehow I missed the koha-shell. After a number of years of Koha, you'd think I'd be more diligent in reading documentation. The reason for the manual command started with Kyle Hall's sugggeston and highlighting the database bloat with z39.50 records. Also, our cronjobs are not running as expected. I suspect a local configuration problems, even though it's a fresh vanilla package setup. The koha-shell does do what I needed without a new command, so I'll close the enhancement bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:02:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 15:02:49 +0000 Subject: [Koha-bugs] [Bug 15937] Batch checkout buggy behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937 --- Comment #2 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #1) >No information means "everything went fine", when you get a red alert it's "checkout impossible". Prefix at least "Cannot check out. The patron has a debt of 10.0" And again Koha let to checkout the first item without await for confirmation, i.e., the expected behavior is: 1) enter the barcodes 2) show table with checkboxes in titles, no checkout yet at this point, but program checkout the first item in the table 3) Confirm checkout 4) The table with all items checked out is presented. >What's the message displayed? What do you suggest? Alert message about status of MaxFine for example, MaxFine=10 If patron has a debt about $ 10.00 or less, some items will not check out Or Some items will not check out if patron has a debt or has some items checked out. Review the circulation policies for patron category and MaxFine syspref to see how many items you can check out to this patron. NOTE: This feature isn't in help page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:07:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 15:07:57 +0000 Subject: [Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to SC but fails to checkin item on Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039 --- Comment #2 from Colin Campbell --- I managed to reproduce this when Barry first reported it. But rerunning the test script I used then against master the buggy behaviour does not occur, nor with the current 3.22 and 3.20 releases. I wonder if a subsequent patch to C4/Circulation or the ILS routines has rectified this as a side effect -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:23:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 15:23:57 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:24:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 15:24:18 +0000 Subject: [Koha-bugs] [Bug 14712] Feature for controlling cron jobs/cmd line scripts from staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14712 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 16:57:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 15:57:23 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 --- Comment #4 from Marcel de Rooy --- Created attachment 48547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48547&action=edit Bug 15956: New unit test SIP/Message.t This patch adds a unit test for testing all handlers in MsgType.pm. For a start, we test the handler for Patron Status requests. A next patch will add tests for Patron Info requests. And hopefully the other handlers will follow.. Note: The tests have been written for SIP protocol version 2. Test plan: Run t/db_dependent/SIP/Message.t If bug 13871 has not yet been pushed, test 12 (subtest 1) will fail. That is no problem. After that push, all tests should no longer fail. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:03:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:03:05 +0000 Subject: [Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:03:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:03:07 +0000 Subject: [Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951 --- Comment #1 from Owen Leonard --- Created attachment 48548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48548&action=edit Bug 15951 - Use Font Awesome icons for acquisitions order cancellation confirmation In Acquisitions, when you delete (cancel) an order, a dialog asks you to confirm. This dialog should be styled with Font Awesome icons. Other minor edit: Changing page grid style for centered main content area. To test, apply the patch and locate a basket in Acquisitions with an order. - View the details for the basket. - Click the 'Delete' link next to the order you want to delete. - Confirm that the dialog is correctly styled. - Test the cancel operation and verify that you are correctly redirected back to where you were. - Test the confirmation operation and verify that your order is deleted. - Also test the deletion process from Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt page -> Delete order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:15:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:15:46 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #7 from Nicole C. Engard --- Work to be done: * Fix storage of Emoji characters in the database ** Emoji characters are supported in Unicode: http://www.unicode.org/emoji/charts/full-emoji-list.html * Research and implement tools to display Emojis properly in the Staff and OPAC Seeking co-sponsors: http://devs.bywatersolutions.com/projects/enable-emoji-support-tags/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:31:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:31:50 +0000 Subject: [Koha-bugs] [Bug 15958] New: ZOOM/Zebra-connection cache flushing Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15958 Bug ID: 15958 Summary: ZOOM/Zebra-connection cache flushing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org When writing tests related to searching, When searching the local index repeatedly, changes in the index are not applied to the search results if the results always return the same records. This is due to ZOOM caching the results. This feature adds a ZOOM::Connection flushing subroutine to get rid of old caches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:32:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:32:44 +0000 Subject: [Koha-bugs] [Bug 15958] ZOOM/Zebra-connection cache flushing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15958 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 48549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48549&action=edit Bug 15958 - ZOOM/Zebra-connection cache flushing When writing tests related to searching, When searching the local index repeatedly, changes in the index are not applied to the search results if the results always return the same records. This is due to ZOOM caching the results. This feature adds a ZOOM::Connection flushing subroutine to get rid of old caches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:33:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:33:32 +0000 Subject: [Koha-bugs] [Bug 15958] ZOOM/Zebra-connection cache flushing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15958 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:35:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:35:45 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15959 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 [Bug 15959] Use Font Awesome icons for attach item confirmations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:35:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:35:45 +0000 Subject: [Koha-bugs] [Bug 15959] New: Use Font Awesome icons for attach item confirmations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Bug ID: 15959 Summary: Use Font Awesome icons for attach item confirmations Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/moveitem.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 15785 In the catalog, when you use the "Edit -> Attach item" menu option, the confirmation and error dialogs should be styled with Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:36:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:36:35 +0000 Subject: [Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:36:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:36:37 +0000 Subject: [Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 --- Comment #3 from Nicole C. Engard --- Created attachment 48550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48550&action=edit [SIGNED-OFF] Bug 15864 - SMS cellular providers link missing from administration sidebar menu When the SMSSendDriver system preference is set to "Email" a link to the SMS cellular providers management page should appear in the left-hand sidebar menu on Administration pages. This patch adds the link to admin-menu.inc. To test, apply the patch set your SMSSendDriver system preference to "Email." View various Administration pages which show the left-hand sidebar menu and confirm that "SMS cellular providers" is in the list. Empty the SMSSendDriver preference and confirm that the link no longer appears. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:38:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:38:08 +0000 Subject: [Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:44:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:44:39 +0000 Subject: [Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:44:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:44:41 +0000 Subject: [Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 --- Comment #1 from Owen Leonard --- Created attachment 48551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48551&action=edit Bug 15959 - Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:51:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:51:46 +0000 Subject: [Koha-bugs] [Bug 15825] Patron lists does not show tools menu sidebar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15825 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Templates Assignee|francescalamoore at gmail.com |oleonard at myacpl.org CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:52:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:52:19 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:58:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:58:36 +0000 Subject: [Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 17:58:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 16:58:38 +0000 Subject: [Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48200|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48552&action=edit [SIGNED-OFF] Bug 15672 - Show descriptions instead of codes on the hold ratios report This patch revises the hold ratios report so that it uses template plugins to display descriptions instead of codes for item holding branch, item home branch, item type, and library name. To test you should have multiple items on the hold ratio report (set the ratio to a small number to increase the number of results). It should include one or more items which have a shelving location set. View the hold ratios report and confirm that library names, shelving location descriptions, and item type descriptions are shown instead of codes. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:12:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 17:12:02 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:12:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 17:12:04 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48460|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 48554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48554&action=edit [SIGNED-OFF] Bug 15936 - Revise layout and behavior of SMS cellular providers management This patch changes the behavior of the SMS cellular providers management page so that sections of the page are shown or hidden based on what the current task is. Other changes include: - Moving JavaScript to a separate file - Adding a toolbar with a "New SMS provider" button. - Adding the "generic" catalog search header form to the top of the page. - Adding "Required" classes to required fields so that the staff client's built-in JS validation library can be used. To test, the SMSSendDriver system preference must be set to "Email." Apply the patch and go to Administration -> SMS cellular providers. - Confirm that the add/edit form is hidden initially. A toolbar with a "New SMS provider" button should appear with existing SMS cellular providers in a table below. If there are no existing providers a message dialog should say so. - Confirm that the "New SMS provider" button works: - The table should be hidden and an empty "add" form displayed. - Confirm that an empty form cannot be submitted. - Confirm that submitting valid data works. - Confirm that clicking the "Cancel" button hides the form and redisplays the table. - Test the "edit" button for an existing provider: - Confirm that the edit form is displayed and populated with the correct data. - Confirm that edits are saved correctly. - When viewing the table of existing providers, confirm that clicking the "Delete" button triggers a confirmation dialog. Test both cancelling and confirming that dialog. - Ponder whether all this is an improvement or not. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:12:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 17:12:26 +0000 Subject: [Koha-bugs] [Bug 15961] New: Use Font Awesome icons for confirmation of currency deletion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Bug ID: 15961 Summary: Use Font Awesome icons for confirmation of currency deletion Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/currency.pl?op=delete_confirm OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 15785 When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:12:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 17:12:26 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15960 Blocks| |15961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15960 [Bug 15960] Use Font Awesome icons for classification filing rule deletion error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 [Bug 15961] Use Font Awesome icons for confirmation of currency deletion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:29:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 17:29:33 +0000 Subject: [Koha-bugs] [Bug 15962] New: Currency deletion doesn't correctly identify currencies in use Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Bug ID: 15962 Summary: Currency deletion doesn't correctly identify currencies in use Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/currency.pl?op=delete_confirm OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org currency.pl tries to see if a currency is active before deleting it: my $total_row = $dbh->selectrow_hashref( 'select count(*) as total from aqbooksellers where currency=?', {}, $curr ); However it doesn't look like the currency column in aqbooksellers is used (anymore?). It looks to me like there are two columns to check: List prices aqbooksellers.listprice) and invoice price (aqbooksellers.invoiceprice). If you try to delete a currency which is in use as a list or invoice price in a vendor record the process will fail silently: currency.pl: DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`aqbasket`, CONSTRAINT `aqbasket_ibfk_3` FOREIGN KEY (`basketgroupid`) REFERENCES `aqbasketgroups` (`id`) ON UPDATE CASCADE) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:41:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 17:41:58 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 18:42:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 17:42:00 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 --- Comment #1 from Owen Leonard --- Created attachment 48555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48555&action=edit Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:24:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:24:00 +0000 Subject: [Koha-bugs] [Bug 15963] New: Use Font Awesome icons for confirmation after deleting MARC tag Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963 Bug ID: 15963 Summary: Use Font Awesome icons for confirmation after deleting MARC tag Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/marctagstructure.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 15785 After deleting a MARC tag the user is presented with a confirmation dialog which should use Font Awesome. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:24:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:24:00 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963 [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:32:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:32:51 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48077|0 |1 is obsolete| | --- Comment #41 from R?mi Mayrand-Provencher --- Created attachment 48556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48556&action=edit Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on current master for testing) http://bugs.koha-community.org/show_bug.cgi?id=11879 To test this patch: Update database Edit a borrower's informations. The "Main Contact Method" selectbox appears in the form and its value is correctly. Works as expected. For handling of syspref BorrowerUnwantedField use second patch- Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:33:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:33:03 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48078|0 |1 is obsolete| | --- Comment #42 from R?mi Mayrand-Provencher --- Created attachment 48557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48557&action=edit Bug 11879 - Fix syspref BorrowerUnwantedField How I tested: Apply 1st patch Apply this patch Edit syspref BorrowerUnwantedField to exclude fields Edit patron's contact information Make sure that fields do not longer appear in drop down for Main contact Wors as expected http://bugs.koha-community.org/show_bug.cgi?id=11879 Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:33:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:33:14 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48079|0 |1 is obsolete| | --- Comment #43 from R?mi Mayrand-Provencher --- Created attachment 48558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48558&action=edit Bug 11879 - Update BDIx schema and show main contact method in moremember.pl Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:33:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:33:22 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 --- Comment #44 from R?mi Mayrand-Provencher --- Created attachment 48559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48559&action=edit Bug 11879 QA follow-up Changed "Mobile Phone" to Other Phone, modified deletedborrowers table structute and added the field in opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:33:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:33:45 +0000 Subject: [Koha-bugs] [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963 --- Comment #1 from Owen Leonard --- Created attachment 48560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48560&action=edit Bug 15963 - Use Font Awesome icons for confirmation after deleting MARC tag This patch revises the dialog which appears after you have deleted a MARC tag. To test, apply the patch and go to Administration -> MARC frameworks -> MARC sturcture -> Delete. - Confirm that you want to delete a MARC tag. - Verify that the confirmation dialog you are shown is styled correctly. - Verify that clicking "OK" redirects you to the right place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:33:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:33:43 +0000 Subject: [Koha-bugs] [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:34:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:34:39 +0000 Subject: [Koha-bugs] [Bug 11879] Add a new borrower field : main contact method. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:37:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:37:39 +0000 Subject: [Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48548|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48561&action=edit [SIGNED-OFF]Bug 15951: Use Font Awesome icons for acquisitions order cancellation confirmation In Acquisitions, when you delete (cancel) an order, a dialog asks you to confirm. This dialog should be styled with Font Awesome icons. Other minor edit: Changing page grid style for centered main content area. To test, apply the patch and locate a basket in Acquisitions with an order. - View the details for the basket. - Click the 'Delete' link next to the order you want to delete. - Confirm that the dialog is correctly styled. - Test the cancel operation and verify that you are correctly redirected back to where you were. - Test the confirmation operation and verify that your order is deleted. - Also test the deletion process from Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt page -> Delete order. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:38:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:38:16 +0000 Subject: [Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:52:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:52:40 +0000 Subject: [Koha-bugs] [Bug 15964] New: Cannot view detail bib record because missing perl module WWW::YouTube::Download Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 Bug ID: 15964 Summary: Cannot view detail bib record because missing perl module WWW::YouTube::Download Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl WWW::YouTube::Download needs to be marked as required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:55:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:55:24 +0000 Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 --- Comment #1 from H?ctor Eduardo Castro Avalos --- Created attachment 48562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48562&action=edit [SIGNED-OFF]Bug 15964: Followup: make module WWW::YouTube::Download required Module C4::HTML5Media is used in detail.pl, so if you don't have installled module for YouTube, you get an internal server error. This patch make module WWW::YouTube::Download required and adds it to package dependencies Test plan: 1. Don't have installed module WWW::YouTube:Download, neither package libwww-youtube-download-perl 2. Try to access biblio detail in staff client (detail.pl) - you'll be presented withh internal server error 3. Check the About page -> Perl modules, the WWW::YouTube::Download should be reported as missing optional 4. Apply the patch 5. Check the About page -> Perl modules, the WWW::YouTube::Download should now be reported as missing required 6. Create and install debian package, the libwww-youtube-download-perl should be the dependency and so installed with koha-common package (use apt-get install -f, if neccessery) 7. Check the About page -> Perl modules, the WWW::YouTube::Download should now be reported as Module current 8. Try to access biblio detail in staff client (detail.pl) - it should be display, no error now Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:55:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:55:46 +0000 Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:57:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:57:48 +0000 Subject: [Koha-bugs] [Bug 15794] Allow the use of emojis as tags on records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |Seeking cosponsors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:58:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:58:23 +0000 Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |mirko at abunchofthings.net, | |nengard at gmail.com Status|Needs Signoff |Signed Off --- Comment #2 from H?ctor Eduardo Castro Avalos --- Hi Josef Moravec I move your patch to this new bug Regard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:59:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:59:34 +0000 Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt at gmail.com |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:59:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:59:56 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 20:59:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 19:59:58 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48555|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48563&action=edit [SIGNED-OFF] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:01:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 20:01:29 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Attachment #48542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:31:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 20:31:35 +0000 Subject: [Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48551|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48564&action=edit [SIGNED-OFF]Bug 15959: Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:31:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 20:31:55 +0000 Subject: [Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:43:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 20:43:25 +0000 Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 --- Comment #3 from Josef Moravec --- Thanks H?ctor, also for sign-off ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 21:59:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 20:59:12 +0000 Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Mirko Tietgen --- Hi H?ctor and Josef, we talked about this on IRC today and the plan is to fix it in a different way. The module is not available in Wheezy and it is not a core function, only a few people will actually need it. We will change the "use WWW::YouTube:Download" to a 'require' with the condition of the youtube-syspref being enabled, so people on Wheezy don't get bothered by this. I plan to add a patch tomorrow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:23:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 21:23:41 +0000 Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 --- Comment #5 from Josef Moravec --- I should be more often on IRC ;) Thanks Mirko for clarification, I'm looking forward to your patch ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:42:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 21:42:06 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m --- Comment #201 from Brendan Gallagher --- (In reply to Jonathan Druart from comment #199) > I would like to get other opinions on the discussion on comment 38 and > comment 39 about the idea to reuse existing search scripts and templates. > IMO it will be a mess in a near future: > 1/ we will want to implement things for ES, not supported by Zebra > 2/ at some point the features already implemented for Zebra won't be > available for ES > => We will have to write switch (if se=='es' {} elsif se == 'zebra') > everywhere. A sort of road map that I have in mind (and yes I'll back that up with funding etc.) 1. Get Elastic into Koha (marked as experimental) - making sure that we aren't breaking anything with Zebra! (that's the main testing we need now) 2. Elasticsearch talks JSON 3. As we want to develop new features that are ES centric and not Zebra - we split those off 4. Meaning we can build a new frontend for it, that uses elasticsearch to search, and the restful api to get records. 5. New Frontend for it - that is not C4::Search (no one really wants to work that anymore). 6. introducing the Catmandu libraries into Koha should be a good thing - we can start to explore RDF etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:48:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 21:48:35 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48542|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 22:49:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 21:49:09 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #21 from Brendan Gallagher --- Just marking that last patch - as not obsolete until we've got another patch that does what we need. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:03:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:03:05 +0000 Subject: [Koha-bugs] [Bug 15947] SIPILS.t should be moved to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:08:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:08:15 +0000 Subject: [Koha-bugs] [Bug 15927] Remove use of for alternating row colors. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:08:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:08:43 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15964 --- Comment #22 from Josef Moravec --- H?ctor moved the patch to newly created bug 15964, that's propably the reason of obsoleting my followup here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:08:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:08:43 +0000 Subject: [Koha-bugs] [Bug 15964] Cannot view detail bib record because missing perl module WWW::YouTube::Download In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15964 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:37:20 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher --- Pushed to Mater - Should be in the May 2016 Release. thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:40:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:40:11 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |brendan at bywatersolutions.co | |m --- Comment #30 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:43:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:43:28 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Patch doesn't apply --- Comment #47 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:44:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:44:26 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |brendan at bywatersolutions.co | |m --- Comment #21 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:45:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:45:18 +0000 Subject: [Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #14 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:46:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:46:01 +0000 Subject: [Koha-bugs] [Bug 15456] Fix tabs and inconsistent indentation in smart-rules.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15456 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Patch doesn't apply --- Comment #6 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:47:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:47:07 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #44 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:48:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:48:54 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Patch doesn't apply --- Comment #37 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:52:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:52:39 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #24 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:53:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:53:58 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Patch doesn't apply --- Comment #36 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:54:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:54:54 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |brendan at bywatersolutions.co | |m --- Comment #79 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 2 23:55:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 22:55:38 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |brendan at bywatersolutions.co | |m --- Comment #50 from Brendan Gallagher --- Didn't apply cleanly - I know because of the moving target that master is. Please rebase. Once it's done - leave me an @later in #koha and I'll jump right on it. Thank you so much for the time and bother of rebasing. Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 00:03:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 23:03:36 +0000 Subject: [Koha-bugs] [Bug 9296] overduerules table needs restructuring to allow future extension In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9296 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 00:12:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 23:12:20 +0000 Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #106 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 00:14:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 23:14:07 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #45 from Brendan Gallagher --- (In reply to Brendan Gallagher from comment #44) > Didn't apply cleanly - I know because of the moving target that master is. > Please rebase. Once it's done - leave me an @later in #koha and I'll jump > right on it. Thank you so much for the time and bother of rebasing. > > Brendan Sorry - my mistake - need the last patch - that applies :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 00:20:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Mar 2016 23:20:01 +0000 Subject: [Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #46 from Brendan Gallagher --- Pushed last patch - thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 01:01:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 00:01:40 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #13 from Nick Clemens --- I think there is a problem here. Unless I missed something the lines below will now never be triggered, so the notice will not be pushed to output_chunks, so it will never be sent to the library in the case of a patron with no emails or sms 727 if ( ($mtt eq 'email' and not scalar @emails_to_use) or ($mtt eq 'sms' and not $data->{smsalertnumber}) ) { 728 push @output_chunks, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 01:05:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 00:05:36 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:29:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:29:37 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:29:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:29:40 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 --- Comment #5 from Aleisha Amohia --- Created attachment 48565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48565&action=edit Bug 15824 - 'Done' button is unclear on batch item modification and deletion To test: MODIFICATION 1) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 2) Click edit -> Edit items in a batch 3) Click Save (you don't need to make any changes) 4) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 5) Go to a biblio record page 6) Select one or some or all items in the record 7) Click modify selected items 8) Click Save 9) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 10) Go to batch item modification (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl) 11) Write some barcodes into the barcode list and click Continue 12) Click Save 13) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item mod page. DELETION 14) Go to a biblio record page (ie http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1) 15) Click edit -> Delete items in a batch 16) Unselect all the items so you don't actually delete them, then click Delete selected items 17) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 18) Go to a biblio record page 19) Select one or some or all items in the record 20) Click Delete selected items 21) Unselect all the items so you don't actually delete them, then click Delete selected items 22) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the record detail page. 23) Go to batch item deletion (http://localhost:8081/cgi-bin/koha/tools/batchMod.pl?del=1) 24) Write some barcodes into the barcode list and click Continue 25) Unselect all the items so you don't actually delete them, then click Delete selected items 26) Validate 'Done' button. Confirm that there is now a link in dialog message box which takes you back to the batch item deletion page. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:30:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:30:14 +0000 Subject: [Koha-bugs] [Bug 15824] 'Done' button is unclear on batch item modification and deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15824 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:39:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:39:23 +0000 Subject: [Koha-bugs] [Bug 15952] Moving cataloging search actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:39:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:39:26 +0000 Subject: [Koha-bugs] [Bug 15952] Moving cataloging search actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48537|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 48566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48566&action=edit Bug 15952: Moving cataloging search actions into a drop-down menu Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge conflict To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Fr?d?ric Demians Expected result following the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:42:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:42:22 +0000 Subject: [Koha-bugs] [Bug 15952] Moving cataloging search actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48566|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 48567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48567&action=edit Bug 15952: Moving cataloging search actions into a drop-down menu Edit: Have removed the datatables stuff - wasn't necessary. Also fixed a merge conflict To test: 1) Go to Cataloging and do a search in the catalog and reservoir (cataloguing/addbooks.pl) 2) Confirm that for the results found in catalog, the options (MARC and Card preview, Edit biblio, Add/edit items) are there and behave as expected. 3) Confirm that for the results found in reservoir, the options (MARC and Card preview, Add biblio) are there and behave as expected. 4) Set user permissions so that the user cannot edit the catalog or items. (editcatalogue -> edit_catalogue and edit_items) 5) Confirm that you no longer see the options to edit or add items/biblio in either table. Sponsored-by: Catalyst IT Signed-off-by: Fr?d?ric Demians Expected result following the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:46:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:46:45 +0000 Subject: [Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:46:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:46:48 +0000 Subject: [Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48534|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 48568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48568&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed ddatatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 02:50:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 01:50:25 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia at hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Aleisha Amohia --- fatal: sha1 information is lacking or useless (t/db_dependent/Accounts.t). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:18:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 02:18:25 +0000 Subject: [Koha-bugs] [Bug 15953] Patroncards toolbar is now broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15953 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical --- Comment #1 from Aleisha Amohia --- Setting to Critical because it actually disrupts the use of this feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:20:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 02:20:44 +0000 Subject: [Koha-bugs] [Bug 15965] New: Koha to MARC mapping - table changes with selection of drop down menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Bug ID: 15965 Summary: Koha to MARC mapping - table changes with selection of drop down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com See /cgi-bin/koha/tools/overduerules.pl When you select a new library in the drop down, the table showing rules updates automatically to show the rules for that library. This change should be added to cgi-bin/koha/admin/koha2marclinks.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:22:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 02:22:52 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:22:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 02:22:55 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 --- Comment #1 from Aleisha Amohia --- Created attachment 48569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48569&action=edit Bug 15965: Koha to MARC mapping - table changes with selection of drop down menu To test: 1) Go to Admin -> Koha to MARC Mapping 2) Test selecting biblio / biblioitems / items 3) Confirm the table content changes and behaves as it should which each selection Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 03:26:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 02:26:55 +0000 Subject: [Koha-bugs] [Bug 15966] New: Move MARC frameworks actions into a drop down menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Bug ID: 15966 Summary: Move MARC frameworks actions into a drop down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 04:35:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 03:35:50 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 04:37:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 03:37:04 +0000 Subject: [Koha-bugs] [Bug 15896] Use Koha::Account::pay internally for makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15896 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #2 from M. Tompsett --- Oops... forgot to apply 15895. Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 04:39:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 03:39:09 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- (In reply to Aleisha Amohia from comment #3) > fatal: sha1 information is lacking or useless (t/db_dependent/Accounts.t). Confirmed. 15895 (3 way merge okay), 15896, 15906, and 15907 all apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 04:44:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 03:44:40 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47956|0 |1 is obsolete| | --- Comment #51 from M. Tompsett --- Created attachment 48570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48570&action=edit Bug 12426: Allow resending of messages from the notices tab in the patron account This patch adds a link 'Resend' under a notice in 'failed' status in the Patron's Notices tab. By clicking the link, we will request notices.pl with parameter "resendnotice=XXXXX" where XXXXX is message_id. In notices.pl, we then check whether the given message is actually in 'failed' status. If so, we use the C4::Letters::ResendMessage(123) to change the status of the message into 'pending'. This way it will be processed again by the cronjob process_message_queue.pl. To test, find/create a Patron that has failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the failed message 4. Observe that there is nothing for resending the failed message 5. Apply patch. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status Works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 04:44:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 03:44:46 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47957|0 |1 is obsolete| | --- Comment #52 from M. Tompsett --- Created attachment 48571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48571&action=edit Bug 12426: Simplify the code adding a new subroutine GetMessage The C4::Letters module does not have a GetMessage subroutine, which could be quite useful. This patch adds it and simplifies the code added by the previous patch. It also adds a few tests and fixes POD typos. Note that ResendNotice only resends failed messages. This will avoid to resend already sent messages (using an url from the browser history for instance). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 04:44:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 03:44:52 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47958|0 |1 is obsolete| | --- Comment #53 from M. Tompsett --- Created attachment 48572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48572&action=edit Bug 12426: Allow resend for sent messages This patch allows to resend both sent and failed messages. With messages in 'sent' status, we have to be careful not to accidentally send sent messages again. With the previous patch using GET request, this was likely to happen because of browser storing the GET parameters. This patch changes request method from GET to POST. Instead of a simple link, we now have a form element. In notices.pl we redirect back to notices.pl, because with POST there is a risk of resending the message accidentally by form resubmission at refresh. To test, find/create a Patron that has sent or failed notices in message_queue: 1. Enable EnchancedMessagingPreferences system preference 2. Go to Patrons -> Notices 3. In the Notice column, click the title of the sent or failed message 4. Observe that there is nothing for resending the sent or failed message 5. Apply the patches. 6. Reload Notices page and repeat step 3 7. Observe that there is now a link "Resend" in the Status-column 8. Click Resend 9. Observe that the message gets into 'pending' status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 04:44:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 03:44:57 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48049|0 |1 is obsolete| | --- Comment #54 from M. Tompsett --- Created attachment 48573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48573&action=edit Bug 12426: [QA Follow-up] Clear to_address to force update When resending an email from the Notices tab in Patrons, we would like to use the recent email address. Test plan: [1] Look up a patron with some notices sent. [2] Adjust the patron email address (watch AutoEmailPrimaryAddress). [3] Resend the notice. Verify if the new address was used. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 04:51:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 03:51:44 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #55 from M. Tompsett --- Sorry, Marcel, my rebase lost your sign-off markers at the end of the files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:10:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:10:27 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47246|0 |1 is obsolete| | --- Comment #80 from M. Tompsett --- Created attachment 48574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48574&action=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:10:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:10:33 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47247|0 |1 is obsolete| | --- Comment #81 from M. Tompsett --- Created attachment 48575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48575&action=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! Bug 12803 [QA Followup] - Fix koha-qa.pl errors Bug 12803 [QA Followup] - Update unit tests due to changes in master Bug 12803 [QA Followup] - Fix to stop failing unit tests Bug 12803 [QA Followup] - Remove duplicate 'use' lines Bug 12803 [QA Followup] - Remove NO_CACHE Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:17:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:17:39 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |mtompset at hotmail.com --- Comment #82 from M. Tompsett --- I'm running through patch does not apply queue. Only HoldsQueue.t file changed in terms of use statements. Test file proves fine. Everything else identical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:26:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:26:55 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46864|0 |1 is obsolete| | --- Comment #37 from M. Tompsett --- Created attachment 48576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48576&action=edit Bug 14694 - Make decreaseloanHighHolds more flexible This patch allows for more flexibility for determining when the number of holds a record has should trigger the reduction of the loan length for items on that record. This patch adds a new system preference decreaseLoanHighHoldsControl, which defaults to 'static', the original behavior of the feature. It also has a new behavior 'dynamic' which makes the feature only decrease the loan length if the number of holds on the record exceeds the number of holdable items + decreaseLoanHighHoldsValue. It also allows items to be filtered from the list of items based on the damaged, lost, not for loan, and withdrawn values even if those values would have allowed holds ( i.e. values < 0 ) Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set decreaseLoanHighHolds to Enable 4) Set decreaseLoanHighHoldsControl to "over the number of items on the record" 5) Set decreaseLoanHighHoldsDuration to 1 6) Set decreaseLoanHighHoldsValue to 3 7) Create a record with 5 items 8) Please 8 or more holds on the record 9) Check out one of the items to a patron 10) Note the loan length is reduced to 1 day 11) Set decreaseLoanHighHoldsValue to 3 to 2 12) Check out one of the items to a patron 13) Note the loan length is *not* reduced 14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses 15) Set one item to be damaged 16) Note the loan length is reduced 17) Unset the damaged status 18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn Signed-off-by: Christopher Brannon Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:27:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:27:00 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46865|0 |1 is obsolete| | --- Comment #38 from M. Tompsett --- Created attachment 48577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48577&action=edit Bug 14694 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:27:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:27:05 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46866|0 |1 is obsolete| | --- Comment #39 from M. Tompsett --- Created attachment 48578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48578&action=edit Bug 14694 [QA Followup] - Fix typos Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:27:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:27:10 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46867|0 |1 is obsolete| | --- Comment #40 from M. Tompsett --- Created attachment 48579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48579&action=edit Bug 14694 [QA Followup] - Fix syspref order Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:27:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:27:15 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46868|0 |1 is obsolete| | --- Comment #41 from M. Tompsett --- Created attachment 48580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48580&action=edit Bug 14694: Create data the tests need Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 05:35:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 04:35:12 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |mtompset at hotmail.com --- Comment #42 from M. Tompsett --- Conflict was with bug 15629 adding Koha::Libraries on the first patch. Everything is code identical. Ran t/db_dependent/Circulation_dateexpiry.t and t/db_dependent/DecreaseLoanHighHolds.t with no issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:38:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:38:44 +0000 Subject: [Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:38:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:38:47 +0000 Subject: [Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48541|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 48581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48581&action=edit [PASSED QA] Bug 15755: Display default item type as "All" in circ rules Bug 15354 did not fix correctly the issue with the item type display. The default item type '*' should be "All", at the moment nothing is displayed in the column. Test plan: 1/ Define a rule for default item types (All/*) and for specific item types. 2/ Translate some item type descriptions used in previous step 3/ Default item type should be "All" and correct translations should be displayed. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:39:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:39:22 +0000 Subject: [Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to SC but fails to checkin item on Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039 --- Comment #3 from Katrin Fischer --- That would be nice - thx for the update Colin! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:40:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:40:58 +0000 Subject: [Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Nice catch! I think you are right about currency being no longer in use - I had to track down the deletion problem a little while ago. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:48:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:48:14 +0000 Subject: [Koha-bugs] [Bug 15950] Use Font Awesome icons for acquisitions basket close confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:48:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:48:16 +0000 Subject: [Koha-bugs] [Bug 15950] Use Font Awesome icons for acquisitions basket close confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15950 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48518|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 48582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48582&action=edit [PASSED QA] Bug 15950: Use Font Awesome icons for acquisitions basket close confirmation When closing a basket in Acquisitions the confirmation dialog should be styled using Font Awesome icons. This patch adds them. The cancel button has been moved into its own form so that we can get rid of several problematic JavaScript issues: The use of the "javascript:" pseudo-protocol, the use of an "onclick" attribute, and the use of a JS redirect where a GET action will do. To test, apply the patch and locate an open basket in Acquisitions which can be closed. - Click the 'Close this basket' button and confirm that the icons in the dialog look correct. - Test the cancel operation to make sure you are redirected back to the page showing the basket details. - Test the confirm operation and verify that the basket is closed. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer Please note that the confirmation message display depends on BasketConfirmations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:51:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:51:30 +0000 Subject: [Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:51:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:51:33 +0000 Subject: [Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48550|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 48583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48583&action=edit [PASSED QA] Bug 15864 - SMS cellular providers link missing from administration sidebar menu When the SMSSendDriver system preference is set to "Email" a link to the SMS cellular providers management page should appear in the left-hand sidebar menu on Administration pages. This patch adds the link to admin-menu.inc. To test, apply the patch set your SMSSendDriver system preference to "Email." View various Administration pages which show the left-hand sidebar menu and confirm that "SMS cellular providers" is in the list. Empty the SMSSendDriver preference and confirm that the link no longer appears. Signed-off-by: Nicole C Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:55:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:55:59 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:56:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:56:02 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48563|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 48584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48584&action=edit [PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. Signed-off-by: Nicole C Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:58:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:58:49 +0000 Subject: [Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 07:58:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 06:58:51 +0000 Subject: [Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48561|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 48585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48585&action=edit [PASSED QA] Bug 15951: Use Font Awesome icons for acquisitions order cancellation confirmation In Acquisitions, when you delete (cancel) an order, a dialog asks you to confirm. This dialog should be styled with Font Awesome icons. Other minor edit: Changing page grid style for centered main content area. To test, apply the patch and locate a basket in Acquisitions with an order. - View the details for the basket. - Click the 'Delete' link next to the order you want to delete. - Confirm that the dialog is correctly styled. - Test the cancel operation and verify that you are correctly redirected back to where you were. - Test the confirmation operation and verify that your order is deleted. - Also test the deletion process from Acquisitions -> Vendor -> Invoices -> Invoice -> Go to receipt page -> Delete order. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 08:05:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 07:05:18 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #23 from Mirko Tietgen --- Created attachment 48586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48586&action=edit Bug 14168 Follow-up: require WWW::YouTube::Download only when syspref enabled This patch fixes the problem of missing WWW::YouTube::Download breaking record detail views. Instead of a general 'use', the module is only required if the related syspref is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 08:06:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 07:06:04 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 08:11:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 07:11:31 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #24 from Mirko Tietgen --- I added a followup. Expected results: - without libwww-youtube-download-perl -- HTML5MediaYouTube disabled: detail views work fine -- HTML5MediaYouTube enabled: detail views throw an error ('Can't locate WWW/YouTube/Download.pm in @INC ?') - with libwww-youtube-download-perl -- HTML5MediaYouTube disabled: detail views work fine -- HTML5MediaYouTube enabled: detail views work fine and YT video works I can't switch this back to needs signoff for some reason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 08:13:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 07:13:13 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48586|0 |1 is obsolete| | --- Comment #25 from Mirko Tietgen --- Created attachment 48587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48587&action=edit Bug 14168 Follow-up: require WWW::YouTube::Download only when syspref enabled This patch fixes the problem of missing WWW::YouTube::Download breaking record detail views. Instead of a general 'use', the module is only required if the related syspref is enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 08:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 07:28:54 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #56 from Marcel de Rooy --- Putting this back where it came from (PQA) Any reason why you moved this back to SO, Mark? If it was a hard rebase, getting another signoff should imo go via NSO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 08:30:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 07:30:45 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 --- Comment #9 from Fr?d?ric Demians --- Pushed in 3.20.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:21:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:21:26 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #20 from Fr?d?ric Demians --- What point(s) prevent this patch to return to 'signed-off' status? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:24:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:24:20 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:24:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:24:25 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48111|0 |1 is obsolete| | Attachment #48112|0 |1 is obsolete| | Attachment #48142|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 48588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48588&action=edit Bug 15548: Move new patron related code to Patron* The 'borrower' should not be used anymore, especially for new code. This patch move files and rename variables newly pushed (i.e. in the Koha namespace). Test plan: 1/ git grep Koha::Borrower should not return code in use. 2/ Prove the different modified test files 3/ Do some clicks in the member^Wpatron module to be sure there is not an obvious error. Signed-off-by: Hector Castro Works as described. Tested with Circulation, Members/Patrons, Discharge, Restrictions modules and the must common functionalities Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:24:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:24:31 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #23 from Jonathan Druart --- Created attachment 48589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48589&action=edit Bug 15548 [QA Followup] - Catch a couple new Koha::Borrower uses Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:24:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:24:34 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 --- Comment #24 from Jonathan Druart --- Created attachment 48590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48590&action=edit Bug 15548 [QA Followup] - More new uses of Koha::Borrower Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:26:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:26:18 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #31 from Jonathan Druart --- Bug 15548 has been rebased, they apply now cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:29:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:29:09 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:29:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:29:12 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48425|0 |1 is obsolete| | Attachment #48426|0 |1 is obsolete| | Attachment #48427|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart --- Created attachment 48591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48591&action=edit Bug 15632 [QA Followup] - Get rid of use of uninitialized value errors for unit tests * Set $user to "" if not passed * Tidy sub -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:29:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:29:37 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #50 from Jonathan Druart --- Created attachment 48593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48593&action=edit Bug 15632 [QA Followup] - Change method type to _type for bug 15446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:29:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:29:33 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #49 from Jonathan Druart --- Created attachment 48592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48592&action=edit Bug 15632 [QA Followup] - Undo changes needed for Bug 13618 which was reverted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:31:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:31:41 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #25 from Jonathan Druart --- (In reply to Brendan Gallagher from comment #24) > Didn't apply cleanly - I know because of the moving target that master is. > Please rebase. Once it's done - leave me an @later in #koha and I'll jump > right on it. Thank you so much for the time and bother of rebasing. > > Brendan Brendan, we just need the last patch, others are already pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:36:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:36:51 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #4 from Fr?d?ric Demians --- I confirm that Unimarc host 205 field shouldn't be copied into 461$a. But It shouldn't either be suppressed (as with your patch). Shouldn't it be copied into 461$e? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:00 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47213|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 48594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48594&action=edit Bug 15084: Add Koha::Acquisition::Currenc[y|ies] classes The first step of this patch set is to move the business logic code from admin/currencies.pl to Koha::Acquisition::Currenc[y|ies]. Then a foreign key will be created on aqorders.currency as we want to assure data integrity. Note that a aqbooksellers.currency also exists but is never used. It could be removed in another bug report. This update has to care about possible breaking relation. For instance an old order has been made using a currency which is now deleted. To be sure the update process won't break a new column currency.archived is created and leave open the door for a further improvement (marked a currency as archived from the interface: this won't be provided by this enhancement). These archived currencies won't appear on the interface for newly created items (order/suggestion). Once this is done it becomes easy to remove the subroutine from C4::Budgets: GetCurrencies and GetCurrency. ConvertCurrency will also be removed but is not used anymore. Note that none of these subroutines were covered by tests. Now they are. Test plan: 0/ Don't apply this patch 1/ Create a temporary currency and an order using it 2/ Remove the currency from your CLI 3/ Apply the patch and execute the DB entry 4/ Note that the currency is inserted and marked as archived. 5/ Edit the previous order and confirm that the correct currency is still selected. It won't never be displayed anywhere else. 6/ Test the admin script: on admin/currency.pl add/remove/edit currencies. You could not have 2 active currencies at the same time. 7/ Then on the different scripts of the acquisition module, focus on the currencies values and create a new order, receive it. Create/edit a suggestion Other changes must be checked by the QAer. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:04 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47214|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 48595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48595&action=edit Bug 15084: Make sure the previous active currency is marked as inactive On inserting an active currency, others should be marked as inactive. We can only have 1 active currency at the same time. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:08 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47215|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart --- Created attachment 48596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48596&action=edit Bug 15084: use Koha::Acquisition::Currenc[y|ies] in admin/currency Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:12 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47216|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 48597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48597&action=edit Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search Most part of the code here is unnecessary complex. We should selected the currency if it is selected, that's all :) Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:15 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47217|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart --- Created attachment 48598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48598&action=edit Bug 15084: Remove C4::Budgets::ConvertCurrency This subroutine is unused and can be removed. There is no trace left of currency in C4::Budgets. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:19 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47218|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart --- Created attachment 48599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48599&action=edit Bug 15084: Add tests for Koha::Acquisition::Currenc[y|ies] Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:22 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47219|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart --- Created attachment 48600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48600&action=edit Bug 15084: DB Changes - add currency.archived and FK on aqorders.currency See the comment for details. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:25 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47220|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart --- Created attachment 48601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48601&action=edit Bug 15084: DBIx::Class - Shema changes Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:28 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47221|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart --- Created attachment 48602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48602&action=edit Bug 15084 [QA Followup] - Clean up test currencies after unit tests Test currency left behind will cuase next run of the unit test to fail as well as leaving db cruft. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:32 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #47 from Jonathan Druart --- Created attachment 48603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48603&action=edit Bug 15084: Fix conflict with bug 15446 (type vs _type) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:42:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:42:50 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #48 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:44:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:44:41 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:44:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:44:43 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48512|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 48604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48604&action=edit Bug 15941 - The template for cloning circulation and fine rules says "issuing rules" The template for cloning circulation and fine rules should use the phrase "circulation and fine rules" instead of "issuing rules." Also changed: Added "Cancel" link to return the user to the circulation and fine rules page. To test, navigate directly to /cgi-bin/koha/admin/clone-rules.pl. The page title, breadcrumbs, and heading should all use the phrase "circulation and fine rules." Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:52:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:52:17 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 --- Comment #14 from Jonathan Druart --- (In reply to Nick Clemens from comment #13) > I think there is a problem here. > > Unless I missed something the lines below will now never be triggered, so > the notice will not be pushed to output_chunks, so it will never be sent to > the library in the case of a patron with no emails or sms > > > 727 if ( ($mtt eq 'email' and not scalar > @emails_to_use) or ($mtt eq 'sms' and not $data->{smsalertnumber}) ) { > 728 push @output_chunks, Haaaaa!!! Good catch Nick! This script drives me crazy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:57:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:57:27 +0000 Subject: [Koha-bugs] [Bug 15967] New: Print notices are not generated if the patron cannot be notified Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Bug ID: 15967 Summary: Print notices are not generated if the patron cannot be notified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Notices Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Regression introduced by bug 14133, see but 14133 comment 13. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:57:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:57:51 +0000 Subject: [Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15967 --- Comment #15 from Jonathan Druart --- See bug 15967. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 [Bug 15967] Print notices are not generated if the patron cannot be notified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 09:57:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 08:57:51 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133 [Bug 14133] Print notices generated in special case do not use print template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:01:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:01:06 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:01:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:01:08 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 --- Comment #1 from Jonathan Druart --- Created attachment 48605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48605&action=edit Bug 15967: Fix regression from bug 14133 - notify the library if patron is not Regression introduced by bug 14133, see but 14133 comment 13. Test plan: Without this patch applied, if a patron cannot be notified (no email address or sms number), the print notice generated for the library was not. With this patch applied, the print notice should be generated using the print template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:01:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:01:16 +0000 Subject: [Koha-bugs] [Bug 15928] Show unlinked guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- I can see the improvement with your patch, but isn't it a bug in the first place? Shouldn't the guarantor Surname/Firstname data entry be blocked? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:04:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:04:44 +0000 Subject: [Koha-bugs] [Bug 15940] Remove unused JavaScript from authorities MARC subfield structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:04:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:04:46 +0000 Subject: [Koha-bugs] [Bug 15940] Remove unused JavaScript from authorities MARC subfield structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48477|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 48606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48606&action=edit Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure The authorities MARC subfield structure template contains some unused JavaScript, "function displayMoreConstraint()" This patch removes it. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> Subfields -> Edit subfields and confirm that there are no JavaScript errors and tab switching works correctly. A search of the source code should show no instances of "displayMoreConstraint." Signed-off-by: Fr?d?ric Demians No regression, no JS warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:11:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:11:49 +0000 Subject: [Koha-bugs] [Bug 15937] Batch checkout buggy behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937 --- Comment #3 from Jonathan Druart --- (In reply to H?ctor Eduardo Castro Avalos from comment #2) > (In reply to Jonathan Druart from comment #1) > > >No information means "everything went fine", when you get a red alert it's "checkout impossible". > > Prefix at least "Cannot check out. The patron has a debt of 10.0" > > And again Koha let to checkout the first item without await for > confirmation, i.e., the expected behavior is: 1) enter the barcodes 2) show > table with checkboxes in titles, no checkout yet at this point, but program > checkout the first item in the table 3) Confirm checkout 4) The table with > all items checked out is presented. This is not as trivial as it seems :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:14:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:14:57 +0000 Subject: [Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:14:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:14:59 +0000 Subject: [Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48467|0 |1 is obsolete| | --- Comment #3 from Fr?d?ric Demians --- Created attachment 48607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48607&action=edit Bug 15925 [Revised] Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard
- Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Validation errors have been corrected on all three templates, including removal of an extra
. Revision: I was wrong about the frequency of use of "Modify." There's no clear-cut reason to replace it with "Edit" so I have undone that change. Signed-off-by: Fr?d?ric Demians Works as expected. No regression. Better texts. Consistent validation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:16:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:16:09 +0000 Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:17:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:17:18 +0000 Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11703 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 [Bug 11703] Convert checkouts table to ajax datatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:17:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:17:18 +0000 Subject: [Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15219 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 [Bug 15219] Server-side processing and pagination on checkouts tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:20:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:20:05 +0000 Subject: [Koha-bugs] [Bug 15940] Remove unused JavaScript from authorities MARC subfield structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:20:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:20:08 +0000 Subject: [Koha-bugs] [Bug 15940] Remove unused JavaScript from authorities MARC subfield structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48606|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48608&action=edit Bug 15940 - Remove unused JavaScript from authorities MARC subfield structure The authorities MARC subfield structure template contains some unused JavaScript, "function displayMoreConstraint()" This patch removes it. To test, apply the patch and go to Administration -> Authority types -> MARC structure -> Subfields -> Edit subfields and confirm that there are no JavaScript errors and tab switching works correctly. A search of the source code should show no instances of "displayMoreConstraint." Signed-off-by: Fr?d?ric Demians No regression, no JS warning. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:25:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:25:57 +0000 Subject: [Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:26:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:26:00 +0000 Subject: [Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48607|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 48609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48609&action=edit Bug 15925 [Revised] Correct some markup issues with patron lists pages This patch makes some markup changes to the patron lists interface in order to make them more consistent with other areas of Koha. Change to look for when testing: Tools -> Patron lists: - Wrap "New patron list" button in standard
- Place toolbar above page heading. Tools -> Patron lists -> New patron list: - Use built-in form validation for required fields - Clarify page title and breadcrumbs on list add and edit Validation errors have been corrected on all three templates, including removal of an extra
. Revision: I was wrong about the frequency of use of "Modify." There's no clear-cut reason to replace it with "Edit" so I have undone that change. Signed-off-by: Fr?d?ric Demians Works as expected. No regression. Better texts. Consistent validation. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:26:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:26:02 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 --- Comment #5 from Zeno Tajoli --- In fact I read the standard too quickly. I don't see the subfield $e in 461 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:29:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:29:44 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48604|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48610&action=edit Bug 15941 - The template for cloning circulation and fine rules says "issuing rules" The template for cloning circulation and fine rules should use the phrase "circulation and fine rules" instead of "issuing rules." Also changed: Added "Cancel" link to return the user to the circulation and fine rules page. To test, navigate directly to /cgi-bin/koha/admin/clone-rules.pl. The page title, breadcrumbs, and heading should all use the phrase "circulation and fine rules." Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:29:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:29:42 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:30:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:30:12 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- There are 2 more on other templates: help/admin/smart-rules.tt:

Using the issuing rules matrix you can define rules that depend on patron/item type combinations. To set your rules, choose a library from the pull down (or 'all libraries' if you want to apply these rules to all libraries)

help/tools/automatic_item_modification_by_age.tt:
  • configure issuing rules depending the 'new' status.
  • -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:36:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:36:05 +0000 Subject: [Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Jonathan Druart --- When editing a biblio, if a field is required it's highlighted. With your patch, the highlight does no longer appear. Could you have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:39:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:39:02 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #14 from Fr?d?ric Demians --- There is something wrong here. The 1st patch is enough. No reindexing is required since 'Date/time-last-modified' index is already defined. After adding an alias in ccl.properties (1st patch), and copying ccl.properties in the installed configuration, restarting the Zebra server is all you need to do to get working searches without prefix with ccl= -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:41:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:41:27 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #15 from Fr?d?ric Demians --- You don't have to add a new index: dtlm:w 'dtlm' is just a CCL shortcut to the already existing index Date/time-last-modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:42:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:42:33 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47561|0 |1 is obsolete| | --- Comment #16 from Fr?d?ric Demians --- Comment on attachment 47561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47561 Bug 15694: (followup)Update DOM index filter definitions Not required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:42:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:42:51 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47741|0 |1 is obsolete| | --- Comment #17 from Fr?d?ric Demians --- Comment on attachment 47741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47741 Bug 15694: (followup)Update DOM index for UNIMARC/biblios Not required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:46:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:46:05 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:46:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:46:07 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 --- Comment #18 from Fr?d?ric Demians --- Created attachment 48611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48611&action=edit Bug 15694: Add aliases for date/time last modified This patch will add indexes for Date/time-last-modified. To test: 1. apply patch 2. reindex 3. search for dtlm:DATE and date-time-last-modified:DATE 4. confirm that you get results Signed-off-by: Hector Castro Works as advertised Signed-off-by: Fr?d?ric Demians I confirm Hector signing-off. A simple Zebra server restart suffice to get working the searches on date-time-last-modified and dtlm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:46:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:46:34 +0000 Subject: [Koha-bugs] [Bug 15694] Date/time-last-modified not searchable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15694 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47512|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:50:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:50:53 +0000 Subject: [Koha-bugs] [Bug 9254] New option to block patrons from changing messaging preferences in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 MAP changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mapinnovatives at yahoo.com --- Comment #40 from MAP --- Dear, When this patch will available on the version? Praseeth MA MAP Innovative Technologies India, Kerala, Palakkad -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:53:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:53:21 +0000 Subject: [Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Owen, It cannot work. These values can be multi-valuated (separated by
    ) and the TT plugins do not manage that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:53:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:53:44 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:53:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:53:46 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48219|0 |1 is obsolete| | --- Comment #6 from Fr?d?ric Demians --- Created attachment 48612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48612&action=edit Bug 15669 Alphabetize marc modification templates This patch sorts the modification templates when getting them from the database This affects the pages below: tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:58:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:58:42 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48554|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 48613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48613&action=edit Bug 15936 - Revise layout and behavior of SMS cellular providers management This patch changes the behavior of the SMS cellular providers management page so that sections of the page are shown or hidden based on what the current task is. Other changes include: - Moving JavaScript to a separate file - Adding a toolbar with a "New SMS provider" button. - Adding the "generic" catalog search header form to the top of the page. - Adding "Required" classes to required fields so that the staff client's built-in JS validation library can be used. To test, the SMSSendDriver system preference must be set to "Email." Apply the patch and go to Administration -> SMS cellular providers. - Confirm that the add/edit form is hidden initially. A toolbar with a "New SMS provider" button should appear with existing SMS cellular providers in a table below. If there are no existing providers a message dialog should say so. - Confirm that the "New SMS provider" button works: - The table should be hidden and an empty "add" form displayed. - Confirm that an empty form cannot be submitted. - Confirm that submitting valid data works. - Confirm that clicking the "Cancel" button hides the form and redisplays the table. - Test the "edit" button for an existing provider: - Confirm that the edit form is displayed and populated with the correct data. - Confirm that edits are saved correctly. - When viewing the table of existing providers, confirm that clicking the "Delete" button triggers a confirmation dialog. Test both cancelling and confirming that dialog. - Ponder whether all this is an improvement or not. Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 10:59:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 09:59:22 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 --- Comment #5 from Jonathan Druart --- Kyle, do you agree with this UI change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:18:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 10:18:56 +0000 Subject: [Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:18:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 10:18:59 +0000 Subject: [Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48564|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48614&action=edit Bug 15959: Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. Signed-off-by: Hector Castro Works as described Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:19:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 10:19:39 +0000 Subject: [Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- It would be interesting to use CSS3 variables (https://www.w3.org/TR/css-variables/) to define the different colors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:30:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 10:30:28 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:30:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 10:30:31 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48612|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 48615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48615&action=edit Bug 15669: Alphabetize marc modification templates This patch sorts the modification templates when getting them from the database This affects the pages below: tools/batch_record_modification.pl tools/marc_modification.pl tools/stage-marc-import.pl To test: 1 - Add some marc modification templates in a non alpha order (Shoes, Hats, Cats) 2 - visit the pages above and note the templates are in order added 3 - apply patch 4 - visit the three pages and note correct order 5 - verify all tools continue to work as expected Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:30:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 10:30:36 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 --- Comment #8 from Jonathan Druart --- Created attachment 48616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48616&action=edit Bug 15669: Add a test for GetModificationTemplates Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 11:55:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 10:55:21 +0000 Subject: [Koha-bugs] [Bug 9227] items in transit can be checked out without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9227 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:24:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:24:00 +0000 Subject: [Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #211 from Jonathan Druart --- See bug 15715 for the cause of the revert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:35:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:35:01 +0000 Subject: [Koha-bugs] [Bug 15968] New: Unnecessary loop in C4::Templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Bug ID: 15968 Summary: Unnecessary loop in C4::Templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org >From C4::Templates::output # add variables set via param to $vars for processing for my $k ( keys %{ $self->{VARS} } ) { $vars->{$k} = $self->{VARS}->{$k}; } This loop is not necessary, we could do the same with $vars = { %$vars, %{ $self->{VARS} } }; After a quick benchmark, it gains 100 microseconds when we pass 170 vars to the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:36:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:36:33 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:36:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:36:35 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 --- Comment #1 from Jonathan Druart --- Created attachment 48617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48617&action=edit Bug 15968: Unnecessary loop in C4::Templates >From C4::Templates::output # add variables set via param to $vars for processing for my $k ( keys %{ $self->{VARS} } ) { $vars->{$k} = $self->{VARS}->{$k}; } This loop is not necessary, we could do the same with $vars = { %$vars, %{ $self->{VARS} } }; After a quick benchmark, it gains 100 microseconds when we pass 170 vars to the template. Test plan: Do some clicks on the interface, everything should be ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:36:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:36:59 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:36:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:36:59 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15968 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 [Bug 15968] Unnecessary loop in C4::Templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:37:20 +0000 Subject: [Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 --- Comment #4 from Katrin Fischer --- Hm sounds familiar - would something like the fix for http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=363cb9c02ed017a0a20951d5caa9f9e5376600d0 help? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:49:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:49:53 +0000 Subject: [Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 --- Comment #5 from Jonathan Druart --- Yes, I have searched for this patch but did not find it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:57:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:57:24 +0000 Subject: [Koha-bugs] [Bug 15672] Show descriptions instead of codes on the hold ratios report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15672 --- Comment #6 from Katrin Fischer --- Ask a librarian :P -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 12:59:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 11:59:52 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #12 from Jonathan Druart --- Retested today on opac-search: Without the patch (i.e master): 17.0s (of 20.8s), executing 3550368 statements and 1053896 subroutine calls in 421 source files and 63 string evals. With the patch: Profile of /home/koha/perl5/bin/plackup for 95.8s (of 117s), executing 19107084 statements and 7240133 subroutine calls in 421 source files and 63 string evals. With the patch *and* the syspref cache (i.e. remove C4::Context->disable_syspref_cache;) 15.8s (of 18.6s), executing 2588556 statements and 903720 subroutine calls in 421 source files and 63 string evals. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:11:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:11:49 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 --- Comment #57 from M. Tompsett --- (In reply to Marcel de Rooy from comment #56) > Putting this back where it came from (PQA) > Any reason why you moved this back to SO, Mark? > If it was a hard rebase, getting another signoff should imo go via NSO. Because I wasn't sure what status I should move it to, but it wasn't hard. And your sign-offs were lost, because I didn't have them to start, and I forgot to add them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:12:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:12:45 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #13 from Jonathan Druart --- Something interesting: on master: # spent 35.1ms within DBI::common::DESTROY which was called 12520 times, avg 3?s/call with path: # spent 2.54s (697ms+1.85) within DBIx::Class::DESTROY which was called 118584 times, avg 21?s/call -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:15:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:15:31 +0000 Subject: [Koha-bugs] [Bug 15969] New: Allow use of Template Toolkit syntax for Phone Notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Bug ID: 15969 Summary: Allow use of Template Toolkit syntax for Phone Notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org By allowing the use of Template Toolkit for generating the outgoing Talking Tech CSV files, we can give libaries more control over the data they send to Itiva. This enhancement would also make it possible to use the script for other services since the output is no longer fixed to a single format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:18:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:18:26 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #134 from Sally Healey --- Hi all, I know this isn't strictly a sign-off, but we wanted to note that we've been using these patches (thanks Colin) on our live - and rather large - system over the past year. We're extremely happy with how the module operates - everything works correctly with no known issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:19:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:19:56 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:19:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:19:59 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 --- Comment #1 from Kyle M Hall --- Created attachment 48618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48618&action=edit Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices By allowing the use of Template Toolkit for generating the outgoing Talking Tech CSV files, we can give libaries more control over the data they send to Itiva. This enhancement would also make it possible to use the script for other services since the output is no longer fixed to a single format. Test Plan: 1) Apply this patch 2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout 3) Generate the CSV file via the script misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl 4) Enable Template Toolkit for the notices and update the notice text to be: [% FILTER remove("\r\n") %] "[% format %]", "[% language %]", "[% type %]", "[% level %]", "[% borrower.cardnumber %]", "[% borrower.title %]", "[% borrower.firstname %]", "[% borrower.surname %]", "[% borrower.phone %]", "[% borrower.email %]", "[% library_code %]", "[% branch.id %]", "[% branch.branchname %]", "[% item.barcode %]", "[% due_date %]", "[% biblio.title %]", "__MESSAGE_ID__" [% END %] 5) Regenerate the notices 6) Compare the originals, note the format is the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:22:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:22:08 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48498|0 |1 is obsolete| | Attachment #48499|0 |1 is obsolete| | Attachment #48500|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 48619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48619&action=edit Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:22:20 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #22 from Kyle M Hall --- Created attachment 48620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48620&action=edit Bug 14757 [QA Followup] - Add Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:22:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:22:25 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #23 from Kyle M Hall --- Created attachment 48621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48621&action=edit Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it behind a syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:22:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:22:28 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #24 from Kyle M Hall --- Created attachment 48622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48622&action=edit Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 13:37:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 12:37:48 +0000 Subject: [Koha-bugs] [Bug 15928] Show unlinked guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15928 --- Comment #3 from Nick Clemens --- Some libraries use this currently for patrons whose guarantor doesn't have a card. It lets them have a record of the name of a responsible party and I think removing this ability would be a loss. I also think these fields can be used for organisation/affiliation when there may not be an account but still allows for grouping patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 14:25:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 13:25:24 +0000 Subject: [Koha-bugs] [Bug 15970] New: Plack should not clear syspref cache Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Bug ID: 15970 Summary: Plack should not clear syspref cache Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15341, 13815 Just played with nytprof and found something exciting: If I remove the following line: C4::Context->clear_syspref_cache(); from the psgi file, the processing time is divided per 2 (!) With the clear cache: for 15.8s (of 18.6s), executing 2588556 statements and 903720 subroutine calls in 421 source files and 63 string evals. Without the clear cache: for 7.82s (of 8.69s), executing 904432 statements and 262539 subroutine calls in 421 source files and 63 string evals. I have tried to update a pref (NoLoginInstructions): it's saved and displayed correctly. Am I missing something? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 [Bug 15341] Performance - Retrieve all sysprefs at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 14:25:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 13:25:24 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 [Bug 15970] Plack should not clear syspref cache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 14:25:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 13:25:24 +0000 Subject: [Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 [Bug 15970] Plack should not clear syspref cache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 14:25:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 13:25:59 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15342 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 14:25:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 13:25:59 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 [Bug 15970] Plack should not clear syspref cache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 14:55:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 13:55:04 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Paul Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.johnson at staffs.ac.uk --- Comment #135 from Paul Johnson --- Hi all Sorry haven't done a formal sign off yet but completely agree with Sally's previous comment. Here at Staffordshire University we've been using EDI since 2011 and testing the new EDI patches during the recent updates to the module and can confirm that everything is working as planned with no known issues. thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:02:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:02:36 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #136 from Nicole C. Engard --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 7736: Support Ordering via Edifact EDI messages Using index info to reconstruct a base tree... M C4/Acquisition.pm M C4/Installer/PerlDependencies.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt :6102: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm Auto-merging C4/Acquisition.pm Failed to merge in the changes. Patch failed at 0001 Bug 7736: Support Ordering via Edifact EDI messages The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Amended-patch-hYhFhR.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:04:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:04:04 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:04:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:04:08 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46996|0 |1 is obsolete| | Attachment #47004|0 |1 is obsolete| | --- Comment #137 from Kyle M Hall --- Created attachment 48623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48623&action=edit Bug 7736: Support Ordering via Edifact EDI messages Add support for processing incoming Edifact Quotes, Invoices and order responses and generating and transmission of Edifact Orders. Basic workflow is that an incoming quote generates an aquisition basket in Koha, with each line corresponding to an order record The user can then generate an edifact order from this (or another) basket, which is transferred to the vendor's site The supplier generates an invoice on despatch and this will result in corresponding invoices being generated in Koha The orderlines on the invoice are receipted automatically. We also support order response messages. This may include simple order acknowledgements, supplier reports/amendments on availability. Cancellation messages cause the koha order to be cancelled, other messages are recorded against the order Which messages are to be supported/processed is specifiable on a vendor by vendor basis via the admin screens You can also specify auto order i.e. to generate orders from quotes without user intervention - This reflects existing workflows where most work is done on the suppliers website then generating a dummy quote Received messages are stored in the edifact_messages table and the original can be viewed via the online Database changes are in installer/data/mysql/atomicchanges/edifact.sql Note new perl dependencies: Net::SFTP:Foreign Text::Unidecode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:04:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:04:18 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #138 from Kyle M Hall --- Created attachment 48624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48624&action=edit Bug 7736 Add Edifact order fields to Acquisition.t Modification in Acquisition.t to support in test the new fields of the table aqorders: line_item_id, suppliers_reference_number, suppliers_reference_qualifier, suppliers_report Original patch by Zeno Tajoli I amended to include the report field (ColinC) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:16:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:16:36 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:16:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:16:42 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48623|0 |1 is obsolete| | --- Comment #139 from Nicole C. Engard --- Created attachment 48625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48625&action=edit [SIGNED-OFF] [SIGNED-OFF] Bug 7736: Support Ordering via Edifact EDI messages Add support for processing incoming Edifact Quotes, Invoices and order responses and generating and transmission of Edifact Orders. Basic workflow is that an incoming quote generates an aquisition basket in Koha, with each line corresponding to an order record The user can then generate an edifact order from this (or another) basket, which is transferred to the vendor's site The supplier generates an invoice on despatch and this will result in corresponding invoices being generated in Koha The orderlines on the invoice are receipted automatically. We also support order response messages. This may include simple order acknowledgements, supplier reports/amendments on availability. Cancellation messages cause the koha order to be cancelled, other messages are recorded against the order Which messages are to be supported/processed is specifiable on a vendor by vendor basis via the admin screens You can also specify auto order i.e. to generate orders from quotes without user intervention - This reflects existing workflows where most work is done on the suppliers website then generating a dummy quote Received messages are stored in the edifact_messages table and the original can be viewed via the online Database changes are in installer/data/mysql/atomicchanges/edifact.sql Note new perl dependencies: Net::SFTP:Foreign Text::Unidecode Signed-off-by: Paul Johnson Signed-off-by: Sally Healey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:17:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:17:04 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48624|0 |1 is obsolete| | --- Comment #140 from Nicole C. Engard --- Created attachment 48626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48626&action=edit [SIGNED-OFF] [SIGNED-OFF] Bug 7736 Add Edifact order fields to Acquisition.t Modification in Acquisition.t to support in test the new fields of the table aqorders: line_item_id, suppliers_reference_number, suppliers_reference_qualifier, suppliers_report Original patch by Zeno Tajoli I amended to include the report field (ColinC) Signed-off-by: Paul Johnson Signed-off-by: Sally Healey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:17:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:17:45 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #141 from Nicole C. Engard --- Sally and Paul, I put your sign offs on these patches. Thanks for the update! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:48:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:48:24 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #1 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #0) > Just played with nytprof and found something exciting: > > If I remove the following line: > C4::Context->clear_syspref_cache(); > from the psgi file, the processing time is divided per 2 (!) > > With the clear cache: > for 15.8s (of 18.6s), executing 2588556 statements and 903720 subroutine > calls in 421 source files and 63 string evals. > > Without the clear cache: > for 7.82s (of 8.69s), executing 904432 statements and 262539 subroutine > calls in 421 source files and 63 string evals. Such a difference looks kind of weird - unless the script you are testing calls (for whatever reasons) CGI->new() repeatedly ? BTW, how many times was C4::Context::preference() called in that test? > Am I missing something? With that line removed, each time when you change some syspref value, you'll need to restart starman server/workers manually for that change to take effect. However, clearing syspref cache inside CGI->new() override sub is probably not 100% flawless method anyway, so serwer restarts are still needed if one wants to be on the safe side ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 15:59:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 14:59:55 +0000 Subject: [Koha-bugs] [Bug 15937] Batch checkout buggy behavior In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15937 --- Comment #4 from H?ctor Eduardo Castro Avalos --- (In reply to Jonathan Druart from comment #3) Hi Jonathan > > And again Koha let to checkout the first item without await for > > confirmation, i.e., the expected behavior is: 1) enter the barcodes 2) show > > table with checkboxes in titles, no checkout yet at this point, but program > > checkout the first item in the table 3) Confirm checkout 4) The table with > > all items checked out is presented. Sometimes librarians make mistakes and enter an incorrect patron, if she or he realizes that has made a mistake, she/he can change the patron at this point without check out any item in the list. > This is not as trivial as it seems :) Yes, it could be. Regards -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:00:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:00:16 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED Assignee|robin at catalyst.net.nz |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:28:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:28:58 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #5 from Tom?s Cohen Arazi --- Created attachment 48628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48628&action=edit Bug 15870: (QA followup) Add tests This patch introduces functionality tests for the new Koha::Filter. It iterates over all the possible 'hidden' values defined in the docs for hiding/showing fields and subfields, and checks the filter does the job. It tests the functionality for both opac and intranet interfaces and tries to catch all scenarios. It adds control fields to the sample record (they traverse a different branch in the code). TODO: Add another subfield to 245, set it to be hidden, and make sure 245 $a is still shown. The original tests file has been renamed conveniently. To test: - Run $ prove t/db_dependent/Filter_MARC_ViewPolicy.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:30:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:30:02 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39785|0 |1 is obsolete| | Attachment #39786|0 |1 is obsolete| | Attachment #44860|0 |1 is obsolete| | --- Comment #35 from Blou --- Created attachment 48629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48629&action=edit Bug 11317 - Rename config to 'accessdir' and fix qa Also translate date with datetime format preference and move to Tools. Test preparation : * Add the "accessdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/files-access" directory : ... /tmp/files-access ... * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/files-access * Add a test file in the log directory : $ cd /tmp/files-access $ echo "Hello world!" > test.txt Test : * Go in the "tools/Additional tools" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:33:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:33:56 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #36 from Blou --- The last patch introduced 'filesaccess', but didn't replace all 'publicdir' reference. I squashed the last three patches because I did not see the value of having a patch that changed to publicdir signed off followed by a patch to move it to accessdir then another patch to fix it... This feature does not warrant that many patches in Koha's history. An historian... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:38:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:38:11 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Tom?s Cohen Arazi --- This bug was lacking functionality tests. As it is in my best interest to have this moving, I've gone through the process of writing unit tests for this piece of code. Things that weren't tested: - opac vs. intranet (interface option) - test all the possible values. - control fields and datafields traverse different code branches, and needed to be tested. The tests I wrote cover most of what is needed. Please read the TODO in the commit message. The tests fail. Mark: you need to get rid of the clone. The RecordProcessor pipeline is designed so it works on the original object. Doing so will make several tests pass: foreach my $current_record (@records) { - my $result = $current_record->clone(); + my $result = $current_record; There are still problems. Hopefully problems in the tests. I couldn't spend more time on this. Also, there is a weird construct you should get rid off, so you simplify the code and make it more readable: + else { + # visibility is a "level" (-7 to +7), default to 0 + my $visibility = $marcsubfieldstructure->{$tag}->{q{@}}->{hidden}; + $visibility //= 0; + my $hidden; + if ( $display->{$interface}->{$visibility} ) { + $hidden = 0; + } + else { + $hidden = 1; + $result->delete_fields($field); + } + } could be just: + else { + # visibility is a "level" (-7 to +7), default to 0 + my $visibility = $marcsubfieldstructure->{$tag}->{q{@}}->{hidden}; + $visibility //= 0; + if ( ! $display->{$interface}->{$visibility} ) { + $result->delete_fields($field); + } + } Looking forward to your comments and/or followups. Count on me to have this done ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:43:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:43:10 +0000 Subject: [Koha-bugs] [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48560|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48630&action=edit [SIGNED-OFF]Bug 15963: Use Font Awesome icons for confirmation after deleting MARC tag This patch revises the dialog which appears after you have deleted a MARC tag. To test, apply the patch and go to Administration -> MARC frameworks -> MARC sturcture -> Delete. - Confirm that you want to delete a MARC tag. - Verify that the confirmation dialog you are shown is styled correctly. - Verify that clicking "OK" redirects you to the right place. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:43:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:43:36 +0000 Subject: [Koha-bugs] [Bug 15963] Use Font Awesome icons for confirmation after deleting MARC tag In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15963 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:48:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:48:55 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:48:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:48:59 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48349|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 48631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48631&action=edit Bug 15871: Improve PerlCritic level for t/RecordProcessor.t perlcritic -5 failed. Attempt to clean up to a higher level: -- use English to address use of $@ variable -- perltidy on the code -- substitute q{} for '' -- expand out single line hacky goodness (... s/\.pm$//) to more code -- remove parenthesis on functions that don't need it -- add x, s, and m as needed to regexps -- change double quotes to single quotes where no variable involved -- tweaked eval destroy test to check return value and use $EVAL_ERROR -- renamed $processor to $record_processor in the subtest to avoid lexical warnings TEST PLAN --------- $ perlcritic -5 t/RecordProcessor.t Don't modify $_ in list functions at line 43, column 25. See page 114 of PBP. (Severity: 5) $ perlcritic -2 t/RecordProcessor.t No package-scoped "$VERSION" variable found at line 1, column 1. See page 404 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 34, column 36. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 34, column 39. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 36, column 33. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 36, column 36. See page 53 of PBP. (Severity: 2) Don't modify $_ in list functions at line 43, column 25. See page 114 of PBP. (Severity: 5) Regular expression without "/s" flag at line 43, column 33. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/x" flag at line 43, column 33. See page 236 of PBP. (Severity: 3) Regular expression without "/m" flag at line 43, column 33. See page 237 of PBP. (Severity: 2) Regular expression without "/s" flag at line 43, column 66. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/x" flag at line 43, column 66. See page 236 of PBP. (Severity: 3) Regular expression without "/m" flag at line 43, column 66. See page 237 of PBP. (Severity: 2) Expression form of "grep" at line 47, column 8. See page 169 of PBP. (Severity: 4) Expression form of "grep" at line 50, column 20. See page 169 of PBP. (Severity: 4) Regular expression without "/s" flag at line 50, column 26. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 50, column 26. See page 237 of PBP. (Severity: 2) Return value of eval not tested at line 73, column 1. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) Magic punctuation variable $@ used at line 78, column 5. See page 79 of PBP. (Severity: 2) Reused variable name in lexical scope: $processor at line 84, column 5. Invent unique variable names. (Severity: 3) Subroutine "new" called using indirect syntax at line 87, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 93, column 18. See page 349 of PBP. (Severity: 4) Quotes used with a string containing no non-whitespace characters at line 96, column 40. See page 53 of PBP. (Severity: 2) Subroutine "new" called using indirect syntax at line 99, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 106, column 18. See page 349 of PBP. (Severity: 4) $ prove -v t/RecordProcessor.t t/RecordProcessor.t .. ok All tests successful. Files=1, Tests=13, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.22 cusr 0.02 csys = 0.25 CPU) Result: PASS $ prove -v t/RecordProcessor.t ... $ git bz apply 15871 Repeat perlcritic level 2, and only $VERSION warning should exist. Retest with the prove. Run koha qa test tools. Signed-off-by: Hector Castro Works as advertised Signed-off-by: Jesse Maseto Signed-off-by: Tomas Cohen Arazi I don't really care about perlcritic as long as it involves changing '' into qw{} (WTF?) Anyway, I'd do this kind of things as we go, for example, if we were adding more tests. In that case it would just be a followup for this, after you provided a patch for an enh/bugfix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 16:59:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 15:59:35 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart --- New pref not added by the update DB process, please fix asap. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:05:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:05:26 +0000 Subject: [Koha-bugs] [Bug 15971] New: Allow use of all biblio and biblioitems fields in serial claim letters Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15971 Bug ID: 15971 Summary: Allow use of all biblio and biblioitems fields in serial claim letters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When creating a serial claim letter only title, author and serial are offered as fields in the notice editor. It should be possible to print all fields from the biblio and biblioitems tables including the ISSN in the notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:09:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:09:47 +0000 Subject: [Koha-bugs] [Bug 15972] New: Make it possible to include additional title information in notices (such as 245$b) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15972 Bug ID: 15972 Summary: Make it possible to include additional title information in notices (such as 245$b) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org For some titles the 245$a (MARC21) is not specific enough and it would be necessary to include the 245$b information in the notices, that is currently not mapped in the database. Apart from 245$b (remainder of title) other information like 245$n/$p for volumes would be nice to have. This was reported by a library using serial claims - where the title is often the same and the correct serial can only be identified with the help of additional information. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:22:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:22:20 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47936|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 48632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48632&action=edit Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees This enhancment allows a library to prevent patrons from checking out items if his or her guarantees own too much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:22:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:22:17 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:29:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:29:39 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:29:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:29:42 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48617|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 48633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48633&action=edit Bug 15968: Unnecessary loop in C4::Templates >From C4::Templates::output # add variables set via param to $vars for processing for my $k ( keys %{ $self->{VARS} } ) { $vars->{$k} = $self->{VARS}->{$k}; } This loop is not necessary, we could do the same with $vars = { %$vars, %{ $self->{VARS} } }; After a quick benchmark, it gains 100 microseconds when we pass 170 vars to the template. Test plan: Do some clicks on the interface, everything should be ok. Signed-off-by: Fr?d?ric Demians Perl idiosyncratic way of merging hash, clearer, if not quicker (not verified) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:33:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:33:01 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #39 from R?mi Mayrand-Provencher --- Created attachment 48634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48634&action=edit Bug 6934 - QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:35:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:35:38 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |remi.mayrand-provencher at inL | |ibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:38:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:38:59 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access files from the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #37 from Blou --- Created attachment 48635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48635&action=edit Bug 11317 - Allows for multiple directories to be accessible It is now possible to add as many SOMEDIR as needed to the config file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:41:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:41:13 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- It works. But why this: + $('#koha2marc').find("input:submit").hide(); Since you have already this: - If at first place, you hide in JS the submit button, isn't it in order to keep working the form whether JS is disabled. So why suppressing the itself? For me, JS has to be activated in the pro interface, and as so, the JS line should be suppressed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:44:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:44:42 +0000 Subject: [Koha-bugs] [Bug 15973] New: Do not disable syspref cache for Plack Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 Bug ID: 15973 Summary: Do not disable syspref cache for Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13805 Bug 13805 fixes an installer bug by disabling the syspref cache. It was not a good idea, it introduced performance issues (see bug 13805 comment 14). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 [Bug 13805] Installer does not work under Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:44:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:44:42 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 [Bug 15973] Do not disable syspref cache for Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:46:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:46:38 +0000 Subject: [Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:46:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:46:41 +0000 Subject: [Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 --- Comment #1 from Jonathan Druart --- Created attachment 48636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48636&action=edit Bug 15973: Revert "Bug 13805: (Plack) Disable syspref cache" This reverts commit ca00f0ddaeb76106b4aa274fd1848844ae042f58. Bug 13805 fixes an installer bug by disabling the syspref cache. It was not a good idea, it introduced performance issues (see bug 13805 comment 14). Test plan: Test plan: 0/ Create a new database and fill the database entry in the koha conf with its name 1/ Go on the mainpage, you should be redirected to the installer 2/ Try to log in You should not get the login form again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:46:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:46:43 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #27 from Mirko Tietgen --- Created attachment 48637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48637&action=edit Bug 14168 Followup: Atomic update for syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:47:18 +0000 Subject: [Koha-bugs] [Bug 13805] Installer does not work under Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 --- Comment #18 from Jonathan Druart --- See bug 15973 for the revert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:49:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:49:20 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 --- Comment #2 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #1) > (In reply to Jonathan Druart from comment #0) > > Just played with nytprof and found something exciting: > > > > If I remove the following line: > > C4::Context->clear_syspref_cache(); > > from the psgi file, the processing time is divided per 2 (!) > > > > With the clear cache: > > for 15.8s (of 18.6s), executing 2588556 statements and 903720 subroutine > > calls in 421 source files and 63 string evals. > > > > Without the clear cache: > > for 7.82s (of 8.69s), executing 904432 statements and 262539 subroutine > > calls in 421 source files and 63 string evals. > > Such a difference looks kind of weird - unless the script you are testing > calls (for whatever reasons) CGI->new() repeatedly ? > > BTW, how many times was C4::Context::preference() called in that test? No idea, patch is coming. > > Am I missing something? > > With that line removed, each time when you change some syspref value, you'll > need to restart starman server/workers manually for that change to take > effect. However, clearing syspref cache inside CGI->new() override sub is > probably not 100% flawless method anyway, so serwer restarts are still > needed if one wants to be on the safe side ;) Yes indeed, I have fixed bug 11998 to solve this constraint. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:49:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:49:31 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 [Bug 15970] Plack should not clear syspref cache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:49:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:49:31 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 [Bug 11998] Syspref caching issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:53:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:53:25 +0000 Subject: [Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 --- Comment #2 from Jonathan Druart --- Created attachment 48638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48638&action=edit Bug 15973: follow-up for the debian package psgi file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 17:58:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 16:58:07 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48632|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 48639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48639&action=edit Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees This enhancment allows a library to prevent patrons from checking out items if his or her guarantees own too much. Test Plan: 1) Apply this patch 2) Find or create a patron with a guarantor 3) Add a fine to the patron's account 4) Set the new system preference NoIssuesChargeGuarantees to be less than the amount owed by the patron 4) Attempt to check out an item to the guarantor, you will either be warned or prevented from checking out based on your system settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:11:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:11:03 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:11:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:11:09 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36583|0 |1 is obsolete| | Attachment #36584|0 |1 is obsolete| | Attachment #36585|0 |1 is obsolete| | Attachment #36586|0 |1 is obsolete| | Attachment #36587|0 |1 is obsolete| | Attachment #36588|0 |1 is obsolete| | Attachment #36589|0 |1 is obsolete| | Attachment #36590|0 |1 is obsolete| | Attachment #36591|0 |1 is obsolete| | Attachment #36592|0 |1 is obsolete| | Attachment #36593|0 |1 is obsolete| | Attachment #36594|0 |1 is obsolete| | Attachment #36595|0 |1 is obsolete| | --- Comment #97 from Jonathan Druart --- Created attachment 48640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48640&action=edit Bug 11998: Use Koha::Cache to cache sysprefs At the moment, the sysprefs are only cache in the thread memory executing the processus When using Plack, that means we need to clear the syspref cache on each page. To avoid that, we can use Koha::Cache to cache the sysprefs correctly. A big part of the authorship of this patch goes to Robin Sheat. Test plan: 1/ Add/Update/Delete local use prefs 2/ Update pref values and confirm that the changes are correctly taken into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:19:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:19:36 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:19:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:19:39 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 --- Comment #3 from Jonathan Druart --- Created attachment 48641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48641&action=edit Bug 15970: Do not clear syspref cache in psgi file This in only in koha.psgi, it has been introduced by bug 13815 but should not have been added by this patch. Removing it should not introduce any changes. Not that it won't impact debian packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:23:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:23:03 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #40 from H?ctor Eduardo Castro Avalos --- Created attachment 48642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48642&action=edit Cash register image Hi R?mi Still capitalization in reports-menu.inc >
  • Serials
  • >
  • Cash Register
  • I could observe this: When you start both calendars are set with the current date, i.e., 2016-03-03, but if you change the "From:" date to 2016-01-01, the date in "To:" change also and if you try to change it, for example, to the current date (2016-03-03), you cannot do it at all with the calendar, just manually. See image attached. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:23:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:23:23 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:24:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:24:06 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48587|0 |1 is obsolete| | --- Comment #28 from Jesse Weaver --- Created attachment 48643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48643&action=edit Bug 14168: (followup) require WWW::YouTube::Download only when syspref enabled This patch fixes the problem of missing WWW::YouTube::Download breaking record detail views. Instead of a general 'use', the module is only required if the related syspref is enabled. Signed-off-by: Jesse Weaver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:24:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:24:13 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48637|0 |1 is obsolete| | --- Comment #29 from Jesse Weaver --- Created attachment 48644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48644&action=edit Bug 14168: (followup) atomic update for syspref Signed-off-by: Jesse Weaver Fixed small typo (extra '). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:27:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:27:05 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > Something interesting: > > on master: > # spent 35.1ms within DBI::common::DESTROY which was called 12520 times, avg > 3?s/call > > with path: > # spent 2.54s (697ms+1.85) within DBIx::Class::DESTROY which was called > 118584 times, avg 21?s/call Note that I don't get that without C4::Context->clear_syspref_cache, see bug 15970. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:29:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:29:56 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Status|Failed QA |Signed Off --- Comment #21 from Kyle M Hall --- I think the issue at hand is that this patch revealed a new bug in testing where the non-package version of Koha's apache conf no longer matches the package version in behavior and functionality. While appreciated, I think Fr?d?ric's followup is not needed and we should instead fix the bug for non-package installs of Koha. That should solve the issue and once that and the license followup have been submitted this can move forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:30:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:30:07 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #41 from H?ctor Eduardo Castro Avalos --- Of course otherwise works correctly. About QA comments (comment 38) we need to await Jonathan's reply. Regards -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:30:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:30:14 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 18:30:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 17:30:23 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #98 from Jonathan Druart --- Patches squashed, rebased and adapted to current master. I have rewritten and it seems to work as expected. See also bug 15970, bug 15341 and bug 15873, to know why we need this patch. Note that we still have Name "Cache::RemovalStrategy::FIELDS" used only once: possible typo at /usr/share/perl/5.20/fields.pm line 135. Name "Cache::RemovalStrategy::LRU::FIELDS" used only once: possible typo at /usr/share/perl/5.20/fields.pm line 135. Name "Tie::Hash::FIELDS" used only once: possible typo at /usr/share/perl/5.20/fields.pm line 135. Forget them, unless you know how to fix them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:06:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 18:06:08 +0000 Subject: [Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11998 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:06:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 18:06:08 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15973 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:45:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 18:45:23 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #22 from Fr?d?ric Demians --- Kyle, my patch was also about adding (In reply to Kyle M Hall from comment #21) > I think the issue at hand is that this patch revealed a new bug in testing > where the non-package version of Koha's apache conf no longer matches the > package version in behavior and functionality. While appreciated, I think > Fr?d?ric's followup is not needed and we should instead fix the bug for > non-package installs of Koha. That should solve the issue and once that and > the license followup have been submitted this can move forward. I agree with this plan... Where is located the Apache conf file? Do you already know what is its difference with etc/koha-http.conf? My followup patch was also introducing a way to specify a local XSLT in extended mode. See this: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46460&action=diff But it could be added later when this patch will be in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:53:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 18:53:18 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #25 from R?mi Mayrand-Provencher --- Created attachment 48645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48645&action=edit Bug 12532 - Redirect guarantee email to guarantor Added unit tests. Added an atomicupdate file. Reordered the sysprefs in alphabetical order. Refactored some code. TEST PLAN: I Apply the patch II Run updatedatabase.pl III Run db_dependent/Letters.t and db_dependant/Members.t 0) Enable EnhancedMessagingPreferences preference; 0) Enable EnableRedirectGuaranteeEmail preference; 1) Select a patron with child; 2) Enable Item checkout -> email in patron messaging preferences; 3) Select the patron's child; 4) Checkout an item; 5) Valide child checkout message in patron's inbox; sponsored by the ville de victoriaville Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 19:56:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 18:56:23 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |remi.mayrand-provencher at inL | |ibro.com Status|Patch doesn't apply |Needs Signoff --- Comment #26 from R?mi Mayrand-Provencher --- Fixed conflicts, the patch should now apply properly. Like my coworker said earlier in this discussion, our sponsor is not interested in developping a new preference that allows guarantors to be cc'd. We think this patch is ok on its own and if there happens to be a need for guarantors to be cc'd, the patch for this new feature should be in another bug report. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:13:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:13:33 +0000 Subject: [Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 --- Comment #30 from Brendan Gallagher --- Ok I should be caught up on this one now. Please let me know if I did something screwy or missed something. Thanks much -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:28:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:28:54 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:29:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:29:24 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #25 from R?mi Mayrand-Provencher --- Created attachment 48649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48649&action=edit Bug 11297 - Add support for custom PQF attributes for Z39.50 server searches. Adds the "Attributes" field to z3950 servers. The feature here is not quite de same. In the old patches, the attributes were applied to individual query parts if the part already contains "@attr" and the additionnal attribute is not already in the query part. Here, the content of the new field is prepended to all PQF queries sent to the server. This new way of doing is simpler and works for the sponsor. Test plan: I) Apply the patch II) Run updatedatabase.pl 1) Add a new z3950 server with the following parameters: Hostname : catalogue.banq.qc.ca Port : 210 Database : IRIS Syntax : Marc21 2) Perform a z3950 search on that server. Keyword (Any) : egypt 2.1) Nothing Found. 3) Add attributes on the server administration page @attr 4=1 4) Perform the same z3950 search 4.1) A lot of results modified: C4/Breeding.pm modified: Koha/Schema/Result/Z3950server.pm modified: admin/z3950servers.pl new file: installer/data/mysql/atomicupdate/Bug11297_z3950servers_attributes.sql modified: installer/data/mysql/kohastructure.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt Followed test plan, works as expected. Signed-off-by: Marc V?ron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:30:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:30:24 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |remi.mayrand-provencher at inL | |ibro.com --- Comment #26 from R?mi Mayrand-Provencher --- fixed conflicts, patch should apply correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:38:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:38:14 +0000 Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:38:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:38:17 +0000 Subject: [Koha-bugs] [Bug 15889] Login with LDAP deletes extended attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15889 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48327|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 48650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48650&action=edit Bug 15889 - LDAP authentication: Only update mapped attributes. Test plan: - Update your configuration file to use LDAP authentication and enable update (1) option, - login with an existing user with extended attrbitutes that are not in LDAP mapping, - check that all attributes are still here. Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:49:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:49:45 +0000 Subject: [Koha-bugs] [Bug 15974] New: Rancor - 942c is always displaying first in the list. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Bug ID: 15974 Summary: Rancor - 942c is always displaying first in the list. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: ed.veal at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When you open a record up using the advanced marc editor if there is a 942c the display will show the first in the list of possible koha Itypes. If you change this to the correct type it will save correctly. However, if you open a record and don't correct the 942c it will save based on what appears in the field (the first option). Ed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:50:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:50:53 +0000 Subject: [Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46098|0 |1 is obsolete| | --- Comment #8 from H?ctor Eduardo Castro Avalos --- Created attachment 48651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48651&action=edit Bug 14277: add zebra indexes for lexile that respect 521 indicator 1. Added the following indexes: Interest-age-level | 591$a ind1=1 Interest-grade-level | 591$a ind1=2 lexile-number | 591$a ind1=8 Reading-grade-level | 591$a ind1=0 Moved 'lex' from a zebra index to a ccl alias to lexile-number. Changed the handling of st-numeric in C4/Search.pm to allow for search ranges. Signed-off-by: Nick Clemens Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 20:51:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 19:51:32 +0000 Subject: [Koha-bugs] [Bug 14277] Search index 'lex' does not honor MARC indicator "ind1" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14277 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off --- Comment #9 from H?ctor Eduardo Castro Avalos --- Hi Nick and Barton Community sign-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:02:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:02:06 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 --- Comment #5 from Heather Braum --- This issue is definitely a bug, and a step backward in Koha's search. Our system has used Koha for 8 years. And the behavior through 3.18.12 (where our system was before we moved to 3.22.3), was that searching for patrons by both firstname and surname always worked in all the various patron search boxes: holds searching, search patrons, guarantor search, checkout search, etc. When we moved to 3.22.3 on Sunday, I could no longer search for patrons using first name and surname on request.pl (holds requests) and guarantor search (The test patron I used was white sox, but we saw this with numerous other patrons). Checkout search with these names worked, as did using search patrons through the patrons page OR moremember.pl. Yesterday, two librarians reported that the search patrons tab on the Koha home page also returned no results. Nick has temporarily patched these three instances for us so the system is back to behaving the way it always has behaved. There needs to be a more permanent fix for this issue. We can't be the only system where librarians click in these patron search boxes and type in first name and last name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:01:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:01:51 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #202 from Kyle M Hall --- (In reply to Katrin Fischer from comment #198) > We should avoid to repeat the Solr problem - I think part of the problem was > that it was not production ready when included in Koha and I'd hate to see > us get stuck in a similar way with ES. I think the problem was that Solr integration ran out of steam ( i.e. development funding ). That is not going to happen with Elastic. I think it's safe to say that we are fully committed to getting Elastic to work with Koha. It's something of a chicken and egg problem. We can't let past failures cause hesitation on future opportunities, that will only lead to stagnation. As an aside, I'm looking forward to Elastic as a way to greatly speed up our patron search. With Elastic we'll be able to index our patron data as well as record data! In fact, we'll be able to use it for any type of data where we search on large data sets! Once Elastic is part of Koha I plan on starting to work on an (optional) way for the patron search to take advantage of Elastic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:02:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:02:57 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Ed Veal changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |pianohacker at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:07:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:07:45 +0000 Subject: [Koha-bugs] [Bug 15975] New: Add Owning Library Column to Checkouts Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15975 Bug ID: 15975 Summary: Add Owning Library Column to Checkouts Change sponsored?: Seeking cosponsors Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/add-owning-l ibrary-column-checkouts/ OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Work to do: Include owning library column on the list of checkouts for patrons. Pages needing enhancement: cgi-bin/koha/circ/circulation.pl cgi-bin/koha/members/moremember.pl Seeking Co Sponsors : http://devs.bywatersolutions.com/projects/add-owning-library-column-checkouts/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:17:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:17:12 +0000 Subject: [Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #58 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:17:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:17:48 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:24:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:24:56 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:25:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:25:00 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48640|0 |1 is obsolete| | --- Comment #99 from Chris Cormack --- Created attachment 48652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48652&action=edit Bug 11998: Use Koha::Cache to cache sysprefs At the moment, the sysprefs are only cache in the thread memory executing the processus When using Plack, that means we need to clear the syspref cache on each page. To avoid that, we can use Koha::Cache to cache the sysprefs correctly. A big part of the authorship of this patch goes to Robin Sheat. Test plan: 1/ Add/Update/Delete local use prefs 2/ Update pref values and confirm that the changes are correctly taken into account Signed-off-by: Chris -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:28:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:28:42 +0000 Subject: [Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #83 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release! Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:29:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:29:33 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #100 from Chris Cormack --- Please note I have tested this under CGI, caching works fine, but it still needs testing under plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:37:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:37:34 +0000 Subject: [Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Brendan Gallagher --- Ah thanks Jonathan - I thought it was something silly like that. Ok last patch pushed to master - may 2016 release target. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 21:55:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 20:55:25 +0000 Subject: [Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:09:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 21:09:34 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Heather Braum changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:16:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 21:16:42 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #49 from Brendan Gallagher --- Pushed to MAster - Should be in the May 2016 Release. Thanks! (Let me know if I missed something here - but I'm pretty sure we are good to go) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:24:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 21:24:11 +0000 Subject: [Koha-bugs] [Bug 15632] Move the messages related code to Koha::Patron::Messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #51 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:34:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 21:34:28 +0000 Subject: [Koha-bugs] [Bug 15350] DBIx::Class Startup speed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48519|0 |1 is obsolete| | --- Comment #5 from Jesse Weaver --- Created attachment 48653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48653&action=edit Bug 15350: Move the import of Koha::Schema to a basic `use` This moves the import of Koha::Schema from an on-demand `require` to just a `use`; most everything in Koha uses C4::Context, which will indirectly end up calling Koha::Database->schema->new anyway, so this was no longer saving anything. Note that this saves time only when a Plack-based Koha needs to create a database connection, which is usually only the case for a new worker. Unscientific timings before patch: * First load of koha2marclinks.pl on a new worker: 0.70 seconds * Each load after: 0.17 seconds After patch: * First load: 0.31 seconds * Each load after: 0.17 seconds Jonathan, you seem to be right. NYTProf was making me think we needed to do both, but timings suggest otherwise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:53:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 21:53:06 +0000 Subject: [Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|pianohacker at gmail.com |jweaver at bywatersolutions.co | |m CC| |jweaver at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 22:54:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 21:54:48 +0000 Subject: [Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #25 from Jesse Weaver --- Pushed to master, thanks for your work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:08:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:08:07 +0000 Subject: [Koha-bugs] [Bug 15976] New: test bug for a script we are developping. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 Bug ID: 15976 Summary: test bug for a script we are developping. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: remi.mayrand-provencher at inLibro.com Reporter: remi.mayrand-provencher at inLibro.com QA Contact: testopia at bugs.koha-community.org CC: remi.mayrand-provencher at inLibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:08:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:08:46 +0000 Subject: [Koha-bugs] [Bug 15976] test bug for a script we are developping. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |remi.mayrand-provencher at inL |y.org |ibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:11:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:11:07 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:18:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:18:35 +0000 Subject: [Koha-bugs] [Bug 15669] alphabetize marc modification pulldowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:23:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:23:34 +0000 Subject: [Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in May 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:25:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:25:27 +0000 Subject: [Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:30:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:30:09 +0000 Subject: [Koha-bugs] [Bug 15940] Remove unused JavaScript from authorities MARC subfield structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:31:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:31:43 +0000 Subject: [Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:54:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:54:57 +0000 Subject: [Koha-bugs] [Bug 15959] Use Font Awesome icons for attach item confirmations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:56:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:56:19 +0000 Subject: [Koha-bugs] [Bug 15951] Use Font Awesome icons for acquisitions order cancellation confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15951 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2106 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:57:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:57:24 +0000 Subject: [Koha-bugs] [Bug 15950] Use Font Awesome icons for acquisitions basket close confirmation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15950 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 3 23:58:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 22:58:56 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |brendan at bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher --- Needs some rebasing Owen - Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 00:53:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Mar 2016 23:53:30 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #7 from M. Tompsett --- Wow. Much more comprehensive tests. I'll have to look into the clone issue. I can't remember why I had hidden, except to perhaps clarify that a delete was a hide. I'll look more closely at your comments. Though, I just noticed you missed a perldoc change in the package, because you renamed the test file. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 02:45:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 01:45:30 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #44 from Nick Clemens --- On a fresh DB I am having issues with the loss of the 'letternumber' column overdue_notices.pl throws errors for unknown column, I can't save triggers I think the last line below was an accidental deletion? diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql ... @@ -2568,12 +2569,10 @@ CREATE TABLE `message_transport_types` ( DROP TABLE IF EXISTS `overduerules_transport_types`; CREATE TABLE overduerules_transport_types( `id` INT(11) NOT NULL AUTO_INCREMENT, - `branchcode` varchar(10) NOT NULL DEFAULT '', - `categorycode` VARCHAR(10) NOT NULL DEFAULT '', - `letternumber` INT(1) NOT NULL DEFAULT 1, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:00:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 02:00:31 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:00:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 02:00:33 +0000 Subject: [Koha-bugs] [Bug 15967] Print notices are not generated if the patron cannot be notified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15967 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48605|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 48654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48654&action=edit Bug 15967: Fix regression from bug 14133 - notify the library if patron is not Regression introduced by bug 14133, see but 14133 comment 13. Test plan: Without this patch applied, if a patron cannot be notified (no email address or sms number), the print notice generated for the library was not. With this patch applied, the print notice should be generated using the print template Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:02:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 02:02:05 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #45 from M. Tompsett --- Comment on attachment 38288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38288 Bug 13624 - Remove columns branchcode, categorytype from table overduerules_transport_types This is the obsoleted patch where it accidentally disappeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 03:03:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 02:03:02 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #46 from M. Tompsett --- (In reply to Nick Clemens from comment #44) > On a fresh DB I am having issues with the loss of the 'letternumber' column > overdue_notices.pl throws errors for unknown column, I can't save triggers > I think the last line below was an accidental deletion? Yes. I agree with that assessment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 08:07:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 07:07:12 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #203 from Katrin Fischer --- Hi Kyle, I should try and clarify my comment :) I am not against including this as an experimental feature at all! - I just think we need to be clear and upfront in documentation on what is working and what not - so people know what to expect. Right now I am not quite sure what to expect of the work available - what should be working? What is intended to work? It would help me to understand that better and give me a starting point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 09:23:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 08:23:13 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #42 from Jonathan Druart --- (In reply to H?ctor Eduardo Castro Avalos from comment #41) > Of course otherwise works correctly. About QA comments (comment 38) we need > to await Jonathan's reply. No :) Please signoff if everything works as expected. Then I, or another QAer, will be able to qa it again. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 09:30:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 08:30:47 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48652|0 |1 is obsolete| | --- Comment #101 from Josef Moravec --- Created attachment 48655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48655&action=edit Bug 11998: Use Koha::Cache to cache sysprefs At the moment, the sysprefs are only cache in the thread memory executing the processus When using Plack, that means we need to clear the syspref cache on each page. To avoid that, we can use Koha::Cache to cache the sysprefs correctly. A big part of the authorship of this patch goes to Robin Sheat. Test plan: 1/ Add/Update/Delete local use prefs 2/ Update pref values and confirm that the changes are correctly taken into account Signed-off-by: Chris Signed-off-by: Josef Moravec Tested with plack with syspref cache enabled, there is some time between setting the syspref and applying it, but it takes just one reload of page, it shouldn't be problem, should it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 09:34:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 08:34:09 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #47 from Jonathan Druart --- (In reply to Nick Clemens from comment #44) > On a fresh DB I am having issues with the loss of the 'letternumber' column > > overdue_notices.pl throws errors for unknown column, I can't save triggers > > I think the last line below was an accidental deletion? > > diff --git a/installer/data/mysql/kohastructure.sql > b/installer/data/mysql/kohastructure.sql > ... > @@ -2568,12 +2569,10 @@ CREATE TABLE `message_transport_types` ( > DROP TABLE IF EXISTS `overduerules_transport_types`; > CREATE TABLE overduerules_transport_types( > `id` INT(11) NOT NULL AUTO_INCREMENT, > - `branchcode` varchar(10) NOT NULL DEFAULT '', > - `categorycode` VARCHAR(10) NOT NULL DEFAULT '', > - `letternumber` INT(1) NOT NULL DEFAULT 1, Oops, indeed! @inLibro, please provide a follow-up asap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 09:47:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 08:47:05 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 --- Comment #6 from Jonathan Druart --- (In reply to Heather Braum from comment #5) > > Nick has temporarily patched these three instances for us so the system is > back to behaving the way it always has behaved. How? Nick, where is the patch? :) > There needs to be a more permanent fix for this issue. We can't be the only > system where librarians click in these patron search boxes and type in first > name and last name. I understand your POV, but we need to find a solution to satisfy everybody. If we default to "contains", searches will return too many results. We could: 1/ add a special case to search on firstname and surname (if start_with) 2/ add a pref to default on contains or start_with 3/ let the libraries who want a different behavior modify the default with some JS code I like none of these solutions. Anything else to suggest? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 09:58:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 08:58:10 +0000 Subject: [Koha-bugs] [Bug 15350] DBIx::Class Startup speed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13690 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 09:58:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 08:58:10 +0000 Subject: [Koha-bugs] [Bug 13690] Koha::Schema should be lazy-loaded In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13690 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15350 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:01:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:01:52 +0000 Subject: [Koha-bugs] [Bug 15350] DBIx::Class Startup speed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #6 from Jonathan Druart --- Jesse, I finally don't think this patch is worth the gain: for the scripts not using Plack (misc/*), they will load of the schema even if it's not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:07:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:07:37 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48547|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy --- Created attachment 48656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48656&action=edit Bug 15956: New unit test SIP/Message.t This patch adds a unit test for the handlers of Patron Status and Patron Info requests. It can be extended with test for the other handlers later (hopefully). Note: The tests have been written for SIP protocol version 2. Test plan: Run t/db_dependent/SIP/Message.t. Note: If bug 13871 has not yet been pushed, test 12 (subtest 1) should fail with something like 'Code AF not found'. Same for test 15 of subtest 2. That is no problem; after that push, all tests should pass. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:32:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:32:19 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #102 from Jonathan Druart --- (In reply to Josef Moravec from comment #101) > Tested with plack with syspref cache enabled, there is some time between > setting the syspref and applying it, but it takes just one reload of page, > it shouldn't be problem, should it? Interesting, I have not noticed that. If it's just a couple of seconds, I am sure it is fine :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:34:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:34:04 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |magnus at libriotech.no --- Comment #31 from Magnus Enger --- Katrin told me to do it! could someone mark 14377 doesn't apply for me? fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:40:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:40:55 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45564|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 48657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48657&action=edit Bug #14377 Show "BIBNO - Suppressed in OPAC" for records with 942$n=1. Includes class="suppressed_opac" for library specific styles. Suggested css: .suppressed_opac { color:red; font-size:1.25em; font-weight:bold; float:right; margin-right:2em; clear:none; } Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:41:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:41:03 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45566|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart --- Created attachment 48658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48658&action=edit Bug 14377 [QA Followup] - Use true value description for authorised value Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:41:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:41:08 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45568|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart --- Created attachment 48659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48659&action=edit Bug 14377 [QA Followup] - Remove biblionumber, move message to below title for search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:41:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:41:12 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46900|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 48660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48660&action=edit Bug 14377 [QA Followup] - Add support for NORMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:41:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:41:17 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46993|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart --- Created attachment 48661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48661&action=edit Bug 14377 [QA Followup] - Don't do 942$n processing for UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:41:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:41:52 +0000 Subject: [Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #37 from Jonathan Druart --- Rebase, easy conflict with bug 4941 fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:47:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:47:11 +0000 Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #26 from Jonathan Druart --- Modern::Perl is used in C4::Ris since bug 12357. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:47:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:47:21 +0000 Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:47:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:47:37 +0000 Subject: [Koha-bugs] [Bug 2505] Omnibus: Enable Perl warnings in all modules and scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2505 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34442|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 10:52:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 09:52:04 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #103 from Josef Moravec --- It looks like it is just 1 or 2 seconds max, so it is absolutely OK ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:07:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:07:57 +0000 Subject: [Koha-bugs] [Bug 15653] Updating a guarantor has never updated its guarantees In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15653 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47265|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48662&action=edit Bug 15653: Remove unused C4::Members::UpdateGuarantees subroutine Looking at the code, there is some broken with the guarantees code. It seems that the expected behavior would be to update address, fax, B_city, mobile, city and phone info of the guarantees when a guarantor is modified. But the code in C4::Members::ModMember is broken: 668 my $borrowercategory= GetBorrowercategory( $data{'category_type'} ); 669 if ( exists $borrowercategory->{'category_type'} && $borrowercategory->{'category_type'} eq ('A' || 'S') ) { 670 # is adult check guarantees; 671 UpdateGuarantees(%data); 672 } First, GetBorrowerCategory expects a categorycode, not a category_type. Then UpdateGuarantees retrieves the param like: 989 sub UpdateGuarantees { 990 my %data = shift; Which means that %data will always be something like ( a_key => undef ) And nothing more. The updateguarantees subroutine (It has been renamed) has been introduced by commit 56825e415fc232e38f0a874dc9a81fa2169ef06b Date: Mon Aug 30 13:48:58 2004 +0000 modularizing (with Members.pm) members management (beginning of...) And the `%data = shift` already existed... This code has never worked and could be removed. See http://lists.koha-community.org/pipermail/koha-devel/2016-January/042241.html Test plan: Confirm the previous assertions. Note that I have found this bug working on bug 15631, see patch "Bug 15631: Koha::Cities - remove getidcity and GetCities" Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:14:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:14:37 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48544|0 |1 is obsolete| | Attachment #48545|0 |1 is obsolete| | Attachment #48546|0 |1 is obsolete| | Attachment #48656|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy --- Created attachment 48663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48663&action=edit Bug 15956: Rearranging some SIP unit tests The original SIP_ILS.t is split up into SIP/Patron.t and SIP/Transaction.t. The assumption on a hardcoded existing and non-existing card number is replaced by adding and deleting a card number (:patron) with TestBuilder. Test plan: Run SIP/Patron.t Run SIP/Transaction.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:14:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:14:41 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 --- Comment #7 from Marcel de Rooy --- Created attachment 48664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48664&action=edit Bug 15956: Remove warn from handle_patron_status Removes a warn and some commented warns. Test plan: Nothing to do here. Will be covered later by additional unit test. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:14:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:14:45 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 --- Comment #8 from Marcel de Rooy --- Created attachment 48665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48665&action=edit Bug 15956: Move SIPILS.t to SIP/ILS.t Move the file. Some trivial (cosmetic) edits: whitespace, comments. Test plan: Run SIP/ILS.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:14:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:14:48 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 --- Comment #9 from Marcel de Rooy --- Created attachment 48666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48666&action=edit Bug 15956: New unit test SIP/Message.t This patch adds a unit test for the handlers of Patron Status and Patron Info requests. It can be extended with test for the other handlers later (hopefully). Note: The tests have been written for SIP protocol version 2. Test plan: Run t/db_dependent/SIP/Message.t. Note: If bug 13871 has not yet been pushed, test 12 (subtest 1) should fail with something like 'Code AF not found'. Same for test 15 of subtest 2. That is no problem; after that push, all tests should pass. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:15:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:15:12 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13871 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:15:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:15:12 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15956 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:15:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:15:32 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13871 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 [Bug 13871] OverDrive message when user authentication fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:15:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:15:32 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15956 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 [Bug 15956] Rearranging some SIP unit tests (test without SIP server) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:16:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:16:43 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48386|0 |1 is obsolete| | Attachment #48387|0 |1 is obsolete| | Attachment #48392|0 |1 is obsolete| | Attachment #48393|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy --- Created attachment 48667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48667&action=edit Bug 13871: Adjusted perl tidy on MsgType.pm Run perltidy pro=xt/perltidyrc on the file. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:16:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:16:49 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #44 from Marcel de Rooy --- Created attachment 48668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48668&action=edit Bug 13871: [TITLE_AMENDED] Additional changes The original perltidy patch from Mason has been amended. The perltidy itself has been moved to a separate patch with the current perltidyrc applied. As noted on Bugzilla, the original perltidy patch included some extra changes: [1] You prefix timestamp with Sip This is not actually needed (it is imported), but if we should prefix it, we should prefix now with C4::SIP::Sip. But you only changed two occurrences (out of 26). So I remove these two changes. [2] You remove the $server parameter from two calls of maybe_add: A closer look at the remaining code tells me that $server is always passed to maybe_add for FID_SCREEN_MSG. So this only left me the current whitespace change. But at least we documented what we did or did not, and why.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:16:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:16:55 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #45 from Marcel de Rooy --- Created attachment 48669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48669&action=edit Bug 13871 - OverDrive message when user authentication fails NOTE: apply this patch after the additional perltidy patch this patch is basically a small work-around to fix some confusing login text, when users enter incorrect auth details via Overdrive's website with this option disabled (default) there is no change to SIP's behaviour to test... 1/ configure your overdrive account to talk to your Koha's SIP service 2/ start Koha's SIP 3/ enter a correct username and correct password in overdrive see overdrive display '(1) Greetings from Koha' (good) 4/ enter a correct username and *incorrect* password in overdrive see overdrive display '(1) Greetings from Koha' (bad) 5/ enter an incorrect username in overdrive see overdrive display '(1)' (badder) 6/ apply patch, enable 'overdrive-mode' in Koha's SIPConfig.xml example... --------------------- --------------------- 7/ restart SIP 8/ enter a correct username and correct password see overdrive display '(1) Greetings from Koha' 9/ enter a correct username and *incorrect* password see overdrive display '(1) Invalid patron or patron password' 10/ enter an incorrect username and incorrect password see overdrive display '(1) Invalid patron or patron password' http://bugs.koha-community.org/show_bug.cgi?id=1387 Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:17:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:17:06 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #47 from Marcel de Rooy --- Created attachment 48671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48671&action=edit Bug 13871: [QA Follow-up] Adjust Patron Info Request Conform QA comment, Patron Info request is slightly adjusted to be consistent with changes to Patron Status request. If the cardnumber is ok and the password is wrong, BL=N is reported but also add 'Invalid password' in AF. Additionally, an invalid card number is reported in AF. Test plan: [1] Send patron info request for invalid card. [2] Idem for valid card, no password. [3] Idem for valid card, good password. [4] Idem for valid card, wrong password. Signed-off-by: Marcel de Rooy Verified by telnetting SIP server. And tested additionally with the new unit test of bug 15956. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:17:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:17:01 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #46 from Marcel de Rooy --- Created attachment 48670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48670&action=edit Bug 13871: [QA Follow-up] Adjust Patron Status Request Conform QA comment on Bugzilla, we do this: [1] Attribute for overdrive mode/invalid credentials is not really needed. We can always pass a screen message that card or password is invalid. [2] If the cardnumber is correct and the password is wrong, we should still honour the request. The bad password is recognized by BLN and an additional message in AF. Signed-off-by: Marcel de Rooy Verified by telnetting SIP server. And tested additionally with the new unit test of bug 15956. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:20:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:20:38 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #48 from Marcel de Rooy --- QA Comment: Since this patch waited much too long, I have been working somewhat more on it to get it thru QA. My main concerns were: [1] Change of behavior when sending correct card number but invalid password. We should get patron info with BL=Y and CQ=N. Your patch changed the if-structure and handled this situation similar to wrong card number. So no patron information. Handled in a followup. [2] Adding a SIPconfig attribute like overdrivemode or msg_invalid_credentials is not really needed. If we can prevent adding such "prefs", the code will be simpler. Although the response contains BL and CQ to inform about the checked credentials, we could just send "Invalid card number" if there is no card (add AF here). If the card is OK and the pw is not, we could add Invalid pw to the existing AF. This does not harm anyone. Handled in a followup. [3] We should have a look at Patron Info too. Added a followup. Added a new report for additional unit tests for changes in Patron Status/Patron Info. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:21:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:21:27 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:31:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:31:00 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #49 from Marcel de Rooy --- Created attachment 48672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48672&action=edit Bug 13871: [QA Follow-up] Add $server for FID_SCREEN_MSG When you are ready, you still see that small detail. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:32:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:32:30 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (test without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:32:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:32:56 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rearranging some SIP unit |Rearranging some SIP unit |tests (test without SIP |tests (testable without SIP |server) |server) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 11:36:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 10:36:40 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 --- Comment #10 from Marcel de Rooy --- I have rebased this on top of bug 13871. So please apply that first if not yet pushed. The commit message should be read in that light. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:00:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:00:29 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:00:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:00:37 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #17 from Marcel de Rooy --- Created attachment 48674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48674&action=edit Bug 5404: Move the test to a new IsMarcStructureInternal sub Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:00:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:00:32 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48099|0 |1 is obsolete| | Attachment #48478|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy --- Created attachment 48673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48673&action=edit Bug 5404: C4::Koha - remove subfield_is_koha_internal_p The commit b5ecefd485a75d54a5fa26fff5a0cc890541e2c3 Date: Mon Feb 3 18:46:00 2003 +0000 had a funny description: Added function to check if a MARC subfield name is "koha-internal" (instead of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm "Temporarily", since 2003, everything is relative, isn't it? :) The thing is that GetMarcStructure returns hash like field_200 => { subfield_a => { %attributes_of_subfield_a }, %attributes_of_field_200 } The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'. We don't want to loop on these values when looping on subfields. Since there are just { k => v } with v is a scalar (string), it's easier to test if we are processing a subfield testing the reference. At some places, we don't need to test that, we are looping on values from MARC::Field->subfields which are always valid subfields. Test plan: 1/ Edit items using the batch item mod tool 2/ display and edit items via the cataloguing module. You should not see any changes between before and after the patch applied. Tech notes: We need to check what we are processing when we loop on 'subfields' from GetMarcStructure, not from MARC::Field->subfields. Signed-off-by: Josef Moravec Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:00:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:00:41 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #18 from Marcel de Rooy --- Created attachment 48675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48675&action=edit Bug 5404: [QA Follow-up] Add test descriptions Adding descriptions for changes in t/db_dependent/Biblio.t. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:02:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:02:19 +0000 Subject: [Koha-bugs] [Bug 10697] Revert from using GetReserveStatus to use CheckReserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10697 --- Comment #13 from Jonathan Druart --- Comment on attachment 20164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20164 Bug 10697 - Adding more unit tests to CheckReserves Review of attachment 20164: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10697&attachment=20164) ----------------------------------------------------------------- Is it still valid? ::: t/db_dependent/Reserves.t @@ +130,5 @@ > + $constraint, $bibitems, $priority, $resdate, $expdate, $notes, > + $title, undef, $found); > + > +($status, $reserve, $all_reserves) = CheckReserves($itemnumber2); > +is($status,"Reserved", "Reserved - title level hold, still on shelf"); Why are we expecting "Reserved"? If I understand correctly the tests, there is not hold at this point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:08:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:08:18 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:08:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:08:21 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48633|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 48676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48676&action=edit Bug 15968: Unnecessary loop in C4::Templates >From C4::Templates::output # add variables set via param to $vars for processing for my $k ( keys %{ $self->{VARS} } ) { $vars->{$k} = $self->{VARS}->{$k}; } This loop is not necessary, we could do the same with $vars = { %$vars, %{ $self->{VARS} } }; After a quick benchmark, it gains 100 microseconds when we pass 170 vars to the template. Test plan: Do some clicks on the interface, everything should be ok. Signed-off-by: Fr?d?ric Demians Perl idiosyncratic way of merging hash, clearer, if not quicker (not verified) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:09:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:09:13 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:09:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:09:16 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22818|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 48677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48677&action=edit Bug 11203 - Datatables in acqusitions do not ignore "stopwords" in titles Sorting by the "summary" column does not produce the preferred results. Title beginning with 'a', 'an', or 'the' are sorted using those articles. Test plan: 1) Place an order for 2 items with the titles "Alpha" and "The Alpha", along with some other records with titles starting with something between 'a' and 't', and 't' and 'z' 2) Sort the "pending orders" table, note the incorrect sorting 3) Receive all the items 4) Sort the "already received" table, note the incorrect sorting 5) Apply the patch 6) Repeat steps 1-4, note the corrected sorting 7) Check acqui/basket.pl for correct sorting 8) Check acqui/invoice.pl for correct sorting JD: Disclaimer: I have not tested this patch, just rebased it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:09:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:09:22 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #4 from Marcel de Rooy --- Great test plan :) And the speed is back ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:17:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:17:33 +0000 Subject: [Koha-bugs] [Bug 15977] New: Optional double screen message in Patron Info/Status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15977 Bug ID: 15977 Summary: Optional double screen message in Patron Info/Status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com This code in MsgType.pm: $resp .= maybe_add( FID_SCREEN_MSG, $patron->{branchcode}, $server ) if ( $server->{account}->{send_patron_home_library_in_af} ); produces two AFs if you enable that attribute in your config. Not sure if that should be the case and is conform protocol. Also: are we solving a problem here in the wrong place? It looks kind of inappropriate use.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:24:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:24:16 +0000 Subject: [Koha-bugs] [Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Patch doesn't apply |RESOLVED --- Comment #4 from Jonathan Druart --- This is not needed anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:24:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:24:36 +0000 Subject: [Koha-bugs] [Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Patch doesn't apply |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Jonathan Druart --- This is not needed anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:30:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:30:10 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #19 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #18) > Created attachment 48675 [details] [review] > Bug 5404: [QA Follow-up] Add test descriptions > > Adding descriptions for changes in t/db_dependent/Biblio.t. Oops forgot that, thanks for the follow-up! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 12:42:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 11:42:36 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #104 from Jacek Ablewicz --- Code itself looks fine to me, but I'm a bit worried about some potential problems this patch may introduce indirectly. As it would be now possible to set up permanent & shared cache for system preferences (memcache, fastmmap), in such installations we may expect some extra troubles, e.g. with: - bunch of t/* tests (quite o lot of them) is still using ->set_preference() insted of mock_preference() - they don't commit changes to the database, but running them may now result in syspref "cache poisoning", affecting behaviour of the other processes - remaining code chunks which are dealing with systempreferences table directly (installer, updatedatabase.pl, some tests and admin/maintenance scripts); updatedatabase.pl seems to be OK (at least at the 1st glance), not sure about installer - it does call clear_syspref_cache() 1+ time, but not necessarily everywhere where it should do it / not at the each and every step (?) - up to now, when a given script retrieved some preference once, it was guaranted that all subsequent ->preference() calls during the script run will return the same value; now it will always use the current value instead - I guess sometimes that will be a good thing, and sometimes not so much - but probably not very important in practical circumstances Also there will be some (hopefully very) little performace hit due to caching system overheads (and 10 sec deafult expire in case of Cache::Memory - but it will affect only the long-running scripts) - how little, it remains to be seen ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:20:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 12:20:53 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:20:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 12:20:56 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48580|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall --- Created attachment 48678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48678&action=edit Bug 14694: Create data the tests need Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:49:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 12:49:22 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43600|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 48679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48679&action=edit Bug 11565 - decreaseLoanHighHolds needs Override This patch allows the high holds loan length decrease to be overridden either by a checkbox that remembers its setting during a series of checkouts, or by a one time use override checkbox that will show in the warning popup if a checkout is affected by high holds. Test Plan: 1) Set up a checkout that will be affected by decreaseLoanHighHolds 2) Attempt to check out an item 3) Check the override checkbox 4) Note the checkout date is not reduced 5) Return the item 6) Start a new checkout for the patron 7) Check the "Don't decrease lean length based on holds" checkbox 8) Check out the item 9) Note you are not warned about the high holds decrease and that the checkout length is not reduced Signed-off-by: Kyle M Hall Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:49:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 12:49:48 +0000 Subject: [Koha-bugs] [Bug 11565] decreaseLoanHighHolds needs Override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:56:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 12:56:58 +0000 Subject: [Koha-bugs] [Bug 15635] Move the patron images related code to Koha::Patron::Images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15635 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle at bywatersolutions.com --- Comment #32 from Kyle M Hall --- Pushed to Master, should be in the May 2106 Release. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:57:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 12:57:53 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #3) > Created attachment 48641 [details] [review] > Bug 15970: Do not clear syspref cache in psgi file > > This in only in koha.psgi, it has been introduced by bug 13815 but > should not have been added by this patch. > > Removing it should not introduce any changes. > Not that it won't impact debian packages. Yeah. No one cares about misc/plack/koha.psgi. Why not patching debian/templates/plack.psgi instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:59:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 12:59:24 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 [Bug 15978] Use Font Awesome icons for guided reports error dialog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 13:59:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 12:59:24 +0000 Subject: [Koha-bugs] [Bug 15978] New: Use Font Awesome icons for guided reports error dialog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Bug ID: 15978 Summary: Use Font Awesome icons for guided reports error dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/marctagstructure.pl OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 15785 If you create or update an SQL report using an invalid authorized value a dialog will ask you to confirm before saving the report. This dialog should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:01:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:01:55 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:20:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:20:40 +0000 Subject: [Koha-bugs] [Bug 15976] test bug for a script we are developping. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 --- Comment #1 from R?mi Mayrand-Provencher --- Created attachment 48680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48680&action=edit bug test boop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:22:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:22:51 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #27 from Katrin Fischer --- Created attachment 48681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48681&action=edit [PASSED QA] Bug 14306: Show URL from MARC21 field 555$u under Title Notes/Descriptions This patch includes: [1] Add some logic to GetMarcNotes to embed the contents of MARC21 field 555$u in a html anchor tag. [2] Add a unit test for GetMarcNotes in Biblio.t [3] Remove calls to GetMarcNotes from sendbasket.pl (opac and staff). A closer look revealed that the data was not used; the notes in the mail of sendbasket are taken from GetBiblioData. Test plan: [1] Edit a record. Add one or two URLS in 555$u. Add something in 500$a too. [2] Check if you can click the URLs in opac and staff detail tab Notes or Descriptions. [3] Run the unit test t/db../Biblio.t [4] Add something in the cart. Click More Details and send the cart. Verify that you have something in Notes (from 500$a). Signed-off-by: Marc Veron Followed test plan. Works as expected. QA tools OK. Tested with all patches together, works as expected Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:22:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:22:55 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #28 from Katrin Fischer --- Created attachment 48682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48682&action=edit [PASSED QA] Bug 14306: Follow-up for URLs in 555$u This patch removes the code for inserting the anchor tags around URLs in GetMarcNotes (as added originally). The URLs are placed in separate array elements; the template should take care of further handling. The unit test has been adjusted accordingly. Test plan: Run the unit test. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:23:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:23:01 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #29 from Katrin Fischer --- Created attachment 48683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48683&action=edit [PASSED QA] Bug 14306: Changes for basket and detail templates A simple regex is added to the basket and detail templates to select the URLs passed separately from MARC21 555$u by GetMarcNotes. Note that the regex tests if a note starts with http:// or https:// and does not contain any whitespace in order to be considered as a url. These URLs are put in an anchor tag. This touches four places: [1] opac detail, tab title notes [2] catalogue detail, tab Descriptions [3] opac basket, more details, notes [4] staff basket, more details, notes Test plan: [1] Edit a record. Add a 500$a, 555$a and a URL in 555$u. Put "http://this is not a url" in the 500$a (whitespace!). [2] Check opac-detail, tab Title Notes. Check the URL. [3] Do the same for catalogue/detail. [4] Add record to cart in OPAC. Open basket. Check More details. [5] Repeat previous step in staff. Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:23:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:23:06 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #30 from Katrin Fischer --- Created attachment 48684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48684&action=edit [PASSED QA] Bug 14306: Remove call to GetMarcNotes from sendshelf Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). Signed-off-by: Marc V?ron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:23:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:23:48 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:23:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:23:53 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:23:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:23:56 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:24:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:24:02 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46253|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:24:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:24:06 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46254|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:26:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:26:24 +0000 Subject: [Koha-bugs] [Bug 15976] test bug for a script we are developping. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 --- Comment #2 from R?mi Mayrand-Provencher --- Created attachment 48685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48685&action=edit bug test preparation for conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:28:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:28:04 +0000 Subject: [Koha-bugs] [Bug 15976] test bug for a script we are developping. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 --- Comment #3 from R?mi Mayrand-Provencher --- Created attachment 48686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48686&action=edit bug test CONFLICT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:33:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:33:22 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #105 from Jonathan Druart --- Created attachment 48687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48687&action=edit Bug 11998: Use t::lib::Mocks::mock_preference in tests Unless in t/db_dependent/Context.t where we want to test the cache behaviors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:33:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:33:27 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #106 from Jonathan Druart --- Created attachment 48688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48688&action=edit Bug 11998: Use C4::Context->preference in Koha/Schema/Result/Item.pm Otherwise some tests won't pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:36:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:36:45 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #107 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #104) > - bunch of t/* tests (quite o lot of them) is still using ->set_preference() > insted of mock_preference() - they don't commit changes to the database, but > running them may now result in syspref "cache poisoning", affecting > behaviour of the other processes Yes, that is addressed in the last 2 patches. > - remaining code chunks which are dealing with systempreferences table > directly (installer, updatedatabase.pl, some tests and admin/maintenance > scripts); updatedatabase.pl seems to be OK (at least at the 1st glance), not > sure about installer - it does call clear_syspref_cache() 1+ time, but not > necessarily everywhere where it should do it / not at the each and every > step (?) Yes, we should replace them, and avoid to update/insert sysprefs during the update DB process. > - up to now, when a given script retrieved some preference once, it was > guaranted that all subsequent ->preference() calls during the script run > will return the same value; now it will always use the current value instead > - I guess sometimes that will be a good thing, and sometimes not so much - > but probably not very important in practical circumstances Theoretically it could be an issue but, as you said, I don't think it could be a problem in practice. > Also there will be some (hopefully very) little performace hit due to > caching system overheads (and 10 sec deafult expire in case of Cache::Memory > - but it will affect only the long-running scripts) - how little, it remains > to be seen ;) In conjunction with other patches (depending on this bug report), I am expecting a gain. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:37:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:37:20 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #108 from Jonathan Druart --- (In reply to Jonathan Druart from comment #105) > Created attachment 48687 [details] [review] > Bug 11998: Use t::lib::Mocks::mock_preference in tests > > Unless in t/db_dependent/Context.t where we want to test the cache > behaviors. Note that tests in t/db_dependent/HoldsQueue.t do not pass, but I have no idea why! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:40:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:40:56 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #109 from Jonathan Druart --- (In reply to Jonathan Druart from comment #108) > (In reply to Jonathan Druart from comment #105) > > Created attachment 48687 [details] [review] [review] > > Bug 11998: Use t::lib::Mocks::mock_preference in tests > > > > Unless in t/db_dependent/Context.t where we want to test the cache > > behaviors. > > Note that tests in t/db_dependent/HoldsQueue.t do not pass, but I have no > idea why! If you use this file (modified by this patch) and prove it on top of master, they don't pass neither. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:48:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:48:43 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 --- Comment #7 from Nick Clemens --- (In reply to Jonathan Druart from comment #6) > (In reply to Heather Braum from comment #5) > > > > Nick has temporarily patched these three instances > How? Nick, where is the patch? :) It is a quick patch to force contains on the affected pages, I don't think you like that solution :-) > 2/ add a pref to default on contains or start_with This is the best option I think so far > I like none of these solutions. Anything else to suggest? I think adding an options for phrase searching with qutoes would restore old and allow new behaviour as well. Terms could be split if not qutoed and used as now if quoted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:49:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:49:17 +0000 Subject: [Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:49:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:49:19 +0000 Subject: [Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 --- Comment #1 from Owen Leonard --- Created attachment 48689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48689&action=edit Bug 15978 - Use Font Awesome icons for guided reports error dialog If you try to save an SQL report with an invalid authorized value placeholder you will be presented with a confirmation dialog. This patch updates it to use Font Awesome icons. Also fixed: Validation error found in testing: Duplicated
    tag and series of redundant inputs. Each input cut had an exact duplicate in the same form. To test, apply the patch and go to Reports -> Create from SQL. - Create a new SQL report and fill in as many fields as possible to verify correct operation. - Try to save your report with an invalid authorized value placeholder, for example: SELECT * FROM items WHERE items.itype = <> - Confirm that the confirmation dialog is styled correctly. - Test the operation of the "Edit SQL" button. You should be sent back a page. - Test the operation of the "Save anyway" button and confirm that your report was saved. - Repeat these steps when editing an existing report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 14:51:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 13:51:25 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 --- Comment #5 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #4) > (In reply to Jonathan Druart from comment #3) > > Created attachment 48641 [details] [review] [review] > > Bug 15970: Do not clear syspref cache in psgi file > > > > This in only in koha.psgi, it has been introduced by bug 13815 but > > should not have been added by this patch. > > > > Removing it should not introduce any changes. > > Not that it won't impact debian packages. > > Yeah. No one cares about misc/plack/koha.psgi. Why not patching > debian/templates/plack.psgi instead? I do :) Because it does not disable the syspref cache, contrary to my earlier belief. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:03:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 14:03:17 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:03:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 14:03:19 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48584|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 48690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48690&action=edit [PASSED QA] Bug 15961 - Use Font Awesome icons for confirmation of currency deletion When deleting a currency, the confirmation and error dialogs should use Font Awesome icons. This patch makes this change. To test, apply the patch and go to Administration -> Currencies and exchange rates. - Click the "delete" link next to any currency. - Verify that the confirmation dialog is correctly styled. - Test the both cancel and confirm operations. - Verify that the deletion confirmation dialog is correctly styled. Bug 15962 prevents testing the error dialog which should appear if you try to delete a currency which is use (defined as a currency in a vendor record). To test this error you could manually enter a currency code into aqbooksellers.currency and then try to delete that currency. Signed-off-by: Nicole C Engard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:13:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 14:13:39 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #43 from H?ctor Eduardo Castro Avalos --- Hi R?mi About my comment 40, i don't know if is that the behavior expected, or, needs to be corrected? Is the patch ready to sign-off? If yes, I'll sign-off immediately. Regards -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:33:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 14:33:02 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #31 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #30) > Signed-off-by: Katrin Fischer Great. Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:40:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 14:40:01 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #110 from Kyle M Hall --- At some point in the tests, StaticHoldsQueueWeight becomes zero for reasons unknown and the unit tests rely on this bug! t/db_dependent/HoldsQueue.t .. 1..26 ok 1 - use C4::Reserves; ok 2 - use C4::HoldsQueue; 1 SET StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at t/db_dependent/HoldsQueue.t line 74. StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 3 - take from homebranch (don't use cost matrix) pick up branch ok 4 - take from homebranch (don't use cost matrix) holding branch ok 5 - take from homebranch (use cost matrix) pick up branch ok 6 - take from homebranch (use cost matrix) holding branch StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 7 - take from holdingbranch (don't use cost matrix) pick up branch ok 8 - take from holdingbranch (don't use cost matrix) holding branch ok 9 - take from holdingbranch (use cost matrix) pick up branch ok 10 - take from holdingbranch (use cost matrix) holding branch StaticHoldsQueueWeight: IggZam,xND8TnZydP,lfyZhGooM9 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 11 - take from lowest cost branch (don't use cost matrix) pick up branch ok 12 - take from lowest cost branch (don't use cost matrix) holding branch ok 13 - take from lowest cost branch (use cost matrix) pick up branch ok 14 - take from lowest cost branch (use cost matrix) holding branch ok 15 - GetHoldsQueueItems ok 16 - item type included in queued items list (bug 5825) ok 17 - C4::HoldsQueue::least_cost_branch returns the local branch if it is in the list of branches to pull from StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 18 - Holds queue filling correct number for default holds policy 'from home library' ok 19 - Holds queue filling 1st correct hold for default holds policy 'from home library' ok 20 - Holds queue filling 2nd correct hold for default holds policy 'from home library' ok 21 - Is today a holiday for pickup branch StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 22 - Holds not filled with items from closed libraries StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 23 - Holds queue filling correct number for holds for default holds policy 'from any library' StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 24 - Holds not filled with items from closed libraries 2 SET StaticHoldsQueueWeight: wVjTn,QwXVJjV,IhgDeror at t/db_dependent/HoldsQueue.t line 395. StaticHoldsQueueWeight: 0 at /home/vagrant/kohaclone/C4/HoldsQueue.pm line 620. ok 25 - Bug 14297 - Holds Queue building ignoring holds where pickup & home branch don't match and item is not from le ok 26 - Bug 15062 - Holds queue with Transport Cost Matrix will transfer item even if transfers disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:47:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 14:47:36 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #111 from Kyle M Hall --- This must be a caching issue. If I simply make this change: ok( exists($queue_item->{itype}), 'item type included in queued items list (bug 5825)' ); +warn "TEST: " . C4::Context->preference("StaticHoldsQueueWeight"); The tests begin to fail on master! I think the only reasonable solution is to mock the actual expected value for the time being and write a replacement for HoldsQueue.t from the ground up in time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:52:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 14:52:16 +0000 Subject: [Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48689|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48691&action=edit [SIGNED-OFF]Bug 15978: Use Font Awesome icons for guided reports error dialog If you try to save an SQL report with an invalid authorized value placeholder you will be presented with a confirmation dialog. This patch updates it to use Font Awesome icons. Also fixed: Validation error found in testing: Duplicated tag and series of redundant inputs. Each input cut had an exact duplicate in the same form. To test, apply the patch and go to Reports -> Create from SQL. - Create a new SQL report and fill in as many fields as possible to verify correct operation. - Try to save your report with an invalid authorized value placeholder, for example: SELECT * FROM items WHERE items.itype = <> - Confirm that the confirmation dialog is styled correctly. - Test the operation of the "Edit SQL" button. You should be sent back a page. - Test the operation of the "Save anyway" button and confirm that your report was saved. - Repeat these steps when editing an existing report. Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 15:52:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 14:52:27 +0000 Subject: [Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:28:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 15:28:29 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48543|0 |1 is obsolete| | --- Comment #6 from Zeno Tajoli --- Created attachment 48692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48692&action=edit Patch for Unimarc format -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:28:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 15:28:56 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 --- Comment #7 from Zeno Tajoli --- Created attachment 48693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48693&action=edit Followup of the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:30:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 15:30:45 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 --- Comment #8 from Zeno Tajoli --- Hi Fr?d?ric , I have written a follow-up of the patch. Now data from 205$a (of father) will go into 461$e (of child). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:32:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 15:32:16 +0000 Subject: [Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- A minor problem: FAIL C4/Circulation.pm OK critic FAIL forbidden patterns forbidden pattern: Data::Dumper::Dumper (line 1870) forbidden pattern: Data::Dumper::Dumper (line 1872) I think this text could be improved: " Item location updated from CART (Not an authorized value) to Fiction shelf " I think that should be "Item shelving location" (since "location" could be confused with "library"). I think the text "Not an authorized value" is not helpful to the user and is potentially scary. Think "UNAUTHOIRZED VALUE!!" I still have an issue with the data-entry aspect of this feature. In testing, I was stopped right away by having not put a space after the colon: 'FIC: CART' works 'FIC:CART' fails silently I don't think it's reasonable to expect the user to know this. For that matter, I don't think it's reasonable to expect the user to know the code for all existing shelving location authorized values. I realize this is an administrative setting, but I think we can do better. At minimum we need: - Text describing explicitly the correct format. - Some way to warn the user if their entry is incorrect. - Text explaining that an "_ALL_" rule overrides all others, or better: - Some way to warn the user if they have set an "_ALL_" rule along with other rules Overall this new patch is a great improvement over the last. But I still think we can do better. I think a separate template is needed, although I wouldn't fail the patch for that unless there was some consensus. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:48:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 15:48:40 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:48:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 15:48:42 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48497|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 48694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48694&action=edit Bug 15832 - Fix items split-up in pendingreserves.tt Test plna: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - libraries filter should not contain duplicate. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:48:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 15:48:58 +0000 Subject: [Koha-bugs] [Bug 15832] Pending reserves: duplicates branches in datatable filter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 16:59:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 15:59:31 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:03:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:03:00 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #6 from Nicole C. Engard --- Created attachment 48695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48695&action=edit opac broken After applying this patch the OPAC display is completely broken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:03:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:03:22 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 --- Comment #7 from Nicole C. Engard --- Created attachment 48696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48696&action=edit no difference in staff And there is no difference in the staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:03:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:03:28 +0000 Subject: [Koha-bugs] [Bug 15436] Use semicolon between series name and volumne information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15436 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:14:21 +0000 Subject: [Koha-bugs] [Bug 15978] Use Font Awesome icons for guided reports error dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15978 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- URL|/cgi-bin/koha/admin/marctag |/cgi-bin/koha/reports/guide |structure.pl |d_reports.pl?phase=Create | |report from SQL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:16:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:16:22 +0000 Subject: [Koha-bugs] [Bug 15979] New: Use Font Awesome icons subscription deletion confirmation dialog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Bug ID: 15979 Summary: Use Font Awesome icons subscription deletion confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-detail.pl?subscript ionid=X&op=del OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 15785 If you try to delete a subscription which has not expired or which has linked issues or items you are presented with a confirmation dialog. This dialog should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:16:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:16:22 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15979 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:22:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:22:01 +0000 Subject: [Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:22:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:22:03 +0000 Subject: [Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 --- Comment #1 from Owen Leonard --- Created attachment 48697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48697&action=edit Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog When deleting a subscription which has not expired or which has linked issues or items, a dialog asks for confirmation. This patch updates the dialog to use Font Awesome icons. Other minor change: Corrected capitalization in dialog heading. To test, apply the patch and go to Serials. - Locate a subscription which can be deleted and which has not expired, has linked items, or has linked issues. - View the detail page for that subscription. - Choose "Delete subscription" from the "Edit" menu. - Verify that the confirmation dialog is correctly styled. - Verify that the "No, don't delete" button works correctly. - Verify that the "Yes, delete" button deletes the subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:29:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:29:18 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #50 from Marcel de Rooy --- Are we still missing some things here? I see some problems related to aqorder and currency when running TestBuilder.t Looking further, I also saw a foreign key for currency in aqorders that does not appear in kohastructure (although that is not the solution yet). Also we need some DBIx updates for Koha/Schema/Result; is that a RM action? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:45:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:45:32 +0000 Subject: [Koha-bugs] [Bug 15291] Can't import item data in acquisition from a stage file with modification templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15291 J Schmidt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jschmidt at switchinc.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:45:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:45:31 +0000 Subject: [Koha-bugs] [Bug 15981] New: Serials frequencies can be deleted without warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Bug ID: 15981 Summary: Serials frequencies can be deleted without warning Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-frequencies.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com There is some code in the serials frequencies template for triggering a JavaScript alert to confirm deletion of a frequency, but it is incomplete. You only get a warning about deleting a frequency which is in use by an existing subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:57:45 +0000 Subject: [Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 17:57:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 16:57:47 +0000 Subject: [Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 --- Comment #1 from Owen Leonard --- Created attachment 48699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48699&action=edit Bug 15981 - Serials frequencies can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial frequency. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage frequencies - In the list of frequencies, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:00:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:00:45 +0000 Subject: [Koha-bugs] [Bug 15982] New: Serials numbering patterns can be deleted without warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Bug ID: 15982 Summary: Serials numbering patterns can be deleted without warning Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-numberpatterns.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com, testopia at bugs.koha-community.org When the user tries to delete a serials numbering pattern there should be a JavaScript alert asking for confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:05:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:05:16 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:05:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:05:19 +0000 Subject: [Koha-bugs] [Bug 15955] Tuning function 'New child record' for Unimarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15955 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48692|0 |1 is obsolete| | Attachment #48693|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 48700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48700&action=edit Tuning function 'New child record' for Unimarc 205$a -> 461$e Now the sYstem tries to insert value of 205$a into 461$a when a child is created from the father record. In UNIMARC 46x tags there is not present a subfield for ediction value (205$a in UNIMARC). To Test: 1) Check to have EasyAnalyticalRecords on 'off' 2) Check to use UNIMARC 3) Create a record with data in 200$a (title), 205$a (ediction), 700 (author) 215$a(Place), 215$d(date) 4) From those record create a child using 'New'->'New child record' 5) See the values in 461 tag: You can see that in 461$a there is the value of 205$a from father This is wrong, you need to have the value of 700 $a and $b from father record, and 205$a in 461$e. 6) Appy the patch 7) Redo 4-5 8) Now 461 is good Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:09:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:09:32 +0000 Subject: [Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:09:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:09:34 +0000 Subject: [Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 --- Comment #1 from Owen Leonard --- Created attachment 48701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48701&action=edit Bug 15982 - Serials numbering patterns can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial numbering pattern. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage numbering patterns. - In the list of patterns, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:14:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:14:02 +0000 Subject: [Koha-bugs] [Bug 15983] New: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Bug ID: 15983 Summary: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-numberpatterns.pl?o p=del&id=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 15785 If you try to delete a serials numbering pattern which is in use by an existing subscription you are presented with a confirmation dialog. This dialog should use Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:14:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:14:02 +0000 Subject: [Koha-bugs] [Bug 15785] Use Font Awesome icons in confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15980 Blocks| |15983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15980 [Bug 15980] Use Font Awesome icons in subscription frequency deletion confirmation dialog https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:35:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:35:29 +0000 Subject: [Koha-bugs] [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:35:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:35:31 +0000 Subject: [Koha-bugs] [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 --- Comment #1 from Owen Leonard --- Created attachment 48702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48702&action=edit Bug 15983 - Use Font Awesome icons in serial numbering pattern deletion confirmation dialog If you try to delete a serial numbering pattern which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to s to fix validation errors. - Added "alert" class to confirmation dialogs so that they correctly styled. To test, apply the patch and go to Serials -> Numbering patterns. - Click "Delete" on a numbering pattern which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct numbering pattern. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:50:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:50:22 +0000 Subject: [Koha-bugs] [Bug 15984] New: Correct templates which use the phrase "issuing rules" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15984 Bug ID: 15984 Summary: Correct templates which use the phrase "issuing rules" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart at bugs.koha-community.org, testopia at bugs.koha-community.org Two more templates uses the old "issuing rules" phrase. They should be updated to say "circulation and fine rules." help/admin/smart-rules.tt help/tools/automatic_item_modification_by_age.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 18:50:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 17:50:22 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15984 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 20:37:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 19:37:23 +0000 Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #107 from Kyle M Hall --- I just had a thought about this. I think the db column 'new' is going to never be accessible via Koha::Item. I think a followup will be needed to change the column from 'new' to maybe 'new_status'? Any other column name suggestions would be appreciated! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 20:42:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 19:42:10 +0000 Subject: [Koha-bugs] [Bug 13927] Add API route to check hold capabilities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Attachment #37365|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 20:42:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 19:42:13 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #51 from Kyle M Hall --- Created attachment 48703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48703&action=edit Bug 15084 [QA Followup] - Update Schema files Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 20:43:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 19:43:22 +0000 Subject: [Koha-bugs] [Bug 13927] Add API route to check hold capabilities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13927 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37365|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 20:53:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 19:53:45 +0000 Subject: [Koha-bugs] [Bug 15985] New: Include transacting library in fines Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Bug ID: 15985 Summary: Include transacting library in fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Work to be done: 1) Add column issue_id to accountlines table 2) Modify fines generation to set issue_id for fine upon generation 3) Modify updatedatabase.pl to insert issue_id in accountlines for currently accruing fines 4) On the pay fines page, use this data to display the library where the item was checked out from -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:00:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:00:57 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #8 from M. Tompsett --- (In reply to Tom?s Cohen Arazi from comment #6) > Mark: you need to get rid of the clone. The RecordProcessor pipeline is > designed so it works on the original object. I'm torn on that. %%%% SNIP %%%% sub process { my $self = shift; my $record = shift || $self->record; return unless defined $record; my $newrecord = $record; foreach my $filterobj (@{$self->filters}) { next unless $filterobj; $newrecord = $filterobj->filter($newrecord); } return $newrecord; } %%%% SNIP %%%% The clincher for me is that the $filterobj->filter call returns something. What is the point of returning something if we are modifying the original object? The return $newrecord is still necessary because of pre-call binding or passing the record(s) directly. However, the "$newrecord =" makes no sense if the original was not intended to stay intact, because it would have already been modified! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:14:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:14:49 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #44 from R?mi Mayrand-Provencher --- Created attachment 48704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48704&action=edit Bug 6934 Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:15:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:15:28 +0000 Subject: [Koha-bugs] [Bug 8994] Make FindDuplicateAuthority behaviour customizable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8994 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #10 from Chris Cormack --- CONFLICT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:16:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:16:11 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #45 from R?mi Mayrand-Provencher --- This bug should be ready to be signed-off now, thank you for noticing that the calendar weren't functionning as they should have. I Fixed that now. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:18:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:18:55 +0000 Subject: [Koha-bugs] [Bug 14746] Set up logging and configuration file reading for Mojolicious In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14746 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:19:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:19:36 +0000 Subject: [Koha-bugs] [Bug 14747] RESTful API with reverse proxy configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14747 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:20:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:20:17 +0000 Subject: [Koha-bugs] [Bug 14362] PEGI 15 Circulation/AgeRestrictionMarkers test fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14362 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:33:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:33:46 +0000 Subject: [Koha-bugs] [Bug 15986] New: Add a script for sending hold waiting reminder notices Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Bug ID: 15986 Summary: Add a script for sending hold waiting reminder notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Write a script that will take two parameters: a) Length of time hold has been waiting ( in days ) b) Letter code of notice to be emailed 2) Script will take these two parameters and send the specified notice for each hold a patron has. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:34:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:34:43 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole at bywatersolutions.com | |, rhilliker at hotchkiss.org Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:53:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:53:09 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 21:53:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 20:53:09 +0000 Subject: [Koha-bugs] [Bug 15987] New: Acq module fails with undefined subroutine &main::GetCurrency Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Bug ID: 15987 Summary: Acq module fails with undefined subroutine &main::GetCurrency Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart at bugs.koha-community.org Reporter: hector.hecaxmmx at gmail.com QA Contact: testopia at bugs.koha-community.org Depends on: 15084 Acq module fails with undefined subroutine &main::GetCurrency Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:05:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 21:05:10 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #46 from H?ctor Eduardo Castro Avalos --- (In reply to R?mi Mayrand-Provencher from comment #45) > This bug should be ready to be signed-off now, thank you for noticing that > the calendar weren't functionning as they should have. I Fixed that now. Sorry R?mi but doesn't work The message presented is: Form not submitted because of the following problem(s) ------------------------------------------------------------------- - Dates cannot be empty Probably about this bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:13:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 21:13:56 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #47 from R?mi Mayrand-Provencher --- Created attachment 48705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48705&action=edit bug 6934 - second fix to calendars -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:15:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 21:15:11 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #48 from R?mi Mayrand-Provencher --- Really sorry, it was my mistake, I should have tested it again just before sending my patch. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:31:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 21:31:37 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48634|0 |1 is obsolete| | --- Comment #49 from H?ctor Eduardo Castro Avalos --- Created attachment 48706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48706&action=edit [SIGNED-OFF]Bug 6934: QA Follow-up Tried to address every single thing that QA mentioned : 1)Removed isNull function 2)Changed datepicker properly 3)We have to fill in two dates not to be flooded with old entries if we don't want to. 4)The first two fieldsets are now in one bigger field set 5)Removed the use of $fullreportname variable 6)Removed the use of dt_from_string when it already recieved a DT. 7)Removed comments starting with "###" in cash_register_stats.pl 8)Used Text::CSV::Encoded to generate the CSV file (used guided_reports.pl as an example) 9)I am not sure if using C4::Reports::Guided is the right choice here. I instead used the same column names as the one recieved by the query in cash_register_stats because this report uses columns from 5 different tables in addition of using both firstname and surname twice. For the ninth point, I would like to know more about C4::Reports::Guided if you still think using it would be a better solution. Thank you! Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:31:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 21:31:56 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48704|0 |1 is obsolete| | --- Comment #50 from H?ctor Eduardo Castro Avalos --- Created attachment 48707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48707&action=edit [SIGNED-OFF]Bug 6934 Fixed Calendar and removed used of unexisting and unused C4::Budgets getCurrency Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:32:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 21:32:09 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48705|0 |1 is obsolete| | --- Comment #51 from H?ctor Eduardo Castro Avalos --- Created attachment 48708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48708&action=edit [SIGNED-OFF]Bug 6934: second fix to calendars Signed-off-by: Hector Castro -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:33:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 21:33:06 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 22:36:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 21:36:17 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #52 from H?ctor Eduardo Castro Avalos --- R?mi just another issue, when exporting there are problem with utf-8: branchname date accounttype amount title barcode itype Midway 2016-01-25T00:00:00 Rent 5 A lot like love / 2015-0004 Midway 2016-01-28T00:00:00 Rent 5 Antolog??a de entremeses del Siglo de Oro / 2016-0001 But I think IMHO this could be treated in another bug. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 4 23:12:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Mar 2016 22:12:29 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Nick Clemens --- /home/vagrant/kohaclone/.git/rebase-apply/patch:432: trailing whitespace. my @biblionumbers = ref($query->param('biblionumbers')) eq 'Array' fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 21:33:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 20:33:38 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48569|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia --- Created attachment 48709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48709&action=edit Bug 15965: Koha to MARC mapping - table changes with selection of drop down menu EDIT: Removing JS line To test: 1) Go to Admin -> Koha to MARC Mapping 2) Test selecting biblio / biblioitems / items 3) Confirm the table content changes and behaves as it should which each selection Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:28:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:28:47 +0000 Subject: [Koha-bugs] [Bug 13666] Allow SIP2 checkin/checkout to get branch from institution_id field AO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13666 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:29:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:29:30 +0000 Subject: [Koha-bugs] [Bug 13705] Move indexation subs in C4::ZebraIndex In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13705 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:31:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:31:43 +0000 Subject: [Koha-bugs] [Bug 13932] Allow a header to be considered trusted to provide the userid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13932 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Chris Cormack --- fatal: sha1 information is lacking or useless (C4/Auth.pm). error: could not build fake ancestor at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:32:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:32:21 +0000 Subject: [Koha-bugs] [Bug 10440] During receipting for any holds attached to items being receipted, to be identified during the receipting process. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10440 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:32:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:32:42 +0000 Subject: [Koha-bugs] [Bug 13717] Add ability to move old patron attributes when importing borrowers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13717 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- This bug depends on 12598 which is in status Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:33:17 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:35:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:35:50 +0000 Subject: [Koha-bugs] [Bug 13807] SIPServer Input loop not checking for closed connections reliably In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13807 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:36:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:36:22 +0000 Subject: [Koha-bugs] [Bug 13660] rebuild_zebra_sliced.sh - Exclude export phase and use existing exported MARCXML. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13660 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:38:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:38:13 +0000 Subject: [Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:38:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:38:16 +0000 Subject: [Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 --- Comment #1 from Aleisha Amohia --- Created attachment 48710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48710&action=edit Bug 15966: Move MARC frameworks actions into a drop down menu To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:38:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:38:26 +0000 Subject: [Koha-bugs] [Bug 12902] Cronjob monitoring script, nagios3 compatible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org --- Comment #2 from I'm just a bot --- Patch applied cleanly\n -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:40:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:40:39 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:40:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:40:58 +0000 Subject: [Koha-bugs] [Bug 12460] Search history: Combine to start a new search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org --- Comment #13 from I'm just a bot --- This bug depends on 14699 which is in status In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:41:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:41:40 +0000 Subject: [Koha-bugs] [Bug 14843] Notifications and messages via REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org --- Comment #5 from I'm just a bot --- fatal: sha1 information is lacking or useless (Koha/AuthUtils.pm). error: could not build fake ancestor at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:41:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:41:56 +0000 Subject: [Koha-bugs] [Bug 14843] Notifications and messages via REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 --- Comment #6 from I'm just a bot --- This bug depends on bug7174 which is in status Needs Signoff but the patches for it do not apply cleanly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:42:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:42:28 +0000 Subject: [Koha-bugs] [Bug 14843] Notifications and messages via REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14843 --- Comment #7 from I'm just a bot --- This bug depends on 14723 which is in status Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:43:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:43:00 +0000 Subject: [Koha-bugs] [Bug 15988] New: Moving authority types actions into a drop-down menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Bug ID: 15988 Summary: Moving authority types actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:43:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:43:05 +0000 Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:43:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:43:41 +0000 Subject: [Koha-bugs] [Bug 13691] Add some selenium scripts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13691 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:47:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:47:14 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #43 from I'm just a bot --- fatal: previous rebase directory .git/rebase-apply still exists but mbox given. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:47:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:47:51 +0000 Subject: [Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:50:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:50:04 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:50:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:50:07 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 --- Comment #1 from Aleisha Amohia --- Created attachment 48711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48711&action=edit Bug 15988: Moving authority types actions into a drop-down menu To test: 1) Go to Administration -> Authority types 2) Confirm all actions ('MARC Structure', Edit', 'Delete') have been moved into a drop down menu for each auth type, and each action behaves as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:50:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:50:06 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org --- Comment #98 from I'm just a bot --- fatal: previous rebase directory .git/rebase-apply still exists but mbox given. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:50:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:50:09 +0000 Subject: [Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:50:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:50:22 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:50:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:50:45 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org --- Comment #21 from I'm just a bot --- .git/rebase-apply/patch:305: trailing whitespace. warning: 1 line adds whitespace errors. .git/rebase-apply/patch:305: trailing whitespace. warning: 1 line applied after fixing whitespace errors. error: Failed to merge in the changes. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:52:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:52:30 +0000 Subject: [Koha-bugs] [Bug 13548] "High Holds" does not behave correctly when decreaseLoanHighHoldsValue is set to 0. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13548 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:53:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:53:01 +0000 Subject: [Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:55:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:55:02 +0000 Subject: [Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org --- Comment #3 from I'm just a bot --- Applying: Bug 14993 - rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:55:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:55:34 +0000 Subject: [Koha-bugs] [Bug 14844] Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:56:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:56:46 +0000 Subject: [Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:57:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:57:42 +0000 Subject: [Koha-bugs] [Bug 13146] Improve GetRecordValue function by caching field mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13146 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 22:58:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 21:58:15 +0000 Subject: [Koha-bugs] [Bug 12747] Add extra column in Z3950 search result In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org --- Comment #35 from I'm just a bot --- .git/rebase-apply/patch:161: trailing whitespace. Import warning: 1 line adds whitespace errors. .git/rebase-apply/patch:161: trailing whitespace. Import error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt:180 error: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt: patch does not apply error: Did you hand edit your patch? It does not apply to blobs recorded in its index. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:04:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:04:41 +0000 Subject: [Koha-bugs] [Bug 15989] New: Moving classification sources actions into drop-down menus Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Bug ID: 15989 Summary: Moving classification sources actions into drop-down menus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:05:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:05:57 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:06:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:06:00 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 --- Comment #1 from Aleisha Amohia --- Created attachment 48712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48712&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:06:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:06:11 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:11:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:11:37 +0000 Subject: [Koha-bugs] [Bug 15990] New: Moving record matching rules actions into a drop-down menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Bug ID: 15990 Summary: Moving record matching rules actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:12:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:12:58 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:13:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:13:01 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 --- Comment #1 from Aleisha Amohia --- Created attachment 48713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48713&action=edit Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:13:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:13:30 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:15:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:15:04 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48712|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 48714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48714&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:16:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:16:25 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48711|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 48715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48715&action=edit Bug 15988: Moving authority types actions into a drop-down menu To test: 1) Go to Administration -> Authority types 2) Confirm all actions ('MARC Structure', Edit', 'Delete') have been moved into a drop down menu for each auth type, and each action behaves as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:18:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:18:11 +0000 Subject: [Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48710|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 48716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48716&action=edit Bug 15966: Move MARC frameworks actions into a drop down menu To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:20:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:20:35 +0000 Subject: [Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48568|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 48717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48717&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:27:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:27:06 +0000 Subject: [Koha-bugs] [Bug 15991] New: Moving OAI sets actions into a drop-down menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Bug ID: 15991 Summary: Moving OAI sets actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:28:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:28:22 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:28:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:28:25 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 --- Comment #1 from Aleisha Amohia --- Created attachment 48718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48718&action=edit Bug 15991: Moving OAI sets actions into a drop-down menu To test: 1) Go to Administration -> OAI sets 2) Confirm that the actions 'Modify', 'Delete' and 'Define mappings' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:28:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:28:55 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | Change sponsored?|--- |Sponsored --- Comment #2 from Aleisha Amohia --- Similar also to Bug 15990 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:34:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:34:58 +0000 Subject: [Koha-bugs] [Bug 15992] New: Moving item search fields actions into a drop-down menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Bug ID: 15992 Summary: Moving item search fields actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989, Bug 15990, Bug 15991 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:36:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:36:14 +0000 Subject: [Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:36:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:36:17 +0000 Subject: [Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 --- Comment #1 from Aleisha Amohia --- Created attachment 48719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48719&action=edit Bug 15992: Moving item search fields actions into a drop-down menu To test: 1) Go to Administration -> Item search fields 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:36:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:36:47 +0000 Subject: [Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:40:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:40:43 +0000 Subject: [Koha-bugs] [Bug 15993] New: Moving currency actions into a drop-down menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Bug ID: 15993 Summary: Moving currency actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989, Bug 15990, Bug 15991, Bug 15992 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:42:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:42:36 +0000 Subject: [Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:42:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:42:39 +0000 Subject: [Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 --- Comment #1 from Aleisha Amohia --- Created attachment 48720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48720&action=edit Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:43:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:43:00 +0000 Subject: [Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:44:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:44:11 +0000 Subject: [Koha-bugs] [Bug 15994] New: Adding font awesome icons to Funds actions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Bug ID: 15994 Summary: Adding font awesome icons to Funds actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:47:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:47:15 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:47:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:47:18 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 --- Comment #1 from Aleisha Amohia --- Created attachment 48721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48721&action=edit Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:47:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:47:27 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleishaamohia at hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:52:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:52:29 +0000 Subject: [Koha-bugs] [Bug 15995] New: Moving libraries actions into a drop-down menu Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Bug ID: 15995 Summary: Moving libraries actions into a drop-down menu Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: aleishaamohia at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988, Bug 15989, Bug 15990, Bug 15991, Bug 15992, Bug 15993 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:59:18 +0000 Subject: [Koha-bugs] [Bug 15995] Moving libraries actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 6 23:59:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Mar 2016 22:59:21 +0000 Subject: [Koha-bugs] [Bug 15995] Moving libraries actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #1 from Aleisha Amohia --- Created attachment 48722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48722&action=edit Bug 15995: Moving libraries actions into a drop-down menu To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 07:18:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 06:18:40 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 07:18:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 06:18:42 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48709|0 |1 is obsolete| | --- Comment #4 from Fr?d?ric Demians --- Created attachment 48723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48723&action=edit Bug 15965: Koha to MARC mapping - table changes with selection of drop down menu EDIT: Removing JS line To test: 1) Go to Admin -> Koha to MARC Mapping 2) Test selecting biblio / biblioitems / items 3) Confirm the table content changes and behaves as it should which each selection Sponsored-by: Catalyst IT Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 08:47:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 07:47:46 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Bot Control|--- |Ignore this bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 08:47:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 07:47:57 +0000 Subject: [Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 08:57:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 07:57:52 +0000 Subject: [Koha-bugs] [Bug 15736] Add a preference to control whether all items should be shown in checked-in items list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15736 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #15 from Julian Maurice --- Patches pushed to stable, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:08:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:08:39 +0000 Subject: [Koha-bugs] [Bug 15842] Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |julian.maurice at biblibre.com Status|Pushed to Master |RESOLVED --- Comment #10 from Julian Maurice --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:08:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:08:39 +0000 Subject: [Koha-bugs] [Bug 15840] Import borrowers tool explodes if userid already exists In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15840 Bug 15840 depends on bug 15842, which changed state. Bug 15842 Summary: Cannot import patrons if the csv file does not contain privacy_guarantor_checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15842 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:11:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:11:47 +0000 Subject: [Koha-bugs] [Bug 15916] Regression: Many tables' sorting broken by JavaScript error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |julian.maurice at biblibre.com --- Comment #7 from Julian Maurice --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:11:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:11:47 +0000 Subject: [Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Bug 15925 depends on bug 15916, which changed state. Bug 15916 Summary: Regression: Many tables' sorting broken by JavaScript error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:17:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:17:28 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:17:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:17:30 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 --- Comment #1 from Jonathan Druart --- Created attachment 48724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48724&action=edit Bug 15987: Fix undefined subroutine &main::GetCurrency in acqui-home.pl Bug 15987 and bug 15049 were competing the push to master status at the same time. Bug 15987 removed the GetCurrency status and bug 15049 reintrocuced one occurrence of this subroutine. Test plan: Confirm that the test plan for 15049 still passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:17:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:17:33 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 --- Comment #2 from Jonathan Druart --- Created attachment 48725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48725&action=edit Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay Bug 15987 and bug 11622 were competing the push to master status at the same time. Bug 15987 removed the GetCurrency status and bug 11622 reintroduced one occurrence of this subroutine. Test plan: Confirm that the test plan for 11622 still passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:18:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:18:15 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11622, 15049 Severity|enhancement |blocker Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 [Bug 15049] Add warning about "No active currency" to Acquisitions start page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:18:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:18:15 +0000 Subject: [Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:18:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:18:15 +0000 Subject: [Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15987 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:24:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:24:30 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 --- Comment #53 from Jonathan Druart --- (In reply to H?ctor Eduardo Castro Avalos from comment #52) > R?mi just another issue, when exporting there are problem with utf-8: > > branchname date accounttype amount title barcode itype > Midway 2016-01-25T00:00:00 Rent 5 A lot like love / 2015-0004 > Midway 2016-01-28T00:00:00 Rent 5 Antolog??a de entremeses del Siglo de Oro > / 2016-0001 > > But I think IMHO this could be treated in another bug. No, an enhancement won't be pushed with known encoding issues. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:25:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:25:44 +0000 Subject: [Koha-bugs] [Bug 15923] Export records by id list impossible in export_records.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15923 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #15 from Julian Maurice --- Patch pushed to stable, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:33:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:33:51 +0000 Subject: [Koha-bugs] [Bug 14244] viewing a bib item's circ history requires circulation permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14244 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #23 from Julian Maurice --- Patches pushed to stable, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:43:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:43:46 +0000 Subject: [Koha-bugs] [Bug 15306] Don't show translate link for item types if only one language is installed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15306 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #13 from Julian Maurice --- Patch pushed to stable, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 09:58:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 08:58:20 +0000 Subject: [Koha-bugs] [Bug 15605] Accessibility: Can't tab to add link in serials routing list add user popup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15605 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patches pushed to stable, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:00:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:00:17 +0000 Subject: [Koha-bugs] [Bug 15663] Can't delete label from checkbox In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15663 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #13 from Julian Maurice --- Patch pushed to stable, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:01:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:01:27 +0000 Subject: [Koha-bugs] [Bug 15670] Rename "Cancel" to "Cancel hold" when checking in a waiting item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15670 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to stable, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:14:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:14:10 +0000 Subject: [Koha-bugs] [Bug 15674] 'Show/hide columns' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 --- Comment #13 from Julian Maurice --- Created attachment 48726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48726&action=edit [3.22] Bug 15674: Make "Column visibility" translatable Patch for 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:15:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:15:03 +0000 Subject: [Koha-bugs] [Bug 15674] 'Show/hide columns' is not translatable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15674 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #14 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:20:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:20:45 +0000 Subject: [Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11998 Status|Needs Signoff |ASSIGNED Blocks|15970 | --- Comment #15 from Jonathan Druart --- I have no idea how to write this patch on top of bug 11998. We could call set_in_cache for all prefs, but it may spend too much time to process all of them. Or we may not need it anymore. It will be good to benchmark the different possibilities. I will continue to work on this one when bug 11998 will be pushed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 [Bug 11998] Syspref caching issues https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 [Bug 15970] Plack should not clear syspref cache -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:20:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:20:45 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 [Bug 15341] Performance - Retrieve all sysprefs at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:20:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:20:45 +0000 Subject: [Koha-bugs] [Bug 15970] Plack should not clear syspref cache In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15970 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15341 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 [Bug 15341] Performance - Retrieve all sysprefs at once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:21:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:21:05 +0000 Subject: [Koha-bugs] [Bug 15691] Show card number minimum and maximum in visible hint when adding a patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15691 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:22:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:22:13 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 [Bug 15973] Do not disable syspref cache for Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:22:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:22:13 +0000 Subject: [Koha-bugs] [Bug 15973] Do not disable syspref cache for Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 [Bug 11998] Syspref caching issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:27:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:27:40 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #112 from Jonathan Druart --- Created attachment 48727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48727&action=edit Bug 11998: Make HoldsQueue.t tests pass [TO REVERT] This patch should not be the way to make these tests pass. The prefs should not be updated using set_preference, it will modify the values in the cache. I have no idea how to make them pass using the correct way, please help :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:32:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:32:04 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 --- Comment #11 from Julian Maurice --- Created attachment 48728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48728&action=edit [3.22] Bug 15706: Changing to circulate_remaining_permissions Patch for 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 10:39:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 09:39:46 +0000 Subject: [Koha-bugs] [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #12 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:04:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:04:27 +0000 Subject: [Koha-bugs] [Bug 15730] 500 error on returns.pl if barcode doesn't exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15730 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Julian Maurice --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:07:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:07:48 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48723|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 48729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48729&action=edit Bug 15965: Koha to MARC mapping - table changes with selection of drop down menu EDIT: Removing JS line To test: 1) Go to Admin -> Koha to MARC Mapping 2) Test selecting biblio / biblioitems / items 3) Confirm the table content changes and behaves as it should which each selection Sponsored-by: Catalyst IT Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:07:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:07:56 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 --- Comment #6 from Jonathan Druart --- Created attachment 48730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48730&action=edit t rebase# Attachment to Bug 15965 - Koha to MARC mapping - table changes with selection of drop down menu Bug 15965: Select default value ('biblio') if needed It will prevent wrong value to be selected when the back button of the browser is used. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:08:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:08:27 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:09:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:09:14 +0000 Subject: [Koha-bugs] [Bug 15755] Default item type is not marked as "All" in circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15755 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:23:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:23:37 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #11 from Jonathan Druart --- I don't like the new "type" these patches introduced, and I don't understand the complexity of the patches: The SCO user should only be used for the SCO module. From this assumption why don't you just test if the logged in user is the one defined in the AutoSelfCheckID pref? I may missed something and it could be a naive approach, but so easy :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:25:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:25:01 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 --- Comment #5 from Julian Maurice --- Created attachment 48731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48731&action=edit [3.22.x] Bug 15790 - Don't delete a MARC framework if existing records use that framework Patch for 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:25:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:25:19 +0000 Subject: [Koha-bugs] [Bug 15790] Don't delete a MARC framework if existing records use that framework In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15790 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:29:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:29:15 +0000 Subject: [Koha-bugs] [Bug 15833] Bad variable value in renewal template confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15833 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:31:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:31:29 +0000 Subject: [Koha-bugs] [Bug 15864] SMS cellular providers link missing from administration sidebar menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15864 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |julian.maurice at biblibre.com Status|Pushed to Master |RESOLVED --- Comment #6 from Julian Maurice --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:32:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:32:58 +0000 Subject: [Koha-bugs] [Bug 15880] Serials new frequency link should be a toolbar button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15880 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:33:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:33:57 +0000 Subject: [Koha-bugs] [Bug 15881] Serials new numbering pattern link should be a toolbar button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15881 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:35:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:35:19 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:35:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:35:22 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25463|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 48732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48732&action=edit Bug 10347 - Deactivate "Add item" button when "Add multiple copies" was activated When the "Add multiple items" button is pressed the other submit buttons should be hidden in order to eliminate confusion about which button submits the form at that stage in the process. This patch alters the form so that clicking the "add multiple" button hides the other two buttons and displays form for submitting the number of copies to add. This patch also makes changes to accompanying text in order to make things (hopefully) clearer. The button text has been changed (again, see Bug 10346) to "Add multiple copies of this item." Explanatory text has been added "The barcode you enter will be incremented for each additional item," because that seemed non-obvious about the process. Unrelated change: a section of obsolete JavaScript has been removed. To test, go to the add/edit items page for a new or existing record. Test adding a single item, adding & duplicating, and adding multiple. The add multiple form should be shown upon clicking 'add multiple,' and hidden when 'cancel' is clicked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:35:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:35:26 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #14 from Jonathan Druart --- Created attachment 48733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48733&action=edit Bug 10347 [Follow-up] Scroll down clicking on the "Add multiple copies" button Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:35:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:35:42 +0000 Subject: [Koha-bugs] [Bug 10347] Deactivate "Add item" button when "Add multiple copies" was activated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 --- Comment #15 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:35:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:35:44 +0000 Subject: [Koha-bugs] [Bug 15939] modification logs view now silently defaults to only current day's actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:37:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:37:09 +0000 Subject: [Koha-bugs] [Bug 15947] SIPILS.t should be moved to t/db_dependent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15947 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:47:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:47:10 +0000 Subject: [Koha-bugs] [Bug 13778] lists buttons ugly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice --- The initial issue was actually fixed by bug 15223. So this bug is an enhancement, severity changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:47:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:47:33 +0000 Subject: [Koha-bugs] [Bug 13778] Putting patron lists buttons into a dropdown menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13778 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|lists buttons ugly |Putting patron lists | |buttons into a dropdown | |menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:54:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:54:01 +0000 Subject: [Koha-bugs] [Bug 13474] Untranslatable log actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13474 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:54:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:54:08 +0000 Subject: [Koha-bugs] [Bug 15658] Browse system logs: Add more actions to action filter list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15658 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 11:55:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 10:55:56 +0000 Subject: [Koha-bugs] [Bug 15667] Messages in patron account display dates wrongly formatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15667 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:00:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:00:46 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #31 from Julian Maurice --- It looks like an enhancement rather than a bug. Should it be backported to 3.22 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:01:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:01:49 +0000 Subject: [Koha-bugs] [Bug 15699] Opac: Course reserves instructors should be in form "Surname, Firstname" for sorting purposes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #14 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:03:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:03:57 +0000 Subject: [Koha-bugs] [Bug 15719] Silence warning in C4/Language.pm during web install In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15719 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #10 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:08:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:08:23 +0000 Subject: [Koha-bugs] [Bug 15721] About page does not display Apache version In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15721 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #15 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:20:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:20:18 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 --- Comment #8 from Julian Maurice --- Created attachment 48734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48734&action=edit [3.22.x] Bug 15784: Library deletion warning is incorrectly styled Patch for 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:20:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:20:40 +0000 Subject: [Koha-bugs] [Bug 15784] Library deletion warning is incorrectly styled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15784 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:24:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:24:55 +0000 Subject: [Koha-bugs] [Bug 15867] Move MARC modification templates JavaScript into separate file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15867 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Severity|minor |enhancement --- Comment #7 from Julian Maurice --- severity changed to enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:56:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:56:01 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:56:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:56:05 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33323|0 |1 is obsolete| | Attachment #33324|0 |1 is obsolete| | Attachment #33325|0 |1 is obsolete| | Attachment #33326|0 |1 is obsolete| | Attachment #33327|0 |1 is obsolete| | Attachment #33328|0 |1 is obsolete| | --- Comment #38 from Jonathan Druart --- Created attachment 48735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48735&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:56:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:56:08 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #39 from Jonathan Druart --- Created attachment 48736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48736&action=edit Bug 12904 [Followup] - Increase JS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for javascript files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:56:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:56:14 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #40 from Jonathan Druart --- Created attachment 48737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48737&action=edit Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:56:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:56:17 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #41 from Jonathan Druart --- Created attachment 48738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48738&action=edit Bug 12904 [Followup] - Increase CSS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for css files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:56:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:56:22 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #42 from Jonathan Druart --- Created attachment 48739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48739&action=edit Bug 12904 [Followup] - Catch remaining JS files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:56:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:56:26 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #43 from Jonathan Druart --- Created attachment 48740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48740&action=edit Bug 12904 [Followup] - Add to Intranet for Dev Install I managed to miss the intranet vhost directive first time around.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:56:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:56:31 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #44 from Jonathan Druart --- Created attachment 48741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48741&action=edit Bug 12904: Update new occurrences of .js|.css This has been generated using the script attached to the bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:57:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:57:04 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #45 from Jonathan Druart --- Patches rebased (it was a nightmare...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:57:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:57:51 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #46 from Jonathan Druart --- Created attachment 48742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48742&action=edit script to update tt & inc files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 12:58:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 11:58:10 +0000 Subject: [Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #47 from Jonathan Druart --- (In reply to Jonathan Druart from comment #46) > Created attachment 48742 [details] > script to update tt & inc files Usage: perl kv.pl **/*.tt **/*.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:00:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:00:45 +0000 Subject: [Koha-bugs] [Bug 15996] New: Bibliographic records diffing tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15996 Bug ID: 15996 Summary: Bibliographic records diffing tool Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: olli-antti.kivilahti at jns.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently there is no tool to diff differences or changes between biblios or their different versions. This is most useful for logging who changed and what. This feature introduces a biblio diffing module, which takes an arbitrary amount of MARC::Records and produces a complex data structure about all the identified changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:01:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:01:34 +0000 Subject: [Koha-bugs] [Bug 15996] Bibliographic records diffing tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15996 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 48743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48743&action=edit Bug 15996 - Bibliographic records diffing tool Currently there is no tool to diff differences or changes between biblios or their different versions. This is most useful for logging who changed and what. This feature introduces a biblio diffing module, which takes an arbitrary amount of MARC::Records and produces a complex data structure about all the identified changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:08:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:08:34 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #113 from Jacek Ablewicz --- For sysprefs with undef value in the database - while testing with memcache - there are 2 warnings generated: Use of uninitialized value in subroutine entry at /home/koha/devkohaclone/Koha/Cache.pm line 287. Use of uninitialized value in subroutine entry at /home/koha/devkohaclone/Koha/Cache.pm line 287. This only happens when trying to fetch such syspref first time, from unpopulated cache. There are 9 such values in my test database: CoceHost CoceProviders DefaultLongOverdueChargeValue DefaultLongOverdueDays DefaultLongOverdueLostValue MembershipExpiryDaysNotice NovelistSelectPassword NovelistSelectProfile TagsExternalDictionary Non-existing preference fetch generates the same warning (but again only once). Note that subsequent C4::Context->preference() calls will return empty string for such preferences, instead of undef value - not sure if that may cause some problems or not, but it's a change from previous behaviour. Also it does not happen for Cache::Memory (= default caching system after this patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:22:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:22:57 +0000 Subject: [Koha-bugs] [Bug 15526] Drop nozebra database table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:37:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:37:47 +0000 Subject: [Koha-bugs] [Bug 15808] Remove "Return to where you were before" from sysprefs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15808 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:38:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:38:36 +0000 Subject: [Koha-bugs] [Bug 15872] Rancor: Ctrl-Shift-X has incorrect description in "Keyboard shortcuts" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15872 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:54:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:54:52 +0000 Subject: [Koha-bugs] [Bug 15350] DBIx::Class Startup speed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- (In reply to Jonathan Druart from comment #6) > Jesse, > I finally don't think this patch is worth the gain: for the scripts not > using Plack (misc/*), they will load of the schema even if it's not needed. Maybe it is time to think Plack-wise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:55:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:55:11 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #114 from Jacek Ablewicz --- I'm unable to test this patch set with fastmmap caching system - it seems to break it somehow.. With patch, and fastmmap cache enabled, anything (?) that uses Koha::Cache results with: Use of uninitialized value $db_name in concatenation (.) or string at /home/koha/devkohaclone/Koha/Database.pm line 73. Use of uninitialized value $db_host in concatenation (.) or string at /home/koha/devkohaclone/Koha/Database.pm line 73. DBI connect('database=;host=;port=','',...) failed: Access denied for user 'koha'@'localhost' (using password: NO) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1249 DBIx::Class::Storage::DBI::dbh(): DBI Connection failed: Access denied for user 'koha'@'localhost' (using password: NO) at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1253. at /home/koha/devkohaclone/Koha/Database.pm line 90 To reproduce (on command line) 0) ensure that you have fastmmap perl module installed (libcache-fastmmap-perl in debian) 1) apply patch (without patch: no error in current master) 2) export CACHING_SYSTEM=fastmmap 3) export GATEWAY_INTERFACE=1 4) try to run this simple script: #!/usr/bin/perl use Modern::Perl; use C4::Biblio; GetMarcStructure(); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 13:55:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 12:55:41 +0000 Subject: [Koha-bugs] [Bug 15920] Clean up and fix errors in batch checkout template In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:06:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:06:45 +0000 Subject: [Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 --- Comment #6 from Julian Maurice --- Created attachment 48746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48746&action=edit [3.22.x] Bug 15925: Correct some markup issues with patron lists pages Patch for 3.22.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:06:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:06:58 +0000 Subject: [Koha-bugs] [Bug 15925] Correct some markup issues with patron lists pages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:08:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:08:47 +0000 Subject: [Koha-bugs] [Bug 15926] Item search fields admin missing help file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15926 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:13:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:13:42 +0000 Subject: [Koha-bugs] [Bug 15927] Remove use of for alternating row colors. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15927 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:15:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:15:59 +0000 Subject: [Koha-bugs] [Bug 15940] Remove unused JavaScript from authorities MARC subfield structure In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15940 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:19:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:19:38 +0000 Subject: [Koha-bugs] [Bug 12920] Remove AllowRenewalLimitOverride from pl scripts, use Koha.Preference instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12920 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #17 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:22:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:22:52 +0000 Subject: [Koha-bugs] [Bug 14097] Add unit tests to C4::UsageStats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14097 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #60 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:23:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:23:50 +0000 Subject: [Koha-bugs] [Bug 15693] Unnecessary punctuation mark when check-in an item in a library other than the home branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15693 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:26:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:26:27 +0000 Subject: [Koha-bugs] [Bug 15697] Unnecessary comma between title and subtitle on opac-detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15697 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #13 from Julian Maurice --- Patches pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:27:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:27:49 +0000 Subject: [Koha-bugs] [Bug 15871] Improve perl critic of t/RecordProcessor.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15871 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice at biblibre.com --- Comment #11 from Julian Maurice --- Patch pushed to 3.22.x, will be in 3.22.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:33:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:33:44 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #52 from Kyle M Hall --- Created attachment 48747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48747&action=edit Bug 15084 [QA Followup] - Fix new uses of GetCurrency Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:41:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:41:34 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #115 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #114) > I'm unable to test this patch set with fastmmap caching system - it seems to > break it somehow.. With patch, and fastmmap cache enabled, anything (?) that > uses Koha::Cache results with: > > Use of uninitialized value $db_name in concatenation (.) or string at > /home/koha/devkohaclone/Koha/Database.pm line 73. > Use of uninitialized value $db_host in concatenation (.) or string at > /home/koha/devkohaclone/Koha/Database.pm line 73. > DBI connect('database=;host=;port=','',...) failed: Access denied for user > 'koha'@'localhost' (using password: NO) at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1249 > DBIx::Class::Storage::DBI::dbh(): DBI Connection failed: Access denied for > user 'koha'@'localhost' (using password: NO) at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1253. at > /home/koha/devkohaclone/Koha/Database.pm line 90 > > To reproduce (on command line) > > 0) ensure that you have fastmmap perl module installed > (libcache-fastmmap-perl in debian) > 1) apply patch (without patch: no error in current master) > 2) export CACHING_SYSTEM=fastmmap > 3) export GATEWAY_INTERFACE=1 > 4) try to run this simple script: > > #!/usr/bin/perl > > use Modern::Perl; > use C4::Biblio; > GetMarcStructure(); I don't get the error. I don't know if I did something wrong, I don't use fastmmap (I thought we agree it does not have good results). % git diff diff --git a/Koha/Cache.pm b/Koha/Cache.pm index 9856e80..e0f406f 100644 --- a/Koha/Cache.pm +++ b/Koha/Cache.pm @@ -123,6 +123,7 @@ sub new { $ENV{DEBUG} && carp "Selected caching system: " . ($self->{'cache'} // 'none'); + use Data::Dumper;warn Dumper $self; return bless $self, $class; % more t.pl #!/usr/bin/perl use Modern::Perl; use C4::Biblio; GetMarcStructure(); % perl t.pl $VAR1 = { 'memory_cache' => bless( { 'size_limit' => undef, 'namespace' => 'koha', 'load_callback' => undef, 'default_expires' => '0 sec', 'removal_strategy' => bless( {}, 'Cache::RemovalStrategy::LRU' ), 'validate_callback' => undef }, 'Cache::Memory' ), 'timeout' => 0, 'namespace' => 'koha', 'Cache::Memory_get' => sub { "DUMMY" }, 'cache' => bless( { 'Cache' => \205625248, 'allow_recursive' => undef, 'share_file' => '/tmp/sharefile-koha-koha-localhost-koha', 'write_back' => '', 'context' => undef, 'delete_cb' => undef, 'empty_on_exit' => 0, 'num_pages' => 89, 'compress' => 0, 'enable_stats' => 0, 'raw_values' => 0, 'write_cb' => undef, 'read_cb' => undef, 'cache_not_found' => undef, 'pid' => 17602, 'expire_time' => 0, 'page_size' => 65536, 'unlink_on_exit' => 0, 'cache_size' => 5832704 }, 'Cache::FastMmap' ), 'fastmmap_cache' => $VAR1->{'cache'}, 'Cache::Memory_set' => sub { "DUMMY" }, 'default_type' => 'fastmmap' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:44:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:44:17 +0000 Subject: [Koha-bugs] [Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #13 from Kyle M Hall --- (In reply to Marc V?ron from comment #12) > Still valid? Half valid. The ability to count on order items was added with another patch, but only if items are created at the time of ordering. I will close this bug out and open a new one to add just that additional functionality. *** This bug has been marked as a duplicate of bug 13298 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:44:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:44:17 +0000 Subject: [Koha-bugs] [Bug 13298] Holds ratios report ignores ordered items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13298 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #8 from Kyle M Hall --- *** Bug 7887 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:45:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:45:41 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #116 from Jonathan Druart --- Sorry, forget this last comment (I was using master... :D) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 14:51:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 13:51:07 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #12 from Heather Braum --- Jonathan, we're needing to use Koha's Self Check at multiple branches, so have to use multiple logins; we can't save those to the AutoSelfCheckID sys pef as a result. Hence the development need. I'll can't answer the complexity question :) I'll let Nick do that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:03:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:03:17 +0000 Subject: [Koha-bugs] [Bug 15997] New: Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15997 Bug ID: 15997 Summary: Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently, the hold ratios script only counts on order items where the record item is created at the time the order is placed, and not if the item is created when the item is received. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:03:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:03:56 +0000 Subject: [Koha-bugs] [Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15997 --- Comment #14 from Kyle M Hall --- Bug 15997 has been filed to replace the need for this bug patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:03:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:03:56 +0000 Subject: [Koha-bugs] [Bug 15997] Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15997 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7887 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:07:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:07:24 +0000 Subject: [Koha-bugs] [Bug 15997] Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15997 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:07:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:07:26 +0000 Subject: [Koha-bugs] [Bug 15997] Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15997 --- Comment #1 from Kyle M Hall --- Created attachment 48748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48748&action=edit Bug 15997 - Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' Currently, the hold ratios script only counts on order items where the record item is created at the time the order is placed, and not if the item is created when the item is received. Test Plan: 1) Set AcqCreateItem to recieving 2) Run the hold ratios report with "include ordered" checked 3) From aquisitions, order some additional items for the record 4) Re-run the hold ratios report, not there is no change in the ratio for that record 5) Apply this patch 6) Re-run the hold ratios reporat again, the ratio should now have changed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:07:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:07:35 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #117 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #114) > I'm unable to test this patch set with fastmmap caching system - it seems to > break it somehow.. With patch, and fastmmap cache enabled, anything (?) that > uses Koha::Cache results with: > > Use of uninitialized value $db_name in concatenation (.) or string at > /home/koha/devkohaclone/Koha/Database.pm line 73. > Use of uninitialized value $db_host in concatenation (.) or string at > /home/koha/devkohaclone/Koha/Database.pm line 73. > DBI connect('database=;host=;port=','',...) failed: Access denied for user > 'koha'@'localhost' (using password: NO) at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1249 > DBIx::Class::Storage::DBI::dbh(): DBI Connection failed: Access denied for > user 'koha'@'localhost' (using password: NO) at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1253. at > /home/koha/devkohaclone/Koha/Database.pm line 90 > > To reproduce (on command line) > > 0) ensure that you have fastmmap perl module installed > (libcache-fastmmap-perl in debian) > 1) apply patch (without patch: no error in current master) > 2) export CACHING_SYSTEM=fastmmap > 3) export GATEWAY_INTERFACE=1 > 4) try to run this simple script: > > #!/usr/bin/perl > > use Modern::Perl; > use C4::Biblio; > GetMarcStructure(); It works if I revert commit 9e701294dd6ccf4fa5d8b24d1a7da15be353992e Bug 13431 - Shared FastMmap file causes issues No idea why! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:07:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:07:42 +0000 Subject: [Koha-bugs] [Bug 15997] Hold Ratios for ordered items doesn't count orders where AcqCreateItem is set to 'receiving' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15997 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:10:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:10:12 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #118 from Jonathan Druart --- And also this one!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:12:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:12:58 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #119 from Jonathan Druart --- Actually it's certainly caused by the circular dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:14:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:14:36 +0000 Subject: [Koha-bugs] [Bug 15310] Fix duplicate fines issue when changing date or time format In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15310 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED CC| |kyle at bywatersolutions.com --- Comment #4 from Kyle M Hall --- I do believe that bug 15675 fixes this once and for all! That bug changed the behavior such that the fines updater no longer relies on the description for fine selection! I think the only thing left to do is to remove the warnings from the system preferences. *** This bug has been marked as a duplicate of bug 15675 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:14:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:14:36 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #32 from Kyle M Hall --- *** Bug 15310 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:15:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:15:59 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #120 from Jonathan Druart --- (In reply to Jonathan Druart from comment #119) > Actually it's certainly caused by the circular dependency. Koha::Cache::_initialize_fastmmap could read the config file instead of calling C4::Context->config. But the question is: Does someone use fasmmap? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:17:17 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #53 from Jonathan Druart --- (In reply to Kyle M Hall from comment #52) > Created attachment 48747 [details] [review] > Bug 15084 [QA Followup] - Fix new uses of GetCurrency > > Signed-off-by: Kyle M Hall Hum, bug 15987? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:19:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:19:10 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #9 from M. Tompsett --- Progress. GetMarcStructure was pulling cached values. Still working on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:33:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:33:03 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 15:33:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 14:33:06 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47594|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 48749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48749&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:09:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:09:01 +0000 Subject: [Koha-bugs] [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48702|0 |1 is obsolete| | --- Comment #2 from H?ctor Eduardo Castro Avalos --- Created attachment 48751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48751&action=edit [SIGNED-OFF]Bug 15983: Use Font Awesome icons in serial numbering pattern deletion confirmation dialog If you try to delete a serial numbering pattern which is in use by an existing subscription you will be shown a confirmation dialog. This dialog should use Font Awesome icons. Other minor changes: - Added "action" attributes to s to fix validation errors. - Added "alert" class to confirmation dialogs so that they correctly styled. To test, apply the patch and go to Serials -> Numbering patterns. - Click "Delete" on a numbering pattern which is in use by a subscription. - Verify that the confirmation dialog is styled correctly. - Test that the "No, do not delete" button works correctly. - Test that the "Yes, delete" button deletes the correct numbering pattern. Signed-off-by: Hector Castro Works as described -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:09:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:09:12 +0000 Subject: [Koha-bugs] [Bug 15983] Use Font Awesome icons in serial numbering pattern deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15983 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:09:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:09:57 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 --- Comment #2 from Owen Leonard --- I think we should not make dropdowns where there are only two options. I would like to propose that we start using Bootstrap-styled buttons like this when there are only two links: Edit Delete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:15:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:15:02 +0000 Subject: [Koha-bugs] [Bug 15998] New: software error in svc/holds in 3.20.x Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Bug ID: 15998 Summary: software error in svc/holds in 3.20.x Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Hold requests Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 14846 patch was backported to 3.20.7 but the patch use some methods from Koha::Item and Koha::Reserve whereas these modules don't exist in 3.20.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:18:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:18:25 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > Created attachment 48725 [details] [review] > Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay > > Bug 15987 and bug 11622 were competing the push to master status at the > same time. Bug 15987 removed the GetCurrency status and bug 11622 > reintroduced one occurrence of this subroutine. > > Test plan: > Confirm that the test plan for 11622 still passes. Jonathan, I added a qa followup to bug 15084 that fixes the same issues. Do you think it would be better to close this bug, or to revert my patch and push this bug through the community process? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:20:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:20:27 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Patch doesn't apply |RESOLVED --- Comment #44 from Kyle M Hall --- I believe we are pursuing an alternative solution and will continue to get this patch into Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:21:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:21:04 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 --- Comment #1 from Julian Maurice --- Created attachment 48752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48752&action=edit Bug 15998 - svc/holds: use holdingbranch instead of holding_branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:21:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:21:15 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:21:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:21:20 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #121 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #120) > (In reply to Jonathan Druart from comment #119) > > Actually it's certainly caused by the circular dependency. > > Koha::Cache::_initialize_fastmmap could read the config file instead of > calling C4::Context->config. IMO delaying cache init / moving Koha::Cache->get_instance() call into preference() sub may be a better idea. Especially as in current master C4::Context::read_config_file() is apparently called 2+ times per script run allready: - 1st time when we do 'use Koha::Context;' anywhere - 2nd time when we intialize the database connection in Koha::Database via schema() / _new_schema() sub :) > But the question is: Does someone use fasmmap? Probably not (but thats the only shared / permanent caching system available apart from memcache - which has its own quirks and constraints). I only encountered this problem because I was curious how would the 3 different caching systems compare performance-wise, since we are going to use them for something so much speed-sensitive (i.e preference fetching). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:26:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:26:35 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 --- Comment #2 from Owen Leonard --- This patch uses a "trash" icon for delete: ...while other use the "remove" icon (an X): We need to pick one and standardize on it. Perhaps the trash icon is more correct even if it is currently less common in the templates. Use it for "delete" and use the X in cases where we mean "cancel?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:27:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:27:31 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:27:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:27:35 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44065|0 |1 is obsolete| | Attachment #44066|0 |1 is obsolete| | Attachment #44067|0 |1 is obsolete| | Attachment #44068|0 |1 is obsolete| | Attachment #44069|0 |1 is obsolete| | --- Comment #61 from Kyle M Hall --- Created attachment 48753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48753&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:27:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:27:44 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #62 from Kyle M Hall --- Created attachment 48754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48754&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:27:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:27:47 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #63 from Kyle M Hall --- Created attachment 48755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48755&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:27:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:27:51 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #64 from Kyle M Hall --- Created attachment 48756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48756&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:27:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:27:55 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #65 from Kyle M Hall --- Created attachment 48757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48757&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:42:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:42:25 +0000 Subject: [Koha-bugs] [Bug 15999] New: Add "Koha as a CMS" as built in Koha feature Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15999 Bug ID: 15999 Summary: Add "Koha as a CMS" as built in Koha feature Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org The CMS enhancement detailed on the wiki ( https://wiki.koha-community.org/wiki/Koha_as_a_CMS ) is fairly popular and should simply be included as part of Koha and be enabled via a system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:42:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:42:52 +0000 Subject: [Koha-bugs] [Bug 15999] Add "Koha as a CMS" as built in Koha feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15999 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:45:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:45:32 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #204 from Kyle M Hall --- (In reply to Katrin Fischer from comment #203) > Hi Kyle, I should try and clarify my comment :) I am not against including > this as an experimental feature at all! - I just think we need to be clear > and upfront in documentation on what is working and what not - so people > know what to expect. Right now I am not quite sure what to expect of the > work available - what should be working? What is intended to work? It would > help me to understand that better and give me a starting point. Agreed! I think we are all on the same page. Nick is going to begin testing these patches for sign-off. I imagine we will be able to help fill in the gaps where documentation is lacking and be able to tell us if it is lacking in any functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:54:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:54:41 +0000 Subject: [Koha-bugs] [Bug 15527] OAI-PMH should have a stylesheet to aid usability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15527 --- Comment #23 from Kyle M Hall --- (In reply to Fr?d?ric Demians from comment #22) > Kyle, my patch was also about adding (In reply to Kyle M Hall from comment > #21) > > I think the issue at hand is that this patch revealed a new bug in testing > > where the non-package version of Koha's apache conf no longer matches the > > package version in behavior and functionality. While appreciated, I think > > Fr?d?ric's followup is not needed and we should instead fix the bug for > > non-package installs of Koha. That should solve the issue and once that and > > the license followup have been submitted this can move forward. > > I agree with this plan... > > Where is located the Apache conf file? Do you already know what is its > difference with etc/koha-http.conf? > > My followup patch was also introducing a way to specify a local XSLT in > extended mode. See this: > > https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46460&action=diff > > But it could be added later when this patch will be in master. I agree. I think it would be good as a followup on a new bug report. I believe Tom?s is going to file the bug and patch for the issue at hand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:56:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:56:43 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #10 from M. Tompsett --- >From 3.10.x online help hidden allows you to select from 19 possible visibility conditions, 17 of which are implemented. They are the following: -9 => Future use -8 => Flag -7 => OPAC !Intranet !Editor Collapsed -6 => OPAC Intranet !Editor !Collapsed -5 => OPAC Intranet !Editor Collapsed -4 => OPAC !Intranet !Editor !Collapsed -3 => OPAC !Intranet Editor Collapsed -2 => OPAC !Intranet Editor !Collapsed -1 => OPAC Intranet Editor Collapsed 0 => OPAC Intranet Editor !Collapsed 1 => !OPAC Intranet Editor Collapsed 2 => !OPAC !Intranet Editor !Collapsed 3 => !OPAC !Intranet Editor Collapsed 4 => !OPAC Intranet Editor !Collapsed 5 => !OPAC !Intranet !Editor Collapsed 6 => !OPAC Intranet !Editor !Collapsed 7 => !OPAC Intranet !Editor Collapsed 8 => !OPAC !Intranet !Editor !Collapsed 9 => Future use ( ! means 'not visible' or in the case of Collapsed 'not Collapsed') This is pre-bug 9894. So cait was right! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 16:59:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 15:59:27 +0000 Subject: [Koha-bugs] [Bug 15999] Add "Koha as a CMS" as built in Koha feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15999 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:01:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:01:05 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Owen Leonard --- (In reply to Owen Leonard from comment #20) > If a checkin triggers the modal, any messages or alerts which were also > triggered by the checkin will be hidden by the modal and will disappear > after clearing the modal. For instance: A warning that the item was not > checked out, or a checkin message which has been configured for that > particular item type. This is still the case, and I still think it's a problem. The modal hides any other messages on the page and the messages are gone when you dismiss the modal. Regression: This undoes Bug 15670. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:03:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:03:34 +0000 Subject: [Koha-bugs] [Bug 15999] Add "Koha as a CMS" as built in Koha feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15999 --- Comment #1 from Owen Leonard --- Different from Bug 12806? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:10:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:10:04 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #28 from Owen Leonard --- I personally find the default Bootstrap colored button styles to be garish and I don't think we should use them. I prefer a standard button with color added to the icons. This is another case where we need to get some consensus before introducing a wholly new style to the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:24:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:24:18 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #122 from Jacek Ablewicz --- Created attachment 48758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48758&action=edit Bug 11998: Delay cache intialisation Should solve a problem with fastmmap cache system (see comment #114) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:38:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:38:20 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48758|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:41:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:41:26 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48639|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 48759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48759&action=edit Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees This enhancment allows a library to prevent patrons from checking out items if his or her guarantees own too much. Test Plan: 1) Apply this patch 2) Find or create a patron with a guarantor 3) Add a fine to the patron's account 4) Set the new system preference NoIssuesChargeGuarantees to be less than the amount owed by the patron 4) Attempt to check out an item to the guarantor, you will either be warned or prevented from checking out based on your system settings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:45:47 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #123 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #122) > Created attachment 48758 [details] [review] > Bug 11998: Delay cache intialisation > > Should solve a problem with fastmmap cache system (see comment #114) Maybe not such a good idea after all - to work correctly it would need additional numerous changes in other subroutines like clear_syspref_cache(), set_preference() etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:52:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:52:01 +0000 Subject: [Koha-bugs] [Bug 16000] New: Duplicate a report from the New Reports button Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Bug ID: 16000 Summary: Duplicate a report from the New Reports button Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org It would make sense to have a "Duplicate" options in guided_reports.pl on the New Report button outside of the "Use saved" phase of the page. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 17:58:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 16:58:22 +0000 Subject: [Koha-bugs] [Bug 13658] Show 'damaged' items as available in OPAC XSLT result list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13658 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:09:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:09:34 +0000 Subject: [Koha-bugs] [Bug 16001] New: Use standard message dialog when there are no cities to list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Bug ID: 16001 Summary: Use standard message dialog when there are no cities to list Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/cities.pl OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org In Administration -> Cities and towns, if there are no cities defined that information should be shown in the standard
    -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:20:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:20:56 +0000 Subject: [Koha-bugs] [Bug 15968] Unnecessary loop in C4::Templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15968 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:23:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:23:29 +0000 Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:23:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:23:31 +0000 Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 --- Comment #1 from Owen Leonard --- Created attachment 48760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48760&action=edit Bug 16001 - Use standard message dialog when there are no cities to list If there are no existing cities in Administration -> Cities and Towns, the message saying so should be in the standard message dialog. Another minor change: Edit the message to say "There are no cities defined," which I think reads better in English. To test you must have no cities and towns defined. Apply this patch and go to Administration -> Cities and Towns. You should see a message displayed in a standard "message" style dialog. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:28:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:28:14 +0000 Subject: [Koha-bugs] [Bug 13871] OverDrive message when user authentication fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan at bywatersolutions.co | |m --- Comment #50 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:28:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:28:41 +0000 Subject: [Koha-bugs] [Bug 16002] New: ALL/MULTI choices in report dropdowns Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 Bug ID: 16002 Summary: ALL/MULTI choices in report dropdowns Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org When adding choices like <> to a report, it would be great if parameter could be added to the choice where ALL could be a choice at the top of the list. Maybe something like <>. Similarly, it would be great if MULTI could also be a parameter, where the user could select several items from the list, like <>. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:35:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:35:29 +0000 Subject: [Koha-bugs] [Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #20 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:37:03 +0000 Subject: [Koha-bugs] [Bug 15965] Koha to MARC mapping - table changes with selection of drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15965 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #7 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:48:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:48:07 +0000 Subject: [Koha-bugs] [Bug 15961] Use Font Awesome icons for confirmation of currency deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15961 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Brendan Gallagher --- Pushed to Master - Thanks! Should be in the May 2016 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:50:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:50:12 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #29 from Christopher Brannon --- (In reply to Owen Leonard from comment #28) > I personally find the default Bootstrap colored button styles to be garish > and I don't think we should use them. I prefer a standard button with color > added to the icons. > > This is another case where we need to get some consensus before introducing > a wholly new style to the interface. Our library actually uses jquery to color some buttons to make them stand out. Frankly, I think the buttons all blend together, and I don't think colored icons wouldn't stand out enough. I think on the staff side, if garish improves workflow and reduces errors, then bring on the garish. Christopher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 18:57:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 17:57:45 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #44 from Brendan Gallagher --- Pushed to Master - Thanks! Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:00:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:00:33 +0000 Subject: [Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #32 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 - release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:03:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:03:45 +0000 Subject: [Koha-bugs] [Bug 15941] The template for cloning circulation and fine rules says "issuing rules" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15941 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #5 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:18:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:18:54 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #30 from Kyle M Hall --- (In reply to Owen Leonard from comment #27) > (In reply to Owen Leonard from comment #20) > > > If a checkin triggers the modal, any messages or alerts which were also > > triggered by the checkin will be hidden by the modal and will disappear > > after clearing the modal. For instance: A warning that the item was not > > checked out, or a checkin message which has been configured for that > > particular item type. > > This is still the case, and I still think it's a problem. The modal hides > any other messages on the page and the messages are gone when you dismiss > the modal. > Any suggestions for how to resolve this issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:20:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:20:21 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #31 from Kyle M Hall --- (In reply to Christopher Brannon from comment #29) > (In reply to Owen Leonard from comment #28) > > I personally find the default Bootstrap colored button styles to be garish > > and I don't think we should use them. I prefer a standard button with color > > added to the icons. > > > > This is another case where we need to get some consensus before introducing > > a wholly new style to the interface. > > Our library actually uses jquery to color some buttons to make them stand > out. Frankly, I think the buttons all blend together, and I don't think > colored icons wouldn't stand out enough. I think on the staff side, if > garish improves workflow and reduces errors, then bring on the garish. > > Christopher I think a good compromise is to use the bootstrap buttons with the standard gray color. Garishness can easily be added via css/jQuery ; ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:35:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:35:22 +0000 Subject: [Koha-bugs] [Bug 15999] Add "Koha as a CMS" as built in Koha feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15999 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Kyle M Hall --- Nope, same thing! *** This bug has been marked as a duplicate of bug 12806 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:35:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:35:22 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #14 from Kyle M Hall --- *** Bug 15999 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:36:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:36:16 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #32 from Owen Leonard --- I think it's best not to introduce new global style changes in patches which have a non-global scope. Changing the buttons just in this interface would make it break with the design of all similar interfaces. That's not to say that we should continue to update the way Koha looks. I just think we need to do it in a more deliberate way. If folks want to develop a new standard for how we style buttons, make that proposal as a separate bug, a post to koha-devel, a wiki page, etc. Post screenshots and say, "Let's start doing things this way!" and propose a plan for updating the interface across the board. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:36:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:36:22 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 --- Comment #142 from Kyle M Hall --- (In reply to Nicole C. Engard from comment #141) > Sally and Paul, I put your sign offs on these patches. Thanks for the update! Excellent, I will see what I can do to qa this asap! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:38:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:38:05 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48613|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 48761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48761&action=edit Bug 15936 - Revise layout and behavior of SMS cellular providers management This patch changes the behavior of the SMS cellular providers management page so that sections of the page are shown or hidden based on what the current task is. Other changes include: - Moving JavaScript to a separate file - Adding a toolbar with a "New SMS provider" button. - Adding the "generic" catalog search header form to the top of the page. - Adding "Required" classes to required fields so that the staff client's built-in JS validation library can be used. To test, the SMSSendDriver system preference must be set to "Email." Apply the patch and go to Administration -> SMS cellular providers. - Confirm that the add/edit form is hidden initially. A toolbar with a "New SMS provider" button should appear with existing SMS cellular providers in a table below. If there are no existing providers a message dialog should say so. - Confirm that the "New SMS provider" button works: - The table should be hidden and an empty "add" form displayed. - Confirm that an empty form cannot be submitted. - Confirm that submitting valid data works. - Confirm that clicking the "Cancel" button hides the form and redisplays the table. - Test the "edit" button for an existing provider: - Confirm that the edit form is displayed and populated with the correct data. - Confirm that edits are saved correctly. - When viewing the table of existing providers, confirm that clicking the "Delete" button triggers a confirmation dialog. Test both cancelling and confirming that dialog. - Ponder whether all this is an improvement or not. Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:38:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:38:34 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 --- Comment #7 from Kyle M Hall --- (In reply to Jonathan Druart from comment #5) > Kyle, do you agree with this UI change? Yes I do. I thought I had already signed the patch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:39:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:39:00 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #33 from Katrin Fischer --- Consistency++ That said, we can still try to make it really easy to change things using ids and classes, so that libraries can make things stand out if they choose to :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:43:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:43:07 +0000 Subject: [Koha-bugs] [Bug 16002] ALL/MULTI choices in report dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Christopher, I think the problem is in how to make this work with the SQL query. <> is usually used with =, multi could be used with 'in (....)', but not sure how how to make an 'all' work in a good way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:45:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:45:34 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Differentiating between cancel and delete would make sense to me! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:47:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:47:23 +0000 Subject: [Koha-bugs] [Bug 6934] New report Cash Register Statistics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Katrin Fischer --- I agree with Jonathan - please fix the encoding issue! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:51:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:51:42 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #34 from Owen Leonard --- Lest all this talk of style suggest otherwise, it was the issues in comment #27 that prompted me to mark this as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 19:52:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 18:52:47 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #35 from Christopher Brannon --- (In reply to Kyle M Hall from comment #31) > (In reply to Christopher Brannon from comment #29) > > (In reply to Owen Leonard from comment #28) > > > I personally find the default Bootstrap colored button styles to be garish > > > and I don't think we should use them. I prefer a standard button with color > > > added to the icons. > > > > > > This is another case where we need to get some consensus before introducing > > > a wholly new style to the interface. > > > > Our library actually uses jquery to color some buttons to make them stand > > out. Frankly, I think the buttons all blend together, and I don't think > > colored icons wouldn't stand out enough. I think on the staff side, if > > garish improves workflow and reduces errors, then bring on the garish. > > > > Christopher > > I think a good compromise is to use the bootstrap buttons with the standard > gray color. Garishness can easily be added via css/jQuery ; ) As long as the buttons have distinctive IDs. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:00:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:00:36 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #5 from Kyle M Hall --- (In reply to M. Tompsett from comment #4) > (In reply to Aleisha Amohia from comment #3) > > fatal: sha1 information is lacking or useless (t/db_dependent/Accounts.t). > > Confirmed. 15895 (3 way merge okay), 15896, 15906, and 15907 all apply. It's possible I've missed a dependency. Please check out this dependency graph: https://bugs.koha-community.org/bugzilla3/showdependencygraph.cgi?id=15894 Ideally, if we could get signoffs on the patches from top to bottom everything should work itself out. Just for posterity, the order in which I wrote the patches is as follows: 15895 15896 15897 15898 15900 15901 15902 15903 15899 15906 15907 15905 15908 15909 I could simplify the dependency graph my making simply a straight line, but that would prevent any parallel testing that could be occurring. From a practical standpoint, if you test the patches in this order everything should apply cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:03:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:03:53 +0000 Subject: [Koha-bugs] [Bug 15905] Remove use of makepayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15905 --- Comment #6 from Kyle M Hall --- I've pushed out a github branch with this entire patch set applied for ease of testing: https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_15894_-_Unify_all_account_fine_payment_functions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:04:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:04:06 +0000 Subject: [Koha-bugs] [Bug 15894] Unify all account fine payment functions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15894 --- Comment #1 from Kyle M Hall --- I've pushed out a github branch with this entire patch set applied for ease of testing: https://github.com/bywatersolutions/bywater-koha-devel/tree/bug_15894_-_Unify_all_account_fine_payment_functions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:05:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:05:13 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #36 from Kyle M Hall --- (In reply to Owen Leonard from comment #34) > Lest all this talk of style suggest otherwise, it was the issues in comment > #27 that prompted me to mark this as Failed QA. Which part of comment 27? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:11:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:11:48 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #37 from Owen Leonard --- (In reply to Kyle M Hall from comment #36) > Which part of comment 27? The whole thing! 1. The dialog obscures any other messages which might be displayed during checkin, then hides those messages when the dialog is dismissed. 2. The patch reverts the changes made by Bug 15670. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:21:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:21:44 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:21:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:21:47 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47359|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 48762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48762&action=edit Bug 15585 - Move C4::Passwordrecovery to the new namespace Koha::Patron::Password::Reset As promised, here is the long-awaited sequel to #8753. What has changed : - The Koha::Patron::Password::Reset is now used in place of C4::Passwordrecovery - That ugly shift-grep contraption is no more (goodbye old friend) - The generated unique key won't end in a dot anymore Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:23:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:23:18 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker --- Comment #8 from Kyle M Hall --- Marking this as a blocker because we really shouldn't allow the next major release to go out without this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:25:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:25:02 +0000 Subject: [Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account::pay internally for recordpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > Comment on attachment 48331 [details] [review] > Bug 15895 - Add Koha::Account module, use Koha::Account::pay internally for > recordpayment > > Review of attachment 48331 [details] [review]: > ----------------------------------------------------------------- > > ::: t/db_dependent/Accounts.t > @@ +158,5 @@ > > > > + my $line1 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 100 })->store(); > > + my $line2 = Koha::Account::Line->new({ borrowernumber => $borrower->borrowernumber, amountoutstanding => 200 })->store(); > > + $line1->_result->discard_changes; > > + $line2->_result->discard_changes; > > Why do you need these 2 calls? The discard_changes call updates the objects from the database. Without them, any default values inserted by MySQL are not available in the initial object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:26:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:26:53 +0000 Subject: [Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account::pay internally for recordpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 --- Comment #4 from Kyle M Hall --- As an aside, maybe we should just add a reset() ( or maybe refresh() ) method to Koha::Object so we don't have to go through _result() which is specific to our implementation and breaks encapsulation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:35:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:35:11 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:35:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:35:11 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Bug 15735 depends on bug 15734, which changed state. Bug 15734 Summary: Audio Alerts broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:35:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:35:11 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Bug 15733 depends on bug 15734, which changed state. Bug 15734 Summary: Audio Alerts broken https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |CLOSED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:45:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:45:46 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:45:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:45:48 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47736|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 48763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48763&action=edit Bug 15735: Audio Alerts editor broken by use of of single quotes in editor Single quotes audio selector break ability to edit an alert Test Plan: 1) Enable audio alerts 2) Add new a alert with a select containing single quotes such as: input[name*='test'] 3) Note you cannot edit the alert 4) Apply this patch 5) Reload the page 6) You should now be able to edit the alert Signed-off-by: Hector Castro Bug 15734 applied on top. Works as advertised Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:46:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:46:02 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15733 | Depends on|15734 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 [Bug 15733] Audio Alerts issues in master https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 [Bug 15734] Audio Alerts broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:46:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:46:02 +0000 Subject: [Koha-bugs] [Bug 15733] Audio Alerts issues in master In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15733 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15735 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:46:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:46:02 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15735 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:48:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:48:49 +0000 Subject: [Koha-bugs] [Bug 15879] Allow multiple plugin directories to be defined in koha-conf.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15879 --- Comment #4 from Kyle M Hall --- (In reply to Julian Maurice from comment #3) > (In reply to Kyle M Hall from comment #0) > > It would be very useful to be able to define multiple plugin directories in > > the Koha conf file. This would allow for ease of plugin development so that > > each plugin installed can live in its own git repository. > > I think there is a better way to achieve this. Maybe each directory inside > the plugin directory should be considered as a plugin. > As an example, in Drupal 7 each directory with an .info file in it is > considered as a module. That is a good thought, but would require far more re-engineering of the plugin system ( and possibly all plugins ) to support such a system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:51:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:51:38 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:52:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:52:19 +0000 Subject: [Koha-bugs] [Bug 10382] collection not returning to null when removed from course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 --- Comment #14 from Kyle M Hall --- (In reply to Katrin Fischer from comment #13) > Hi Kyle, I think this could be related to the new bug 15876 for locations - > sounds like the same or at least a very similar issue Yes, I expect the issue will be the same for all non-required fields that can be changed when an item is on reserve. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:53:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:53:08 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- The pull down adds another click - so in cases with not so many options I think the buttons could work nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 20:57:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 19:57:31 +0000 Subject: [Koha-bugs] [Bug 15735] Audio Alerts editor broken by use of of single quotes in editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15735 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Brendan Gallagher --- pushed to Master - Should be in the May 2016 release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:01:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:01:40 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:01:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:01:43 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48039|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 48764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48764&action=edit Bug 15534 - Add the ability to prevent a patron from placing a hold on a record with available items Some libraries would like to prevent patrons from placing holds on items where there are other items available for the patron to check out. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circulation rules 4) Note the new option for "On shelf holds allowed" 5) Set the rule to "If all unavailable", set "item level holds" to allow 6) Find a patron/branch/itemtype applicable to this rule 7) Ensure at least one item on the record is available for the patron to check out 8) Attempt to place a hold for the item 9) Note you cannot place the hold 10) Check the available item out to another patron 11) Note you can now place a hold for the first patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:07:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:07:28 +0000 Subject: [Koha-bugs] [Bug 15534] Add the ability to prevent a patron from placing a hold on a record with available items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15534 --- Comment #14 from Kyle M Hall --- > It isn't specified here but if there's items with different item types and > that some of them are not defined as "holdable" in issuing rules and are on > shelves but that all the "holdable" one are checked out, we should have the > possibility to place an hold. > And it should be the same if we have items from different branches : one > that allows holds and the other not. If there's items available in the > branch that doesn't allow holds, but that all the items from the branch that > allows holds are checked out, patrons should be able to place a hold. Those behaviors are beyond the scope of this enhancement, but further enhancements would be welcome! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:12:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:12:14 +0000 Subject: [Koha-bugs] [Bug 15768] koha-news.pl Deep Recursion ERROR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15768 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Humberto Blanco --- (In reply to Jonathan Druart from comment #7) > Humberto, > The message says you are using mod_perl. Try in CGI mode or with Plack. > Lowering the severity to normal. Thanks Jonathan, Now all still working well. I tried mod_perl because CGI mode causes high load in the server. But, thanks now i can solve some other issues like errors when change suggestion status. Have a nice day Humberto, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:15:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:15:02 +0000 Subject: [Koha-bugs] [Bug 15820] suggestion.pl maximum internal redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15820 Humberto Blanco changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #8 from Humberto Blanco --- Thanks for all, Now all still working well. I return to CGI mode and fixed this. Humberto, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:28:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:28:19 +0000 Subject: [Koha-bugs] [Bug 9817] Add Goodreads reviews tab to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817 rhilliker at hotchkiss.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhilliker at hotchkiss.org --- Comment #14 from rhilliker at hotchkiss.org --- +1. More of our patrons use Goodreads than the other social reading platforms, so it would be a bigger selling point than Library Thing or the others that are already baked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:32:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:32:50 +0000 Subject: [Koha-bugs] [Bug 15265] Instagram and pintrest In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15265 rhilliker at hotchkiss.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rhilliker at hotchkiss.org --- Comment #2 from rhilliker at hotchkiss.org --- +1 for Ed's comment. This seems like the kind of thing where a sysadmin should be able to pick-and-choose from a list of known social media platforms. I wonder whether there mightn't even be a way to allow for new platforms by having a field to input the appropriate URI for posting content (since any site that has a RESTful API should be compatible with that method of posting in a consistent way), point to the favicon, and provide the name of the network. That would be awesome! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:39:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:39:29 +0000 Subject: [Koha-bugs] [Bug 14363] OAI-PMH should handle records without marcxml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14363 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:44:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:44:07 +0000 Subject: [Koha-bugs] [Bug 9817] Add Goodreads reviews tab to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817 --- Comment #15 from Katrin Fischer --- Please note that this bug is 'closed wontfix' - so currently noone is working on this or intending to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 21:50:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 20:50:41 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #33 from Katrin Fischer --- Hm, feels a bit big for a maintenance release, might be worth the wait. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 22:14:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 21:14:21 +0000 Subject: [Koha-bugs] [Bug 9817] Add Goodreads reviews tab to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817 --- Comment #16 from Christopher Brannon --- (In reply to Katrin Fischer from comment #15) > Please note that this bug is 'closed wontfix' - so currently noone is > working on this or intending to. Yes, but I am generating conversation in hopes that it will be pursued again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 22:17:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 21:17:29 +0000 Subject: [Koha-bugs] [Bug 9817] Add Goodreads reviews tab to the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9817 --- Comment #17 from Chris Cormack --- Just an FYI as the original author, I won't be working on advertising Amazon for free. So working on raising money to pay a dev might be a better avenue ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 22:55:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 21:55:48 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Edie Discher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com --- Comment #3 from Edie Discher --- I'm not sure exactly where the account rewrite is in the development process, but please consider allowing any outstanding fine or fee credits to be refunded directly to the patron in addition to having them apply to future fines and fees. Lost item replacement costs that are later refunded can be in amounts larger than can be readily reduced by fines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 22:58:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 21:58:34 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #205 from Nick Clemens --- So far most things have worked nicely, problems I have found: Authority search fails when sorting is enabled (Software error:Unable to understand your search query, please rephrase and try again.) and lots of this in logs: Parse Failure [No mapping found for [Heading.phrase] in order to sort on] Authority searching did not throw an error, but wouldn't return results with no sorting. I tried doing a rebuild to clear above but I got errors about AUTOLOAD inheritance for StripNonXmlChars in Authority.pm. I tried adding "use C4::Charset;" but then got an object error. Authority searching from a record via popup gave: Can't locate object method "field" via package "..followed by full marcxml for record Location (Branch) facet returns no results when combined with search Title-series limit often returns no results when combined with search The only problem I hit so far in switching back to zebrawas when I selected zebra as the search engine the cataloging search fails: Can't locate object method "simple_search_compat" via package "Koha::SearchEngine::Zebra::Search" I am going to keep plugging but authorities seems to be the biggest issue for now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 23:21:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 22:21:32 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hm, the acq start page seems to be ok now in master, but I failed to test the paypal related page. It asks for a module that I seem to be missing? I was not able to fix that right away. [Mon Mar 07 23:16:02.290772 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] AH01215: Can't locate URL/Encode.pm in @INC (you may need to install the URL::Encode module) (@INC contains: /home/katrin/kohaclone /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: http://localhost/cgi-bin/koha/opac-account.pl [Mon Mar 07 23:16:02.290880 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] AH01215: BEGIN failed--compilation aborted at /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: http://localhost/cgi-bin/koha/opac-account.pl [Mon Mar 07 23:16:02.291551 2016] [cgi:error] [pid 32291] [client 127.0.0.1:57089] End of script output before headers: opac-account-pay.pl, referer: http://localhost/cgi-bin/koha/opac-account.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 23:24:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 22:24:24 +0000 Subject: [Koha-bugs] [Bug 9254] New option to block patrons from changing messaging preferences in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #41 from Katrin Fischer --- Can we get this unstuck somehow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 23:29:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 22:29:51 +0000 Subject: [Koha-bugs] [Bug 9254] New option to block patrons from changing messaging preferences in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #42 from Katrin Fischer --- Added this bug to the next developer meeting agenda: https://wiki.koha-community.org/wiki/Development_IRC_meeting_22_March -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 7 23:32:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Mar 2016 22:32:01 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #48 from Katrin Fischer --- Hm, looking at the bug - I think we need to fix kohastructure and provide a database update for installations that are missing the column? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 05:52:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 04:52:10 +0000 Subject: [Koha-bugs] [Bug 16003] New: Add spelling exclusion patch to QA Test tools Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 Bug ID: 16003 Summary: Add spelling exclusion patch to QA Test tools Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org isnt() is a valid test function, but codespell thinks it is a typo. This adds a -s switch to the qa test tools, to skip the spelling tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 05:52:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 04:52:57 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 --- Comment #1 from M. Tompsett --- Created attachment 48765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48765&action=edit Add spelling exclusion parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 05:54:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 04:54:41 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |mtompset at hotmail.com --- Comment #2 from M. Tompsett --- It's not really patch 3/3, but I have a couple other tweaks outstanding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 06:03:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 05:03:29 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |QA tools |and plumbing | Product|Koha |Project Infrastructure Version|master |unspecified CC| |chris at bigballofwax.co.nz QA Contact|testopia at bugs.koha-communit | |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 06:33:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 05:33:40 +0000 Subject: [Koha-bugs] [Bug 15646] koha qa test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15646 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Command-line Utilities |QA tools Version|master |unspecified Product|Koha |Project Infrastructure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:19:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:19:00 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48346|0 |1 is obsolete| | --- Comment #11 from M. Tompsett --- Created attachment 48766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48766&action=edit Bug 15870: MARC Filter to exclude fields/subfields lacking visibility TEST PLAN --------- 0) Apply 15777 and 15871 as required. 1) Apply patch 2) prove -v t/db_dependpent/RecordProcessor_ViewPolicy.t -- all should pass. 3) koha qa test tools. BONUS 4) perlcritic -1 t/db_dependpent/RecordProcessor_ViewPolicy.t -- using the koha qa test tools perlcriticrc, it should pass though I am excluding checking print return values. (see bug 15646) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:19:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:19:10 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48628|0 |1 is obsolete| | --- Comment #12 from M. Tompsett --- Created attachment 48767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48767&action=edit Bug 15870: (QA followup) Add tests This patch introduces functionality tests for the new Koha::Filter. It iterates over all the possible 'hidden' values defined in the docs for hiding/showing fields and subfields, and checks the filter does the job. It tests the functionality for both opac and intranet interfaces and tries to catch all scenarios. It adds control fields to the sample record (they traverse a different branch in the code). TODO: Add another subfield to 245, set it to be hidden, and make sure 245 $a is still shown. The original tests file has been renamed conveniently. To test: - Run $ prove t/db_dependent/Filter_MARC_ViewPolicy.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:19:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:19:23 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #13 from M. Tompsett --- Created attachment 48768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48768&action=edit Bug 15870 - Follow-up of filter and tests This patch: - improves perlcritic messages in the filter and tests. - changes should display logic to should hide logic to simplify filter. - perltidies the scripts - debugs the issues outstanding on the comprehensive tests provided in the second commit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:19:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:19:29 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 --- Comment #14 from M. Tompsett --- Created attachment 48769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48769&action=edit Bug 15870 - potential follow up to comment #8 This patch: - makes the Koha::RecordProcessor code more clear by removing the unnecessary newrecord variable. - revises the filter to be more clear about the expectation that operations are done directly on the record parameter. TEST PLAN --------- prove t/RecordProcessor.t prove t/db_dependent/Filter_MARC_ViewPolicy.t run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:22:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:22:26 +0000 Subject: [Koha-bugs] [Bug 15675] Add issue_id column to accountlines and use it for updating fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Severity|minor |enhancement --- Comment #34 from Julian Maurice --- (In reply to Katrin Fischer from comment #33) > Hm, feels a bit big for a maintenance release, might be worth the wait. That was my thinking too, thanks for the confirmation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:22:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:22:27 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 15675, which changed state. Bug 15675 Summary: Add issue_id column to accountlines and use it for updating fines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:22:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:22:27 +0000 Subject: [Koha-bugs] [Bug 15732] Remove accountno column from accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 Bug 15732 depends on bug 15675, which changed state. Bug 15675 Summary: Add issue_id column to accountlines and use it for updating fines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:22:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:22:28 +0000 Subject: [Koha-bugs] [Bug 15895] Add Koha::Account module, use Koha::Account::pay internally for recordpayment In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 Bug 15895 depends on bug 15675, which changed state. Bug 15675 Summary: Add issue_id column to accountlines and use it for updating fines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:26:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:26:16 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #15 from M. Tompsett --- TEST PLAN --------- apply all but the last patch prove -v t/db_dependent/Filter_MARC_ViewPolicy.t prove -v t/RecordProcessor.t run koha qa test tools apply the last patch prove -v t/db_dependent/Filter_MARC_ViewPolicy.t prove -v t/RecordProcessor.t run koha qa test tools Decide if the last patch is what addresses comment #8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 07:59:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 06:59:00 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 08:38:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 07:38:29 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 08:55:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 07:55:15 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 --- Comment #5 from Jonathan Druart --- (In reply to Kyle M Hall from comment #3) > (In reply to Jonathan Druart from comment #2) > > Created attachment 48725 [details] [review] [review] > > Bug 15987: Fix undefined subroutine &main::GetCurrency in opac-account-pay > > > > Bug 15987 and bug 11622 were competing the push to master status at the > > same time. Bug 15987 removed the GetCurrency status and bug 11622 > > reintroduced one occurrence of this subroutine. > > > > Test plan: > > Confirm that the test plan for 11622 still passes. > > Jonathan, I added a qa followup to bug 15084 that fixes the same issues. Do > you think it would be better to close this bug, or to revert my patch and > push this bug through the community process? If you tested the paypal stuff, I am fine with your patch (I have not tested it!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 08:55:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 07:55:57 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > Hm, the acq start page seems to be ok now in master, but I failed to test > the paypal related page. > > It asks for a module that I seem to be missing? I was not able to fix that > right away. > > [Mon Mar 07 23:16:02.290772 2016] [cgi:error] [pid 32291] [client > 127.0.0.1:57089] AH01215: Can't locate URL/Encode.pm in @INC (you may need > to install the URL::Encode module) (@INC contains: /home/katrin/kohaclone > /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 > /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 > /usr/local/lib/site_perl .) at > /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: > http://localhost/cgi-bin/koha/opac-account.pl > [Mon Mar 07 23:16:02.290880 2016] [cgi:error] [pid 32291] [client > 127.0.0.1:57089] AH01215: BEGIN failed--compilation aborted at > /home/katrin/kohaclone/opac/opac-account-pay.pl line 27., referer: > http://localhost/cgi-bin/koha/opac-account.pl > [Mon Mar 07 23:16:02.291551 2016] [cgi:error] [pid 32291] [client > 127.0.0.1:57089] End of script output before headers: opac-account-pay.pl, > referer: http://localhost/cgi-bin/koha/opac-account.pl URL::Encode does not seem to be packaged in our repo. See the original bug report for the discussion about this module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:04:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:04:26 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 --- Comment #6 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #5) > This patch has been pushed to 3.20.x, will be in 3.20.6. % git checkout v3.20.07 HEAD is now at 95a5b0d... Translation updates for Koha 3.20 release % perl -wc serials/checkexpiration.pl Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at serials/checkexpiration.pl line 84. Global symbol "$branch" requires explicit package name (did you forget to declare "my $branch"?) at serials/checkexpiration.pl line 84. serials/checkexpiration.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:08:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:08:05 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8436 --- Comment #7 from Jonathan Druart --- Fr?d?ric, this patch depends on the $branch var, added by bug 8436. I would revert this patch from 3.20.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 [Bug 8436] Add branch limit on checkexpiration.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:08:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:08:05 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15171 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 [Bug 15171] Searching serials expiring after today should be allowed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:09:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:09:35 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 --- Comment #8 from Jonathan Druart --- Reported on the mailing list: https://lists.katipo.co.nz/pipermail/koha/2016-March/044907.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:15:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:15:23 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- use of debug statements, marked as failed QA. I would not skip this pass, why do you want? It's certainly better to fix the annoying false positive 'isnt' than completely skip the spelling check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:19:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:19:24 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:19:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:19:26 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48752|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 48770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48770&action=edit Bug 15998 - svc/holds: use holdingbranch instead of holding_branch Signed-off-by: Fr?d?ric Demians -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:22:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:22:58 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 --- Comment #9 from Fr?d?ric Demians --- (In reply to Jonathan Druart from comment #8) > Reported on the mailing list: > https://lists.katipo.co.nz/pipermail/koha/2016-March/044907.html Thanks. Take a look immediately. Do you know why Jenkins don't run anymore tests for 3.20 branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:23:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:23:54 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #13 from Jonathan Druart --- (In reply to Heather Braum from comment #12) > Jonathan, we're needing to use Koha's Self Check at multiple branches, so > have to use multiple logins; we can't save those to the AutoSelfCheckID sys > pef as a result. Hence the development need. I'll can't answer the > complexity question :) I'll let Nick do that. You are overriding the pref values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:25:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:25:47 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > (In reply to Heather Braum from comment #12) > > Jonathan, we're needing to use Koha's Self Check at multiple branches, so > > have to use multiple logins; we can't save those to the AutoSelfCheckID sys > > pef as a result. Hence the development need. I'll can't answer the > > complexity question :) I'll let Nick do that. (previous comment left too fast!) You are overriding the pref values using the ENV var, that's what you mean? If yes, it should not change anything to what I suggested :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:28:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:28:52 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 --- Comment #10 from Fr?d?ric Demians --- I've already reverted this patch December 29th. So the bug reported on mailing list is there in 3.20.7, but is fixed in 3.20.8 and later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:41:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:41:40 +0000 Subject: [Koha-bugs] [Bug 12478] Elasticsearch support for Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #206 from Jonathan Druart --- The branch is 500 commits behind master, is someone in charge of rebasing it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:48:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:48:31 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 --- Comment #11 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #10) > I've already reverted this patch December 29th. So the bug reported on > mailing list is there in 3.20.7, but is fixed in 3.20.8 and later. Oops, sorry, I should have tested that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 09:52:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 08:52:15 +0000 Subject: [Koha-bugs] [Bug 15171] Searching serials expiring after today should be allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15171 --- Comment #12 from Jonathan Druart --- (In reply to Fr?d?ric Demians from comment #9) Do you know why Jenkins don't run anymore tests for 3.20 branch. Tomas reported an issue on the jenkins config. I will ping him on #koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 10:32:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 09:32:40 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart --- Kyle, The module has been moved to the Koha namespace but does not respect the requirements for that (object oriented). I don't see the point to have it in Koha in that case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 10:53:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 09:53:08 +0000 Subject: [Koha-bugs] [Bug 16004] New: Replace items.new with items.new_status Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Bug ID: 16004 Summary: Replace items.new with items.new_status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Tools Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. It will be renamed with new_status to avoid the ambiguity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 10:53:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 09:53:22 +0000 Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #108 from Jonathan Druart --- (In reply to Kyle M Hall from comment #107) > I just had a thought about this. I think the db column 'new' is going to > never be accessible via Koha::Item. I think a followup will be needed to > change the column from 'new' to maybe 'new_status'? Any other column name > suggestions would be appreciated! See bug 16004. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 10:56:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 09:56:29 +0000 Subject: [Koha-bugs] [Bug 16004] Replace items.new with items.new_status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 10:56:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 09:56:35 +0000 Subject: [Koha-bugs] [Bug 16004] Replace items.new with items.new_status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 --- Comment #1 from Jonathan Druart --- Created attachment 48771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48771&action=edit Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:00:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:00:47 +0000 Subject: [Koha-bugs] [Bug 15802] The system will not allow me to return any books In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|major |normal --- Comment #2 from Jonathan Druart --- Sasha, did you solve your problem? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:03:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:03:27 +0000 Subject: [Koha-bugs] [Bug 12794] Check-in waiting forever on checkin for items due to past dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12794 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- That has certainly been fixed by a previous patches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:05:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:05:39 +0000 Subject: [Koha-bugs] [Bug 8902] Many columns do not appear in batch modification if selected records do not include them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8902 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:06:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:06:48 +0000 Subject: [Koha-bugs] [Bug 15916] Regression: Many tables' sorting broken by JavaScript error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois at bibl | |ibre.com --- Comment #8 from Jonathan Druart --- *** Bug 15915 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:06:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:06:48 +0000 Subject: [Koha-bugs] [Bug 15915] when creating a new child account the pop up guarantor_search.pl is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15915 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Jonathan Druart --- Looks like it has been fixed by bug 15916, please reopen if I am wrong. *** This bug has been marked as a duplicate of bug 15916 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:13:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:13:53 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #54 from Jonathan Druart --- @RM: The schema has not been regenerated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:19:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:19:34 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #55 from Jonathan Druart --- Created attachment 48772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48772&action=edit Bug 15084: typo currency vs currency_code The DB column is currency.currency not currency.currency_code. Test plan: Delete a currency Without this patch, you will get a warning in the logs: No method currency_code! at /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt line 148. And the currency won't be deleted. With this patch, it will! It also changes the value of the delete op. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:50:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:50:50 +0000 Subject: [Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:51:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:51:20 +0000 Subject: [Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 --- Comment #2 from Jonathan Druart --- Created attachment 48773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48773&action=edit Bug 15962: Add messages on the currency admin page Bug 15084 rewrote the currency admin page but forgot to add the messages block. Test plan: Add/update/delete vendors. You should get information messages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:51:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:51:28 +0000 Subject: [Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 --- Comment #3 from Jonathan Druart --- Created attachment 48774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48774&action=edit Bug 15962: Block the currency deletion if used A currency should not be deleted if used by a vendor or a basket. Test plan: 1/ Add a new currency 2/ Create a vendor using this currency 3/ Create a basket using this currency 4/ Try to delete the currency 5/ Delete the basket 6/ Try to delete the currency 7/ Delete the vendor 8/ Delete the currency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:52:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:52:14 +0000 Subject: [Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- You will need the last patch on bug 15084 (typo currency vs currency_code) to test this patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 11:56:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 10:56:48 +0000 Subject: [Koha-bugs] [Bug 15953] Patroncards toolbar is now broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Aleisha, they work for me. Do you have a JavaScript error in the console? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 12:09:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 11:09:49 +0000 Subject: [Koha-bugs] [Bug 15868] Ask for confirmation before deleting MARC modification template action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 12:10:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 11:10:00 +0000 Subject: [Koha-bugs] [Bug 15868] Ask for confirmation before deleting MARC modification template action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868 --- Comment #2 from Jonathan Druart --- Created attachment 48775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48775&action=edit Bug 15868: Ask for confirmation when deleting a MMT action Test plan: Create marc modification template Add an action Delete it With this patch you must get a confirmation mesg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 12:17:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 11:17:52 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 12:17:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 11:17:52 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15969 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 12:18:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 11:18:02 +0000 Subject: [Koha-bugs] [Bug 15868] Ask for confirmation before deleting MARC modification template action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 12:28:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 11:28:15 +0000 Subject: [Koha-bugs] [Bug 15620] Tools: View Log = No Log Found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15620 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- Hello, I confirm the issue in 3.22.01. It has been fixed by bug 15939, which has been pushed to 3.22.x It will be in the next release (3.22.05). *** This bug has been marked as a duplicate of bug 15939 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 12:28:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 11:28:15 +0000 Subject: [Koha-bugs] [Bug 15939] modification logs view now silently defaults to only current day's actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15939 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mustaqeemabd at gmail.com --- Comment #6 from Jonathan Druart --- *** Bug 15620 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 12:42:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 11:42:01 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Kyle, I don't reproduce: update borrowers set email="my at email.com\t " where borrowernumber=42; Then the results are displayed correctly. Moreover the email value is not displayed in the table. Could you detail please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:00:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:00:31 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 --- Comment #2 from Kyle M Hall --- Here is a screencast of me reproducing the issue: http://screencast.com/t/ew0siMJQU I used Sequel Pro to insert the tab and space. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:01:10 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:01:10 +0000 Subject: [Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:01:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:01:22 +0000 Subject: [Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 --- Comment #1 from Jonathan Druart --- Created attachment 48776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48776&action=edit Bug 15741: Fix rounding in total fines calculations C4::Members::GetMemberAccountRecords wrongly casts float to integer It's common to use sprintf in Perl to do this job. % perl -e 'print int(1000*64.60)."\n"'; 64599 % perl -e 'print sprintf("%.0f", 1000*64.60)."\n"'; 64600 Test plan: 1) Create manual invoice for 64.60 (or 1.14, 1.36, ...) 2) Try to pay it using "Pay amount" or "Pay selected" buttons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:01:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:01:45 +0000 Subject: [Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:06:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:06:06 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:06:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:06:20 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46172|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 48777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48777&action=edit Bug 15445 DateUtils.t fails on Jenkins due to server sluggishness Jenkins server is abnormally slow to perform a task done in less than 1s elsewhere. The test stay valid by giving just a bit more time to Jenkins server. TO TEST: - Confirm that the two test hasn't changed. They the just get 4s to perform - Push the patch to master and observe that DateUtils.t doesn't fail anymore. NOTE: Also passed koha qa test tools too. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Amended: Changed to 2s, should be enough -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:07:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:07:36 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 --- Comment #9 from Jonathan Druart --- Fr?d?ric, I have amended your patch and set the delay to 2sec. It should be ok for jenkins. Hope it's fine for you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:15:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:15:21 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #22 from Jonathan Druart --- Is it solved? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:18:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:18:15 +0000 Subject: [Koha-bugs] [Bug 15510] New professional cataloguing editor shows OPAC favicon In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15510 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |INVALID --- Comment #3 from Jonathan Druart --- This is solved, it was a cache issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:27:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:27:59 +0000 Subject: [Koha-bugs] [Bug 15464] Fast Cataloguing gateway timeout In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15464 --- Comment #23 from Patfrat --- I have not yet retried a fresh install. I will try it soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:38:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:38:52 +0000 Subject: [Koha-bugs] [Bug 16004] Replace items.new with items.new_status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11023 CC| |kyle at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:38:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:38:52 +0000 Subject: [Koha-bugs] [Bug 11023] Automatic item modification by age (Was "Toggle new status for items") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 [Bug 16004] Replace items.new with items.new_status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:41:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:41:48 +0000 Subject: [Koha-bugs] [Bug 16004] Replace items.new with items.new_status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48771|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 48778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48778&action=edit Bug 16004: Replace items.new with items.new_status The items.new column is badly named, the Koha::Item->new accessor will never returns this value, but the constructor will be called instead. This patch renames it with new_status to avoid the ambiguity. Test plan: 0/ Do not apply this patch 1/ Define some rules in the "Automatic item modifications by age" tool with at least one items.new field used 2/ Apply this patch 3/ Execute the update DB entry 4/ Reload the tool page and confirm that the changes have been taken into account Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:41:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:41:46 +0000 Subject: [Koha-bugs] [Bug 16004] Replace items.new with items.new_status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:43:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:43:47 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #124 from Jacek Ablewicz --- Some (not very scientific) cache performace tests below. I measured C4::Context->preference() calls; 3 scenarios: A) feching 1 small syspref (marcflavour) over and over - syspref cache (almost) unpopulated B) feching 'marcflavour', cache fully populated (all 545 system preferencers in cache) C) feching all system prefrences in alphabetical order, cache fully populated, average time spent in ->preference() call / per preference Results (A / B / C): - without patch (syspref cache = perl hashref): 1.1us / 1.1us / 0.9us - Cache::Memory: 36us / 53us / 110us - memcached: 41us / 41us / 42us - fastmmap: 14us / 16us / 60us - mysql query cache (256MB, DBI): ... / 130us / 135us - mysql query cache (256MB, DBIx): ... / 1.20ms / 1.20ms -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:46:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:46:59 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > Kyle, > The module has been moved to the Koha namespace but does not respect the > requirements for that (object oriented). I don't see the point to have it in > Koha in that case. Koha namespace modules do not *have* to be OO, though they should be. PERL15: Whenever it makes sense, code added to the Koha:: namespace should be object-oriented. However, code that is naturally procedural should not be shoehorned into the OO style. I'd rather see this moved to the Koha namespace and get maybe updated to be OO later than to introduce a new module to C4. After all, why did we get a promise from Charles to submit this patch if we were later going to decide we would not use it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 13:56:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 12:56:28 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #38 from Kyle M Hall --- (In reply to Owen Leonard from comment #37) > (In reply to Kyle M Hall from comment #36) > > Which part of comment 27? > > The whole thing! > > 1. The dialog obscures any other messages which might be displayed during > checkin, then hides those messages when the dialog is dismissed. > > 2. The patch reverts the changes made by Bug 15670. Let's focus on point 1 for now. What would you suggest as a fix for that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:01:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:01:22 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:01:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:01:26 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47617|0 |1 is obsolete| | Attachment #47618|0 |1 is obsolete| | Attachment #47619|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 48779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48779&action=edit Bug 9805 - Lost items are un-lost if returned, but not if renewed. If an item has a lost status, that status is removed when the item is returned. However, it is not removed if the item is renewed. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Browse to the circ rules 4) Note the "Renew lost?" and "Renewal marks lost found" rules 5) Set and test each of the rules both ways for the rules for all libraries 6) Repeat but for a specific branch this time Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:01:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:01:34 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #36 from Kyle M Hall --- Created attachment 48780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48780&action=edit Bug 9805 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:01:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:01:37 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #37 from Kyle M Hall --- Created attachment 48781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48781&action=edit Bug 9805 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:02:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:02:27 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 --- Comment #38 from Kyle M Hall --- (In reply to Jonathan Druart from comment #34) > t/db_dependent/Circulation/Renewal.t (Wstat: 65280 Tests: 2 Failed: 0) > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 7 tests but ran 2. All the tests passed for me! Can you please try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:11:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:11:37 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #39 from Owen Leonard --- Unless there is a good case for hiding all messages, why not simply leave them there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:13:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:13:52 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48765|0 |1 is obsolete| | --- Comment #4 from M. Tompsett --- Created attachment 48782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48782&action=edit Bug 16003: Add spelling exclusion switch. TEST PLAN --------- Run on a test file with isnt. -- spelling error Patch Run on the same file with a -s -- spelling tests skipped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:14:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:14:02 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Ian Bays changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.bays at ptfs-europe.com --- Comment #3 from Ian Bays --- We have encountered this problem too in data loaded that came with unexpected tabs in the borrower data. It was very difficult to track down. Exactly the symptoms seen by Kyle. No errors that we could see and nothing in the koha error logs that we could find. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:16:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:16:58 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from M. Tompsett --- (In reply to Jonathan Druart from comment #3) > use of debug statements, marked as failed QA. DOH! Valid point. > I would not skip this pass, why do you want? Because I rather see SKIPPED than FAILED, when there is a false positive. Additionally, adding the -s is more typing. Most people won't, like they shouldn't. > It's certainly better to fix the annoying false positive 'isnt' than > completely skip the spelling check. I concede that is the better solution. However, since I don't know how to do that, I did what I know how to do as of this moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:19:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:19:37 +0000 Subject: [Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:43:06 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:43:06 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Nicole C. Engard --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees Using index info to reconstruct a base tree... M C4/Circulation.pm M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Circulation.pm Auto packing the repository in background for optimum performance. See "git help gc" for manual housekeeping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:49:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:49:24 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #11 from Blou --- Interesting, that's the first explanation I have about C4 vs Koha namespace. I always thought C4 was "old crap" and Koha was "new better". Still, I don't understand the obsession toward OOing everything, especially in a non-OO language like Perl. Java created many obsessive behaviors and even more ugly projects because of its misunderstood OO paradigm. (I'm not calling our QA as having OCD, btw :-) I'll leave my 3 cents on this marvelous must-read article from an all-time great: http://www.drdobbs.com/cpp/how-non-member-functions-improve-encapsu/184401197 just because I like to plug it :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:51:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:51:22 +0000 Subject: [Koha-bugs] [Bug 15585] Move C4::Passwordrecovery to Koha::Patron::Password::Reset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15585 --- Comment #12 from Katrin Fischer --- I think we left the door open for non-OO modules atm - so I think this one should be ok from the phrasing in the coding guidelines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 14:55:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 13:55:08 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #56 from Marcel de Rooy --- Created attachment 48783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48783&action=edit Bug 15084: [QA Follow-up] Update kohastructure Adds two db revs to kohastructure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:00:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:00:32 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:00:35 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:00:35 +0000 Subject: [Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48759|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 48784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48784&action=edit Bug 14577 - Allow restriction of checkouts based on fines of guarantor's guarantees This enhancment allows a library to prevent patrons from checking out items if his or her guarantees own too much. Test Plan: 1) Apply this patch 2) Find or create a patron with a guarantor 3) Add a fine to the patron's account 4) Set the new system preference NoIssuesChargeGuarantees to be less than the amount owed by the patron 4) Attempt to check out an item to the guarantor, you will either be warned or prevented from checking out based on your system settings. Signed-off-by: Cathi Wiggin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:03:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:03:15 +0000 Subject: [Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:03:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:03:17 +0000 Subject: [Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #1 from Owen Leonard --- Created attachment 48785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48785&action=edit Bug 16000 - Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:13:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:13:46 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:13:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:13:54 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 --- Comment #4 from Jonathan Druart --- Created attachment 48786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48786&action=edit Bug 15722: Escape patron infos for JSON in patron searches If patron infos contain invalid JSON chars (\t for instance), the results won't appear. The solution is to escape these info. Test plan: Edit patron infos in DB (update borrowers set surname="foobar\t" where borrowernumber=42) Search for foobar (you should have more than 1 result) Without this patch, DT retrieves a bad formatted JSON and the results won't appear. With this patch, the table result appears -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:14:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:14:12 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:15:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:15:13 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #39 from Dobrica Pavlinusic --- Is there reason -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:16:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:16:15 +0000 Subject: [Koha-bugs] [Bug 15868] Ask for confirmation before deleting MARC modification template action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:16:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:16:17 +0000 Subject: [Koha-bugs] [Bug 15868] Ask for confirmation before deleting MARC modification template action In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15868 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48775|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 48787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48787&action=edit [SIGNED-OFF] Bug 15868: Ask for confirmation when deleting a MMT action Test plan: Create marc modification template Add an action Delete it With this patch you must get a confirmation mesg Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:18:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:18:03 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #40 from Dobrica Pavlinusic --- Is there reason why we use output_pref( { dt => dt_from_string( $subs->{startdate} ), dateonly => 1 } ); instead of output_pref( { str => subs->{startdate}, dateonly => 1 } ); Second one has nice side-effect that it supports empty dates (which return as undef from database) in serial module. In our case, empty dates for planneddate and publisheddate produce application error base hash { dt => dt_from_string( $line->{planneddate} ), dateonly => 1 } folds to { dt , dateonly => 1 } which makes dt = 'dateonly' which in turn is not object and result in application error. Should I prepare separate bug for this change? Does it make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:30:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:30:42 +0000 Subject: [Koha-bugs] [Bug 14969] Remove C4::Dates from serials/*.pl files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14969 --- Comment #41 from Jonathan Druart --- (In reply to Dobrica Pavlinusic from comment #40) > Is there reason why we use > > output_pref( { dt => dt_from_string( $subs->{startdate} ), dateonly => 1 > } ); > > instead of > > output_pref( { str => subs->{startdate}, dateonly => 1 } ); > > Second one has nice side-effect that it supports empty dates (which return > as undef from database) in serial module. In our case, empty dates for > planneddate and publisheddate produce application error base hash > > { dt => dt_from_string( $line->{planneddate} ), dateonly => 1 } > > folds to > > { dt , dateonly => 1 } > > which makes dt = 'dateonly' which in turn is not object and result in > application error. > > Should I prepare separate bug for this change? Does it make sense? Dobrica, The removal of C4::Dates was quite long, and bug 15166 (which introduced the str param) has been done during this process. Of course we should remove *all* occurrences of output_pref({dt = dt_from_string}); as it is dangerous. It's on my todo list, I just need some motivation... Please open the bug report and assign it to me, maybe it will bring me some energy to do it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:40:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:40:43 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin at inlibro.com --- Comment #11 from Blou --- I'd like to reply on Robin's comment. Here, I see a serious need for this as a matter of managing security. Let just call that the disgruntled employee scenario. I have no need for it RIGHT NOW, but as we plan for every possible outcome, to safeguard our customer's data or maintaining 24/7 access, one of them is the I-QUIT-AND-DESTROY-ALL-YOUR-SH.. scenario. So OK, I have my you-quit-I-lock-out-your-account. But changing a database password is a pain, always with some unforeseen consequences (yeah, I should plan those too). You try to not have to do it. Life is just simpler that way... Also, that's very hard to automate, or do manually through 100 databases. SO, why give a user through a very easy to use UI, very easy to remember staff url, an Uber-Access to all that is sacred in our business ? Anyway, too long text. We can argue about my failures as a security manager, but I reserve the right to argue that this direct access to the system should be blockable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:40:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:40:55 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40963|1 |0 is obsolete| | --- Comment #12 from Blou --- Comment on attachment 40963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40963 Bug 11590: Restrict the actions for the DB user I'd like to test this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:49:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:49:34 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #125 from Jonathan Druart --- Hi Jacek, Did you try to profile a "real life" situation? I think it would make sense to use NYTProf on different pages, with bug 15973 and bug 15970 (if needed) applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 15:59:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 14:59:59 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #13 from Blou --- The patch does what I need, but would need two more things, I think: 1) Make that a preference. To make it more acceptable to the people who don't believe in security :) 1b) The preference should by default be ON, but hey, that's arguable. 2) Prevent the unlimited creation of superuser using that user. I think as soon as there's one in the DB, the creation should be blocked. After that, an access directly to the db is required if you forget your account. Otherwise, the door is as open as before. 2b) I got a bash script to create support accounts from the backend. I'd be happy to add it to a patch if wanted. I'll sign the first patch off, because I think it's already a great move ahead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:00:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:00:57 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:02:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:02:20 +0000 Subject: [Koha-bugs] [Bug 11590] Restrict the actions for the DB user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11590 --- Comment #14 from Blou --- Created attachment 48788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48788&action=edit [SIGNED-OFF] Bug 11590: Restrict the actions for the DB user The DB user (the one defined in the KOHA_CONF file, section config) should not be used to navigate into Koha. It has been decided to let it actif to create the first user easily. This patch suggests to restrict as much as possible the actions for this user. If logged with this user, the administrator will only be able to create the first user and that's all. Automatically the new user created will be a superlibrarian. Test plan: 1/ Use the DB user to log you in into Koha. 2/ Make sure you are just able to go to the about and help pages. On the main page, you are pleased to create an user. 3/ Click on the link to create a new user 4/ Fill the form and save 5/ You are redirected to the loggin page 6/ Use the new user credentials and confirm it has been created as a superlibrarian. Signed-off-by: Philippe Blouin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:31:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:31:20 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:31:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:31:23 +0000 Subject: [Koha-bugs] [Bug 15722] Patron search cannot deal with hidden characters ( tabs ) in fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15722 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48786|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 48789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48789&action=edit Bug 15722: Escape patron infos for JSON in patron searches If patron infos contain invalid JSON chars (\t for instance), the results won't appear. The solution is to escape these info. Test plan: Edit patron infos in DB (update borrowers set surname="foobar\t" where borrowernumber=42) Search for foobar (you should have more than 1 result) Without this patch, DT retrieves a bad formatted JSON and the results won't appear. With this patch, the table result appears Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:37:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:37:03 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #49 from Blou --- So, we need a patch that corrects the pushed-to-master patch, for future installations. AND that patch must also provide a fix to those who already installed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:42:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:42:23 +0000 Subject: [Koha-bugs] [Bug 16005] New: Standardize use of icons for delete and cancel operations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005 Bug ID: 16005 Summary: Standardize use of icons for delete and cancel operations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Right now we are using a mix of similar icons for operations like delete, cancel, close, etc. We need to set a standard so that it is clear which icon means what. I propose that the "trash" icon be used anywhere something is being deleted, removed, or cleared: http://fortawesome.github.io/Font-Awesome/icon/trash/ I propose that we use the "times" (for which "remove" is an alias) icon for cancel operations (where buttons are used): http://fortawesome.github.io/Font-Awesome/icon/times/ I propose that we use the "times-circle" icon to mean "close:" http://fortawesome.github.io/Font-Awesome/icon/times-circle/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:43:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:43:17 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:43:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:43:20 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48749|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall --- Created attachment 48790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48790&action=edit Bug 11360 - Disable barcode field and submit button when a hold is found At the moment when scanning in returns, it can be easy to miss a hold trap due to the fact that the barcode and submit are still active and the barcode field is focused on. A librarian who is focused on scanning can easily scan another item and pass over the form, which is equivalent to clicking the "ignore" button. Test Plan: 1) Apply this patch 2) Trap a hold, note the new modal 3) Check the hold in a second time 4) Note the new modal 5) For each modal, test each button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:44:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:44:00 +0000 Subject: [Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360 --- Comment #41 from Kyle M Hall --- This latest patch should fix both of your issues Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 16:44:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 15:44:46 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 --- Comment #6 from M. Tompsett --- Created attachment 48791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48791&action=edit Bug 16003 - Add exceptions file logic to codespell call I created an exceptions file by: $ git grep "isnt(" | cut -f2- -d":" | sort -u > ~/qa-test-tools/spelling.exceptions I then patched QohA/File.pm to include a -x extension to the codespell call if the exceptions file existed. TEST PLAN --------- In your koha development directory apply bug 15870 run the koha qa test tools -- you will get a complaint about isnt(, likely because it is tokenized as isnt. apply this patch to your qa test tools run the koha qa test tools on bug 15870 again -- spelling issue passed! THIS IS A COUNTER PATCH. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:05:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:05:17 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #57 from Marcel de Rooy --- Aarrggg This was hard to find: The foreign key constraint (in AQorder) will sometimes fail on you: Why? aqorder: | currency | varchar(3) | YES | MUL | NULL | currency: | currency | varchar(10) | NO | PRI | | Length is not the SAME !! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:09 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:13 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47606|0 |1 is obsolete| | Attachment #47607|0 |1 is obsolete| | Attachment #47608|0 |1 is obsolete| | Attachment #47609|0 |1 is obsolete| | Attachment #47610|0 |1 is obsolete| | Attachment #47611|0 |1 is obsolete| | Attachment #47612|0 |1 is obsolete| | Attachment #47613|0 |1 is obsolete| | Attachment #47614|0 |1 is obsolete| | Attachment #47615|0 |1 is obsolete| | --- Comment #71 from Kyle M Hall --- Created attachment 48792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48792&action=edit Bug 14695 - Update database Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:27 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48513|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 48793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48793&action=edit Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher This patch adds a syspref "AggressiveMatchOnISSN" allowing for a match of ISSNs with or without hyphens. It uses Business::ISSN in order to follow the use of Business::ISBN and allow for validation of ISSNs To test: 1 - Find a record in your system with an ISSN (or add one) 2 - Stage a record containing the same ISSN but lacking a hyphen 3 - Matching on ISSN should find 0 matches 4 - Repeat with no hyphen ISSN in system and hyphen ISSN in import 5 - Matching should find 0 6 - Apply patch 7 - Update datbase and install Business::ISSN 8 - Leave AggressiveMatchOnISSN as don't and repeat original tests- no change 9 - Set AggressiveMatchOnISSN as do and repeat original test 10 - You should find a match 11 - prove t/Koha.t - all tests pass Sponsored by North Central Regional Library System (NCRL) www.ncrl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:32 +0000 Subject: [Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48514|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 48794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48794&action=edit Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN This is an optional follow up depending on community opinion. While copying over the code form the ISBN portion I noticed that with aggressive matching enabled invalid ISBNs (and hence ISSNs) were being stripped from the record. I think in the case of a library exporting records, making changes, and reimporting they would expect to get a match on ISSN or ISBN whether or not the number is valid. This patch changes the subroutine to return the original ISSN in the case of it being invalid. To test: With first patch only export a record with an invalid ISSN and reimport with AggressiveMatchOnISSN enabled and match on ISSN - you should not get a match Apply this patch reimport the file and you should find a match. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:32 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #72 from Kyle M Hall --- Created attachment 48795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48795&action=edit Bug 14695 - Update DB Schema file Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:36 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #73 from Kyle M Hall --- Created attachment 48796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48796&action=edit Bug 14695 - Add new circulation rule Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:40 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #74 from Kyle M Hall --- Created attachment 48797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48797&action=edit Bug 14695 - Tidy C4::Reserves::CanItemBeReserved Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:44 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #75 from Kyle M Hall --- Created attachment 48798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48798&action=edit Bug 14695 - Add ability to place multiple item holds on a given record per patron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:48 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #76 from Kyle M Hall --- Created attachment 48799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48799&action=edit Bug 14695 [QA Followup] - Filling one hold fills all of them Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:53 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #77 from Kyle M Hall --- Created attachment 48800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48800&action=edit Bug 14695 [QA Followup] - Make existing unit tests pass * Removes tests no longer needed * Updates rules to work with existing tests * Fixes code issues revealed by unit tests Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:08:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:08:57 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #78 from Kyle M Hall --- Created attachment 48801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48801&action=edit Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:09:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:09:01 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #79 from Kyle M Hall --- Created attachment 48802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48802&action=edit Bug 14695 - Warn librarian if max_holds_per_record is reached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:09:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:09:05 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 --- Comment #80 from Kyle M Hall --- Created attachment 48803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48803&action=edit Bug 14695 - Don't use holds_to_place_count when checking an item. This fix the following bug: If you select 2 in "Holds to place (count)" and finally check an item, so you get 2 holds for the same item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:14:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:14:46 +0000 Subject: [Koha-bugs] [Bug 16006] New: merge_authorities.pl doesn't work Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16006 Bug ID: 16006 Summary: merge_authorities.pl doesn't work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: remi.mayrand-provencher at inLibro.com Reporter: remi.mayrand-provencher at inLibro.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Running the merge_authorities.pl script with options -f and -t set properly returns this on a clean master installation: Can't locate object method "authtypecode" via package "2" (perhaps you forgot to load "2"?) at ./merge_authority.pl line 58. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:15:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:15:25 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #15 from Nick Clemens --- You are correct Joubu, there are easier methods, patch to follow later -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:21:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:21:37 +0000 Subject: [Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #45 from Kyle M Hall --- Created attachment 48804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48804&action=edit Bug 14694 [QA Followup] - Update Koha::Borrower references to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:27:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:27:23 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #58 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #57) > Aarrggg > This was hard to find: > The foreign key constraint (in AQorder) will sometimes fail on you: > Why? > aqorder: > | currency | varchar(3) | YES | MUL | NULL | > currency: > | currency | varchar(10) | NO | PRI | | > > Length is not the SAME !! So I take it we need a dbrev to update aqorder.currency to varchar(10) as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 17:31:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 16:31:27 +0000 Subject: [Koha-bugs] [Bug 15987] Acq module fails with undefined subroutine &main::GetCurrency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15987 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 19:00:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 18:00:20 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #25 from Kyle M Hall --- Created attachment 48805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48805&action=edit Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 19:28:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 18:28:49 +0000 Subject: [Koha-bugs] [Bug 15930] DataTables patron search defaulting to 'starts_with' and not getting correct parameters to parse multiple word searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15930 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- I think using quotes to define names to not split apart makes the most sense. so a starts_with search for Kyle Hall will look for fields starting with "Kyle" and/or fields starting with "Hall" where a search for "Kyle Hall" will look for fields starting with "Kyle Hall" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 19:31:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 18:31:23 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #27 from I'm just a bot --- fatal: previous rebase directory .git/rebase-apply still exists but mbox given. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 19:32:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 18:32:16 +0000 Subject: [Koha-bugs] [Bug 14560] Introduce a way of handling Rameau composed authorities, without breaking normal workflow In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14560 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot at bugs.koha-community. | |org --- Comment #8 from I'm just a bot --- .git/rebase-apply/patch:30: trailing whitespace. my ($counteditedbiblio,$countunmodifiedbiblio,$counterrors)=(0,0,0); .git/rebase-apply/patch:35: trailing whitespace. .git/rebase-apply/patch:97: trailing whitespace. # Get All candidate Tags for the change .git/rebase-apply/patch:101: trailing whitespace. # May be used as a template for a bulkedit field .git/rebase-apply/patch:115: trailing whitespace. my $tag=$field->tag(); warning: squelched 1 whitespace error warning: 6 lines add whitespace errors. .git/rebase-apply/patch:30: trailing whitespace. my ($counteditedbiblio,$countunmodifiedbiblio,$counterrors)=(0,0,0); .git/rebase-apply/patch:35: trailing whitespace. .git/rebase-apply/patch:97: trailing whitespace. # Get All candidate Tags for the change .git/rebase-apply/patch:101: trailing whitespace. # May be used as a template for a bulkedit field .git/rebase-apply/patch:115: trailing whitespace. my $tag=$field->tag(); error: patch failed: C4/AuthoritiesMarc.pm:1553 error: C4/AuthoritiesMarc.pm: patch does not apply error: Did you hand edit your patch? It does not apply to blobs recorded in its index. at ./getter.pl line 196. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 19:32:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 18:32:32 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:32:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:32:53 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:32:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:32:56 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48619|0 |1 is obsolete| | --- Comment #26 from Nicole C. Engard --- Created attachment 48806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48806&action=edit Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices This bug is the beginning of a conversion from our current bespoke syntax for slips and notices to Template Toolkit syntax. This patch is the initial seed which will evolve over time. With this addition, we can take advantage of our Koha Objects to greatly simplify the processing of Slips and Notices over time. Test Plan: 1) Apply this patch 2) Ensure you have the default CHECKOUT notice 3) Check out and return an item for a patron 4) Note the text of the CHECKOUT notice 5) Replace your CHECKOUT notice with the following: The following items have been checked out: ---- [% biblio.title %] ---- Thank you for visiting [% branch.branchname %]. 6) Repeat step 3 7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text Signed-off-by: Bernardo Gonzalez Kriegel New notice syntax works, no koha-qa errors Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:33:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:33:03 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48620|0 |1 is obsolete| | --- Comment #27 from Nicole C. Engard --- Created attachment 48807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48807&action=edit Bug 14757 [QA Followup] - Add Unit Tests Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:33:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:33:08 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48621|0 |1 is obsolete| | --- Comment #28 from Nicole C. Engard --- Created attachment 48808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48808&action=edit Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it behind a syspref Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:33:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:33:13 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48622|0 |1 is obsolete| | --- Comment #29 from Nicole C. Engard --- Created attachment 48809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48809&action=edit Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:33:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:33:17 +0000 Subject: [Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48805|0 |1 is obsolete| | --- Comment #30 from Nicole C. Engard --- Created attachment 48810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48810&action=edit Bug 14757 [QA Followup] - Change all references to Koha::Borrower to Koha::Patron Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:35:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:35:14 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:35:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:35:16 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48618|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48811&action=edit Bug 15969 - Allow use of Template Toolkit syntax for Phone Notices By allowing the use of Template Toolkit for generating the outgoing Talking Tech CSV files, we can give libaries more control over the data they send to Itiva. This enhancement would also make it possible to use the script for other services since the output is no longer fixed to a single format. Test Plan: 1) Apply this patch 2) Set up a waiting hold, and overdue checkout, and a non-overdue checkout 3) Generate the CSV file via the script misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl 4) Enable Template Toolkit for the notices and update the notice text to be: [% FILTER remove("\r\n") %] "[% format %]", "[% language %]", "[% type %]", "[% level %]", "[% borrower.cardnumber %]", "[% borrower.title %]", "[% borrower.firstname %]", "[% borrower.surname %]", "[% borrower.phone %]", "[% borrower.email %]", "[% library_code %]", "[% branch.id %]", "[% branch.branchname %]", "[% item.barcode %]", "[% due_date %]", "[% biblio.title %]", "__MESSAGE_ID__" [% END %] 5) Regenerate the notices 6) Compare the originals, note the format is the same Signed-off-by: Sean McGarvey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:46:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:46:20 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48766|0 |1 is obsolete| | --- Comment #16 from H?ctor Eduardo Castro Avalos --- Created attachment 48812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48812&action=edit [SIGNED-OFF]Bug 15870: MARC Filter to exclude fields/subfields lacking visibility TEST PLAN --------- 0) Apply 15777 and 15871 as required. 1) Apply patch 2) prove -v t/db_dependpent/RecordProcessor_ViewPolicy.t -- all should pass. 3) koha qa test tools. BONUS 4) perlcritic -1 t/db_dependpent/RecordProcessor_ViewPolicy.t -- using the koha qa test tools perlcriticrc, it should pass though I am excluding checking print return values. (see bug 15646) Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:46:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:46:29 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48767|0 |1 is obsolete| | --- Comment #17 from H?ctor Eduardo Castro Avalos --- Created attachment 48813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48813&action=edit [SIGNED-OFF]Bug 15870: (QA followup) Add tests This patch introduces functionality tests for the new Koha::Filter. It iterates over all the possible 'hidden' values defined in the docs for hiding/showing fields and subfields, and checks the filter does the job. It tests the functionality for both opac and intranet interfaces and tries to catch all scenarios. It adds control fields to the sample record (they traverse a different branch in the code). TODO: Add another subfield to 245, set it to be hidden, and make sure 245 $a is still shown. The original tests file has been renamed conveniently. To test: - Run $ prove t/db_dependent/Filter_MARC_ViewPolicy.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:46:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:46:38 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48768|0 |1 is obsolete| | --- Comment #18 from H?ctor Eduardo Castro Avalos --- Created attachment 48814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48814&action=edit [SIGNED-OFF]Bug 15870: Follow-up of filter and tests This patch: - improves perlcritic messages in the filter and tests. - changes should display logic to should hide logic to simplify filter. - perltidies the scripts - debugs the issues outstanding on the comprehensive tests provided in the second commit. Signed-off-by: Hector Castro -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:46:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:46:46 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48769|0 |1 is obsolete| | --- Comment #19 from H?ctor Eduardo Castro Avalos --- Created attachment 48815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48815&action=edit [SIGNED-OFF]Bug 15870: potential follow up to comment #8 This patch: - makes the Koha::RecordProcessor code more clear by removing the unnecessary newrecord variable. - revises the filter to be more clear about the expectation that operations are done directly on the record parameter. TEST PLAN --------- prove t/RecordProcessor.t prove t/db_dependent/Filter_MARC_ViewPolicy.t run koha qa test tools Signed-off-by: Hector Castro Works as advertised. NO koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:46:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:46:59 +0000 Subject: [Koha-bugs] [Bug 15870] Add Filter for MARC to respect visibility settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15870 H?ctor Eduardo Castro Avalos changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 20:54:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 19:54:15 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #59 from Katrin Fischer --- Ithink it would be the easiest fix that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:27:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:27:11 +0000 Subject: [Koha-bugs] [Bug 16007] New: Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Bug ID: 16007 Summary: Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: charles.farmer at inlibro.com QA Contact: testopia at bugs.koha-community.org Bug 13624 definitely broke the master by removing the column `overduerules_transport_type`.`letternumber` from kohastructure.sql. This seems to be a mistake, since we only dropped columns `branchcode` and `categorycode` in the atomicupdate file. This new bug is to keep track of everything made to address this issue. I don't know if we'll start with a patch correcting the master, or if we'll rebase to old patch and move from there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:28:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:28:01 +0000 Subject: [Koha-bugs] [Bug 16007] Correction of 'Remove columns branchcode, categorytype from table overduerules_transport_types' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16007 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |charles.farmer at inlibro.com |y.org | Assignee|gmcharlt at gmail.com |charles.farmer at inlibro.com Status|NEW |ASSIGNED Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:33:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:33:51 +0000 Subject: [Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:33:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:33:53 +0000 Subject: [Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48697|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48816&action=edit Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog When deleting a subscription which has not expired or which has linked issues or items, a dialog asks for confirmation. This patch updates the dialog to use Font Awesome icons. Other minor change: Corrected capitalization in dialog heading. To test, apply the patch and go to Serials. - Locate a subscription which can be deleted and which has not expired, has linked items, or has linked issues. - View the detail page for that subscription. - Choose "Delete subscription" from the "Edit" menu. - Verify that the confirmation dialog is correctly styled. - Verify that the "No, don't delete" button works correctly. - Verify that the "Yes, delete" button deletes the subscription. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:35:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:35:41 +0000 Subject: [Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:35:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:35:43 +0000 Subject: [Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48699|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48817&action=edit Bug 15981 - Serials frequencies can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial frequency. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage frequencies - In the list of frequencies, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:37:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:37:32 +0000 Subject: [Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:37:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:37:34 +0000 Subject: [Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48701|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48818&action=edit Bug 15982 - Serials numbering patterns can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial numbering pattern. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage numbering patterns. - In the list of patterns, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:41:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:41:05 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:41:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:41:07 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48715|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 48819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48819&action=edit Bug 15988: Moving authority types actions into a drop-down menu To test: 1) Go to Administration -> Authority types 2) Confirm all actions ('MARC Structure', Edit', 'Delete') have been moved into a drop down menu for each auth type, and each action behaves as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:41:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:41:31 +0000 Subject: [Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 Edie Discher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:42:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:42:15 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:42:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:42:17 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48714|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 48820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48820&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:43:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:43:18 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:43:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:43:20 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48713|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard --- Created attachment 48821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48821&action=edit Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:45:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:45:07 +0000 Subject: [Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:45:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:45:09 +0000 Subject: [Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48716|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 48822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48822&action=edit Bug 15966: Move MARC frameworks actions into a drop down menu To test: 1) Go to Administration -> MARC bibliographic framework (admin/biblio_framework.pl) 2) Confirm that all actions have now been moved into drop down menus. a) For Default framework, actions available are 'MARC structure', 'Export' and 'Import'. b) Confirm these buttons all work as expected. c) For all other frameworks, actions available are 'MARC structure', 'Edit', 'Delete', 'Export' and 'Import'. d) Confirm these buttons all work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:47:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:47:54 +0000 Subject: [Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:47:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:47:56 +0000 Subject: [Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48717|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 48823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48823&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Fr?d?ric Demians Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:49:55 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:49:55 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48718|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 48824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48824&action=edit Bug 15991: Moving OAI sets actions into a drop-down menu To test: 1) Go to Administration -> OAI sets 2) Confirm that the actions 'Modify', 'Delete' and 'Define mappings' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:49:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:49:53 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:51:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:51:48 +0000 Subject: [Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:51:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:51:50 +0000 Subject: [Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48719|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48825&action=edit Bug 15992: Moving item search fields actions into a drop-down menu To test: 1) Go to Administration -> Item search fields 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:53:28 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:53:28 +0000 Subject: [Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:53:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:53:30 +0000 Subject: [Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48720|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48826&action=edit Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:54:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:54:39 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:54:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:54:41 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48721|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard --- Created attachment 48827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48827&action=edit Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:55:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:55:38 +0000 Subject: [Koha-bugs] [Bug 15995] Moving libraries actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 21:55:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 20:55:40 +0000 Subject: [Koha-bugs] [Bug 15995] Moving libraries actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48722|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48828&action=edit Bug 15995: Moving libraries actions into a drop-down menu To test: 1) Go to Administration -> Libraries and Groups 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and buttons behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:01:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:01:11 +0000 Subject: [Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:01:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:01:13 +0000 Subject: [Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48785|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 48829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48829&action=edit Bug 16000 - Duplicate a report from the New Reports button This patch creates a combined edit/duplicate/delete toolbar menu option similar to the one on the bibliographic detail page. Also added is the "Schedule" link which was previously only available from the main list of saved reports. Also added is some deletion confirmation JavaScript for deletions initiated from the toolbar. To test, apply the patch and go to Reports -> Saved reports. - Click "Show" in the menu for any saved report. The toolbar which appears on this page should show the new menu items. - Confirm the behavior of all the buttons. - As you check the behavior of the button actions, check that the toolbar is shown and hidden appropriately for each action. - Confirm that the toolbar is correctly shown or hidden when building a guided report. - Confirm that the "Schedule" button is shown or hidden according to the logged-in user's "schedule_tasks" permission. - Confirm that clicking the "Delete" menu option triggers a JS confirmation. Signed-off-by: Nicole C Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:03:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:03:22 +0000 Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #2 from Nicole C. Engard --- This might be user error, but I applied the patch and see no difference. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:03:45 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:03:45 +0000 Subject: [Koha-bugs] [Bug 16002] ALL/MULTI choices in report dropdowns In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16002 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:31:23 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:31:23 +0000 Subject: [Koha-bugs] [Bug 16008] New: noisy "fatal" warning when new file is moved in another patch Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 Bug ID: 16008 Summary: noisy "fatal" warning when new file is moved in another patch Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: QA tools Assignee: koha-bugs at lists.koha-community.org Reporter: mtompset at hotmail.com While working on Bug 15870, koha qa test tools gave this error fatal: ambiguous argument 't/db_dependent/RecordProcessor_ViewPolicy.t': unknown revision or path not in the working tree. This is in part, because a test file was moved/renamed and the files changed list includes the old filename. Gracefully handle the file no longer existing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:32:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:32:54 +0000 Subject: [Koha-bugs] [Bug 16006] merge_authorities.pl doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16006 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |major --- Comment #1 from Katrin Fischer --- Changing severity as this is an existing, but sadly broken feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:36:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:36:58 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:37:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:37:01 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 --- Comment #1 from M. Tompsett --- Created attachment 48830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48830&action=edit Bug 16008: noisy "fatal" warning when new file is moved in another patch The failure was tracked down to check_forbidden_patterns in QohA/File.pm's check_forbidden_patterns function. As there can't be any forbidden patterns on a non-existent file, this patch returns the default 1 when the file being checked does not exist. TEST PLAN --------- apply bug 15870 to your koha run qa test tools -- see the warning apply this patch to your qa test tools run qa test tools -- no more warning -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:37:21 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:37:21 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtompset at hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:48:09 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:48:09 +0000 Subject: [Koha-bugs] [Bug 16006] merge_authorities.pl doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16006 R?mi Mayrand-Provencher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |francois.charbonnier at inlibr | |o.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:56:08 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:56:08 +0000 Subject: [Koha-bugs] [Bug 15445] DateUtils.t fails on Jenkins due to server sluggishness In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15445 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 22:57:27 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 21:57:27 +0000 Subject: [Koha-bugs] [Bug 15936] Revise layout and behavior of SMS cellular providers management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15936 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 23:05:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 22:05:32 +0000 Subject: [Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 --- Comment #60 from Brendan Gallagher --- Pushed the last two patches (48772 and 48783) Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 23:08:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 22:08:48 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 8 23:08:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 22:08:50 +0000 Subject: [Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47318|0 |1 is obsolete| | Attachment #47319|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 48831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48831&action=edit Bug 12663 - SCOUserCSS and SCOUserJS ignored on selfcheck login page Currently if not logged in when browsing to http://YOURCATALOG/cgi-bin/koha/sco/sco-main.pl You are redirected to opac-auth.tt and SCOUserCSS and SCOUserJS are not loaded. This page passes through a parameter to the template to indicate this is an SCO login and appropriate CSS and JS should be loaded. Additionally this patch ensure that when loggin in using the form you are redirected to the sco-main.pl instead of the patron account page for the user. To test: 1 - Verify that normal login works on both staff and opac 2 - Verify that SCO link goes to login page if AutoSelfCheckAllowed is not allowed 3 - Enter changes into SCOUserJS and SCOUserCSS and observe these are present on SOC log in page 4 - Verify that a logged in opac user without permissions cannot access the self-checkout module 5 - Verify that AutoSelfCheckAllowed and associated system preferences function as expected 6 - Verify the AutoSelfCheck user is logged out if they attempt to visit another page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 00:15:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 23:15:07 +0000 Subject: [Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Christopher Brannon --- While the menu works, it doesn't deliver. Duplicate just puts me in a new report, not a duplicate. The menu could also be visible when editing. I don't think that would pose any issues. Do you? The other menu items appear to work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 00:20:41 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 23:20:41 +0000 Subject: [Koha-bugs] [Bug 16009] New: crash displaying pending offline circulations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Bug ID: 16009 Summary: crash displaying pending offline circulations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Displaying a list of pending offline circulation actions can now fail if the cardnumber is null (as can be the case with a return). The associated crash is: DBD::mysql::st execute failed: called with 1 bind variables when 0 are needed [for Statement "SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE cardnumber IS NULL"] at /usr/share/koha/lib/C4/Members.pm line 451. This appears to be a consequence of bug 15344; it turns out that GetMemberDetails handled cardnumber => NULL better than GetMember does at present. This looks like it affects master, 3.20.8+, and 3.22.2+ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 00:25:22 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 23:25:22 +0000 Subject: [Koha-bugs] [Bug 16009] crash displaying pending offline circulations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 00:25:49 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 08 Mar 2016 23:25:49 +0000 Subject: [Koha-bugs] [Bug 16009] crash displaying pending offline circulations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 01:55:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 00:55:20 +0000 Subject: [Koha-bugs] [Bug 16000] Duplicate a report from the New Reports button In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16000 --- Comment #4 from Owen Leonard --- (In reply to Christopher Brannon from comment #3) > While the menu works, it doesn't deliver. Duplicate just puts me in a new > report, not a duplicate. I do not find this to be the case. Have you tried it with more than one report? > The menu could also be visible when editing. I don't think that would pose > any issues. Do you? This is something which I describe in my latest update to the interface patterns page on the wiki: "In this view the toolbar is not displayed, because the user is expected to either submit a completed form or choose the 'Cancel' link to abort the process of creating a new entry." https://wiki.koha-community.org/wiki/Interface_patterns#The_.27New.27_entry_form However, the option of duplicating something might be relevant during an edit process. I wonder if we should have a "Save as new report" option or something like that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 01:59:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 00:59:19 +0000 Subject: [Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 02:45:47 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 01:45:47 +0000 Subject: [Koha-bugs] [Bug 16009] crash displaying pending offline circulations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 02:45:50 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 01:45:50 +0000 Subject: [Koha-bugs] [Bug 16009] crash displaying pending offline circulations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16009 --- Comment #1 from Galen Charlton --- Created attachment 48832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48832&action=edit Bug 16009: fix GetMember() search on NULL/undef values This patch fixes a bug whereby GetMember(searchfield => undef) (i.e., searching for patron records where 'searchfield' is NULL) would crash. This fixes a regression introduced by bug 15344 that in turn exposed a long-standing bug in GetMember(). To test: [1] Import some offline circulation transactions that include at least one return. [2] Attempt to view the list of pending transactions; a crash will occur. [3] Apply the patch and view the list of pending transactions again; this time, it should work. Signed-off-by: Galen Charlton -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 03:02:46 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 02:02:46 +0000 Subject: [Koha-bugs] [Bug 15642] Batch patron deletion should not delete patrons with issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 03:06:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 02:06:26 +0000 Subject: [Koha-bugs] [Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens --- Is this valid then, or does sortmax/bug 7041 solve this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 03:57:02 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 02:57:02 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 03:57:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 02:57:05 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47478|0 |1 is obsolete| | --- Comment #68 from Nick Clemens --- Created attachment 48833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48833&action=edit Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches but now adds a patron_list_id parameter to C4::Members::GetBorrowersToExpunge and uses that routine to fetch patrons from a list. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table 5) Verify previous functionality has not changed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:17:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:17:20 +0000 Subject: [Koha-bugs] [Bug 16010] New: merge_authorities migration script is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16010 Bug ID: 16010 Summary: merge_authorities migration script is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 15381 Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2 you will get: Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl line 58. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:17:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:17:20 +0000 Subject: [Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type[s] - part 2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16010 [Bug 16010] merge_authorities migration script is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:25:04 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:25:04 +0000 Subject: [Koha-bugs] [Bug 16010] merge_authorities migration script is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:25:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:25:07 +0000 Subject: [Koha-bugs] [Bug 16010] merge_authorities migration script is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16010 --- Comment #1 from Jonathan Druart --- Created attachment 48834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48834&action=edit Bug 16010: follow-up of 15381 - FIX merge_authorities migration script Caused by commit 7e70202d34d75f988fbaea9b911347417c203aac Bug 15381: Remove GetAuthType and GetAuthTypeCode If you execute perl misc/migration_tools/merge_authority.pl -f 1 -t 2 you will get: Can't locate object method "authtypecode" via package "1" (perhaps you forgot to load "1"?) at misc/migration_tools/merge_authority.pl line 58. GetAuthority does not return a Koha::Authority but a MARC::Record: there is no authtype code method! Test plan: perl misc/migration_tools/merge_authority.pl -f X -t Y Should not return any error. Note that if the authid X or Y does not exist, the script will die. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:26:33 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:26:33 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #50 from Jonathan Druart --- (In reply to Blou from comment #49) > So, we need a patch that corrects the pushed-to-master patch, for future > installations. AND that patch must also provide a fix to those who already > installed? Yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:35:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:35:44 +0000 Subject: [Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624 --- Comment #51 from Katrin Fischer --- I think there should be existing examples for fixes like this - a change to the kohastructure accompanied by a database update. It should ideally check if the column is there already, so people don't get an error on updating in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:42:59 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:42:59 +0000 Subject: [Koha-bugs] [Bug 16011] New: Remove $VERSION from our modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Bug ID: 16011 Summary: Remove $VERSION from our modules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org It has been decided to remove the $VERSION from our modules. See the discussion on http://koha.1045719.n5.nabble.com/Proposal-Deal-with-modules-versioning-VERSION-td5876752.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:49:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:49:29 +0000 Subject: [Koha-bugs] [Bug 16011] Remove $VERSION from our modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:49:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:49:32 +0000 Subject: [Koha-bugs] [Bug 16011] Remove $VERSION from our modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #1 from Jonathan Druart --- Created attachment 48835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48835&action=edit Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:50:24 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:50:24 +0000 Subject: [Koha-bugs] [Bug 16011] Remove $VERSION from our modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48835|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 48836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=edit Bug 16011: $VERSION - remove use vars $VERSION perl -p -i -e 's/^(use vars .*)\$VERSION\s?(.*)/$1$2/' **/*.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:50:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:50:30 +0000 Subject: [Koha-bugs] [Bug 16011] Remove $VERSION from our modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #3 from Jonathan Druart --- Created attachment 48837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48837&action=edit Bug 16011: $VERSION - Remove the $VERSION init Mainly a perl -p -i -e 's/^.*3.07.00.049.*\n//' **/*.pm Then some adjustements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:50:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:50:37 +0000 Subject: [Koha-bugs] [Bug 16011] Remove $VERSION from our modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #4 from Jonathan Druart --- Created attachment 48838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=edit Bug 16011: $VERSION - Remove comments perl -p -i -e 's/^.*set the version for version checking.*\n//' **/*.pm + manual adjustements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 09:52:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 08:52:26 +0000 Subject: [Koha-bugs] [Bug 16011] Remove $VERSION from our modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #5 from Jonathan Druart --- Intentionally there is no test plan for this patch set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 10:05:58 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 09:05:58 +0000 Subject: [Koha-bugs] [Bug 16011] Remove $VERSION from our modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 10:23:44 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 09:23:44 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 --- Comment #7 from Jonathan Druart --- Created attachment 48839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48839&action=edit Bug 16003: Add exception pattern list for codespell checks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 10:25:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 09:25:17 +0000 Subject: [Koha-bugs] [Bug 16003] Add spelling exclusion patch to QA Test tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16003 --- Comment #8 from Jonathan Druart --- Mark, Please have a look at this patch. I think it does what you want but in a more flexible way: we won't blacklist an entire file, but just a line. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 10:32:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 09:32:16 +0000 Subject: [Koha-bugs] [Bug 16008] noisy "fatal" warning when new file is moved in another patch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Hi Mark, Actually it's a ... feature :) You are not supposed to add a file and remove it in the same patch set. It should be a new check actually, but at the moment I would prefer to keep the warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 10:33:52 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 09:33:52 +0000 Subject: [Koha-bugs] [Bug 16011] Remove $VERSION from our modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16011 --- Comment #6 from Josef Moravec --- Shouldn't be the whole line removed in these files? https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/BackgroundJob.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/Dewey.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/Generic.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/ClassSortRoutine/LCC.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Matcher.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Members/AttributeTypes.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/Members/Messaging.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/C4/SMS.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Borrower/Files.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Misc/Files.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48836&action=diff#a/Koha/Template/Plugin/Cache.pm_sec1 For you it's just another regexp I believe ;) Here stayd empty BEGIN block, is it necessary to keep it? Just asking ;) https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/BackgroundJob.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Matcher.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Members/AttributeTypes.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/C4/Members/Messaging.pm_sec1 https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48838&action=diff#a/Koha/Borrower/Files.pm_sec1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 10:37:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 09:37:25 +0000 Subject: [Koha-bugs] [Bug 16010] merge_authorities migration script is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16010 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 11:09:25 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 10:09:25 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #126 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #125) > Hi Jacek, > Did you try to profile a "real life" situation? catalogue/search.pl (159 search results, w/ 50 results displayed per page) It calls ->preference() 808 times, fetching 84 different preferences. Total time spent in ->preference() calls (excluding 1st call which triggers DBIx class loading = 250-300ms on this test server) 1) without patch, current master: 98 ms 2) without patch, Bug 13967 reverted: 11 ms 3) with patch & default caching system (Cache::Memory): 98 ms + 70 ms spent in ->get_from_cache() 4) with patch & memcached: 34 ms spent in ->get_from_cache() I have no idea how "typical" is that particular example... I expect that a given script will use somewhere around 50-100 different system preferences, but how many times will ->preference() be called on average is pretty much impossible to estimate (200 ... 1000 ... 2000 ?) Re/ caching system penalty in general - this patch will be probably not the biggest offender though; for example, Bug 11842 had bigger impact on catalogue/search.pl (150-350ms) - deserialising big, complex data structures in perl turns out to be quite expensive (especially if you do it 50 times per script run, like in this case). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 11:18:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 10:18:31 +0000 Subject: [Koha-bugs] [Bug 11998] Syspref caching issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11998 --- Comment #127 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #121) > C4::Context::read_config_file() is apparently called 2+ times per script run > allready: > > - 1st time when we do 'use Koha::Context;' anywhere > - 2nd time when we intialize the database connection in Koha::Database > via schema() / _new_schema() sub and 3rd time in C4/Auth_with_cas.pm (line 40) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 11:28:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 10:28:51 +0000 Subject: [Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Jonathan Druart --- t/db_dependent/Circulation/Renewal.t .. 1/7 DBD::mysql::st execute failed: Unknown column 'me.hold_fulfillment_policy' in 'field list' The Schema is wrong, you are adding default_branch_circ_rules.hold_fulfillment_policy, which is not in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 11:34:13 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 10:34:13 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 11:34:16 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 10:34:16 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48770|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48840&action=edit Bug 15998 - svc/holds: use holdingbranch instead of holding_branch Signed-off-by: Fr?d?ric Demians Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 11:40:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 10:40:36 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|normal |blocker --- Comment #4 from Jonathan Druart --- This is a blocker for 3.20.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:01:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:01:32 +0000 Subject: [Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:01:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:01:34 +0000 Subject: [Koha-bugs] [Bug 15979] Use Font Awesome icons subscription deletion confirmation dialog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48816|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48841&action=edit Bug 15979 - Use Font Awesome icons subscription deletion confirmation dialog When deleting a subscription which has not expired or which has linked issues or items, a dialog asks for confirmation. This patch updates the dialog to use Font Awesome icons. Other minor change: Corrected capitalization in dialog heading. To test, apply the patch and go to Serials. - Locate a subscription which can be deleted and which has not expired, has linked items, or has linked issues. - View the detail page for that subscription. - Choose "Delete subscription" from the "Edit" menu. - Verify that the confirmation dialog is correctly styled. - Verify that the "No, don't delete" button works correctly. - Verify that the "Yes, delete" button deletes the subscription. Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:03:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:03:29 +0000 Subject: [Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48817|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48842&action=edit Bug 15981 - Serials frequencies can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial frequency. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage frequencies - In the list of frequencies, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:03:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:03:26 +0000 Subject: [Koha-bugs] [Bug 15981] Serials frequencies can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:05:54 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:05:54 +0000 Subject: [Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48818|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48843&action=edit Bug 15982 - Serials numbering patterns can be deleted without warning A JavaScript alert should ask the user to confirm deletion of a serial numbering pattern. This patch adds this to the template. To test, apply the patch and go to Serials -> Manage numbering patterns. - In the list of patterns, click any "Delete" link. - Verify that a JavaScript alert is triggered. - Test that cancelling the alert cancels the deletion operation. - Test that confirming the alert allows the deletion to complete. Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:05:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:05:51 +0000 Subject: [Koha-bugs] [Bug 15982] Serials numbering patterns can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15982 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:09:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:09:12 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:09:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:09:29 +0000 Subject: [Koha-bugs] [Bug 15998] software error in svc/holds in 3.20.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15998 --- Comment #5 from Fr?d?ric Demians --- Will be in 3.20.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:10:01 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:10:01 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:10:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:10:03 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48819|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 48844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48844&action=edit Bug 15988: Moving authority types actions into a drop-down menu To test: 1) Go to Administration -> Authority types 2) Confirm all actions ('MARC Structure', Edit', 'Delete') have been moved into a drop down menu for each auth type, and each action behaves as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:11:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:11:07 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- Note: authority_type.authtypecode is escaped every other time, it does not make sense. That was prior to this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:14:48 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:14:48 +0000 Subject: [Koha-bugs] [Bug 15741] Incorrect rounding in total fines calculations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15741 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #2 from Sally Healey --- I was keen to sign this patch off, as this causes terrible problems for us. Test plan: 1) Create manual invoice for 64.60 (or 1.14, 1.36, ...) 2) Try to pay it using "Pay amount" or "Pay selected" buttons Using 'Pay Amount' button: 1) Create manual invoice for a single payment: 64.60 (or 1.14, 1.36, ...) 2) Pay it using 'Pay Amount' button Pass: this works as expected. 1) Create manual invoice for multiple lines which total: 64.60 (or 1.14, 1.36, ...) 2) Pay all lines using 'Pay Amount' button Pass: this works as expected. 1) Create manual invoice for multiple lines. 2) Decide to pay an amount which totals: 64.60 (or 1.14, 1.36, ...) 3) Pay using 'Pay Amount' button Pass: this works as expected. Using 'Pay Selected' button: 1) Create manual invoice for a single payment: 64.60 (or 1.14, 1.36, ...) 2) Pay it using 'Pay Selected' button Fail: 'You must pay a value less than or equal to 64.60 (or 1.14, 1.36, ...)' displays 1) Create manual invoice for multiple lines which total: 64.60 (or 1.14, 1.36, ...) 2) Pay all lines using 'Pay Selected' button Pass: this works as expected 1) Create manual invoice for multiple lines. 2) Choose some lines which total: 64.60 (or 1.14, 1.36, ...) 3) Pay chosen lines using 'Pay Selected' button Pass: the error line does not appear. However, there seems to be a major error with the 'Pay Selected' function, which is reported in the following bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15397 Can we sign off this patch as it mends the functionality of the 'Pay Amount' button and focus on the 'Pay Selected' issue in a different bug - which appears to be a much bigger problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:21:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:21:20 +0000 Subject: [Koha-bugs] [Bug 16012] New: The default authority type is not editable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16012 Bug ID: 16012 Summary: The default authority type is not editable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 15380 Bug 15380 introduced a regression on the authority types admin page: the default authority type (authtypecode="") is no longer editable. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:21:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:21:20 +0000 Subject: [Koha-bugs] [Bug 15380] Move the authority types related code to Koha::Authority::Type[s] - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15380 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16012 [Bug 16012] The default authority type is not editable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:22:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:22:51 +0000 Subject: [Koha-bugs] [Bug 16012] The default authority type is not editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16012 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:22:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:22:53 +0000 Subject: [Koha-bugs] [Bug 16012] The default authority type is not editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16012 --- Comment #1 from Jonathan Druart --- Created attachment 48845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48845&action=edit Bug 16012: Restore the ability to edit default authority type Bug 15380 introduced a regression on the authority types admin page: the default authority type (authtypecode="") is no longer editable. Test plan: Edit the authority type to update the summary => Without this patch you will get the "add a new authority type" form => With this patch applied, the correct behavior will be restored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:23:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:23:32 +0000 Subject: [Koha-bugs] [Bug 15988] Moving authority types actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15988 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16012 --- Comment #6 from Jonathan Druart --- I have found bug 16012 on QAing on this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:23:32 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:23:32 +0000 Subject: [Koha-bugs] [Bug 16012] The default authority type is not editable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16012 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15988 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:26:40 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:26:40 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:26:43 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:26:43 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48820|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 48846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48846&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:28:51 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:28:51 +0000 Subject: [Koha-bugs] [Bug 16013] New: Classification sources are not deletable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16013 Bug ID: 16013 Summary: Classification sources are not deletable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:29:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:29:15 +0000 Subject: [Koha-bugs] [Bug 15989] Moving classification sources actions into drop-down menus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16013 --- Comment #5 from Jonathan Druart --- I have found bug 16013 on QAing this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:29:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:29:15 +0000 Subject: [Koha-bugs] [Bug 16013] Classification sources are not deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15989 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:30:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:30:39 +0000 Subject: [Koha-bugs] [Bug 16013] Classification sources are not deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16013 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:30:42 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:30:42 +0000 Subject: [Koha-bugs] [Bug 16013] Classification sources are not deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16013 --- Comment #1 from Jonathan Druart --- Created attachment 48847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48847&action=edit Bug 16013: Make classification sources deletable Because of a wrong variable scope, the classification sources are not deletable. Test plan: Create a classification sources (admin/classsources.pl) Try to delete it Without this patch, the classification source won't be deleted With this patch, it will work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:35:26 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:35:26 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:35:29 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:35:29 +0000 Subject: [Koha-bugs] [Bug 15990] Moving record matching rules actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15990 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48821|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 48848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48848&action=edit Bug 15990: Moving record matching rules actions into a drop-down menu To test: 1) Go to Administration -> Record matching rules 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:45:11 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:45:11 +0000 Subject: [Koha-bugs] [Bug 15966] Move MARC frameworks actions into a drop down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15966 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- I am wondering if the import and export icon buttons are not inverted, please confirm it's what you want. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:50:05 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:50:05 +0000 Subject: [Koha-bugs] [Bug 15932] Moving Authorities actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- QA comment: There is a wrong behavior: Click on Actions > Delete > Cancel => The scrollbar goes to the top -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:51:56 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:51:56 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Could you add a confirmation message when deleting a set please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:57:14 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:57:14 +0000 Subject: [Koha-bugs] [Bug 16014] New: OAI sets can be deleted without warning Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16014 Bug ID: 16014 Summary: OAI sets can be deleted without warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:57:30 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:57:30 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #5 from Jonathan Druart --- (In reply to Jonathan Druart from comment #4) > Could you add a confirmation message when deleting a set please? Ok forget that, I have opened bug 16014. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:57:37 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16014 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:57:37 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:57:37 +0000 Subject: [Koha-bugs] [Bug 16014] OAI sets can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15991 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:59:15 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:59:15 +0000 Subject: [Koha-bugs] [Bug 16014] OAI sets can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 12:59:18 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 11:59:18 +0000 Subject: [Koha-bugs] [Bug 16014] OAI sets can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16014 --- Comment #1 from Jonathan Druart --- Created attachment 48849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48849&action=edit Bug 16014: Display a warning on deleting OAI sets A JavaScript alert should ask the user to confirm deletion of a OAI set. Test plan: Define a OAI set Delete it => With this patch you should get a warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:00:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:00:39 +0000 Subject: [Koha-bugs] [Bug 16014] OAI sets can be deleted without warning In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16014 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15991 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15991 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 [Bug 15991] Moving OAI sets actions into a drop-down menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:00:39 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:00:39 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16014 | Depends on| |16014 --- Comment #6 from Jonathan Druart --- Aleisha, could you please rebase this patch on top of bug 16014 (to make it backportable)? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16014 [Bug 16014] OAI sets can be deleted without warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:01:00 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:01:00 +0000 Subject: [Koha-bugs] [Bug 15991] Moving OAI sets actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15991 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:06:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:06:53 +0000 Subject: [Koha-bugs] [Bug 15887] Revise layout and behavior of item search fields management In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15887 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15992 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:06:53 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:06:53 +0000 Subject: [Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15887 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart --- You are loosing the confirmation and highlight made on bug 15887. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:07:03 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:07:03 +0000 Subject: [Koha-bugs] [Bug 15992] Moving item search fields actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:09:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:09:36 +0000 Subject: [Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:11:31 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:11:31 +0000 Subject: [Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:11:34 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:11:34 +0000 Subject: [Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48826|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 48850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48850&action=edit Bug 15993: Moving currency actions into a drop-down menu To test: 1) Go to Administration -> Currencies and exchange rates 2) Confirm that the actions 'Edit' and 'Delete' have been moved into a drop-down menu and buttons behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:12:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:12:12 +0000 Subject: [Koha-bugs] [Bug 15993] Moving currency actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15962 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Note that the deletion does not work, I have fixed that yesterday on bug 15962. The 2 patches do not conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:12:12 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:12:12 +0000 Subject: [Koha-bugs] [Bug 15962] Currency deletion doesn't correctly identify currencies in use In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15962 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15993 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:16:07 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:16:07 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart --- % git grep Delete | grep fa-trash|wc 11 156 3712 % git grep Delete | grep fa-remove|wc 16 220 4297 I also prefer the trash icon for the deletion. I have just QAed several patches using the trash icons, so let's move fa-remove to fa-trash in another bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:17:17 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:17:17 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:17:20 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:17:20 +0000 Subject: [Koha-bugs] [Bug 15994] Adding font awesome icons to Funds actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48827|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 48851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48851&action=edit Bug 15994: Adding font awesome icons to Funds actions To test: 1) Go to Administration -> Funds 2) Confirm that appropriate Font Awesome icons now appear to each action in drop down menu Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:22:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:22:19 +0000 Subject: [Koha-bugs] [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16015 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 [Bug 16015] Cannot delete a group of libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:22:19 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:22:19 +0000 Subject: [Koha-bugs] [Bug 16015] New: Cannot delete a group of libraries Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 Bug ID: 16015 Summary: Cannot delete a group of libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 15294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15294 [Bug 15294] Move the C4::Branch related code to Koha::Libraries - part 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:24:36 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:24:36 +0000 Subject: [Koha-bugs] [Bug 16015] Cannot delete a group of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:24:38 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:24:38 +0000 Subject: [Koha-bugs] [Bug 16015] Cannot delete a group of libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16015 --- Comment #1 from Jonathan Druart --- Created attachment 48852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48852&action=edit Bug 16015: Restore the ability to delete a group of libraries If a group of libraries is linked to at least 1 library, the group cannot be delete and the librarian should get a warning message. But if no libraries are linked, the deletion should be allowed. Since bug 15294 this behavior is broken: The deletion is always blocked: "This library category cannot be deleted. 0 libraries are still using it", hum... Test plan: Create a group of libraries, delete it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 9 13:25:57 2016 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 09 Mar 2016 12:25:57 +0000 Subject: [Koha-bugs] [Bug 15995] Moving libraries actions into a drop-down menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15995 --- Comment #3 from Jonathan Druart --- Comment on attachment 48828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48828 Bug 15995: Moving libraries actions into a drop-down menu Review of attachment 48828: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15995&attachment=48828) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ +306,5 @@ > [% category.categorycode %] > [% category.codedescription %] > > +