[Koha-bugs] [Bug 15878] C4::Barcodes::hbyymmincr inccorectly calculates max and should warn when no branchcode present
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sat May 21 14:19:57 CEST 2016
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15878
--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Comment on attachment 51624
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51624
[SIGNED-OFF] Bug 15878 - Updated unit tests for hbyymmincr barcodes
Review of attachment 51624:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15878&attachment=51624)
-----------------------------------------------------------------
::: t/db_dependent/Barcodes.t
@@ +84,4 @@
> };
>
>
> +$schema->storage->txn_begin;
There is an issue (existed before this patch), the transaction should begin in
the subtests.
@@ +96,5 @@
> + source => 'Branch',
> + branchcode => 'LETTERS',
> + });
> +
> + my $branchcode_1 = "LETT";
LETT vs LETTERS?
$barcode_branch is never used later.
@@ +97,5 @@
> + branchcode => 'LETTERS',
> + });
> +
> + my $branchcode_1 = "LETT";
> + print "$branchcode_1\n";
Unused debug statement.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list