[Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553

--- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just from a glance, I can understand the ugly-qualification.

Do we really need these hashes where we dump all data from various tables? The
original select was quite a lazy one.
Why should an overdue object contain a title, if it contains an item or
biblionumber? I guess most columns will not be used at all.

When refactoring only this one GetOverduesForPatron routine, you want to just
produce the same result. But the problem might be at the places where we call
it.

Pragmatically, we can probably not go further without this. The name
unblessed_all_relateds could still improve? We are already using unblessed;
should unbless have been better? And now unbless_related ?
Are the assumptions on relation[0] and rs->[0] really future proof?

-- 
You are receiving this mail because:
You are watching all bug changes.