[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Andreas Hedström Mace from comment #18)
> Without having actually tested this bug, only reading the discussion, I
> would say that I have to agree with Sonia. 
> 
> As this new date is set after the material is checked in, it doesn't appear
> (at least to me) that the expire date set by the patron would be valuable
> anymore. And the added value of excluding dates that the library is closed
> from the number of day in ReservesMaxPickUpDelay, seem greater than any
> negative impact.

Hi Andreas,
Thx for your feedback.
I read it again too now. This patch tries to achieve its goal by modifying the
expirationdate, while it actually should change this select in
CancelExpiredReserves?

my $query = "SELECT * FROM reserves WHERE TO_DAYS( NOW() ) - TO_DAYS(
waitingdate ) > ? AND found = 'W' AND priority = 0";

If the holiday stuff is taken into account here, I am having the impression
that we achieve the same. Mabye Sonia or Alex can respond to that?

-- 
You are receiving this mail because:
You are watching all bug changes.