[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Nov 17 11:23:53 CET 2016


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438

--- Comment #15 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Colin Campbell from comment #12)
> > The logic in C4::Circulation is that causes are returned in Uppercase and
> > data associated with causes are in lower case (In some cases the data is
> > still appearing as hash elemrnts of the uppercase entry but in these cases
> > the case distinction holds) Its a godawful design - but by wrapping the call
> > in a rtn that drops any lowercase "pseudo" causes we can fix the bug in hand.
> 
> This is really awkward indeed :)
> I'd prefer to list all the available error codes and add a big warning to
> CanBookBeIssued to inform the devs that this white-list need to be updated
> as well.

Yes I think that the returns need a rethink, a bit of design and proper
documentation. We should probably do that as a separate bug as the implications
could be quite large. I did not try to address that in this patch but to
address how Sip was handly the current api to fix the problems it was causing
users

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list