[Koha-bugs] [Bug 18300] Delete missing upload records
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Thu Apr 20 20:29:32 CEST 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18300
--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 62497
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62497&action=edit
Bug 18300: [QA Follow-up] Fix return value inconsistency
As noted on bug report 17669, the return values of delete (both singular
and plural), delete_missing and delete_temporary should be consistent.
Removed the if-construction around full_path. We do not need it; in the
very exceptional case that full_path would be empty, we should delete
the record since the file is missing.
Adjusted POD and unit tests accordingly.
Test plan:
Run t/db_dependent/Upload.t
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list