[Koha-bugs] [Bug 18339] Koha::Patron::Attribute ->opac_editable and -> opac_display should be removed

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Apr 25 14:29:43 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18339

--- Comment #18 from Owen Leonard <oleonard at myacpl.org> ---
Created attachment 62663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62663&action=edit
[SIGNED-OFF] Bug 18339: (followup) Remove warnings on adding a patron
modification

This patch removes warnings raised because hash values existence is not
checked before comparing them.

As the sub is deleting fields that are similar from the modification, I
considered
the following use cases
- Both fields are defined, need to compare values, should delete if they match
- One of the fields is defined, the other isn't, discrepancy, should not
delete.
- Both fields are not defined, they match, should delete.

Signed-off-by: Marc Véron <veron at veron.ch>

Signed-off-by: Owen Leonard <oleonard at myacpl.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list