[Koha-bugs] [Bug 15492] Stand alone self check-in tool

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15492

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Jonathan Druart from comment #14)
> All works great, few concerns:
> 1. Code in C4::Auth must be simplify and merged with existing one (you c/p
> 25  lines)

Done.

> 2. Only the AutoSelfCheckID should be able to connect to sci-main.pl, we
> should apply the same behaviour as self-checkout (no?)

The behaviour for SCI is different. Users with SCI permission can only access
SCI in the OPAC. This should be carefully documented in the manual (it is
explicitly mentioned in the permissions page).

> 3. Description (and name) of the permission self_checkout must be adapted

Done. I've moved self check-related sysprefs like this:

- selc_check
  * self_checkin_module
  * self_checkout_module

Existing code has been adjusted. This needs to be tested just in case, that's
why I moved it back to NSO (it is a trivial change, though).

> 4. I do not know how SCOMainUserBlock is used, but it may be wrong to
> display it for SCI (?)

I did what I planned for a followup bug: making SCI have its own set of
sysprefs. I was going to do it anyway, but cleaner on the same patchset. Good
catch.

> 5. "Data corruption detected" => Are we sure we want to display that at the
> OPAC?
> 6. If error code is not known, we should display it instead of ignore it
> (BLOCK error_message)

Both addessed with Nick's idiomatic aid.

-- 
You are receiving this mail because:
You are watching all bug changes.