[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

--- Comment #9 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 56662
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56662
Bug 17467: Add koha-zebra script to handle Zebra daemons

Review of attachment 56662:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17467&attachment=56662)
-----------------------------------------------------------------

::: debian/scripts/koha-zebra
@@ +135,5 @@
> +
> +    if is_zebra_running ${name}; then
> +
> +        stop_zebra ${name} && \
> +        start_zebra ${name}

This logic is failing. The stop always runs, but the start never does.
Remember 0 success, but 0 && foo is short-circuited logic.

Also, missing verbose check to print a nice informational message about
Restarting Zebra.

@@ +148,5 @@
> +zebra_status()
> +{
> +    local name=$1
> +
> +    if is_zebra_running; then

missing $name.

-- 
You are receiving this mail because:
You are watching all bug changes.