[Koha-bugs] [Bug 17691] Add serial subscriptions info on vendor profile page

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I really like the idea!

Looking at this from the view of translators, I'd like to make a suggestion:

+                    <h2>Subscription Details</h2>
+                    <p><strong>This vender has: </strong>[% subscriptioncount
%]
+                    [% IF subscriptioncount == 1 %] subscription [% ELSE %]
subscriptions [% END %]
+                    </p>
+

The h2 is cool, but capitalization should be: Subscription details

The paragraph will be turned into 2 strings by the translation tools:
- This vendor has
- subscription subscriptions (with some additional markup %s in between)
Strings show up out of context for translators and in alphabetical order - so
that makes it really hard to 'get it right' - depending on the language it's
also often hard to predict, what the right sequence of words/grammar should be
like.

My suggestion would be to make it:
Number of subscriptions: [% subscriptioncount %]

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.