[Koha-bugs] [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Jan 18 23:20:18 CET 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855
--- Comment #102 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 59174
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59174
Bug 17855 -Removed HTML regexes from all fields on all screens of onboarding
tool except branchcode, patron category code and item type code. Also ensured
these three remaining regexes are all {1,10} for length as they are all
required.
Review of attachment 59174:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17855&attachment=59174)
-----------------------------------------------------------------
Thanks for removing the pattern= and tweaking some regexp's to be 1,10.
In some cases you removed the title= piece, which means no tooltip. Tooltips
are great to have. I would have left them, just without the length
specification stuff.
::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep1.tt
@@ +65,4 @@
> <ol>
> <li>
> <label for="branchcode" class="required">Library code: </label>
> + <input type="text" pattern="[0-9A-Za-z]{1,10}" title="Please enter up to 10 letters and/or numbers" name="branchcode" id="branchcode" size="10" maxlength="10" value="[% library.branchcode %]" class="required" required="required" />
Never hurts to have a |html, just to make sure no injections could accidentally
happen.
::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt
@@ +128,4 @@
> <h3>Patron identity</h3>
> <li>
> <label for="surname" class="required">Surname: </label>
> + <input type="text" id="surname" name="surname" value="[% surname %]" class="required" required="required" />
Probably should have |html in the surname too.
@@ -156,5 @@
> <span class="required">Required</span>
> </li>
> <li>
> <label for="firstname" class="required">First name: </label>
> - <input type="text" pattern="[a-zA-Z ]+" title="Please only enter letters in the firstname field" name="firstname" id="firstname" size="20" value="[% firstname |html %]" class="required" required="required">
|html was okay.
@@ -214,5 @@
> <span class="required">Required</span>
> </li>
> <li>
> <label for="passwordlabel" class="required">Password: </label>
> - <input type="password" name="password" id="password" size="20" value="[% member.password |html %]" class="required" required="required">
This was probably okay to leave with the |html.
::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep4.tt
@@ -55,5 @@
> </li>
>
> <li>
> <label for="description" class="required">Description: </label>
> - <input type="text" name="description" pattern="[A-Za-z1-9 ]+" title="Please only enter letters or numbers into this item type description" id="description" size="42" value="[% itemtype.description |html %]" class="required" required="required">
Probably okay to leave the |html.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list