[Koha-bugs] [Bug 16881] Apply KohaTable and ColVis plugin on MARCdetail's items table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16881

--- Comment #12 from Alex Arnaud <alex.arnaud at biblibre.com> ---
(In reply to Nick Clemens from comment #8)
> I really like this feature and agree with Cait, the ability for users to
> save their settings will make workflows easier for librarians
> 
> I agree with Jonathan too, this feature should be made usable for other
> pages too, even if it is only introduced here first. 
> 
> 1 - C4/Utils/DataTables/DynamicColumnsSettings.pm - sub
> catalogue_marcdetail_itemst 
> This should be more generic, the work should be done in a function that can
> be passed data from any page
I don't know how to make it more generic. It return all item fields depending
on a framwork code...
> 
> 2 - The script should be moved ot a javascript files for inclusion when
> necessary, and can then be triggered by code on each page.
> 
> 3 -The current code calls the service function each time the table is
> rendered, so a sort will also make a call, this should only happen when
> column view changes
What do you mean by service function ? If you speak about the
saveStateCallback, it is called only when a "column button" is clicked. 
> 
> 4 - Ideally when a user restores all columns we shouldn't need to save their
> data, maybe we only store columns that are exceptions?
There is no option for restoring all columns for now.
> 
> 5 - This should use the REST api and not an svc script
> 
> 6 -  $schema->resultset('UsersColumnsSetting')->update_or_create 
> This should use Koha::Object

-- 
You are receiving this mail because:
You are watching all bug changes.