[Koha-bugs] [Bug 18760] printable checkin alerts

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 64256
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64256
Bug 18760 - Add item printable checkin alert field

Review of attachment 64256:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18760&attachment=64256)
-----------------------------------------------------------------

Hi,

I took a look at these patches, I agree a per item check-in note could be quite
useful. But I have found some issues with the patch and have some concerns:

For the existing patch, see the splinter review notes and below:
- Changes to kohastructure.sql are missing.
- SQL should use AFTER/BEFORE to make sure the column is always added in the
same spot.

General concern:
In MARC21 there is only one unmapped subfield left: $k To prevent people from
unmapping important things and make this feature discoverable, we should at
least provide a default mapping for new installations and a note for existing
ones if $k (or UNIMARC equivalent) is already mapped.

But that makes me think: I wonder if this should really be part of the MARC
record or if it wouldn't be better to have these kinds of notes in a separate
table, manageable outside of the item editor. Example: What if we'd like to
have another note for check-out? 

- We are running out of unused subfields.
- There is a possible privavy issue, because as soon as you add a
Koha-to-MARC-mapping, the note field will be searchable in the OPAC (existing
problem with itemnotes_nonpublic). 
- Also, it will get exported with the MARC exports and be visible on the MARC
view if not set up correctly (given that the visibility settings now work
correctly)

Maybe something to be discussed some more.

::: circ/print-alert.pl
@@ +1,4 @@
> +#!/usr/bin/perl
> +
> +
> +# Copyright 2008 LibLime

Copy and paste error?

@@ +18,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +
> +use strict;
> +#use warnings; FIXME - Bug 2505

Should be Modern::Perl instead.

-- 
You are receiving this mail because:
You are watching all bug changes.