[Koha-bugs] [Bug 17975] TT syntax for notices - Prove that HOLD_SLIP is compatible

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17975

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63973|0                           |1
        is obsolete|                            |
  Attachment #63974|0                           |1
        is obsolete|                            |
             Status|Signed Off                  |Passed QA
                 CC|                            |kyle at bywatersolutions.com

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64334&action=edit
Bug 17975: TT syntax for notices - Prove that HOLD_SLIP is compatible

Here we need to test <<today>>.
We already pass a value, but it was wrong. We must pass a string, not a
DateTime object, otherwise the KohaDates plugin will not display the
hours part if we need it.

Test plan:
Define a HOLD_SLIP notice template to match your need.
Do not forget to use
  [% today | $KohaDates %]
or
  [% today | $KohaDates with_hours => 1 %]
To access data from the reserves table, use the 'hold' variable

Tested both patches together with several date formats, works as expected.
Signed-off-by: Marc Véron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 64335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64335&action=edit
Bug 17975: Let C4::Letters manage today param substitution

The today parameter is properly handled from C4::Letters subroutines, we
do not need to pass it from callers.

Signed-off-by: Marc Véron <veron at veron.ch>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

--- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.