[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

--- Comment #53 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Please look at this code in C4/Letters.pm: 
    if ( $table eq 'reserves' && $values->{'waitingdate'} ) {
        my @waitingdate = split /-/, $values->{'waitingdate'};

        $values->{'expirationdate'} = '';
        if ( C4::Context->preference('ReservesMaxPickUpDelay') ) {
            my $dt = dt_from_string();
            $dt->add( days => C4::Context->preference('ReservesMaxPickUpDelay')
);
            $values->{'expirationdate'} = output_pref( { dt => $dt, dateonly =>
1 } );
        }
This code should be adjusted too in line with the changes in
$hold->set_waiting. Actually, if there is a waiting date, we must assume now
that it is no longer needed to calculate an expiration date. In the above code
the holiday was not respected either.

-- 
You are receiving this mail because:
You are watching all bug changes.