[Koha-bugs] [Bug 14399] "missingitem" code from inventory.pl doesn't work properly

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14399

--- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to David Cook from comment #0)
> However, the second one is strange. It's not even in relation to the actual
> task of taking inventory. This state also isn't determined "after" running
> the inventory, which might almost make sense. No, it's right after creating
> an inventory list. On top of this weirdness, the code also has an
> unintentional bug. 

The bug with $_ is no longer in the code. But this code is still weird.
Actually, the "not scanned" items are the missing items! If these items also
have a lower datelastseen, they are also marked as 'missing'. But note that if
you scanned an item, datelastseen has been updated. This is useless.

I tried to imagine why this was introduced; perhaps it was meant as a compare
with the last inventory date. But since all scanned items are already updated,
this compare does not work.

I will remove this section on bug 12913.

> Firstly, contrary to the comment, "dls" is actually the inventory's
> "datelastseen", while "cdls" is the "datelastseen" of the item. Annoying?
> Yes, but not super important.

Yes, this comment was confusing and will be removed.

-- 
You are receiving this mail because:
You are watching all bug changes.