[Koha-bugs] [Bug 18897] Koha_Elasticsearch_Indexer.t doesn' t skip when ES module not installed

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Oct 2 16:56:22 CEST 2017


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18897

Tomás Cohen Arazi <tomascohen at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #66779|0                           |1
        is obsolete|                            |

--- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
Created attachment 67523
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67523&action=edit
Bug 18897: Use Module::Load::Conditional::can_load

Rather than rely on eval(), Jonathan Druart recommended in
comment #6 to use Use Module::Load::Conditional::can_load.
This addresses that concern.

TEST PLAN
---------
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
$ sudo apt-get install libcatmandu-store-elasticsearch-perl
-- Note it runs as expected.
run the koha qa test tools

Signed-off-by: Lee Jamison <ldjamison at marywood.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list