[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #167 from Magnus Enger <magnus at libriotech.no> ---
As far as I can see, these are the remaining problems pointed to by the qa
script, that can actually be fixed:

 FAIL   Koha/Exceptions/Ill.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   OK     spelling
   OK     valid

I think Tomas introduced this in a followup. He can probably add a little bit
of POD to it. 

 FAIL   Koha/Illrequestattributes.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'object_class'
   OK     spelling
   OK     valid

 FAIL   Koha/Illrequests.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'object_class'
   OK     spelling
   OK     valid

These two files do have some subs that are missing POD. I can look at that
again tomorrow. 

 FAIL   installer/data/mysql/atomicupdate/ill_tables.sql
   FAIL   git manipulation
                The file has been added and deleted in the same patchset

Not sure how we can fix this without redoing completely the patches from Alex? 

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt
   OK     forbidden patterns
   OK     git manipulation
   OK     spelling
   FAIL   tt_valid
                lines 665
   FAIL   valid_template
                : not found

The codes mixes TT directives and HTML rather intimately: 

665                   <table
666                       [% FOREACH filter IN prefilters %]
667                       data-filter-[% filter.name %]="[% filter.value %]"
668                       [% END %]
669                       id="ill-requests">

Not sure how we can do it differently, though?

-- 
You are receiving this mail because:
You are watching all bug changes.