[Koha-bugs] [Bug 12691] Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12691

--- Comment #25 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Jonathan Druart from comment #24)
> What are we doing here?
> 
> If it is just replacing syspref fetch with Koha.Preference, the following is
> wrong:
> 
> -                [% IF ( display_patron_image ) %]
> +                [% IF (
> Koha.Preference('ShowPatronImageInWebBasedSelfCheck') ) %]
> 
> display_patron_image is set when $borrower is set AND the pref is set.
> We had too many regressions in this area, I will not take any risks.
> 
> If we are doing something else, it is not written in the commit messages.
> 
> Please clarify.

Oh I see what you mean, I think I've made the logic a little too confusing.
I'll take out the [% IF ( Koha.Preference('ShowPatronImageInWebBasedSelfCheck')
) %] line in the template and leave the logic for that as it was.

-- 
You are receiving this mail because:
You are watching all bug changes.