[Koha-bugs] [Bug 19190] Silly calculation of average time in touch_all scripts
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Sep 22 21:10:59 CEST 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190
David Bourgault <david.bourgault at inlibro.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66551|0 |1
is obsolete| |
--- Comment #3 from David Bourgault <david.bourgault at inlibro.com> ---
Created attachment 67332
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67332&action=edit
Bug 19190: [Follow-up] Do not rely on the return of ModItem
touch_all_items looks at the return of ModItem to determine if the
operation was successful. But ModItem does not return a meaningful
value. This patch puts the ModItem call in an eval and looks at $@.
Test plan:
Run touch_all_items with a where condition and verbose option.
Put print 1/0; at the end of ModItem.
Run touch_all_items again. You should see: ERROR WITH ITEM xxx !!!!
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Signed-off-by: David Bourgault <david.bourgault at inlibro.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list