[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Sep 27 15:39:06 CEST 2017
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260
Magnus Enger <magnus at libriotech.no> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |magnus at libriotech.no
--- Comment #1 from Magnus Enger <magnus at libriotech.no> ---
As far as I can tell, this is a regression introduced by bug 12063.
Attachment 63091 on that bug moves the code that takes care of
ExpireReservesMaxPickupDelay from C4/Reserves.pm (sub CancelExpiredReserves):
- if ( C4::Context->preference("ExpireReservesMaxPickUpDelay") ) {
- my $max_pickup_delay =
C4::Context->preference("ReservesMaxPickUpDelay");
- my $cancel_on_holidays =
C4::Context->preference('ExpireReservesOnHolidays');
to Koha/Hold.pm (sub set_waiting):
+ if ( C4::Context->preference("ExpireReservesMaxPickUpDelay") ) {
+ my $max_pickup_delay =
C4::Context->preference("ReservesMaxPickUpDelay");
+ my $cancel_on_holidays =
C4::Context->preference('ExpireReservesOnHolidays');
+ my $calendar = Koha::Calendar->new( branchcode => $self->branchcode );
Then attachment 63095 removes the check on ExpireReservesMaxPickUpDelay:
- if ( C4::Context->preference("ExpireReservesMaxPickUpDelay") ) {
- my $max_pickup_delay =
C4::Context->preference("ReservesMaxPickUpDelay");
- my $cancel_on_holidays =
C4::Context->preference('ExpireReservesOnHolidays');
- my $calendar = Koha::Calendar->new( branchcode => $self->branchcode );
...
+ my $max_pickup_delay = C4::Context->preference("ReservesMaxPickUpDelay");
+ my $cancel_on_holidays =
C4::Context->preference('ExpireReservesOnHolidays');
+ my $calendar = Koha::Calendar->new( branchcode => $self->branchcode );
But it is not clear from the commit message that this is intentional...
Perhaps the fix is as easy as putting the if on ExpireReservesMaxPickUpDelay
back in? I will investigate this further, if noone beats me to it.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
More information about the Koha-bugs
mailing list