From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 00:07:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Mar 2018 22:07:39 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Tomas, could you sign-off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 00:42:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Mar 2018 22:42:47 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72676|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 73515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73515&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items ? receive? ? tick this checkbox 8. save 9. click on "finish receiving" 10. go to the record ? Acquisition details 11. apply this patch 12. refresh the page 13. you should see the new column Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 00:45:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Mar 2018 22:45:57 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from Victor Grousset/tuxayo --- "any permission in the acquisitions module" So I used CAN_user_acquisition Here is my amend: diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index f130644..9b1eb1a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -704,9 +704,13 @@ [% IF (order.invoiceid) %] - - [% order.invoicenumber %] + [% IF CAN_user_acquisition %] + + [% order.invoicenumber %] + [% ELSE %] + [% order.invoicenumber %] + [% END %] ########################################################## note: I haven't invalidated the sign off. (maybe I should?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 01:24:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Mar 2018 23:24:32 +0000 Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file with default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- We tested this at the hackfest and selecting the fund on the default accounting details should work - otherwise it would have no function. Sonia also said that they used the feature a lot and it used to work like that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 01:25:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Mar 2018 23:25:40 +0000 Subject: [Koha-bugs] [Bug 20423] ReservesNeedReturns allows multiple patrons to have the same item set to 'waiting' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20423 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 01:34:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Mar 2018 23:34:19 +0000 Subject: [Koha-bugs] [Bug 19527] Alter Zebra indexing to sort by descending document ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19527 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 01:35:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 31 Mar 2018 23:35:51 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Accounts::purge_zero_ba |C4::Accounts::purge_zero_ba |lance_fees does not check |lance_fees does not check |account_offsets. |account_offsets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 12:36:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 10:36:56 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 --- Comment #4 from Katrin Fischer --- Hi Kyle, this checks out well for me and I am signing off to move this along. Just one question: Would it be safe to remove this warning now from the docs of cleanup_database? WARNING: Fees and payments may not be deleted together. This will not affect the account balance but may be confusing to staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 12:37:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 10:37:45 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 12:37:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 10:37:49 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73350|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 73516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73516&action=edit Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets purge_zero_balance_fees is used in cleanup_database.pl to determine which fees can be cleaned up. It uses a simple SQL query to determine which rows in accountlines need to be removed: 463 my $sth = $dbh->prepare( 464 q{ 465 DELETE FROM accountlines 466 WHERE date < date_sub(curdate(), INTERVAL ? DAY) 467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL ); 468 } The function comes with the following warning: 451 B Because fines and payments are not linked in accountlines, it is 452 possible for a fine to be deleted without the accompanying payment, 453 or vise versa. This won't affect the account balance, but might be 454 confusing to staff. This was a reasonable solution prior to the addition of account_offsets in 17.11. The problem now is that rows in accountlines which are linked as credits in accountlines will *always* have amountoutstanding marked as 0. These are linked to debits via account_offsets. purge_zero_balance_fees will delete credits and leave rows in account_offsets which link to deleted credits. Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may have all of their credits removed without warning. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 12:47:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 10:47:59 +0000 Subject: [Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes marked as problematic with no_barcode? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- In German it's slightly different: Konvolut. I think having a proper solution in Koha for these kinds of items would be nice. EasyAnalytics is one way, but because of the way it uses fields in the record it's not usable in our union catalog setting. We have implemented something for the OPAC using the notes fields to create linkings, here is an example: https://bbf.bsz-bw.de/cgi-bin/koha/opac-detail.pl?biblionumber=22022 Note says: bound with... clicking on the search link brings up the other items, it's bound with and that have no barcode (in this case 1, but can be many). >From the items without barcode a link leads back to the barcode item. Links are created by putting ## callnumber or %% callnumber into the item notes, with the option to have specific notes before the separator. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:05:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 11:05:40 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #9 from Katrin Fischer --- (In reply to Fridolin SOMERS from comment #8) > (In reply to Katrin Fischer from comment #7) > > >8) Without patch you see "For loan" in items.notforloan for value 0 > > >9) With patch you see "Available" in items.notforloan for value 0 > > > > Still 'For loan' for me. Please fix test plan or patch! > > If you have memcached and/or plack, you need to restart them when you change > authorized values. Hi Frido, that should not be necessary in current versions, but I am retesting anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:28:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 11:28:48 +0000 Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows "For loan" for value 0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131 --- Comment #10 from Katrin Fischer --- Hm, ok, I might not understand the reasoning behind this patch or even the bug it tries to fix :( >From my testing: 6) Create in authorized values category "NFL" a value 0 with description "Available" 7) Go to inventory /cgi-bin/koha/tools/inventory.pl 8) Without patch you see "For loan" in items.notforloan for value 0 9) With patch you see "Available" in items.notforloan for value 0 When I do that, I end up with 2 values showing on the inventory form: For loan and Available - both actually meaning the same. Also: On the edit item form the Available appears twice(!) in the pull down and the X to empty the field is no longer present. What I can see is an inconsistency on the inventory form as we only have a "0" value for not for loan, while we don't have that for lost, withdrawn and damaged. I'd suggest to either remove it or add an empty option for all of them. But also not using 'for loan' - because it still might not be, but something like 'not set'. Or: Not lost, not withdrawn, not damaged,... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:31:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 11:31:34 +0000 Subject: [Koha-bugs] [Bug 20127] Label Making Solution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20127 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- This sounds like extensive functionality planned. Why a plugin and not a solution within Koha? Because it wouldn't fit besides the existing label editor? Maybe it could use a part of it like the batch process? We also have the quick label printing where a little of that is possible, but not quite. But they are formatted to be changed by CSS easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:34:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 11:34:04 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #29 from Katrin Fischer --- I like the idea of a wiki page with information on how this will work and where the limits might be. Do you need to change MySQL configuration as well or is the koha-conf variable enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:52:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 11:52:11 +0000 Subject: [Koha-bugs] [Bug 17489] Allow Koha plugins to have translations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17489 --- Comment #3 from Katrin Fischer --- Hi Kyle, this looks promising! I am not sure I can figure it out myself, any chance you could spend some time on a prototype? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:02:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 12:02:19 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 --- Comment #5 from Katrin Fischer --- Added to next meeting's agenda: https://wiki.koha-community.org/wiki/General_IRC_meeting_4_April_2018#Agenda -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:11:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 12:11:14 +0000 Subject: [Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 --- Comment #2 from Katrin Fischer --- useDaysMode is used for calculating the due dates and usually not involved in the overdues process. I am not sure it's the right one. Maybe finesCalendar would be a better fit as it's already used to count the days overdue? So it would make sense to use it for determining the suspension date as well. With an update to the description. We could also have a new preference SuspensionCalendar mimicking the behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:14:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 12:14:35 +0000 Subject: [Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 --- Comment #3 from Katrin Fischer --- Actually looking at Bug 13909 - Suspension days calculation doesn't honour finesCalendar I think finesCalendar would be best. And update the description to say: Calculate fines and suspensions based on days overdue ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:17:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 12:17:38 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #12 from Katrin Fischer --- What I think is: Don't make the option, because the chance of messing up existing reports is very very slim. They will remain working as they work now if parameters are named differently. If there exist parameters who already are named the exactly same, the patch will take effect, but then we can also assume that this is indeed the wanted behaviour. Of course we should add a nice note to the release notes to highlight the new feature! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:22:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 12:22:25 +0000 Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19578 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:22:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 12:22:25 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- I think it seems the safest bet to keep the current behavour and do the processing for all fields from biblio and biblioitems. Could you provide a test plan Jonathan? Not quite sure yet how to work with the TT syntax in notices. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:48:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 13:48:38 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #30 from Tom?s Cohen Arazi --- (In reply to Katrin Fischer from comment #29) > I like the idea of a wiki page with information on how this will work and > where the limits might be. Do you need to change MySQL configuration as well > or is the koha-conf variable enough? Only koha-conf.xml! Isn't that beautiful? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:52:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 13:52:06 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #42 from Katrin Fischer --- There are some mostly small issues: 1) Small rebase conflict in SQL files for permissions 2) Capitalization +Home › Circulation › Checkout Notes 2) Translatability $("#status_" + $issue_id).text("Not seen"); $("#status_" + $issue_id).text("Seen"); 3) Move JavaScript to the bottom - we are currently migrating all pages to do that. See: Bug 17858 - Omnibus: Move staff client JavaScript to the footer 4) Missing [% VERSION %] variable for JavaScript libraries: + See: Bug 12904 - Force browser to load new JavaScript and CSS files after upgrade 5) Typo: + ( 1, 'manage_checkout_nots', 'Mark checkout notes as seen/not seen'), 6) There are also some issues noted by the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt FAIL forbidden patterns forbidden pattern: Include [% KOHA_VERSION %] in css paths (bug 12904) - May be false positive (line 7) forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug 12904) - May be false positive (line 76) FAIL valid_template parse error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt line 134: unexpected token ([) [% note.patron.title [% END %] FAIL circ/on-site_checkouts.pl FAIL valid Global symbol "$pending_onsite_notes" requires explicit package name circ/on-site_checkouts.pl had compilation errors. I've tried to test, but I can't see the link on the circulation home page, possibly to a problem (typo?) with the permissions. Please fix and test. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:54:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 13:54:38 +0000 Subject: [Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14224 |17698 --- Comment #8 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #7) > (In reply to Katrin Fischer from comment #6) > > Could there be a case where a library wants to activate the feature, but use > > it without email? We have some cases like the suggestions emails where you > > just delete the notice in that case. Maybe we could just adapt the text a > > little and remove the error/warning? Making the options dependent seems more > > hassle. > > I'm still working on the patch for Bug 17698 where the checkout notes will > be shown on the staff dashboard, similar to how patron modifications are > shown. I could add a patch to this bug that depends on 17698 where, if no > notice is defined, it will not try to send an email and instead just show > the note on the staff dashboard? hope that makes sense. Yep, makes sense to me! I have taken a look on bug 17698 and it looks promising. Linking both reports now. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 [Bug 14224] patron notes about item shown at check in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 [Bug 17698] Make patron notes show up on staff dashboard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:54:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 13:54:38 +0000 Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:54:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 13:54:38 +0000 Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19772 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772 [Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:00:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:00:55 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #67 from Katrin Fischer --- Hi David, thx for submitting. Peeking at the code I am not quite sure how it works, but notice it adds a lot of code to C4. Would probably need quite a bit of work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:13:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:13:22 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:13:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:13:15 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |Needs Signoff --- Comment #4 from Katrin Fischer --- Hi Andreas, thx for your patches! Some things: 1) Once you submitted your patches it's important to switch the status to 'Needs Signoff' in order to get the attention of the testers, otherwise patches can get easily lost in the saved searches. 2) The QA test tools can help you to find problems with your code easily. For your patches the report is: FAIL misc/cronjobs/advance_notices.pl OK critic FAIL forbidden patterns forbidden pattern: tab char (line 367) forbidden pattern: tab char (line 479) forbidden pattern: tab char (line 366) forbidden pattern: tab char (line 374) forbidden pattern: tab char (line 357) forbidden pattern: tab char (line 373) forbidden pattern: tab char (line 372) forbidden pattern: tab char (line 348) forbidden pattern: tab char (line 356) forbidden pattern: tab char (line 350) forbidden pattern: tab char (line 368) forbidden pattern: tab char (line 358) forbidden pattern: tab char (line 347) forbidden pattern: tab char (line 349) forbidden pattern: tab char (line 355) forbidden pattern: tab char (line 365) forbidden pattern: tab char (line 353) forbidden pattern: tab char (line 369) forbidden pattern: tab char (line 371) forbidden pattern: tab char (line 352) forbidden pattern: tab char (line 354) forbidden pattern: tab char (line 364) forbidden pattern: tab char (line 351) forbidden pattern: tab char (line 370) FAIL t/db_dependent/cronjobs/advance_notices_digest.t FAIL critic Expression form of "eval" at line 167, column 1. See page 161 of PBP. Bareword file handle opened at line 158, column 1. See pages 202,204 of PBP. FAIL forbidden patterns forbidden pattern: tab char (line 67) 3) This can all be fixed, but I see another problem here: libraries are differently organized and we support a lot of different use cases with Koha. Some libraries want Koha to only send one email instead of many, others like yours don't want this behaviour. So we need to find a compromise here and a way to make this configurable. I think a system preference could work here as I don't see how to add it to the notices configuration in a good way. 4) We usually don't test .pl files yet... but not opposed to more tsts :) Tests are failing for me right now: t/db_dependent/cronjobs/advance_notices_digest.t .. 1/5 # Failed test 'There are two messages in the queue' # at t/db_dependent/cronjobs/advance_notices_digest.t line 175. # got: '0' # expected: '2' # Looks like you planned 5 tests but ran 1. # Looks like you failed 1 test of 1 run. t/db_dependent/cronjobs/advance_notices_digest.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 5/5 subtests 5) If you want, you could also add an individual Sponsord-By line for each sponsoring library. It depends on how you want the output in the release notes later on. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:27:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:27:39 +0000 Subject: [Koha-bugs] [Bug 2797] Add Summary records to represent summary holdings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2797 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 20447 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:27:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:27:39 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Katrin Fischer --- *** Bug 2797 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:33:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:33:58 +0000 Subject: [Koha-bugs] [Bug 20488] Manual renewal due date ignore closed day in calendar In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20488 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- I think a warning with the option to confirm would be good instead of automatically moving to the next opening day. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:41:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:41:48 +0000 Subject: [Koha-bugs] [Bug 20505] New: Selenium tests fail if server not running Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 Bug ID: 20505 Summary: Selenium tests fail if server not running Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org If the dependencies for the Selenium tests are installed, but the steps recommended on https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha are not taken before running the selenium tests, they die non-gracefully. Patch them to skip informatively. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:50:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:50:23 +0000 Subject: [Koha-bugs] [Bug 20505] Selenium tests fail if server not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 --- Comment #1 from M. Tompsett --- Created attachment 73517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73517&action=edit Bug 20505: Patch selenium tests to skip gracefully TEST PLAN --------- 1) In a koha shell on kohadevbox, run prove -v t/db_dependent/selenium until it doesn't skip because of missing dependencies, but rather because of not running a selenium server. 2) apply this patch and restart_all 3) rerun the tests -- they will skip gracefully and informatively. 4) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:50:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 14:50:21 +0000 Subject: [Koha-bugs] [Bug 20505] Selenium tests fail if server not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:35:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 15:35:24 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett --- Tested: Staff OPAC Self-checkout And fresh install Only the fresh install allowed the system log in, as desired. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:49:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 15:49:18 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #10 from M. Tompsett --- Attempted steps to go to urls which should trigger modified code in both logged in and logged out states. Failures and successes as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:50:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 15:50:30 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #11 from M. Tompsett --- Comment on attachment 73400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73400 Bug 20489: Prevent DB user login Review of attachment 73400: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20489&attachment=73400) ----------------------------------------------------------------- ::: acqui/neworderempty.pl @@ +203,5 @@ > my $order_patron = Koha::Patrons->find( $order_user_id ); > push @order_users, $order_patron if $order_patron; > } > + if ( $data->{subscriptionid} ) { > + $template->param( subscriptionid => $data->{subscriptionid} ); This tweak is the one I don't understand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:55:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 15:55:55 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73494|0 |1 is obsolete| | --- Comment #21 from Victor Grousset/tuxayo --- Created attachment 73518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73518&action=edit Bug 19910 - Use the delimiter syspref to name download link To test: 1 - Set delimiter syspref to anything but comma 2 - Download report results as comma separated text 3 - They actually follow the syspref 4 - Apply patch 5 - Download link should now match pref selection 6 - Change pref, note link changes 7 - Verify things still work as expected Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:58:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 15:58:46 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #9 from Katrin Fischer --- I am not sure all libraries can generally agree to send the notice on date due, because then the user has no way to return the item on time usually. I think there are separate issues thinking about the notice: - Don't send a notice every day the item is not returned, sent a notice once or at least not too often - Be able to inform the patrons on time before the due date so they are able to return the item on time - Don't inform the user weeks ahead Could it help to set the "No renewal before" to a lower number of days? This would prevent auto renewals from happening and together with "No automatic renewal after" could limit the timeframe for sending the notice to a few days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 18:19:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 16:19:01 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #8 from Katrin Fischer --- (In reply to Jonathan Druart from comment #7) > Next step is to re-add the ability to "edit the manual". > I would suggest to remove the possibility to edit the manual, but allow to > create new pages (which will not be erased on update). > > I need to know what are the different use cases and needs. Possible use cases I could see for local help files: - Being able to explain custom fields like authorised values, patron attributes etc. - Being able to explain how to use collections, locations, item types - Offer local help for cataloguing like explanations for fields and subfields, internal standards and agreements > We need also to think about an ergonomic way to manage these additional help > files. > For instance: in the top right of the staff pages we will have a "Help" > group buttons with > Link to the official manual | Add a new page > And when new pages are created: > Link to the official manual | Additional pages 1..N | Add a new page > > The additional pages would be linked to a specific page of the staff > interface (see the mapping in Koha::Manual) > > Does it make sense? Other ideas/opinions? That makes sense to me. I think having a HTML based editor would be better than .rst for the local help files and that we should store them in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 18:25:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 16:25:40 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Patch doesn't apply --- Comment #9 from Katrin Fischer --- Hi Jonathan, can you please rebase? I tried but it got a bit chaotic. I think you are missing the change to koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc for the new permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 18:30:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 16:30:20 +0000 Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdiazmunoz at gmail.com, | |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Julian, this is an interesting approach. Are you aware that we can currently already translate the SQL files for the frameworks using pootle? For an example: http://translate.koha-community.org/de/marc21/ Bernardo provides the auto-generated SQL files for creating patches for the web installer. Could there be a way to bring this together? Use po files to create the .yml file? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 21:51:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Apr 2018 19:51:08 +0000 Subject: [Koha-bugs] [Bug 20158] add a new column in the tables of the list's module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20158 --- Comment #4 from Katrin Fischer --- Hi Marjorie, I see what you mean, but I am not sure putting more and more item information on the display is the best solution, especially as it will clutter the display for libraries with a lot of items on some of the records. What is your use case? Why would you want to see the barcodes? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 02:42:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 00:42:12 +0000 Subject: [Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428 --- Comment #12 from M. Tompsett --- Comment on attachment 73430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73430 Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files Review of attachment 73430: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20428&attachment=73430) ----------------------------------------------------------------- ::: Koha/UploadedFile.pm @@ +169,5 @@ > sub temporary_directory { > my ( $class ) = @_; > + return (C4::Context->config('upload_tmp_path')) > + ? C4::Context->config('upload_tmp_path') > + : File::Spec->tmpdir; Why a trinary when a || File::Spec->tmpdir would work more nicely? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 02:46:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 00:46:47 +0000 Subject: [Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 --- Comment #4 from M. Tompsett --- Comment on attachment 72272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72272 Bug 20304: Remove warnings from cataloguing scripts Review of attachment 72272: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20304&attachment=72272) ----------------------------------------------------------------- ::: cataloguing/additem.pl @@ +157,5 @@ > my $temp2 = $temp->field($CNtag); > if ($temp2) { > + my $value = q{}; > + $value .= $temp2->subfield($CNsubfield) if $temp2->subfield($CNsubfield); > + $value .= $temp2->subfield($CNsubfield2) if $temp2->subfield($CNsubfield2); Where's the space gone? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 02:48:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 00:48:00 +0000 Subject: [Koha-bugs] [Bug 20505] Selenium tests fail if server not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 02:48:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 00:48:13 +0000 Subject: [Koha-bugs] [Bug 20505] Selenium tests fail if server not running In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 03:32:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 01:32:25 +0000 Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #7 from M. Tompsett --- Comment on attachment 73362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73362 Bug 18889 - Storing and display of barcode with fines in intranet Review of attachment 73362: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18889&attachment=73362) ----------------------------------------------------------------- ::: C4/Accounts.pm @@ +281,4 @@ > date => \'NOW()', > amount => $amount, > description => $desc, > + barcode => $barcode, Why pass barcode when the itemnumber is available? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 03:33:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 01:33:07 +0000 Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #8 from M. Tompsett --- Created attachment 73519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73519&action=edit Bug 18889: Simpler counter-patch There is no need to add barcode into the accountlines table, as a relationship via itemnumber can easily look it up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 03:39:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 01:39:55 +0000 Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #9 from M. Tompsett --- Counter Patch Test Plan ------------------------ 1) Add a manual fine with a barcode to a member. 2) Look at the pay invoice tab. -- no barcode shown. 3) apply counter patch only patch -- and no updatedatabase or rebuilding tables required! 4) restart_all (silly plack caching) 5) refresh the pay invoice tab. -- barcode now displayed. 6) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:09:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 02:09:56 +0000 Subject: [Koha-bugs] [Bug 20419] Current location not updated correctly on the return of an item on hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Status|Needs Signoff |Failed QA --- Comment #2 from M. Tompsett --- Please include unit tests when modifying C4 or Koha libraries. This prevents regression. It would be nice if they fail before the fix, and then pass after the fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:18:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 02:18:42 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #5 from M. Tompsett --- Comment on attachment 71098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71098 Bug 20116: Cache language list Review of attachment 71098: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20116&attachment=71098) ----------------------------------------------------------------- ::: C4/Languages.pm @@ +122,3 @@ > if ($interface && $interface eq 'opac' ) { > my $htdocs = C4::Context->config('opachtdocs'); > @languages = _get_opac_language_dirs( $htdocs, $theme ); Forgot to delete this line, I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:29:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 02:29:03 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20103 CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:29:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 02:29:03 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19735 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:37:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 02:37:00 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #17 from M. Tompsett --- Comment on attachment 73186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73186 Bug 19066 - Add branchcode to accountlines Review of attachment 73186: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19066&attachment=73186) ----------------------------------------------------------------- ::: Koha/Account.pm @@ +76,4 @@ > my $account_type = $params->{account_type}; > my $offset_type = $params->{offset_type} || $type eq 'writeoff' ? 'Writeoff' : 'Payment'; > > + $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; why not below the $userenv below? Less referencing, shorter line, and easier to read. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 09:56:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 07:56:47 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #53 from Katrin Fischer --- Alex, should this be set back to Signed off with your follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 12:26:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 10:26:51 +0000 Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search rather than filtering existing results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346 --- Comment #10 from Alex Buckley --- Created attachment 73520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73520&action=edit Bug 20346 - Making JS strings translatable This is based on tester feedback in comments 7 and 8 Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 13:24:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 11:24:06 +0000 Subject: [Koha-bugs] [Bug 20506] New: How do I get drop menu help for classification in koha? Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20506 Bug ID: 20506 Summary: How do I get drop menu help for classification in koha? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: manjunath at tapmi.edu.in QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl we have installed koha s/w in our library. we are not able to make the s/w auto appenadable field for books, journal issues, project reports separately. we ahave separate Accno/barcode for each item type. similarly, how do we get DDC classno & subject help from current pool of classnos and subject headings in the collection?. we have table of classnos and subejct headings in the book collection. we need the selection help to avoid typo errors. can KOHA community help us? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 13:26:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 11:26:42 +0000 Subject: [Koha-bugs] [Bug 20506] How do I get drop menu help for classification in koha? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20506 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer --- Bugzilla is used for reporting bugs and enhancement requests, but this reads more like a support request. Please ask your questions on the mailing list: https://koha-community.org/support/koha-mailing-lists/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 13:50:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 11:50:39 +0000 Subject: [Koha-bugs] [Bug 20507] New: Shelf browser does not update image sources when paging Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507 Bug ID: 20507 Summary: Shelf browser does not update image sources when paging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When using a cover source other than Amazon (which uses static links) the shelf browser does not fire a call to the image sources when moving to a new page To recreate: Enable coce (https://coce.bywatersolutions.com) and enable all sources except amazon Enable shelf browser View a title in the opac View the shelf browser, note images load on first page Page left or right and note images are not loaded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:09:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:09:42 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71098|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 73521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73521&action=edit Bug 20116: Cache language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:09:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:09:59 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #7 from Jonathan Druart --- (In reply to M. Tompsett from comment #5) > Comment on attachment 71098 [details] [review] > Bug 20116: Cache language list > > Review of attachment 71098 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Languages.pm > @@ +122,3 @@ > > if ($interface && $interface eq 'opac' ) { > > my $htdocs = C4::Context->config('opachtdocs'); > > @languages = _get_opac_language_dirs( $htdocs, $theme ); > > Forgot to delete this line, I think. Indeed, thanks for catching it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:15:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:15:39 +0000 Subject: [Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72272|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 73522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73522&action=edit Bug 20304: Remove warnings from cataloguing scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:16:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:16:45 +0000 Subject: [Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304 --- Comment #6 from Jonathan Druart --- (In reply to M. Tompsett from comment #4) > Comment on attachment 72272 [details] [review] > Bug 20304: Remove warnings from cataloguing scripts > > Review of attachment 72272 [details] [review]: > ----------------------------------------------------------------- > > ::: cataloguing/additem.pl > @@ +157,5 @@ > > my $temp2 = $temp->field($CNtag); > > if ($temp2) { > > + my $value = q{}; > > + $value .= $temp2->subfield($CNsubfield) if $temp2->subfield($CNsubfield); > > + $value .= $temp2->subfield($CNsubfield2) if $temp2->subfield($CNsubfield2); > > Where's the space gone? lost, but I found it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:26:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:26:48 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:26:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:26:52 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69807|0 |1 is obsolete| | Attachment #69808|0 |1 is obsolete| | Attachment #70131|0 |1 is obsolete| | Attachment #70132|0 |1 is obsolete| | Attachment #70133|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 73523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73523&action=edit Bug 19817: Redirect to the online manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:26:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:26:58 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #11 from Jonathan Druart --- Created attachment 73524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73524&action=edit Bug 19817: Remove local help files + edit help feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:27:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:27:02 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #12 from Jonathan Druart --- Created attachment 73525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73525&action=edit Bug 19817: Make the location of the manual configurable - KohaManualBaseURL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:27:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:27:06 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #13 from Jonathan Druart --- Created attachment 73526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73526&action=edit Bug 19817: Move code to Koha::Manual to make it testable and reusable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:27:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:27:11 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #14 from Jonathan Druart --- Created attachment 73527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73527&action=edit Bug 19817: Add new permission edit_help Change in existing behaviour! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:29:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:29:39 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #15 from Jonathan Druart --- Done, note that the last patch does nothing (new permission is not used). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:35:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:35:30 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73400|0 |1 is obsolete| | Attachment #73425|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 73528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73528&action=edit Bug 20489: Prevent DB user login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:35:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:35:33 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #13 from Jonathan Druart --- Created attachment 73529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73529&action=edit Bug 20489: Remove warnings from the interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:36:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:36:13 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 --- Comment #14 from Jonathan Druart --- (In reply to M. Tompsett from comment #11) > This tweak is the one I don't understand. It was not related to this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:38:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:38:29 +0000 Subject: [Koha-bugs] [Bug 20077] Patroncards are printed blank In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #7 from Chris Nighswonger --- (In reply to Sven H. from comment #3) > > > I have a similar problem. > > When I try to print the patron cards, the > /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl does not finish > and runs with 100% CPU load. > > In plack-error.log I find the following lines: > Use of uninitialized value $batch_id in concatenation (.) or string at > /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl line 68. > Use of uninitialized value in multiplication (*) at > /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. > Use of uninitialized value in addition (+) at > /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256. > Use of uninitialized value in multiplication (*) at > /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288. > Use of uninitialized value in multiplication (*) at > /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. > Use of uninitialized value in addition (+) at > /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256. > Use of uninitialized value in multiplication (*) at > /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288. > Use of uninitialized value in multiplication (*) at > /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239. > Use of uninitialized value in addition (+) at > /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256. > > The problem first appeared in February 2018 after I started the Ubuntu > updates. Unfortunately I don't remember what has been updated. > snip > > Unfortunately I am not able to print patron cards at the moment. It would be > great if there was a solution for this soon. I'm not sure what is going on in this particular instance, but taking the same steps on my production system results in a PDF containing the expected cards and nearly zero CPU usage. Unless someone else can confirm the problem, I would look at something local. Perhaps a Koha update did not apply well or some such, resulting in a script not being updated. Also, this appears to be a different problem than the one the OP reported. It would be good to open a new bug for it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:49:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:49:09 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 --- Comment #12 from Jonathan Druart --- Test plan: - Confirm that the new tests pass. That should be enough to confirm this change make sense. Test plan (manual): - Create a biblio with a title ending with a punctuation (like "with_punctuation_"), or any other fields of biblio/biblioitem - Generate a notice which will display this field (CHECKIN for instance) Use the historical syntax and the TT syntax, both should display the title without the punctuation character at the end CHECKIN historical: The following items have been checked in: ---- <> ---- CHECKIN TT syntax: The following items have been checked in: ---- [% biblio.title %] ---- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:50:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:50:04 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:51:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:51:45 +0000 Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:55:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 14:55:54 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #27 from Jonathan Druart --- (In reply to Jon Knight from comment #26) > (In reply to Katrin Fischer from comment #25) > > Hi S?verine, there is no a setting in administration > currency for each > > currency, where you can define if there should be a space or not. > > > > I am torn about seeing the currency. I think we agreed a long while ago that > > we should not show the currency symbols in acq as long as it's the active > > currency as it would clutter a lot of the displays, where you deal with a > > lot of numbers and prices. Would you agree to remove the currency symbol > > display? > > $Price with_symbol => 1 > > That's how I had it before Jonathan Druart asked me to put the symbols in > place in comment #18 above. I don't mind either way as long as the QA team > and RM can agree (or do I have to add in a syspref for this? :-) ). > > I'll await a decision before changing this simple patch again. IIRC you displayed the currency code :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 17:16:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 15:16:55 +0000 Subject: [Koha-bugs] [Bug 20508] New: Validation for *MandatoryField and *UnwantedField sysprefs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20508 Bug ID: 20508 Summary: Validation for *MandatoryField and *UnwantedField sysprefs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When any the system preferences BorrowerMandatoryField BorrowerUnwantedField PatronSelfModificationBorrowerUnwantedField PatronSelfRegistrationBorrowerMandatoryField PatronSelfRegistrationBorrowerUnwantedField are being populated, we should check that a) The entered fields are columns in the borrowers table b) Mandatory / Unwanted fields that refer to the same form (BorrowerMandatoryField/BorrowerUnwantedField and PatronSelfRegistrationBorrowerMandatoryField/PatronSelfRegistrationBorrowerUnwantedField) do not contain the same fields. c) If autoMemberNum is set, don't allow cardnumber in *MandatoryField See also: * Bug 17433 * Bug 19642 * Bug 19225 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 17:38:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 15:38:46 +0000 Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- https://archive.ifla.org/VI/8/projects/UNIMARC-HoldingsFormat.pdf -- but isn't there supposed to be a 100?! 12-15 Character Set (Mandatory) These four character positions indicate the principal graphic character sets used in the record. Positions 12-13 designate the G0 set and positions 14-15 designate the G1 set. If a G1 set is not needed, positions 14-15 contain blanks. 01 = ISO 646, IRV version (basic Latin set) 02 = ISO Registration # 37 (basic Cyrillic set) 03 = ISO 5426 (extended Latin set) 04 = ISO DIS 5427 (extended Cyrillic set) 05 = ISO 5428 (Greek set) 06 = ISO 6438 (African coded character set) 07 = ISO 10586 (Georgian set) 08 = ISO 8957 (Hebrew set) Table 1 09 = ISO 8957 (Hebrew set) Table 2 10 = [Reserved] 11 = ISO 5426-2 (Latin characters used in minor European languages and obsolete typography) 50 = ISO 10646 Level 3 (Unicode) Oh yuck... reading the MARC::File::XML library... it basically fakes it. # Does the record think it is already Unicode? if ($original_encoding ne 'a' && lc($format) !~ /^unimarc/o) { # If not, we'll make it so $_transcode++; substr($ldr,9,1,'a'); $record->leader( $ldr ); } which is why the as_xml in elsewhere does the "USMARC" thing. Okay. I'll test this, since I'm assuming Fridolin has already tested in a UNIMARC context before submitting this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 17:57:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 15:57:23 +0000 Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file with default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19453 --- Comment #3 from Jonathan Druart --- Ha, I think I found the problem. It has been caused by commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 [Bug 19453] Client side validation broken for "Fund" select -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 17:57:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 15:57:23 +0000 Subject: [Koha-bugs] [Bug 19453] Client side validation broken for "Fund" select In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20426 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 [Bug 20426] Can't import all titles from a stage file with default values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 18:04:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 16:04:10 +0000 Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file with default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 18:04:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 16:04:13 +0000 Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file with default values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 --- Comment #4 from Jonathan Druart --- Created attachment 73530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73530&action=edit Bug 20426: Fix default fund value when adding orders from iso2709 file A new bug has been highlighted since: commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Prior to bug 19453 the check on the existence of the fund did not work as expected, no select with name='budget_code' existed and the error was never raised. Now it works but expect a fund to be selected for every record to import. This check must only be done if there is no default value selected. Test plan: - Create an order from a staged file - Do not select any funds => You must get a warning - Select a specific fund for some of the records => You must get a warning - Select a default fund in the last tab => You must not get a warning and the records must be imported and inserted with the correct fund -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 18:55:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 16:55:29 +0000 Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757 --- Comment #8 from M. Tompsett --- BTW, it should be noted that this same problem shows itself as an "Internal Server Error" if one tries to manually catalogue a record in UNIMARC, and uses something clearly bad, like "KABOOM!" in the 100$a field. :) substr outside of string at /usr/share/perl5/MARC/File/XML.pm line 561 (#2) (W substr)(F) You tried to reference a substr() that pointed outside of a string. That is, the absolute value of the offset was larger than the length of the string. See "substr" in perlfunc. This warning is fatal if substr is used in an lvalue context (as the left hand side of an assignment or as a subroutine argument for example). Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 563 (#1) Use of uninitialized value $enc in string eq at /usr/share/perl5/MARC/File/XML.pm line 565 (#1) Use of uninitialized value $enc in concatenation (.) or string at /usr/share/perl5/MARC/File/XML.pm line 568 (#1) Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> kaboom at /usr/share/perl5/MARC/File/XML.pm line 568. No need to make any 200 rules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:12:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 17:12:11 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 --- Comment #26 from Jonathan Druart --- Created attachment 73531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73531&action=edit Bug 19974: Make MarkLostItemsAsReturned multiple Given the confusion regarding this behaviour it sounds better to make it configurable. This pref will take 4 different values, 1 per place an item can be marked as lost. Test plan: Mark items as lost and confirm the item is returned or not, depending on the value of the system preference. - from the longoverdue cronjob (--mark-returned takes precedence if set) - from the batch item modification tool - when cataloguing an item - from the items tab of the catalog module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:14:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 17:14:10 +0000 Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually modify the current item (cataloguing/additem.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Severity|normal |major Keywords| |rel_18_05_candidate --- Comment #27 from Jonathan Druart --- I have attached a patch to test, it makes the pref multiple to bring flexibility. We need to resolve this for 18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:19:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 17:19:53 +0000 Subject: [Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- We should not use biblioitems.url but GetMarcUrls instead -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:21:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 17:21:46 +0000 Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #72969|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:21:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 17:21:51 +0000 Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:30:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 17:30:39 +0000 Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 --- Comment #15 from Jonathan Druart --- Created attachment 73532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73532&action=edit Bug 20318: Add class 'required' to the label -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:25:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:25:48 +0000 Subject: [Koha-bugs] [Bug 20392] Multiple biblio holding does not work when patron is not set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20392 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |RESOLVED --- Comment #7 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 18474 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:25:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:25:48 +0000 Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks when patron is searched for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #11 from Jonathan Druart --- *** Bug 20392 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:28:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:28:53 +0000 Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 --- Comment #4 from M. Tompsett --- Created attachment 73534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73534&action=edit Bug 18674: Follow up on missing TZ SetEnv for plack It should also be noted that /etc/apache2/sites-enabled/{configuration file} should also contain: RequestHeader add X-Koha-SetEnv "TZ {timezone}" Where {timezone} is the desired instance timezone. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:28:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:28:48 +0000 Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72214|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 73533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73533&action=edit Bug 18674: Added timezone information to about page Before patch: No timezone section After patch: timezone section at bottom of Server information tab. Actual is what is being used. Config overrides environment variables. So if there is confusion why the environment variables aren't working, it will be visible why. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:29:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:29:30 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:29:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:29:31 +0000 Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the About Koha page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:30:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:30:41 +0000 Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Jonathan Druart --- Please fix patches' author (name and email). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:42:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:42:39 +0000 Subject: [Koha-bugs] [Bug 20509] New: Data consistency - authority types Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509 Bug ID: 20509 Summary: Data consistency - authority types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20385 >From bug 20385. We should display a message on the about page (or a new page dedicated to data consistency) if an authtypecode of authority records does not correspond to an authority type defined in the system. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 [Bug 20385] ElasticSearch authority search raises Software error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:42:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:42:39 +0000 Subject: [Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20509 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509 [Bug 20509] Data consistency - authority types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:46:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:46:31 +0000 Subject: [Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 --- Comment #11 from Jonathan Druart --- We really need tests for these ES methods! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:49:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:49:48 +0000 Subject: [Koha-bugs] [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |15758 --- Comment #4 from Jonathan Druart --- Caused by commit 9b9803b69c8bde879768ccfa3cc4688ef46b7799 Bug 15758: Koha::Libraries - Remove GetBranchesLoop Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:49:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 19:49:48 +0000 Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282 [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:08:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 20:08:52 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #28 from Katrin Fischer --- > That's how I had it before Jonathan Druart asked me to put the symbols in > place in comment #18 above. I don't mind either way as long as the QA team > and RM can agree (or do I have to add in a syspref for this? :-) ). > > I'll await a decision before changing this simple patch again. I talked to Joubu and removing the currency symbols will be safe ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:11:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 20:11:32 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #10 from Jonathan Druart --- (In reply to Kyle M Hall from comment #9) > (In reply to Jonathan Druart from comment #8) > > There is an access to the removed variable "holds" in the template > > loop_order.holds > > > > That means we now see "Can't delete catalog record, see constraints below", > > but without anything below... > > The code you are referencing is in loop_orders, but this patch only alters > loop_received which does not have that message. I'm not sure how this patch > could be causing that. If you can give me some line numbers I'd be happy to > take another look! Indeed, sounds like I mixed the 2 tables reading the code. Something else: 1. What about comment 6? 2. "1 / 0" reads wrong, but I have no idea how it could be better. 3. line 141 $line{holds} = 0; should be removed, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:42:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 20:42:15 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add index from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #8 from Jonathan Druart --- 1. What's the point of the JS function valid_line? I think you should double-check it, it does not do what you expect it to do. 2. You are reusing code to duplicate a new mapping but for something else. You should rename the variables to avoid confusion then. For instance "search_fields" is not an index name 3. Bug report's title is wrong, we are not adding/removing indices 4. I did not implement that part on the original patch because it's hard to keep an interface consistent. For instance: - create a new search field => You cannot create a new mapping, you have to save first - create a new search field, save => You can delete it. So it you create a mapping using it, you can still delete it. If you save => kaboom => If you have a search field already mapped and delete the mapping, you cannot delete the search field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:49:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 20:49:07 +0000 Subject: [Koha-bugs] [Bug 20329] Text input fields are wider than the fieldset class they are inside of In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA Keywords| |rel_18_05_candidate --- Comment #10 from Jonathan Druart --- It is not a good idea to specify a size in px, you should use a relative lenght instead. We already have div.yui-b fieldset.brief select { width: 12em; } 12em sounds like a good value here. Maybe the following addition would be enough: div.yui-b fieldset.brief input { width: 12em; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:52:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 20:52:02 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- Any good reasons to use custom tag elements here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:52:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 20:52:57 +0000 Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in circulation.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #9 from Jonathan Druart --- Translatable strings must be put in .tt files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:59:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 20:59:49 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #11 from Jonathan Druart --- 1. Need to be patched with changes on bug 20282 2. I think you should use the TT plugin AuthorisedValues (and include file options_for_authorised_value_categories) for CCODE and LOC 3. You should use uniq on @barcodes (and use the same split we already do in tools/*: \s\n) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:01:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:01:33 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #16 from Katrin Fischer --- Hi Jonathan, some thoughts: 1) sub _get_base_url doesn't look quite right yet. a) It hardcodes en. Ideally we should try to check for the existence of a translated manual and use that, with a fallback to en. If we can't do that, we'll maybe need to add a pref where you can add the lanugage codes to use. b) For the local manual URL you combine: C4::Context->preference('staffClientBaseURL') . $KohaManualBaseURL; I think it might be good to allow for a full URL in KohaManualBaseURL. That way you could have the help on the same server or at another location. 2) If the permission doesn't work yet, I would not include it :) 3) The manual layout doesn't work well in the small pop up. I wonder if there is a way to leave off the side navigation, but probably we can just make the window a bit wider. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:14:24 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:14:30 +0000 Subject: [Koha-bugs] [Bug 18382] action_logs entry for module HOLDS, action SUSPEND is spammy In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:14:35 +0000 Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks when patron is searched for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:14:15 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #24 from Jonathan Druart --- Patches pushed to master. Congratulations Roch and Philippe for your first patches in! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:14:46 +0000 Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:14:51 +0000 Subject: [Koha-bugs] [Bug 19892] Replace numbersphr variable with Koha.Preference('OPACNumbersPreferPhrase') in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:14:57 +0000 Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:03 +0000 Subject: [Koha-bugs] [Bug 20052] Add Reports object class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:08 +0000 Subject: [Koha-bugs] [Bug 20282] Wrong attribute in template calls to match holding branch when adding/editing a course reserve item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:14 +0000 Subject: [Koha-bugs] [Bug 20291] Add a StaffLoginInstructions system preference to add text to the staff client login box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:17 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- I've tested it and I think it's still a little confusing. Right now it is: total of holds / holds on on order items Which can lead to the 1 / 0 that Jonathan pointed out. Maybe it would make more sense to switch the values? Or just show the total number of holds = record level + item level on on order items? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:19 +0000 Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged invoice without Invoice number In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:25 +0000 Subject: [Koha-bugs] [Bug 20369] Analytics search is broken with QueryAutoTruncate set to 'only if * is added' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:30 +0000 Subject: [Koha-bugs] [Bug 20385] ElasticSearch authority search raises Software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:36 +0000 Subject: [Koha-bugs] [Bug 20462] Duplicate barcodes in batch item deletion cause software error if deleting biblio records. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20462 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:42 +0000 Subject: [Koha-bugs] [Bug 20494] Remove unused code in neworderempty.pl and addbiblio.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:15:47 +0000 Subject: [Koha-bugs] [Bug 20497] LibraryThing: always use https instead of http In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20497 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:17:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 21:17:36 +0000 Subject: [Koha-bugs] [Bug 20462] Duplicate barcodes in batch item deletion cause software error if deleting biblio records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20462 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Duplicate barcodes in batch |Duplicate barcodes in batch |item deletion cause |item deletion cause |software error if deleting |software error if deleting |biblio records. |biblio records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 22:22:02 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73091|0 |1 is obsolete| | --- Comment #24 from Benjamin Rokseth --- Created attachment 73535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73535&action=edit Bug 20271: merging delete biblio/items NOTE: deleteditems/biblio on OAI not sure how to test this, but the changes should be good enough -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 22:22:09 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73092|0 |1 is obsolete| | --- Comment #25 from Benjamin Rokseth --- Created attachment 73536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73536&action=edit Bug 20271 - merge deletedbiblio and -items back - add atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 22:22:14 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73093|0 |1 is obsolete| | --- Comment #26 from Benjamin Rokseth --- Created attachment 73537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73537&action=edit Bug 20271: fix remaining tests, add checks and report in atomicupdate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 22:22:21 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #27 from Benjamin Rokseth --- Created attachment 73538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73538&action=edit Bug 20271: update kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 22:22:27 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #28 from Benjamin Rokseth --- Created attachment 73539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73539&action=edit Bug 20271: delete biblio and biblio_metadata in one go -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 22:22:32 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #29 from Benjamin Rokseth --- Created attachment 73540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73540&action=edit Bug 20271: remove comments regarding deleteditems and -biblio* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:24:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Apr 2018 22:24:56 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #30 from Benjamin Rokseth --- rebased against master and added fixes to comments except OAI. Ere, since you voluntered to add the neccessary fixes to OAI, I leave them to you ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 03:09:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 01:09:45 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65868|0 |1 is obsolete| | --- Comment #54 from Srdjan Jankovic --- Created attachment 73541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73541&action=edit bug 14803: KOHA.Checkouts js object * Use javascript to: - update fines/checkouts info - show/hide checkouts form and messages * Created svc/patron/fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 03:10:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 01:10:48 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 03:10:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 01:10:52 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66261|0 |1 is obsolete| | --- Comment #55 from Srdjan Jankovic --- Created attachment 73542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73542&action=edit Bug 14803 follow-up: outstanding-fees-amount is a class, not id Multiple outstanding-fees-amount displays on the page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 03:16:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 01:16:58 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 --- Comment #56 from Srdjan Jankovic --- Rebased, and fines look fine, however I think checkouts list is somewhat broken on the circ issuing screen. And I believe that's not to do with this patch, but cannot be 100% sure. Can you please have a look. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 05:57:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 03:57:41 +0000 Subject: [Koha-bugs] [Bug 16690] Remote DB installation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Installing DB on remote |Remote DB installation |server fails without GRANT |fails |ALL, because wrong | |permissions are checked | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 05:59:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 03:59:23 +0000 Subject: [Koha-bugs] [Bug 16690] Remote DB installation fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |major --- Comment #10 from M. Tompsett --- Increased importance, because I really feel the local install of the DB on the same machine as the web server is not something larger enterprises wish to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 06:05:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 04:05:56 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73528|0 |1 is obsolete| | --- Comment #15 from M. Tompsett --- Created attachment 73543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73543&action=edit Bug 20489: Prevent DB user login Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 06:05:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 04:05:59 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73529|0 |1 is obsolete| | --- Comment #16 from M. Tompsett --- Created attachment 73544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73544&action=edit Bug 20489: Remove warnings from the interface Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 06:06:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 04:06:44 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from M. Tompsett --- See comment #9 and comment #10 for how I tested. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 07:42:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 05:42:13 +0000 Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer --- Hi Jonathan, Continuing testing: I've used the SQL from the installer file to create my ACQ framework. 1) Looking at the code, why this change on the ISBD view? filters => 'ViewPolicy', options => { interface => 'intranet', - frameworkcode => $framework + frameworkcode => 'ACQ' }, 2) The input fields are much shorter with the ACQ framework active. Can we extend them a bit to be a similar size than before? Especially title and series fields are too short. 3) The descriptions of the fields coming from the default framework are not very nice because they are out of context without the field description. For example 440 says title, but it's not clear it's the series title. The MARC helps a bit. 4) I filled in title and series title and got an error on saving: Indicator in 440 is empty at /home/vagrant/kohaclone/C4/Biblio.pm line 2294. :13: parser error : Opening and ending tag mismatch: record line 6 and datafield ^ :14: parser error : Opening and ending tag mismatch: collection line 2 and record ^ :15: parser error : Extra content at the end of the document -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 07:52:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 05:52:36 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Katrin Fischer --- The tests don't pass for me :( kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Letters/TemplateToolkit.t .. ERROR PROCESSING TEMPLATE: plugin error - Remove_MARC_punctuation: plugin not found at t/db_dependent/Letters/TemplateToolkit.t line 104. # Looks like your test exited with 2 before it could output anything. t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 18/18 subtests Test Summary Report ------------------- t/db_dependent/Letters/TemplateToolkit.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 18 tests but ran 0. FAIL C4/Letters.pm OK critic OK forbidden patterns OK git manipulation FAIL pod empty =head3 *** ERROR: in file C4/Letters.pm FAIL pod coverage POD is missing for add_tt_filters POD is missing for getletter OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:08:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 06:08:16 +0000 Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Process_message_queue sends |Process_message_queue sends |duplicate emails if |duplicate emails if |message_queue is not |message_queue is not |writable. |writable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:24:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 06:24:31 +0000 Subject: [Koha-bugs] [Bug 20510] New: Remove unused sub TotalPaid from C4::Stats Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 Bug ID: 20510 Summary: Remove unused sub TotalPaid from C4::Stats Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org The sub TotalPaid from module C4::Stats is not used anywhere and it should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:27:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 06:27:41 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:28:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 06:28:41 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #28 from Ere Maijala --- Katrin, my patch is alternative to the other ones and in my opinion the correct way to fix this and related encoding issues once and for all. But as I mentioned it's not complete yet and I'd like to have some feedback before I go through the trouble of completing it since it's a bit of tedious work. Kyle's version of url encoding would be fine otherwise, but it will only work for basic latin characters, and the current practice of shoving unencoded stuff into url's is simply wrong and only works because browsers are forgiving in the handling of most characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:33:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 06:33:02 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:33:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 06:33:05 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 --- Comment #1 from Josef Moravec --- Created attachment 73545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73545&action=edit Bug 20510: Remove unused sub TotalPaid from C4::Stats Test plan: 0) Do not apply the patch 1) Run git grep TotalPaid and confirm it is only defined and then used once in a test 2) Apply the patch 3) git grep TotalPaid should return nothing 4) prove t/db_dependent/Stats.t should be green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 10:01:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 08:01:26 +0000 Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #56 from Victor Grousset/tuxayo --- Created attachment 73546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73546&action=edit Bug 12310 : Decimal separator issues: some fixes in fines The main goal is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator Bonuses: - Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator. It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DigitSeparator syspref. - minuses, doesn't remove them == Test plan == 1. Use a translation of the staff interface if possible. 2. When you pay an existing fine (more details in the next steps if needed). Check that you can't enter any string except like "XX.XX" (examples in Annex 1) without having an issue after validation. (x100, trucation, etc) 3. Apply this patch 4. run ~/src/installer/data/mysql/updatedatabase.pl 5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 6. Apply the annex 1 to the "Amount" field 7. When paying a fine (cgi-bin/koha/members/paycollect.pl) 8. Click on "Pay amount" to go to the page to pay all fines 9. Apply the annex 1 to the "Collect from patron" field 10. Click on "Pay" to go to the page to pay fine 11. Apply the annex 1 to the "Collect from patron" field 12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 13. Apply the annex 1 to the "Amount" field 14. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. (and prevent me from having bounty on my head) 15. Express your happiness. This is important, otherwise the sign off spell won't work! The details of expressing your happiness depend on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. What follows is just a list of examples. They don't have to be tried on each field. 6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" 7. Same with "EUR 12.34" -> "12.34" 8. "EUR 12.34?hi lyonthree" -> "12.34" 9. "123 456,7" -> "123456.7" 10. "2" -> "2" 11. "2,0" -> "2.0" 12. "-1'345.95" -> "-1345.95" 13. ",1234" -> ".1234" 14. Set DecimalSeparators syspref to "," 15. Reload the page with the form 16. "1.000" -> "1000" 17. "1.000.000,10" -> "1000000.10" 18. Set DecimalSeparators syspref to "." 19. Reload the page with the form 20. "1,000" -> "1000" 21. "1,000,000.10" -> "1000000.10" 22. Validate the form and check that the final value with the dot was well handled. 23. Think about Koalas and smile. ??? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 10:16:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 08:16:02 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Josef Moravec --- (In reply to Alex Arnaud from comment #51) > (In reply to Josef Moravec from comment #49) > > (In reply to Alex Arnaud from comment #46) > > > (In reply to Josef Moravec from comment #44) > > > > Comment on attachment 70336 [details] [review] [review] [review] [review] > > > > Bug 17656 - Update irregularities on subscription renewals > > > > > > > > Review of attachment 70336 [details] [review] [review] [review] [review]: > > > > ----------------------------------------------------------------- > > > > > > > > > > > > Better to add new subs just to Koha namespace... but I understand it here - > > > > we do not have all the objects needed for serials management (frequencies > > > > and number patterns are missing) and calling C4 subs from Koha namespace is > > > > not good idea... If you are not willing to add needed objects, we could just > > > > fill a bug for now... > > > > > > Don't understand. You mean create Koha::Subscription->GuessEnddate? > > > > Yes, that is what I ment. > > I see one obstacle. GuessEnddate is used with the subscription's data itself > in subscription-renew.pl and with data coming from the html form in > subscription-add.pl. So method calls will be: > > $subscription_object->GuessEnddate() in the first case, > and > $subscription_object->GuessEnddate($firstacquidate, $periodicity, ...) in > the second one > > Quite tricky no? Not that tricky I think, you should use it like this: my $subscription_object = Koha::Subscription->new( { firstacquidate => "....", periodicity => "....", ... }); my $enddate = $subscription_object->guess_end_date; the call is always the same. It doesn't matter if it is in the database or not. If you wan't to save it to db, use ->store, but it is not an obligation. Also, please consider to change ->irregularities and ->permanent_irregularities to be getter and setter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 10:16:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 08:16:41 +0000 Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #55 from Josef Moravec --- It also will need rebase again, sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 10:54:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 08:54:32 +0000 Subject: [Koha-bugs] [Bug 18820] The different parts in the main don't automatically adjust with the available space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73509|0 |1 is obsolete| | --- Comment #25 from Nicolas Legrand --- Created attachment 73547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73547&action=edit Bug 18820: Main block size now adjust to OpacNavRight like it would for opacuserlogin Test plans : - "beforepatch.png" shows the result you get when OpacNavRight and opacnav are set to false. - "opacuserlogin=f_opacnav=f.png" shows the result with the patch and OpacNavRight and opacnav set to false - "opacuserlogin=t_opacnav=f.png" shows the result with the patch and OpacNavRight set to true and opacnav set to false Applied patch, can confirm it functions as expected. Signed-off-by: Dilan Johnpull? Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 11:53:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 09:53:15 +0000 Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:37:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 10:37:27 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70735|0 |1 is obsolete| | Attachment #70736|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 73548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73548&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL 9 - Verify results come out as expected Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:39:26 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 10:39:26 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #14 from Nick Clemens --- Needs to be rebased on bug 20052 - adding get_prepped_report method to Koha/Report.pm and covering with tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:42:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 10:42:13 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 --- Comment #15 from Nick Clemens --- (In reply to Nick Clemens from comment #14) > Needs to be rebased on bug 20052 - adding get_prepped_report method to > Koha/Report.pm and covering with tests Nvm, I didn't add this method - will be a future enh, but out of scope here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:43:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 10:43:38 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:43:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 10:43:42 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73548|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 73549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73549&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL 9 - Verify results come out as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:47:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 10:47:52 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows release notes| |parameters to be re-used in | |reports. When a report asks | |for two variables using the | |same name and | |type/authorised value they | |will be combined into a | |single rquest. i.e. | | | |SELECT | |* | |FROM items | |WHERE | |homebranch=<> AND | |holdingbranch=<> AND itype=<> | | | |Will ask | |for only 2 parameters when | |run, Branchcode and Item | |type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:12:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:12:18 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:12:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:12:27 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 --- Comment #13 from Kyle M Hall --- Created attachment 73551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73551&action=edit Bug 20467 [QA Followup] - Filter barcodes, Remove selector code as batch changes cannot have a previous selection, use template plugins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:12:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:12:20 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73239|0 |1 is obsolete| | Attachment #73453|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 73550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73550&action=edit Bug 20467 [QA Followup]: Add Branches plugin to template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:13:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:13:04 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73239|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:16:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:16:06 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:16:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:16:12 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:18:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:18:28 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #31 from Josef Moravec --- Comment on attachment 72755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72755 Bug 19935: Replace GetPendingIssues - Discharges Review of attachment 72755: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19935&attachment=72755) ----------------------------------------------------------------- ::: Koha/Patron/Discharge.pm @@ +9,4 @@ > > use Koha::Database; > use Koha::DateUtils qw( dt_from_string output_pref ); > +use Koha::Checkouts; should remain Koha::Patrons @@ +35,5 @@ > > + my $patron = Koha::Patrons->find( $params->{borrowernumber} ); > + return unless $patron; > + > + my $has_pending_checkouts = $patron->pending_checkouts->count; shouldn't it be this? As said in commit message? $patron->checkouts->count; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:19:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:19:09 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #32 from Josef Moravec --- Comment on attachment 72756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72756 Bug 19935: Replace GetPendingIssues - deletemem.pl Review of attachment 72756: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19935&attachment=72756) ----------------------------------------------------------------- ::: members/deletemem.pl @@ +77,2 @@ > my $charges = $patron->account->non_issues_charges; > +my $countissues = $patron->pending_checkouts->count; $patron->checkouts->count; should be enough as said in commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:34:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:34:40 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #33 from Josef Moravec --- Comment on attachment 72759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72759 Bug 19935: Replace GetPendingIssues - opac-user.pl Review of attachment 72759: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19935&attachment=72759) ----------------------------------------------------------------- ::: opac/opac-user.pl @@ +180,4 @@ > my @overdues; > my @issuedat; > my $itemtypes = { map { $_->{itemtype} => $_ } @{ Koha::ItemTypes->search_with_localization->unblessed } }; > +my $pending_checkouts = $patron->pending_checkouts({}, { order_by => [ { -desc => 'date_due' }, { -asc => 'issue_id' } ] }); I think it should be $patron->pending_checkouts->search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 13:36:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 11:36:52 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #18 from Kyle M Hall --- (In reply to M. Tompsett from comment #17) > Comment on attachment 73186 [details] [review] > Bug 19066 - Add branchcode to accountlines > > Review of attachment 73186 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Account.pm > @@ +76,4 @@ > > my $account_type = $params->{account_type}; > > my $offset_type = $params->{offset_type} || $type eq 'writeoff' ? 'Writeoff' : 'Payment'; > > > > + $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef; > > why not below the $userenv below? Less referencing, shorter line, and easier > to read. :) I'm not sure what you are referencing? Can you point me to the line numbers? Or if you'd rather submit a patch I'd be happy to sign it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:00:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:00:02 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #34 from Josef Moravec --- > Created attachment 72761 [details] [review] > Bug 19935: Replace GetPendingIssues - SIP > > Sounds like we do not need related fields or 'overdue' flag here. > No idea how to confirm there is no regression here. > Reading through the code, it even looks like we don? need more then barcode... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:01:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:01:17 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:23:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:23:06 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72764|0 |1 is obsolete| | Attachment #72765|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 73552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73552&action=edit Bug 19926: Add the Koha::Object->unblessed_all_relateds method In order to refactor our legacy code step-by-step, we will need to provide code with the exact same behaviors and then improve it. The same idea appears for the TT syntax for notices: we will want to deprecate the existing syntax in order to support only one syntax. Currently we fetch all the values from the related tables, without knowing which are actually used. I am suggestion to introduce a Koha::Object->unblessed_all_relateds method which will return a hash containing all the fields from the related tables (with the problems we know: collision in column names). It is the existing behavior of GetOverduesForPatron and GetPendingIssues for instance, they are used to send notices and so we have to provide all the data needed. See dependent bugs to understand the context and test this patch. Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:23:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:23:04 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:23:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:23:09 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 --- Comment #7 from Josef Moravec --- Created attachment 73553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73553&action=edit Bug 19926: Add tests for Koha::Object->unblessed_all_relateds Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:33:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:33:09 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:35:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:35:31 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:35:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:35:33 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72769|0 |1 is obsolete| | Attachment #72770|0 |1 is obsolete| | --- Comment #18 from Josef Moravec --- Created attachment 73554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73554&action=edit Bug 17553: Move existing tests Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:35:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:35:37 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 --- Comment #19 from Josef Moravec --- Created attachment 73555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73555&action=edit Bug 17553: Move GetOverduesForPatron to Koha::Patron->get_overdues With the help of Koha::Object->unblessed_all_relateds we are going to replace GetOverduesForPatron without introducing regressions (hopefully) on both template notice syntaxes. Test plan: 0/ Do not apply any patches 1/ Check some items in to a given patron, with and without overdues. 2/ Print the overdues slip (Circulation module > Print > Print overdues) 3/ Apply these patches 4/ Print again and compare the result => The 2 generated slips must be exactly the same Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:35:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:35:41 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 --- Comment #20 from Josef Moravec --- Created attachment 73556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73556&action=edit Bug 17553: (Folow-up) Adjust number of tests Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:53:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:53:24 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #31 from Kyle M Hall --- (In reply to Katrin Fischer from comment #29) > I like the idea of a wiki page with information on how this will work and > where the limits might be. Do you need to change MySQL configuration as well > or is the koha-conf variable enough? As Tomas wrote, the koha conf is the only place the timezone will need set. Any entry in the Time Zone Database can be used. It would be a pretty short wiki page, but I can put it up if you want it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:54:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:54:39 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:54:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:54:42 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72752|0 |1 is obsolete| | Attachment #72753|0 |1 is obsolete| | Attachment #72754|0 |1 is obsolete| | Attachment #72755|0 |1 is obsolete| | Attachment #72756|0 |1 is obsolete| | Attachment #72757|0 |1 is obsolete| | Attachment #72758|0 |1 is obsolete| | Attachment #72759|0 |1 is obsolete| | Attachment #72760|0 |1 is obsolete| | Attachment #72761|0 |1 is obsolete| | Attachment #72762|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart --- Created attachment 73557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73557&action=edit Bug 19935: Add Koha::Patron->pending_checkouts To move this subroutine out of the C4 namespace we face the same problematic as bug 17553 (with GetOverduesForPatron). We need to provide an equivalent method and so return all the related value for a given checkout. We can acchieve the easily using Koha::Object->unblessed_all_relateds, but we need to keep in mind that it is a temporary move. Indeed we will want to use our API to only access/retrive values we really need. The whole trick could be removed when the current syntax for notices will be deprecated and removed. Note: this method returns the same number of elements than ->checkouts They indeed returns the same things, but it sounds better to me to have a different method to highlight (from the callers) where does it come from (C4::Members::GetPendingIssues). Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:54:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:54:46 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #36 from Jonathan Druart --- Created attachment 73558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73558&action=edit Bug 19935: Replace GetPendingIssues - IssueSlip Luckily we have a good test coverage here! Test plan: Print issue slips before and after these patches (with overdues, etc.) They should be the same. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:54:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:54:50 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #37 from Jonathan Druart --- Created attachment 73559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73559&action=edit Bug 19935: Replace GetPendingIssues - ILSDI Here we should only access to what we want in the template, but let do it as it for now. Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1 With 42 a borrowernumber with checkouts Before and after these patches the XML must be the same Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:54:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:54:54 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #38 from Jonathan Druart --- Created attachment 73560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73560&action=edit Bug 19935: Replace GetPendingIssues - Discharges We should actually use Koha::Patron->checkouts here to avoid the prefetch. Test plan: A patron with checkouts cannot get a discharge Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:54:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:54:57 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #39 from Jonathan Druart --- Created attachment 73561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73561&action=edit Bug 19935: Replace GetPendingIssues - deletemem.pl Same as previously, we just want Koha::Patron->checkouts->count to know if a patron has checkouts. Test plan: Confirm that you cannot delete a patron's card if they have pending checkouts Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:55:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:55:01 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #40 from Jonathan Druart --- Created attachment 73562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73562&action=edit Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:55:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:55:05 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #41 from Jonathan Druart --- Created attachment 73563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73563&action=edit Bug 19935: Replace GetPendingIssues - opac-ics.pl We only need the biblio title and the barcode, we should not need the whole prefetch. Test plan: On your OPAC summary page export your checkout list using the "Download as iCal/.ics file" link. Before and after the patchset, the generated files must be the same Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:55:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:55:09 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #42 from Jonathan Druart --- Created attachment 73564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73564&action=edit Bug 19935: Replace GetPendingIssues - opac-user.pl At first glance we just need the biblio title and the subtitle (in addition of the fines info), we should not need the prefetch. Test plan: Loggin at the OPAC, on the summary page you should see your checkouts and overdues with the correct values Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:55:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:55:12 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #43 from Jonathan Druart --- Created attachment 73565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73565&action=edit Bug 19935: Replace GetPendingIssues - sco-main Same as previously, we do not need all the prefetched values here, just a few. Test plan: Use the self checkout module to check some items out Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:55:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:55:16 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #44 from Jonathan Druart --- Created attachment 73566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73566&action=edit Bug 19935: Replace GetPendingIssues - SIP Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:55:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:55:21 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #45 from Jonathan Druart --- Created attachment 73567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73567&action=edit Bug 19935: Replace GetPendingIssues - Remove the residue Here we are, no more occurrences of GetPendingIssues, we can remove the tests and subroutine \o/ Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:55:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:55:25 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #46 from Jonathan Druart --- Created attachment 73568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73568&action=edit Bug 19935: Use ->checkouts when ->pending_checkouts->count was used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:55:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:55:29 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #47 from Jonathan Druart --- Created attachment 73569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73569&action=edit Bug 19935: (follow-up) Replace GetPendingIssues - opac-user.pl Syntax issue, can be squashed on pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 14:57:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 12:57:07 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #32 from Katrin Fischer --- Maybe a note that cronjobs might need to be set up to run at different times for each instance? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:04:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:04:50 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #33 from Kyle M Hall --- (In reply to Katrin Fischer from comment #32) > Maybe a note that cronjobs might need to be set up to run at different times > for each instance? Where would you like that note to be? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:06:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:06:08 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #34 from Katrin Fischer --- I was thinking on the wiki page :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:12:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:12:29 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 --- Comment #5 from Kyle M Hall --- (In reply to Katrin Fischer from comment #4) > We could keep the preference and use it to switch between the date being set > automatically and being able to change it. Would that work? Yes, I think that's a good idea. Bookdrop mode should find the last date open and recalculate the fine in full from there. That way it looks the same from a user perspective. Right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:15 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:18 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73557|0 |1 is obsolete| | Attachment #73558|0 |1 is obsolete| | Attachment #73559|0 |1 is obsolete| | Attachment #73560|0 |1 is obsolete| | Attachment #73561|0 |1 is obsolete| | Attachment #73562|0 |1 is obsolete| | Attachment #73563|0 |1 is obsolete| | Attachment #73564|0 |1 is obsolete| | Attachment #73565|0 |1 is obsolete| | Attachment #73566|0 |1 is obsolete| | Attachment #73567|0 |1 is obsolete| | Attachment #73568|0 |1 is obsolete| | Attachment #73569|0 |1 is obsolete| | --- Comment #48 from Josef Moravec --- Created attachment 73570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73570&action=edit Bug 19935: Add Koha::Patron->pending_checkouts To move this subroutine out of the C4 namespace we face the same problematic as bug 17553 (with GetOverduesForPatron). We need to provide an equivalent method and so return all the related value for a given checkout. We can acchieve the easily using Koha::Object->unblessed_all_relateds, but we need to keep in mind that it is a temporary move. Indeed we will want to use our API to only access/retrive values we really need. The whole trick could be removed when the current syntax for notices will be deprecated and removed. Note: this method returns the same number of elements than ->checkouts They indeed returns the same things, but it sounds better to me to have a different method to highlight (from the callers) where does it come from (C4::Members::GetPendingIssues). Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:22 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #49 from Josef Moravec --- Created attachment 73571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73571&action=edit Bug 19935: Replace GetPendingIssues - IssueSlip Luckily we have a good test coverage here! Test plan: Print issue slips before and after these patches (with overdues, etc.) They should be the same. Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:25 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #50 from Josef Moravec --- Created attachment 73572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73572&action=edit Bug 19935: Replace GetPendingIssues - ILSDI Here we should only access to what we want in the template, but let do it as it for now. Test plan: Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=542&show_contact=0&show_loans=1 With 42 a borrowernumber with checkouts Before and after these patches the XML must be the same Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:32 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #52 from Josef Moravec --- Created attachment 73574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73574&action=edit Bug 19935: Replace GetPendingIssues - deletemem.pl Same as previously, we just want Koha::Patron->checkouts->count to know if a patron has checkouts. Test plan: Confirm that you cannot delete a patron's card if they have pending checkouts Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:29 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #51 from Josef Moravec --- Created attachment 73573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73573&action=edit Bug 19935: Replace GetPendingIssues - Discharges We should actually use Koha::Patron->checkouts here to avoid the prefetch. Test plan: A patron with checkouts cannot get a discharge Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:36 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #53 from Josef Moravec --- Created attachment 73575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73575&action=edit Bug 19935: Replace GetPendingIssues - summary-print We are in the notices part, so we need to fetch all the data to avoid regressions. Test plan: Print a summary slip before and after this patch. They must be the same Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:40 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #54 from Josef Moravec --- Created attachment 73576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73576&action=edit Bug 19935: Replace GetPendingIssues - opac-ics.pl We only need the biblio title and the barcode, we should not need the whole prefetch. Test plan: On your OPAC summary page export your checkout list using the "Download as iCal/.ics file" link. Before and after the patchset, the generated files must be the same Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:44 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #55 from Josef Moravec --- Created attachment 73577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73577&action=edit Bug 19935: Replace GetPendingIssues - opac-user.pl At first glance we just need the biblio title and the subtitle (in addition of the fines info), we should not need the prefetch. Test plan: Loggin at the OPAC, on the summary page you should see your checkouts and overdues with the correct values Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:49 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #56 from Josef Moravec --- Created attachment 73578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73578&action=edit Bug 19935: Replace GetPendingIssues - sco-main Same as previously, we do not need all the prefetched values here, just a few. Test plan: Use the self checkout module to check some items out Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:53 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #57 from Josef Moravec --- Created attachment 73579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73579&action=edit Bug 19935: Replace GetPendingIssues - SIP Sounds like we do not need related fields or 'overdue' flag here. No idea how to confirm there is no regression here. Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:13:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:13:56 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #58 from Josef Moravec --- Created attachment 73580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73580&action=edit Bug 19935: Replace GetPendingIssues - Remove the residue Here we are, no more occurrences of GetPendingIssues, we can remove the tests and subroutine \o/ Signed-off-by: Benjamin Rokseth Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:14:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:14:00 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #59 from Josef Moravec --- Created attachment 73581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73581&action=edit Bug 19935: Use ->checkouts when ->pending_checkouts->count was used Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:14:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:14:03 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 --- Comment #60 from Josef Moravec --- Created attachment 73582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73582&action=edit Bug 19935: (follow-up) Replace GetPendingIssues - opac-user.pl Syntax issue, can be squashed on pushing. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:15:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:15:17 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:15:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:15:21 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73283|0 |1 is obsolete| | Attachment #73284|0 |1 is obsolete| | --- Comment #66 from Kyle M Hall --- Created attachment 73583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73583&action=edit Bug 14570 - Make it possible to add multiple guarantors to a record This patch adds the ability to set an unlimited number of guarantors for a given patron. As before, each guarantor may be linked to another Koha patron, and all the behavior that applies to a given guarantor remains the same. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Find some patrons with guarantors, verify the still have their guarantor 4) Test adding and removing guarantors on a patron record, both Koha users and not 5) Verify the "Add child" button works 6) Verify NoIssuesChargeGuarantees still works 7) Verify tools/cleanborrowers.pl will not delete a guarantor 8) Verify the guarantors are displayed on moremember.pl 9) Verify the guarantor is removed by members/update-child.pl 10) Verify the guarantor is removed by misc/cronjobs/j2a.pl 11) Verify import patrons converts guarantor_id, relationship, contactfirstname, and contactsurname into a guarantor 12) prove t/Patron.t 13) prove t/db_dependent/Circulation.t 14) prove t/db_dependent/Circulation/NoIssuesChargeGuarantees.t 15) prove t/db_dependent/Items.t 16) prove t/db_dependent/Koha/Patrons.t 17) prove t/db_dependent/Members.t 18) prove t/db_dependent/Patron/Relationships.t Signed-off-by: Kim Peine Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:15:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:15:29 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #67 from Kyle M Hall --- Created attachment 73584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73584&action=edit Bug 14570 - Update Schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:25:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:25:41 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:25:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:25:45 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68991|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 73585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73585&action=edit Bug 19578: Remove MARC punctuation in notices (TT syntax) Jenkins fails (run 287) on a test in t/db_dependent/Letters/TemplateToolkit.t: With the historical syntax: # Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been canceled for the following reason: With the TT syntax: # Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has been canceled for the following reason: The last character of the biblio's title has been removed because it's a punctuation character. It comes from: C4::Letters::_parseletter 893 $val =~ s/\p{P}$// if $val && $table=~/biblio/; The same replacement is done for patron's attributes too. Test plan: - Confirm that the new tests pass. That should be enough to confirm this change make sense. Test plan (manual): - Create a biblio with a title ending with a punctuation (like "with_punctuation_"), or any other fields of biblio/biblioitem - Generate a notice which will display this field (CHECKIN for instance) Use the historical syntax and the TT syntax, both should display the title without the punctuation character at the end CHECKIN historical: The following items have been checked in: ---- <> ---- CHECKIN TT syntax: The following items have been checked in: ---- [% biblio.title %] ---- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:27:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:27:40 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 --- Comment #15 from Jonathan Druart --- Katrin, sorry I have forgotten to add the new file (TT plugin) for the patch. I have also fixed the POD issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 15:50:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 13:50:45 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 16:29:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 14:29:59 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #408 from Jonathan Druart --- Created attachment 73586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73586&action=edit Bug 7143: Update about page for new releases -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 16:30:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 14:30:09 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #409 from Jonathan Druart --- Created attachment 73587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73587&action=edit Bug 7143: Update about page for new dev - Philippe Audet-Fortin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 16:30:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 14:30:18 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #410 from Jonathan Druart --- Created attachment 73588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73588&action=edit Bug 7143: Update about page for new dev - Roch D'Amour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 16:49:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 14:49:30 +0000 Subject: [Koha-bugs] [Bug 19926] Add the Koha::Object->unblessed_all_relateds method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19926 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 16:49:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 14:49:35 +0000 Subject: [Koha-bugs] [Bug 19935] Move C4::Members::GetPendingIssues to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19935 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #61 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 16:49:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 14:49:24 +0000 Subject: [Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 16:56:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 14:56:33 +0000 Subject: [Koha-bugs] [Bug 19687] Recent upgrade to 17.05.04.000 bulkmarcimport started to fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19687 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 17:10:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 15:10:46 +0000 Subject: [Koha-bugs] [Bug 20511] New: Seasonal prediction just in the staff language Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Bug ID: 20511 Summary: Seasonal prediction just in the staff language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The seasonal (season, day and monthn) prediction it doens't change according the locale defined in the patterns, the pattern uses always the language of the staff user interface. If you create a pattern with staff user language in spanish, it doesn't matter you configure the locale.. the serialq it will be in spanish. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 20:02:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 18:02:55 +0000 Subject: [Koha-bugs] [Bug 20260] Use CodeMirror for the SQL reports editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 20:43:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 18:43:10 +0000 Subject: [Koha-bugs] [Bug 20512] New: Add a second sort possibility in a public list Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20512 Bug ID: 20512 Summary: Add a second sort possibility in a public list Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: patrick.robitaille at collecto.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi, when you sort a public list by call number at the intranet, the documents how has a Lc and a DDC code are placed at the top of the list. to recreate this problem 1) creat a public list with records who have two classifications. 2) Add somes records with only one classification and who would rank before works with two classifications. 2) Sort thi new list by call number. You will notice that the records with tow classificaton codes are at the top of the list It would be greate if we can add the possibility too do a second sort by classification code. Thanks, Patrick. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 20:54:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 18:54:25 +0000 Subject: [Koha-bugs] [Bug 20513] New: Make output_with_http_headers support CSV output Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20513 Bug ID: 20513 Summary: Make output_with_http_headers support CSV output Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org There's no apparent reason for not providing a good set of request headers by default for CSV responses. It would prevent problems and ease developemnt. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 20:54:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 18:54:48 +0000 Subject: [Koha-bugs] [Bug 19223] Help plugin authors output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #15 from Kyle M Hall --- https://github.com/bywatersolutions/koha-plugin-kitchen-sink/commit/b975bb9b8fa981c3c10d3829d8bc3388fb79864a -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 20:56:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 18:56:54 +0000 Subject: [Koha-bugs] [Bug 19223] Help plugin authors output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 20:56:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 18:56:57 +0000 Subject: [Koha-bugs] [Bug 19223] Help plugin authors output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73512|0 |1 is obsolete| | Attachment #73513|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 73589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73589&action=edit Bug 19223: Unit tests for output and output_html methods Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 20:57:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 18:57:04 +0000 Subject: [Koha-bugs] [Bug 19223] Help plugin authors output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 --- Comment #17 from Kyle M Hall --- Created attachment 73590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73590&action=edit Bug 19223: Add methods to correctly handle plugin-generated output This patch introduces two methods to be used by plugin authors: ->output ->output_html They are basically wrappers for the helper methods from C4::Output (output_html_with_http_headers and output_with_http_headers). Plugin authors can use them, or keep the current flexibility of handling the headers themselves in their code. The KitchenSink plugin should be updated to highlight this. To test: - Run: $ kshell k$ prove t/db_dependent/Plugins.t => FAIL: The methods are not implemented - Apply this patch - Run: k$ prove t/db_dependent/Plugins.t => SUCCESS: Tests pass, and they are meaningful - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 20:57:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 18:57:10 +0000 Subject: [Koha-bugs] [Bug 19223] Help plugin authors output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |kyle at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 21:16:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 19:16:30 +0000 Subject: [Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Tom?s Cohen Arazi --- I think we should tie api id and keys to patrons to take advantage of the current permission system. And introduce the use of scopes at a later stage. Julian: can you do it? i.e. pick the code you once wrote for having patrons create api keys on the staff interface? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 22:02:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 20:02:29 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:02:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:02:19 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to marc subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 --- Comment #45 from Charles Farmer --- Created attachment 73591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73591&action=edit Bug 8643 - Paler yellow and better column order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:26:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:26:50 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:26:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:26:55 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73518|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer --- Created attachment 73592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73592&action=edit Bug 19910 - Use the delimiter syspref to name download link To test: 1 - Set delimiter syspref to anything but comma 2 - Download report results as comma separated text 3 - They actually follow the syspref 4 - Apply patch 5 - Download link should now match pref selection 6 - Change pref, note link changes 7 - Verify things still work as expected Signed-off-by: Owen Leonard Signed-off-by: Victor Grousset Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:29:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:29:27 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #9 from Katrin Fischer --- Just make your changes as a follow-up patch (separate) next time. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:32:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:32:47 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:32:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:32:51 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73515|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer --- Created attachment 73593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73593&action=edit Bug 19953: Record page: acquisition details: add column for invoice Test plan: 1. create a vendor with minimal info 2. create a basket with minimal info 3. add a item to the basket 4. close the basket 5. receive a shipment 6. on the "receipt summary" click on "receive" for the wanted item (it should be the only one) 7. items ? receive? ? tick this checkbox 8. save 9. click on "finish receiving" 10. go to the record ? Acquisition details 11. apply this patch 12. refresh the page 13. you should see the new column Signed-off-by: S?verine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:35:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:35:56 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Manage categories displayed |Manage categories displayed |in Quick_add patron list |in Quick add patron list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:39:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:39:53 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Katrin Fischer --- There is an error in the QA test tools. please fix! FAIL koha-tmpl/intranet-tmpl/prog/en/includes/patron-toolbar.inc OK forbidden patterns OK git manipulation OK spelling OK tt_valid FAIL valid_template The method quick_add_display is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:44:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:44:27 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to marc subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Charles Farmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #46 from Charles Farmer --- Tried again with a fresh database: I could see the 'important' field dialog box ONLY after correcting every mandatory field warnings. I don't have much cues to give otherwise. It could either be a javascript problem, or a forgotten atomicupdate? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 23:56:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Apr 2018 21:56:49 +0000 Subject: [Koha-bugs] [Bug 20514] New: Searching for a patron using the search field (street address) returns no results if inputting a address stored in multiple db fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20514 Bug ID: 20514 Summary: Searching for a patron using the search field (street address) returns no results if inputting a address stored in multiple db fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: alexbuckley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If inputting a street address of street number and street name which are stored in different db fields (e.g. 'streetnumber' and 'address') this does not return patron results. If however the street number and name are stored in the same db field then results are returned for your search query. At present the only way to search with the search field of address is to either enter ONLY a streetnumber OR a street name unless they are both stored in the same db field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 04:04:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 02:04:01 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 --- Comment #22 from M. Tompsett --- Created attachment 73594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73594&action=edit Bug 11674: Configuration for MARC field doc URLs Add a new system preference MarcFieldDocURL. Setting it to some URL will make all the MARC documentation links point to that in the MARC edit UI. Leaving the value empty will use the old defaults (http://loc.gov for MARC21 and http://archive.ifla.org for UNIMARC). There are some possible substitutions usable in the URL: - {MARC} is replaced with either "MARC21" or "UNIMARC" - {FIELD} is replaced by the MARC field number, eg. "000", "048", ... - {LANG} is replaced by the UI language, eg. "en", or "fi-FI" To test: 1) Go to Cataloguing > New record 2) Clicking on the question mark links in the MARC edit will open a window to either loc.gov or archive.ifla.org 3) Install patch, run updatedatabase, etc 4) Redo parts 1, and 2. 5) Set the value of MarcFieldDocURL to http://example.com/?field={FIELD}&marc={MARC}&lang={LANG} 6) Redo parts 1 and 2 7) Clicking on the question mark links in the MARC edit will open a window to example.com, with the proper substitutions in the URL for the field, marc flavour and language Signed-off-by: Pasi Kallinen Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 04:03:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 02:03:58 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 04:04:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 02:04:35 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71108|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 04:07:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 02:07:38 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #19 from M. Tompsett --- Created attachment 73595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73595&action=edit Bug 19066: Follow up to reduce C4::Context references -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 07:24:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 05:24:55 +0000 Subject: [Koha-bugs] [Bug 20511] Seasonal prediction just in the staff language In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20511 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I can confirm this behaviour on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 07:42:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 05:42:15 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |josef.moravec at gmail.com --- Comment #46 from Josef Moravec --- Sorry, could you rebase please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 07:46:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 05:46:05 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 07:46:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 05:46:09 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73585|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 73596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73596&action=edit Bug 19578: Remove MARC punctuation in notices (TT syntax) Jenkins fails (run 287) on a test in t/db_dependent/Letters/TemplateToolkit.t: With the historical syntax: # Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been canceled for the following reason: With the TT syntax: # Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has been canceled for the following reason: The last character of the biblio's title has been removed because it's a punctuation character. It comes from: C4::Letters::_parseletter 893 $val =~ s/\p{P}$// if $val && $table=~/biblio/; The same replacement is done for patron's attributes too. Test plan: - Confirm that the new tests pass. That should be enough to confirm this change make sense. Test plan (manual): - Create a biblio with a title ending with a punctuation (like "with_punctuation_"), or any other fields of biblio/biblioitem - Generate a notice which will display this field (CHECKIN for instance) Use the historical syntax and the TT syntax, both should display the title without the punctuation character at the end CHECKIN historical: The following items have been checked in: ---- <> ---- CHECKIN TT syntax: The following items have been checked in: ---- [% biblio.title %] ---- Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 07:56:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 05:56:50 +0000 Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #57 from Katrin Fischer --- Hi Srdjan, QA tests pass, but there is definitely a problem with the checkouts - it claimes I have none now, when I have indeed 4 items checked out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 08:04:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 06:04:39 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19204 --- Comment #12 from Katrin Fischer --- Some tiny things: - number of tests needs to be 114 for them to pass - the headings at the top and the bottom row of the circulation rules table don't match up - Maybe rename "Fine day charging interval" to "Suspension charging interval" to match a bit more with the other related columns? - Adding a see also for bug 19204 - it's obvious here too, that calendar is ignored. Can you provide a quick follow up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 08:04:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 06:04:39 +0000 Subject: [Koha-bugs] [Bug 19204] Fines in days restriction calculation is not taking calender into account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19804 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 08:07:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 06:07:43 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #29 from Katrin Fischer --- Neither the third patch alone nor all of them together apply. Can you please rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 08:32:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 06:32:09 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #31 from Ere Maijala --- I'm working on it now. Looks like there may be a typo in the atomic update. I got the following error: updatedatabase.pl: DBD::mysql::db do failed: Can't DROP FOREIGN KEY `deletedbiblio_metadata_fk_1`; check that it exists [for Statement "ALTER TABLE deletedbiblio_metadata DROP FOREIGN KEY deletedbiblio_metadata_fk_1"] at (eval 1389) line 8. Looking at the old kohastructure.sql I believe it should have tried to drop 'deletedrecord_metadata_fk_1'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 08:53:19 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 06:53:19 +0000 Subject: [Koha-bugs] [Bug 13324] [DEPENDS_ON_13321] The fund values must be based on tax included values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #21 from David Cook --- Maybe I'm missing something but for an upgraded Koha... the only place I'm seeing prices include GST is on acqui-home.pl. Everywhere else is excluding GST, which makes for some rather inconsistent displays. Still pulling the string on this one, but in 17.05.03 the ordered.pl and spent.pl pages (which are reached via acqui-home.pl) don't include GST. The order page doesn't show GST... although I think that is perhaps based on vendor settings. The basket doesn't show GST unlss "Show all details" is selected... Of course, regardless of vendor configuration, you'd need to have a consistent display at a high level, since you'd be aggregating many vendors with different settings... But it would be good to have a budgeted cost because GST included/excluded arbitrarily seems to throw out the budgets... Anyway, looking at this more, but not really seeing this as an improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 08:59:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 06:59:20 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #11 from Victor Grousset/tuxayo --- > Just make your changes as a follow-up patch (separate) next time. :) Got it, two patches wouldn't have looked clean in the history but if two patches are an issue then the maintainer could just squash them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:11:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:11:41 +0000 Subject: [Koha-bugs] [Bug 20402] Implement OAuth2 authentication for REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20402 --- Comment #18 from Julian Maurice --- (In reply to Tom?s Cohen Arazi from comment #17) > I think we should tie api id and keys to patrons to take advantage of the > current permission system. And introduce the use of scopes at a later stage. > > Julian: can you do it? i.e. pick the code you once wrote for having patrons > create api keys on the staff interface? I think it's not needed if you only want to tie an API client with a patron. We could add a xxx in $KOHA_CONF, and act as if that user was authenticated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:18:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:18:49 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #32 from Benjamin Rokseth --- (In reply to Ere Maijala from comment #31) > I'm working on it now. > > > Looks like there may be a typo in the atomic update. I got the following > error: > > updatedatabase.pl: DBD::mysql::db do failed: Can't DROP FOREIGN KEY > `deletedbiblio_metadata_fk_1`; check that it exists [for Statement "ALTER > TABLE deletedbiblio_metadata DROP FOREIGN KEY deletedbiblio_metadata_fk_1"] > at (eval 1389) line 8. > > Looking at the old kohastructure.sql I believe it should have tried to drop > 'deletedrecord_metadata_fk_1'. hmm, sad to say, but no, it's not a typo but db design issues. this commit seems to have added to the confusion: https://github.com/Koha-Community/Koha/commit/739e2e0c5dc26502e195e2cc4c687ababdcaf381 (Bug 17196) and following Bug 18284 you can see that most agree on deleted* tables being a bad idea in the first place. Problem is, kohastructure.sql and updatedatabase.pl is not in sync and libraries having migrated from 16.05 and before would need to delete this foreign key. And this patch is most important for them anyways. I suppose we could add a delete foreign key for both and ignore errors rather than die in the final version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:42:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:42:45 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #12 from Katrin Fischer --- (In reply to Victor Grousset/tuxayo from comment #11) > > Just make your changes as a follow-up patch (separate) next time. :) > > Got it, two patches wouldn't have looked clean in the history but if two > patches are an issue then the maintainer could just squash them. Why would they not have looked clean? It's how we roll :) The general rule is that once a patch has been signed off, you shoud not change the signed patches but add changes as seprate patches. This way the sign-offer and QA can verify the changes and the history is clear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:45:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:45:12 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #33 from Ere Maijala --- Oh, that's a nasty one. But do you even have to drop the constraints to delete the table? I think it's enough to drop the table and all the constraints there would be dropped too, no? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:46:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:46:16 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 --- Comment #13 from Victor Grousset/tuxayo --- > Why would they not have looked clean? It would be like 2/3 of the work in one patch and 1/3 in the other. > It's how we roll :) > The general rule is that once a patch has been signed off, you shoud not change the signed patches but add changes as seprate patches. This way the sign-offer and QA can verify the changes and the history is clear. Thanks for the clarification, it's simpler like that :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:50:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:50:02 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #34 from Ere Maijala --- Created attachment 73597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73597&action=edit Bug 20271 - Use a single pass in the OAI-PMH provider -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:51:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:51:06 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #35 from Ere Maijala --- Changes for the OAI-PMH provider have been attached. I'm really happy to make it so much more simple. Please feel free to rebase or whatever is necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:59:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:59:15 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72089|0 |1 is obsolete| | --- Comment #30 from Ere Maijala --- Created attachment 73598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73598&action=edit Bug 14716: URI-encode URLs in xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14176 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 09:59:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 07:59:56 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 10:00:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 08:00:36 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #31 from Ere Maijala --- Rebased. The last patch alone should apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 10:02:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 08:02:53 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #36 from Benjamin Rokseth --- (In reply to Benjamin Rokseth from comment #32) > (In reply to Ere Maijala from comment #31) > > I'm working on it now. > > > > > > Looks like there may be a typo in the atomic update. I got the following > > error: > > > > updatedatabase.pl: DBD::mysql::db do failed: Can't DROP FOREIGN KEY > > `deletedbiblio_metadata_fk_1`; check that it exists [for Statement "ALTER > > TABLE deletedbiblio_metadata DROP FOREIGN KEY deletedbiblio_metadata_fk_1"] > > at (eval 1389) line 8. > > > > Looking at the old kohastructure.sql I believe it should have tried to drop > > 'deletedrecord_metadata_fk_1'. > > hmm, sad to say, but no, it's not a typo but db design issues. > this commit seems to have added to the confusion: > https://github.com/Koha-Community/Koha/commit/ > 739e2e0c5dc26502e195e2cc4c687ababdcaf381 (Bug 17196) > > and following Bug 18284 you can see that most agree on deleted* tables being > a bad idea in the first place. > > Problem is, kohastructure.sql and updatedatabase.pl is not in sync and > libraries having migrated from 16.05 and before would need to delete this > foreign key. And this patch is most important for them anyways. > > I suppose we could add a delete foreign key for both and ignore errors > rather than die in the final version fail to remember, but probably I put it there because otherwise it complained, perhaps due to the "rename table". the idea was that any leftovers from conflicts should be moved to temporary tables (prepended with _) so that one could check and delete them at convenience I will remove the dies in the atomicupdate and see if it works for us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 10:03:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 08:03:57 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opac-detail.pl -- Series |opac-detail.pl -- Series |link fails when series |link fails when series |title ends with semicolon |title ends with semicolon |preceded by space. |preceded by space -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 10:04:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 08:04:09 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 10:04:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 08:04:31 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45743|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 10:09:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 08:09:23 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #37 from Francesco Rivetti --- (In reply to Benjamin Rokseth from comment #36) > fail to remember, but probably I put it there because otherwise it > complained, perhaps due to the "rename table". the idea was that any > leftovers from conflicts should be moved to temporary tables (prepended with > _) so that one could check and delete them at convenience We had to drop the constraint to avoid the delete on cascade. When we clean up the deletedbiblio andt able, we don't want to drop any items which were left behind because not properly merged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 10:10:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 08:10:55 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #38 from Ere Maijala --- Ok, fair enough. I think Benjamin's proposal of dropping both without die'ing makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 10:11:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 08:11:30 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #204 from Julian Maurice --- test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 11:08:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 09:08:01 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at joensuu.fi --- Comment #17 from paxed --- The manual should first try to be in the currently used UI language, and then whatever other fallbacks there are (with "en" as the last, hardcoded one) or if fallbacks aren't feasible, the non-existing-manual page on koha-community could show something like "The manual does not exist for the language $foo. You can read the [manual in english], or [translate the manual]", with links to the actual manual in english and to the wiki article on how to start translation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 11:14:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 09:14:28 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15003 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 11:14:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 09:14:28 +0000 Subject: [Koha-bugs] [Bug 15003] Help should be a wiki, not translatable via po-files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15003 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19817 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 11:27:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 09:27:36 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at joensuu.fi --- Comment #32 from paxed --- Comment on attachment 73598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73598 Bug 14716: URI-encode URLs in xsl templates. Ere, shouldn't this: + be + -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 11:35:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 09:35:01 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add index from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #9 from Alex Arnaud --- (In reply to Jonathan Druart from comment #8) > 1. What's the point of the JS function valid_line? > I think you should double-check it, it does not do what you expect it to do. > > 2. You are reusing code to duplicate a new mapping but for something else. > You should rename the variables to avoid confusion then. > For instance "search_fields" is not an index name I wanted to reuse the code as much as possible. It is not a problem for to add a js fonction dedicated to duplicate search fields only. > > 3. Bug report's title is wrong, we are not adding/removing indices Right! > > 4. I did not implement that part on the original patch because it's hard to > keep an interface consistent. > For instance: > - create a new search field > => You cannot create a new mapping, you have to save first > - create a new search field, save > => You can delete it. So it you create a mapping using it, you can still > delete it. If you save => kaboom > => If you have a search field already mapped and delete the mapping, you > cannot delete the search field. I see 2 solutions: 1) JS code for validating data when saving and warn the user if there is something inconsistent. May be quite tricky... 2) Submit the form on clicking the "+add" button. There is a disavantage: page is reloaded between each adding. Not confortable for adding many search fields or mapping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 11:41:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 09:41:52 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 11:41:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 09:41:55 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73516|0 |1 is obsolete| | --- Comment #6 from Josef Moravec --- Created attachment 73599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73599&action=edit Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets purge_zero_balance_fees is used in cleanup_database.pl to determine which fees can be cleaned up. It uses a simple SQL query to determine which rows in accountlines need to be removed: 463 my $sth = $dbh->prepare( 464 q{ 465 DELETE FROM accountlines 466 WHERE date < date_sub(curdate(), INTERVAL ? DAY) 467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL ); 468 } The function comes with the following warning: 451 B Because fines and payments are not linked in accountlines, it is 452 possible for a fine to be deleted without the accompanying payment, 453 or vise versa. This won't affect the account balance, but might be 454 confusing to staff. This was a reasonable solution prior to the addition of account_offsets in 17.11. The problem now is that rows in accountlines which are linked as credits in accountlines will *always* have amountoutstanding marked as 0. These are linked to debits via account_offsets. purge_zero_balance_fees will delete credits and leave rows in account_offsets which link to deleted credits. Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may have all of their credits removed without warning. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 11:42:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 09:42:03 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:01:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:01:23 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:01:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:01:25 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73492|0 |1 is obsolete| | --- Comment #8 from S?verine Queune --- Created attachment 73600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73600&action=edit Bug 18316 - Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:01:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:01:28 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 S?verine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73493|0 |1 is obsolete| | --- Comment #9 from S?verine Queune --- Created attachment 73601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73601&action=edit Bug 18316 - Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: S?verine QUEUNE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:02:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:02:43 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #33 from Ere Maijala --- Paxed, yes, indeed. Thanks, I'll fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:15:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:15:53 +0000 Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |josef.moravec at gmail.com --- Comment #6 from Josef Moravec --- Could you rebase please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:28:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:28:16 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:28:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:28:18 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73596|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 73602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73602&action=edit Bug 19578: Remove MARC punctuation in notices (TT syntax) Jenkins fails (run 287) on a test in t/db_dependent/Letters/TemplateToolkit.t: With the historical syntax: # Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been canceled for the following reason: With the TT syntax: # Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has been canceled for the following reason: The last character of the biblio's title has been removed because it's a punctuation character. It comes from: C4::Letters::_parseletter 893 $val =~ s/\p{P}$// if $val && $table=~/biblio/; The same replacement is done for patron's attributes too. Test plan: - Confirm that the new tests pass. That should be enough to confirm this change make sense. Test plan (manual): - Create a biblio with a title ending with a punctuation (like "with_punctuation_"), or any other fields of biblio/biblioitem - Generate a notice which will display this field (CHECKIN for instance) Use the historical syntax and the TT syntax, both should display the title without the punctuation character at the end CHECKIN historical: The following items have been checked in: ---- <> ---- CHECKIN TT syntax: The following items have been checked in: ---- [% biblio.title %] ---- Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:32:15 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:32:15 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73599|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 73603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73603&action=edit Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets purge_zero_balance_fees is used in cleanup_database.pl to determine which fees can be cleaned up. It uses a simple SQL query to determine which rows in accountlines need to be removed: 463 my $sth = $dbh->prepare( 464 q{ 465 DELETE FROM accountlines 466 WHERE date < date_sub(curdate(), INTERVAL ? DAY) 467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL ); 468 } The function comes with the following warning: 451 B Because fines and payments are not linked in accountlines, it is 452 possible for a fine to be deleted without the accompanying payment, 453 or vise versa. This won't affect the account balance, but might be 454 confusing to staff. This was a reasonable solution prior to the addition of account_offsets in 17.11. The problem now is that rows in accountlines which are linked as credits in accountlines will *always* have amountoutstanding marked as 0. These are linked to debits via account_offsets. purge_zero_balance_fees will delete credits and leave rows in account_offsets which link to deleted credits. Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may have all of their credits removed without warning. Test Plan: 1) Apply this patch 2) prove t/db_dependent/Accounts.t Signed-off-by: Katrin Fischer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:36:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:36:30 +0000 Subject: [Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #46 from Josef Moravec --- (In reply to Katrin Fischer from comment #45) > > > > Let [1,2,3,4] be the framework structure > > Let [1,4,2] be the saved record > > > > Currently we load on the framework structure order, giving us > > 1, 2, 3 (empty), 4 > > This does not respect the saved record order. But if we load according do > > the saved record order, where should the empty tag (3) go? Should we place > > it before the saved record's fields or after? Or do some weird half-sorted > > behavior? > > > > before : [3 (empty), 1, 4, 2] > > after : [1, 4, 2, 3 (empty)] > > weird : [1, 3 (empty), 4, 2] > > I'd put the empty ones at the bottom of the list, in alphabetic sequence. +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:36:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:36:44 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #27 from Fridolin SOMERS --- Ah ok its missing a patch for DBIX class files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:41:49 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:41:49 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:41:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:41:53 +0000 Subject: [Koha-bugs] [Bug 18818] Manage categories displayed in Quick add patron list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18818 --- Comment #28 from Fridolin SOMERS --- Created attachment 73604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73604&action=edit Bug 18818: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:45:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:45:34 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #20 from Kyle M Hall --- (In reply to M. Tompsett from comment #19) > Created attachment 73595 [details] [review] > Bug 19066: Follow up to reduce C4::Context references Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:53:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:53:09 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:53:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:53:13 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73598|0 |1 is obsolete| | --- Comment #34 from Ere Maijala --- Created attachment 73605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73605&action=edit Bug 14716: URI-encode URLs in xsl templates. https://bugs.koha-community.org/show_bug.cgi?id=14176 Test plan: 1. Catalog a record with series name "Series & more" 2. Find the record 3. Make sure clicking the "Series & more" link works and the ampersand is properly encoded in the URL. 4. Also try the attached test records and make sure their links work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:54:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:54:54 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #12 from Kyle M Hall --- (In reply to Katrin Fischer from comment #11) > I've tested it and I think it's still a little confusing. > > Right now it is: total of holds / holds on on order items > > Which can lead to the 1 / 0 that Jonathan pointed out. Maybe it would make > more sense to switch the values? Or just show the total number of holds = > record level + item level on on order items? I like the idea of switching the values around. I'll get a followup done asap! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:55:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:55:22 +0000 Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall at gmail.com |ere.maijala at helsinki.fi --- Comment #35 from Ere Maijala --- The bug Paxed noted has been fixed and the patch has been extended to cover all xsl files where I found search links (something with "q=") including UNIMARC and NORMARC. I did my best to test them too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:56:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:56:56 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #13 from Kyle M Hall --- Created attachment 73606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73606&action=edit Bug 19812 [QA Followup] - Swap sides for total and item holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 12:56:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 10:56:53 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:02:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:02:31 +0000 Subject: [Koha-bugs] [Bug 20515] New: "ILL Request" menu options displayed when user has no ILL permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Bug ID: 20515 Summary: "ILL Request" menu options displayed when user has no ILL permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com When the Interlibrary Loans module is enabled the menu option "ILL Requests" is added to the main intranet screen and the "More" dropdown menu. These options are displayed regardless of whether the logged in user has any permissions on this module. They should only be displayed if the user has permissions to work with ILL. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:03:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:03:06 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #14 from Kyle M Hall --- Created attachment 73607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73607&action=edit Bug 19812 [QA Followup] - If 0 holds show '0' not '0 / 0' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:03:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:03:13 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #15 from Kyle M Hall --- Created attachment 73608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73608&action=edit Bug 19812 [QA Followup] - Remove unnecessary line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:17:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:17:21 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73505|0 |1 is obsolete| | --- Comment #9 from Josef Moravec --- Created attachment 73609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73609&action=edit Bug 19267: Rancor - Warn before leaving page if record modified To test: 1 - Open the advanced editor 2 - Make some changes to a record 3 - Click on 'Patrons' or leave the page in some way 4 - Note there is no warning and changes are not saved 5 - Apply patch 6 - Open the advanced editor 7 - Make some changes 8 - Leave the page 9 - Note you get a warning of unsaved changes and can stay on the page Signed-off-by: Charles Farmer Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:17:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:17:18 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:21:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:21:56 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:22:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:22:00 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73027|0 |1 is obsolete| | Attachment #73028|0 |1 is obsolete| | Attachment #73029|0 |1 is obsolete| | Attachment #73030|0 |1 is obsolete| | Attachment #73433|0 |1 is obsolete| | --- Comment #17 from Josef Moravec --- Created attachment 73610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73610&action=edit Bug 20115: Set the languages order with the pref values To avoid the languages to be ordered randomly, it is better to stick on a default order. Let's suppose that the order in the pref is correct. Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:22:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:22:04 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #18 from Josef Moravec --- Created attachment 73611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73611&action=edit Bug 20115: Make the prefs sortable If we depend on the order, we should make it sortable. I let the customization to someone else (we would need an icon to tell the user it's sortable). Something does not work here: If fr-FR and fr-CA is installed, but only 1 is ticked, it will be considered as last. I do not think it's a blocker as it does not make really make sense to have it installed but not used (the interface is also weird, there is a dropdown list with only 1 entry) Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:22:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:22:08 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #19 from Josef Moravec --- Created attachment 73612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73612&action=edit Bug 20115: Trigger "modified" when sort is changed Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:22:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:22:11 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #20 from Josef Moravec --- Created attachment 73613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73613&action=edit Bug 20115: Remove sort on rfc4646_subtag in OPAC templates Signed-off-by: Jesse Maseto Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:22:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:22:16 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 --- Comment #21 from Josef Moravec --- Created attachment 73614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73614&action=edit Bug 20115: Add information about this feature in the pref descriptions I guess a native English speaker will have a better wording :) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:28:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:28:23 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #8 from Josef Moravec --- Comment on attachment 71097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71097 Bug 20116: Prepare the ground Review of attachment 71097: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20116&attachment=71097) ----------------------------------------------------------------- ::: C4/Languages.pm @@ +132,3 @@ > $htdocs = C4::Context->config('opachtdocs'); > + push @languages, _get_intranet_opac_dirs( $htdocs ); > + should be _get_opac_language_dirs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:28:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:28:36 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:32:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:32:10 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #35 from Kyle M Hall --- (In reply to Katrin Fischer from comment #34) > I was thinking on the wiki page :) Sounds good! Here it is: https://wiki.koha-community.org/wiki/Time_Zone_Configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:40:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:40:34 +0000 Subject: [Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 --- Comment #1 from Andrew Isherwood --- Created attachment 73615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73615&action=edit Bug 20515 - "ILL Request" menu options displayed when user has no ILL This patch adds the following additional conditions to the display of both the ILL Requests drop down "More" menu option and the "ILL Requests" option on the intranet front page: Before: [% IF Koha.Preference('ILLModule') %] After: [% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %] This prevents the options being displayed to users who have no permissions to work with ILL. Test plan: View both the intranet front page and "More" dropdown while logged in as a user without ILL permissions, ensure the options do not display. Then do the same with a user with ILL permissions, ensure the options do display. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:48:02 +0000 Subject: [Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 13:48:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 11:48:02 +0000 Subject: [Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:08:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:08:03 +0000 Subject: [Koha-bugs] [Bug 20516] New: Show patron's library in pending discharges table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Bug ID: 20516 Summary: Show patron's library in pending discharges table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:15:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:15:24 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 --- Comment #1 from Julian Maurice --- Created attachment 73616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73616&action=edit Bug 20516: Show patron's library in pending discharges table Test plan: 1. Enable syspref useDischarge 2. Login to OPAC and ask for a discharge (tab on the left) 3. Login to intranet, you should see a message about pending discharges, and a link. Click on the link. 4. Confirm that there is a 'Library' column in the table that is displaying the patron's library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:15:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:15:40 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:34:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:34:46 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Josef Moravec --- Kyle, I still found some issues with this: 1. reported by QA tools, not sure how to fix this..., : FAIL Koha/Old/Checkout.pm FAIL valid merging failed on 'Koha::Checkout' ] Koha::Old::Checkout, current merge results [ Inconsistent hierarchy during C3 merge of class 'Koha::Old::Checkout': 2. This still remains: FAIL Koha/Checkout.pm FAIL pod in file Koha/Checkout.pm Unknown command 'head' *** ERROR: FAIL pod coverage POD is missing for 'library' you should use =head3 I think 3. The code added to Koha/Schema/Result/OldIssue.pm should be after schema loader mark 4. Also, when you make Koha::Checkout base for Koha::Old::Checkout, you should also define relations 'borrower' and 'item' in Koha::Schema::OldIssue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:35:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:35:24 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #62 from Fridolin SOMERS --- Created attachment 73617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73617&action=edit Bug 8962: Changes to CCL.properties, bib1 for authorities, and templates This patch adds a new index Anywhere in ccl.properties in bib1 for authorities, and add "any word" option in intranet search for using this index. Default OPAC and intranet search in still using CCL "Any" index. Testing plan : In a Marc21 GRS-1 Koha : 1/ make some biblio searches without selecting any index (Koha will use "any" index) and note the results. Ex : search "fre", "eng", "book", "history", "history book" 2/ apply the 3 patches 3/ copy the 4 new record.abs files (Marc21 auth, Marc21 bib, Unimarc auth, Unimarc bib) from your sources to the directory used by Zebra configuration in your Koha instance 4/ launch rebuild_zebra.pl -b -r -x -v 5/ check that a new choice "Any word (all indexes)" is visible in advanced search. 6/ make the same searches as 1/ : you should see less results (detailed test plan in patchs 2 and 3) 7/ in Staff interface adavanced search, select "Any word (all indexes)" and make the same searches as 1/ : you should see the same results (maybe with a slight differences, because more notes fields are indexed in Marc21) In a UNIMARC GRS-1 Koha : same test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:35:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:35:42 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70127|0 |1 is obsolete| | --- Comment #63 from Fridolin SOMERS --- Created attachment 73618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73618&action=edit Bug 8962: Restore Any index behavior and add Anywhere index The "Any" index/register should contains all the data contained in all the other indexes/registers (e.g. Title, Author, Subject, etc). The "Anywhere" index/register should contain the entire record including fields/subfields that aren't indexed anywhere else. In GRS1 indexing the Any index was indeed only on fields defined as indexed. This has changed in DOM where all data in MARC is indexed with Any. This generates a lot of results when no index is defined in search. This patch changes the DOM xsl config generation to add Any to each indexed data and add Anywhere to keep a way of searching on all data. Test plan : - Add a data on a field that is not indexed : for example "toto" in 998$z - Add same data as the title of another record - Index the records - Search on toto without index (uses Any) => you get the 2 records - Search on toto with title index => you get the record with "toto" as title - Apply patch - Update DOM xsl config files - Reindex - Search on toto without index (uses Any) => you get the record with "toto" as title - Search on toto with title index => you get the record with "toto" as title - Search on toto with Anywhere index => you get the 2 records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:36:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:36:39 +0000 Subject: [Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #64 from Fridolin SOMERS --- (In reply to Charles Farmer from comment #61) > Unless I'm mistaken, this patch doesn't apply anymore: > > > CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc Indeed. Easy rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:41:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:41:02 +0000 Subject: [Koha-bugs] [Bug 20517] New: Use the "sort bin" field in SIP2 Checkin Response Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Bug ID: 20517 Summary: Use the "sort bin" field in SIP2 Checkin Response Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The SIP2 Checkin Response (10) can have a "variable-length optional field" for "sort bin", labelled "CL". In the description of the SIP2 protocol, this field is described as follows: "sort bin - CL - variable-length field. This field should contain a bin number that indicates how the items should be sorted. The maximum practical number of sort bins for a patron using 3M SelfCheck system is probably only 3 or 4, but many digits are allowed to accommodate some sort of fantastic sorting device using a hierarchical bin numbering scheme." I have a customer who wants to use this field to display messages on the screen of self service machines that tell users to put items in a separate bin based on itemtype, location etc. The idea is to add a syspref that can contain something like this: itemtype:ILL:1 location:CLOSEDSTACKS:2 - The first field is an item field. - The second field is a value to look for in the given item field - The third field is the value given to the CL field in the SIP2 Checkin Response if the value in the second field matches the item on hand. It should also be possible to set the CL field for items that need to be transferred after they have been returned, that is for items that are returned at another library than the homebranch. This will probably be another syspref. If the returned item needs to be transferred to the homebranch, CL is set to the value of the syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:41:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:41:16 +0000 Subject: [Koha-bugs] [Bug 20517] Use the "sort bin" field in SIP2 Checkin Response In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20517 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |magnus at libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:45:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:45:23 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #35 from Josef Moravec --- Why did you added the cleaning of the code in C4/SIP/ILS.pm? It looks OK, but I think it's not related to this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:54:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:54:56 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:54:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:54:59 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71097|0 |1 is obsolete| | Attachment #73521|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 73619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73619&action=edit Bug 20116: Prepare the ground Just refactoring to make the next patch more readable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:55:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:55:03 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #10 from Jonathan Druart --- Created attachment 73620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73620&action=edit Bug 20116: Cache language list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 14:55:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 12:55:31 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #11 from Jonathan Druart --- (In reply to Josef Moravec from comment #8) > Comment on attachment 71097 [details] [review] > Bug 20116: Prepare the ground > > Review of attachment 71097 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Languages.pm > @@ +132,3 @@ > > $htdocs = C4::Context->config('opachtdocs'); > > + push @languages, _get_intranet_opac_dirs( $htdocs ); > > + > > should be _get_opac_language_dirs Erk, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:01:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:01:35 +0000 Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:01:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:01:38 +0000 Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69970|0 |1 is obsolete| | Attachment #69971|0 |1 is obsolete| | Attachment #69972|0 |1 is obsolete| | Attachment #69973|0 |1 is obsolete| | Attachment #69974|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 73621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73621&action=edit Bug 19855: Remove getalert from moremember.pl This is not used later and seems unused since: commit b38997925f603dc9784c25d3db3501644c19e068 Date: Wed Oct 26 09:11:02 2005 +0000 big commit, still breaking things... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:01:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:01:41 +0000 Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 --- Comment #8 from Jonathan Druart --- Created attachment 73622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73622&action=edit Bug 19855: Remove getalert from opac-user.pl This is not used later and seems unused since: commit e61173aa8eb23c111a707eba2cfbd2003df709bf Date: Sun May 21 02:29:09 2006 +0000 syncing dev-week and HEAD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:01:44 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:01:44 +0000 Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 --- Comment #9 from Jonathan Druart --- Created attachment 73623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73623&action=edit Bug 19855: Remove C4::Letters::findrelatedto This subroutine is called only once. It only concat firstname and surname for subscribers. It can be easily replaced with Koha::Patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:01:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:01:48 +0000 Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 --- Comment #10 from Jonathan Druart --- Created attachment 73624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73624&action=edit Bug 19855: Remove $type from the alerts It looks like this feature has never been finished. It has been developed with more flexibility in mind, but only 'issue' is used for this parameter. Apparently it could have been 'virtual', for virtual shelves. Let remove this parameter and clean the code a bit. TODO: Remove the DB column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:01:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:01:52 +0000 Subject: [Koha-bugs] [Bug 19855] Move the "alert" code to Koha::Subscription In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19855 --- Comment #11 from Jonathan Druart --- Created attachment 73625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73625&action=edit Bug 19855: Move getalert, addalert and delalert to Koha::Subscription This patch removes 3 subroutines from C4::Letters: - getalert - addalert - delalert And add 3 methods to Koha::Subscription: - subscribers - add_subscriber - remove_subscriber It makes the code cleaner for future cleanup. TODO - we should remove alert.alertid and alert.type, and rename alert.externalid with alert.subscriptionid That way alert will be renamed borrowers_subscriptions (or similar) and will become a simple join table between borrowers and subscriptions. We will need to deal with FK that could not be satisfied. Let's do that after this patch is pushed. Test plan: Subscribe and unsubscribe to email notifications sent when a new issues is available. Make sure everything works as before and you receive the emails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:07:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:07:10 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 --- Comment #10 from Josef Moravec --- Comment on attachment 72240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72240 Bug 15520: Add permission to restrict circ rules editing to own library Review of attachment 72240: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15520&attachment=72240) ----------------------------------------------------------------- ::: admin/smart-rules.pl @@ +63,5 @@ > + > +my $uid = Koha::Patrons->find( $loggedinuser )->userid; > +my $restricted_to_own_library = $uid && haspermission( $uid, { parameters => 'manage_circ_rules_restricted' }, { no_inherit => 1 } ); > +$template->param( restricted_to_own_library => $restricted_to_own_library ); > +$branch = C4::Context::mybranch() if $restricted_to_own_library; This is not the logged in user's home library, it is the library where the user is logged in now - so when user change library, he/she could change another's library rules! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:07:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:07:25 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:07:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:07:42 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch - Ability to |Elasticsearch - Ability to |add index from UI |add search fields from UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:10:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:10:18 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #11 from Alex Arnaud --- Created attachment 73627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73627&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - you create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (don't save) - check that you can delete this search field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:10:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:10:08 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73476|0 |1 is obsolete| | --- Comment #10 from Alex Arnaud --- Created attachment 73626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73626&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:11:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:11:07 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:14:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:14:29 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:15:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:15:24 +0000 Subject: [Koha-bugs] [Bug 9474] filter overdues with fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marjorie.barry-vila at collect | |o.ca | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:15:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:15:31 +0000 Subject: [Koha-bugs] [Bug 9474] filter overdues with fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:24:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:24:43 +0000 Subject: [Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:47:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:47:38 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72282|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 73628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73628&action=edit Bug 18786: Remove use of Koha::Patron::Images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:48:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:48:14 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 --- Comment #37 from Kyle M Hall --- (In reply to Josef Moravec from comment #35) > Why did you added the cleaning of the code in C4/SIP/ILS.pm? > > It looks OK, but I think it's not related to this report. No idea how the snuck in. This new version of the followup should have that fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:48:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:48:37 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73627|0 |1 is obsolete| | --- Comment #12 from Alex Arnaud --- Created attachment 73629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73629&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authoroties), don't save, - check that you can delete this search field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:49:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:49:00 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:50:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:50:11 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:50:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:50:18 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72141|0 |1 is obsolete| | Attachment #72142|0 |1 is obsolete| | Attachment #72143|0 |1 is obsolete| | Attachment #72144|0 |1 is obsolete| | Attachment #72145|0 |1 is obsolete| | Attachment #72146|0 |1 is obsolete| | Attachment #72147|0 |1 is obsolete| | Attachment #72148|0 |1 is obsolete| | Attachment #72149|0 |1 is obsolete| | Attachment #72150|0 |1 is obsolete| | Attachment #72151|0 |1 is obsolete| | Attachment #72152|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 73630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73630&action=edit Bug 19936: Replace Check_userid - just move the tests This patch moves the tests related to Check_userid out of Members.t The tests must pass with only this patch applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:50:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:50:23 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #48 from Jonathan Druart --- Created attachment 73631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73631&action=edit Bug 19936: Add the Koha::Patron->has_valid_userid method Reuse how C4::Members::Check_Userid works and adapt it to write Koha::Patron->check_userid Adapt the tests to use this new method. The tests still pass, we can adapt the different callers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:50:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:50:28 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #49 from Jonathan Druart --- Created attachment 73632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73632&action=edit Bug 19936: Replace Check_userid - Update the occurrences We previously prove that the method and the subroutine were equivalent, we know update the controller calls. Test plan: - Add and update a patron with different variations of userid (automatically generated or not) - Import patrons with and without userid, as well as with existing userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:50:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:50:34 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #50 from Jonathan Druart --- Created attachment 73633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73633&action=edit Bug 19936: Remove the subroutine Check_Userid It is no longer in user, we can remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:50:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:50:43 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #51 from Jonathan Druart --- Created attachment 73634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73634&action=edit Bug 19936: Move and add tests for Generate_Userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:50:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:50:54 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #53 from Jonathan Druart --- Created attachment 73636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73636&action=edit Bug 19936: Adapt tests And prove that we are not cheating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:50:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:50:48 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #52 from Jonathan Druart --- Created attachment 73635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73635&action=edit Bug 19936: Add the Koha::Patron->generate_userid method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:51:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:51:00 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #54 from Jonathan Druart --- Created attachment 73637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73637&action=edit Bug 19936: Replace Generate_Userid - Update the occurrences Test plan: Same test plan as previous patch: add/update/import patrons and watch the userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:51:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:51:12 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #55 from Jonathan Druart --- Created attachment 73638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73638&action=edit Bug 19936: Remove the subroutine Generate_Userid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:51:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:51:17 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #56 from Jonathan Druart --- Created attachment 73639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73639&action=edit Bug 19936: Remove warnings from tests C4::Members did not "use warnings;" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:51:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:51:23 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #57 from Jonathan Druart --- Created attachment 73640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73640&action=edit Bug 19936: Replace Check_userid - Update the occurrences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 15:51:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 13:51:28 +0000 Subject: [Koha-bugs] [Bug 19936] Move Check_userid and Generate_Userid to Koha::Patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19936 --- Comment #58 from Jonathan Druart --- Created attachment 73641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73641&action=edit Bug 19936: Reuse existing userid if none provided Found this regression when working on other patches: If you edit a patron and blank the userid field, it will be regenerated with an incremented value (firstname.surname will be firstname.surname1) This is because we use a non-existing patron and ->in_storage in has_valid_userid is always false. The trick here is to backup the value, generate the userid, then reset userid to the previous value. As the POD says, it will be fix later, when AddMember and ModMember will be replaced with Koha::Patron->store -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:10:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:10:27 +0000 Subject: [Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:23:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:23:59 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:24:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:24:01 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72652|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 73642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73642&action=edit Bug 20350: Add column configuration to table of saved reports This patch makes changes to the saved reports template to enable a columns configuration button. Settings for the table have been added to columns_settings.yml. To test, apply the patch and go to Reports -> Use saved. - Confirm that there is a "Column visibility" button in the table's pagination toolbar. - Confirm that showing and hiding columns via the button is working correctly. - Confirm that the first, second, and last columns cannot be toggled. Go to Administration -> Columns settings. - Expand the "Reports" section. - Find "id=table_reports." - Make some selections to configure default settings of the reports table. - Return to reports and confirm that these defaults are applied. Signed-off-by: Jesse Maseto -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:25:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:25:43 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 --- Comment #6 from Owen Leonard --- I have rebased the patch and would like to ask QA to look at it. I can't reproduce the errors reported in Comment 4, and I think it may have been a browser cache problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:30:39 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:30:39 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #25 from Tom?s Cohen Arazi --- I tested the patches and they work as expected. Great job! Some remarks: Major: I'd say the ->merge method should execute code wrapped by a transaction. There are risky operations taking place in there. Minor: To my taste, I'd prefer ->merge to be a Koha::Patron method. i.e. no 'keeper' param, as you want to merge the patron list with $self. Also, I'm not sure about borrowernumbers, they could just be Koha::Patron objects passed, and simplify the logic in ->merge. Tests could be placed in t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:33:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:33:28 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #10 from S?verine Queune --- Patchs work as described. I misunderstood the way to use numbers, thinking "1" was the most important field(s) I wanted to search in. Maybe a warning or more detailed description would be useful for reindex can take time for big databases, it would be sad if others make the same mistake as I. This weighting add a lot of relevance to the simple search. In reaction to Gaetan's comment, it also appears that having weight on sub-fields used on the same index would be great. For example, when searching with index "title" in our Unimarc system, we would like to display books that contains the searched word in 200$b before the ones in 410$t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:34:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:34:10 +0000 Subject: [Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This report adds the release notes| |command-line option | |'no-overwrite' so that you | |can add preferences only | |when they are not yet | |present (in other words: | |skip patrons that already | |set their prefs). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:42:40 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:42:40 +0000 Subject: [Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS --- Needs rebase on master. Especially method C4::Koha::GetAuthValCodeFromField has been removed by Bug 17249 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:52:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:52:32 +0000 Subject: [Koha-bugs] [Bug 19752] Improve authentication response in offline_circ/service.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com --- Comment #3 from Matthias Meusburger --- Hi Maksim, service.pl is indeed an intranet page. What do you mean you got nothing? A blank page? Keep in mind that service.pl is meant to be called as a webservice, so it's not abnormal nothing is displayed in the page itself. However, you'll be able to display the HTTP status code using firefox's debug tool (F12 key, then Network tab, then load the page) By the way, I've tested this, and it behaves correctly: I have a 200 error code following the test plan before applying the patch, and a 401 error code with the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:53:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:53:34 +0000 Subject: [Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 16:53:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 14:53:36 +0000 Subject: [Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73615|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 73643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73643&action=edit Bug 20515 - "ILL Request" menu options displayed when user has no ILL This patch adds the following additional conditions to the display of both the ILL Requests drop down "More" menu option and the "ILL Requests" option on the intranet front page: Before: [% IF Koha.Preference('ILLModule') %] After: [% IF Koha.Preference('ILLModule') && (CAN_user_ill || CAN_user_superlibrarian) %] This prevents the options being displayed to users who have no permissions to work with ILL. Test plan: View both the intranet front page and "More" dropdown while logged in as a user without ILL permissions, ensure the options do not display. Then do the same with a user with ILL permissions, ensure the options do display. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:00:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:00:11 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:00:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:00:14 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73616|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 73644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73644&action=edit Bug 20516: Show patron's library in pending discharges table Test plan: 1. Enable syspref useDischarge 2. Login to OPAC and ask for a discharge (tab on the left) 3. Login to intranet, you should see a message about pending discharges, and a link. Click on the link. 4. Confirm that there is a 'Library' column in the table that is displaying the patron's library Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:11:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:11:06 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72082|0 |1 is obsolete| | Attachment #72083|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 73645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73645&action=edit Bug 9302: Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron Signed-off-by: Owen Leonard Signed-off-by: Ed Veal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:11:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:11:14 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #27 from Kyle M Hall --- Created attachment 73646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73646&action=edit Bug 9302 [QA Followup]: Copy merged patrons to deletedborrowers table Signed-off-by: Owen Leonard Signed-off-by: Ed Veal Signed-off-by: BWS Sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:11:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:11:18 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #28 from Kyle M Hall --- Created attachment 73647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73647&action=edit Bug 9302 [QA Followup]: Merge should be a transaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:11:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:11:45 +0000 Subject: [Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #11 from Alex Arnaud --- (In reply to S?verine Queune from comment #10) > Patchs work as described. > > I misunderstood the way to use numbers, thinking "1" was the most important > field(s) I wanted to search in. > Maybe a warning or more detailed description would be useful for reindex can > take time for big databases, it would be sad if others make the same mistake > as I. You mean add a warning to tell users that more the weight is hight more the field is important? > > This weighting add a lot of relevance to the simple search. > > In reaction to Gaetan's comment, it also appears that having weight on > sub-fields used on the same index would be great. > For example, when searching with index "title" in our Unimarc system, we > would like to display books that contains the searched word in 200$b before > the ones in 410$t. I'm not yet confortable enough with all ES capabilities, but it could be done by adding a "other-title" search field with a different weight. Does it make sens for you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:17:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:17:41 +0000 Subject: [Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- But couldn't they change the home library in their records too? I think in general we got a problem there, that you can get around the limits, maybe the logged-in library is more helpful? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:28:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:28:35 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73647|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 73648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73648&action=edit Bug 9302 [QA Followup]: Merge should be a transaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:30:29 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:30:29 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #30 from Kyle M Hall --- Created attachment 73649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73649&action=edit Bug 9302 [QA Followup]: Dumper plugin isn't used -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:47:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:47:21 +0000 Subject: [Koha-bugs] [Bug 19752] Improve authentication response in offline_circ/service.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- I had the FireFox Rester tool installed. On a kohadevbox with Offline Circulation enabled. Something is weird I think with the $lasttime and $timeout check in the function call. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:53:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:53:47 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- --- Comment #16 from Kyle M Hall --- This is still a problem if the html of a notice is malformed. For example, an html notice missing a closing tag or quote can break all the things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:54:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:54:22 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:54:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:54:48 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33876|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:55:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:55:14 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:55:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:55:08 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:56:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:56:13 +0000 Subject: [Koha-bugs] [Bug 20273] Elasticsearch: Auth-finder.pl autocomplete must use search_auth_compat In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20273 --- Comment #6 from Alex Arnaud --- (In reply to Nicolas Legrand from comment #5) > The ysearch.pl use 'contains' operator instead of 'start'. When adjusting > the search form to 'start with', ysearch.pl still launch a 'contains' > operator. It means we need to put a complete word to make it work. > > Is it the wanted behaviour? Wouldn't it be better to put a start operator by > default? When I type three letters and see the wheel spinning without > results, it feels like nothing looks like what I typed. I'm not sure of the right answer, but i'm not upset by that. Operators are used for the search itself, not for autocomplete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 17:59:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 15:59:46 +0000 Subject: [Koha-bugs] [Bug 12123] HTML notices can break the notice viewer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33876|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 73650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73650&action=edit Bug 12123 - HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) :

The following items have been checked out:

----
<>
----

Thank you for visiting the <> of HMCPL.

2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard I followed the test plan successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:02:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:02:55 +0000 Subject: [Koha-bugs] [Bug 20518] New: Don't show "Messages" header and link on patron details if there are no messages Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Bug ID: 20518 Summary: Don't show "Messages" header and link on patron details if there are no messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org On the patron detail page (moremember.pl), a "Messages" header is displayed whether or not there are messages on the account. It should show only when there are messages. In addition "Add a new message" link is redundant because of the button in the toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:06:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:06:28 +0000 Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Jesse Maseto changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:36:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:36:12 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73527|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 73651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73651&action=edit Bug 19817: Add pref KohaManualLanguage -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:36:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:36:17 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #19 from Jonathan Druart --- Created attachment 73652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73652&action=edit Bug 19817: Open the manual in a new window, not a popup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:37:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:37:16 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20225 CC| |mtompset at hotmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 [Bug 20225] Remove unused script reports/stats.print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:37:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:37:16 +0000 Subject: [Koha-bugs] [Bug 20225] Remove unused script reports/stats.print.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 [Bug 20510] Remove unused sub TotalPaid from C4::Stats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:38:03 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:38:03 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #20 from Jonathan Druart --- (In reply to Katrin Fischer from comment #16) > Hi Jonathan, > > some thoughts: > > 1) sub _get_base_url doesn't look quite right yet. > a) It hardcodes en. Ideally we should try to check for the existence of a > translated manual and use that, with a fallback to en. If we can't do that, > we'll maybe need to add a pref where you can add the lanugage codes to use. I have added a patch to add a new pref KohaManualLanguage > b) For the local manual URL you combine: > C4::Context->preference('staffClientBaseURL') . $KohaManualBaseURL; > I think it might be good to allow for a full URL in KohaManualBaseURL. That > way you could have the help on the same server or at another location. The concatenation is done only if the pref does not start with '/', so you can use a value starting with 'http://' > 2) If the permission doesn't work yet, I would not include it :) Patch removed. > 3) The manual layout doesn't work well in the small pop up. I wonder if > there is a way to leave off the side navigation, but probably we can just > make the window a bit wider. Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:38:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:38:41 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20225 |18643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 [Bug 20225] Remove unused script reports/stats.print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:38:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:38:41 +0000 Subject: [Koha-bugs] [Bug 18643] Remove dead code in reports/statistics 'Till reconciliation' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18643 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 [Bug 20510] Remove unused sub TotalPaid from C4::Stats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:38:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:38:41 +0000 Subject: [Koha-bugs] [Bug 20225] Remove unused script reports/stats.print.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20510 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 [Bug 20510] Remove unused sub TotalPaid from C4::Stats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:38:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:38:55 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20225 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 [Bug 20225] Remove unused script reports/stats.print.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:38:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:38:55 +0000 Subject: [Koha-bugs] [Bug 20225] Remove unused script reports/stats.print.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20225 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 [Bug 20510] Remove unused sub TotalPaid from C4::Stats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:40:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:40:12 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 --- Comment #2 from M. Tompsett --- Went back to 3.22.x to see what used it. git log -- reports/ hunted for the stats.print and stats.screen. Added dependencies which have already been pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:44:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:44:32 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:44:35 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:44:35 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73545|0 |1 is obsolete| | --- Comment #3 from M. Tompsett --- Created attachment 73653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73653&action=edit Bug 20510: Remove unused sub TotalPaid from C4::Stats Test plan: 0) Do not apply the patch 1) Run git grep TotalPaid and confirm it is only defined and then used once in a test 2) Apply the patch 3) git grep TotalPaid should return nothing 4) prove t/db_dependent/Stats.t should be green Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:45:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:45:32 +0000 Subject: [Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:45:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:45:34 +0000 Subject: [Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 --- Comment #1 from Owen Leonard --- Created attachment 73654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73654&action=edit Bug 20518 - Don't show "Messages" header and link on patron details if there are no messages This patch modifies the patron detail page so that the "Messages" header is not displayed if there are no messages. Unrelated: A minor change was made to moremember.pl to quiet an error in the log, "Use of uninitialized value $print in string eq at members/moremember.pl line 219." To test, apply the patch and open the detail page for a patron who has no messages. There should be no "Messages" header or "add message" link. Add a message to the patron's account. The message should appear, along with the "Messages" header and "add message" link. The error logs should show no errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 18:58:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 16:58:08 +0000 Subject: [Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:01:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:01:11 +0000 Subject: [Koha-bugs] [Bug 20410] Remove OpacGroupResults system preference and feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20410 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Quick note: The pref is not in sysprefs.sql Use `git grep -i OpacGroupResults` to know where this pref is used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:05:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:05:06 +0000 Subject: [Koha-bugs] [Bug 20519] New: Credit amount in pay.pl should use the class="credit" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20519 Bug ID: 20519 Summary: Credit amount in pay.pl should use the class="credit" Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: baselibrary.consortium at nhs.net QA Contact: testopia at bugs.koha-community.org We use the class="credit" for credits in boraccount.pl but the class="debit" for credits in pay.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:10:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:10:53 +0000 Subject: [Koha-bugs] [Bug 19223] Plugin authors does not output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Help plugin authors output |Plugin authors does not |headers correctly |output headers correctly CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:11:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:11:25 +0000 Subject: [Koha-bugs] [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 [Bug 20520] Re-indent moremember.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:11:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:11:25 +0000 Subject: [Koha-bugs] [Bug 20520] New: Re-indent moremember.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20520 Bug ID: 20520 Summary: Re-indent moremember.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 20518 I would like to re-indent moremember.tt and remove trailing spaces. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20518 [Bug 20518] Don't show "Messages" header and link on patron details if there are no messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:20:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:20:37 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Koha now has a command line release notes| |tool for importing patron | |CSV files of the same | |format the web-based tool | |uses. This tool allows a | |user to specify a | |matchpoint, set default | |values for non-existing | |fields, decide if a match | |should be overwritten, and | |if extended attributes | |should be preserved! | | | |For | |more details, run | |"misc/import_patrons.pl -h" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:43:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:43:14 +0000 Subject: [Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Benjamin Rokseth changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |REST API route for managing release notes| |patrons in database. Adds | |CRUD implementation for | |creating, reading, updating | |and deleting patrons, as | |well as listing with | |optional sorting. | | | |Follows | |new guidelines from REST | |API RFC and Koha Object | |Exceptions regarding | |validation and error | |handling. Patron can modify | |and delete own object, or | |anyone with borrower | |modification permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:49:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:49:31 +0000 Subject: [Koha-bugs] [Bug 19223] Add helper methods to plugins to output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plugin authors does not |Add helper methods to |output headers correctly |plugins to output headers | |correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 19:50:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 17:50:52 +0000 Subject: [Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|REST API route for managing |REST API route for managing release notes|patrons in database. Adds |patrons in database. Adds |CRUD implementation for |CRUD implementation for |creating, reading, updating |creating, reading, updating |and deleting patrons, as |and deleting patrons, as |well as listing with |well as listing with |optional sorting. |optional sorting. | | |Follows |Follows |new guidelines from REST |new guidelines from REST |API RFC and Koha Object |API RFC and Koha Object |Exceptions regarding |Exceptions regarding |validation and error |validation and error |handling. Patron can modify |handling. Patrons can |and delete own object, or |modify and delete their own |anyone with borrower |object, or anyone with |modification permissions. |borrower modification | |permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:02:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:02:08 +0000 Subject: [Koha-bugs] [Bug 16330] Add routes to add, update and delete patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16330 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:02:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:02:05 +0000 Subject: [Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:28:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:28:34 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > Hi Kyle, this checks out well for me and I am signing off to move this > along. Just one question: > > Would it be safe to remove this warning now from the docs of > cleanup_database? > > WARNING: Fees and payments may not be deleted together. This will not affect > the account balance but may be confusing to staff. Kyle, ping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:29:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:29:07 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 --- Comment #9 from Jonathan Druart --- Created attachment 73655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73655&action=edit Bug 20325: Move tests to a subtest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:37:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:37:21 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 --- Comment #10 from Jonathan Druart --- Created attachment 73656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73656&action=edit Bug 20325: Do not remove accountlines between tests This is part of the tests, to make sure they have not been deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:39:45 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:39:45 +0000 Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73546|0 |1 is obsolete| | --- Comment #57 from Victor Grousset/tuxayo --- Created attachment 73657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73657&action=edit Bug 12310 : Decimal separator issues: some fixes in fines The main goal is to prevent - x100 or /100 of the amounts - decimal part truncation Fixes Bug 19521 - Partial fine payment is not working with comma decimal separator Bonuses: - Gets rid of the spaces, currency symbols, names (EUR) There is nothing specific about currency symbols is this patch. It just removes everything that is not a digit a minus or a separator. It handles: - by default comma and dot as decimal separators on the same instance - dot or comma as thousands separators if choose to use only one of them as decimal separator. See DigitSeparator syspref. - minuses, doesn't remove them == Test plan == 1. Use a translation of the staff interface if possible. 2. When you pay an existing fine (more details in the next steps if needed). Check that you can't enter any string except like "XX.XX" (examples in Annex 1) without having an issue after validation. (x100, truncation, etc) 3. Apply this patch 4. run ~/src/installer/data/mysql/updatedatabase.pl 5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl) 6. Apply the annex 1 to the "Amount" field 7. When paying a fine (cgi-bin/koha/members/paycollect.pl) 8. Click on "Pay amount" to go to the page to pay all fines 9. Apply the annex 1 to the "Collect from patron" field 10. Click on "Pay" to go to the page to pay fine 11. Apply the annex 1 to the "Collect from patron" field 12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl) 13. Apply the annex 1 to the "Amount" field 14. If you have ideas of stuff to try to find *regressions* from the previous versions, then try. You might spare librarian tears by finding something before it's released. (and prevent me from having bounty on my head) 15. Express your happiness. This is important, otherwise the sign off spell won't work! The details of expressing your happiness depend on your culture and habits. === Annex 1: Subpart for each concerned page === 1. Set DecimalSeparators syspref to ",." 2. Input "12,34" 3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the conversion. Validating the form does the same but it's a trick to test more quickly by not switching to another page. 4. The value should have been converted to 12.34 5. What follows is just a list of examples. They don't have to be tried on each field. 6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34" 7. Same with "EUR 12.34" -> "12.34" 8. "EUR 12.34?hi lyonthree" -> "12.34" 9. "123 456,7" -> "123456.7" 10. "2" -> "2" 11. "2,0" -> "2.0" 12. "-1'345.95" -> "-1345.95" 13. ",1234" -> ".1234" 14. Set DecimalSeparators syspref to "," 15. Reload the page with the form 16. "1.000" -> "1000" 17. "1.000.000,10" -> "1000000.10" 18. Set DecimalSeparators syspref to "." 19. Reload the page with the form 20. "1,000" -> "1000" 21. "1,000,000.10" -> "1000000.10" 22. Validate the form and check that the final value with the dot was well handled. 23. Think about Koalas and smile. ??? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:39:50 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:39:50 +0000 Subject: [Koha-bugs] [Bug 20122] Empty and close link on cart page not working (js security) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20122 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |kyle at bywatersolutions.com Resolution|INVALID |--- --- Comment #5 from Kyle M Hall --- I was able to reproduce on master. It appears that the empty link works until you reload the page, then the items come back. Furthermore the remove items button doesn't work if *all* items are selected, but does if only some of the cart items are selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:49:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:49:05 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 --- Comment #8 from Jonathan Druart --- This patch is not perfect but fixes the problem. I still think it must be fixed globally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 20:55:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 18:55:46 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 --- Comment #23 from Jonathan Druart --- Created attachment 73658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73658&action=edit Bug 19910: Use span to make translators happy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:04:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:04:27 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 --- Comment #16 from Jonathan Druart --- Patches will be squashed for readability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:07:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:07:30 +0000 Subject: [Koha-bugs] [Bug 19223] Add helper methods to plugins to output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:07:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:07:37 +0000 Subject: [Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:07:42 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:07:42 +0000 Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:07:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:07:48 +0000 Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has confusing and unexpected values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:07:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:07:54 +0000 Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:08:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:08:02 +0000 Subject: [Koha-bugs] [Bug 19953] Record page: acquisition details: add column for invoice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:08:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:08:12 +0000 Subject: [Koha-bugs] [Bug 20008] Restrictions added from memberentry.pl have expiration date ignored if TimeFormat is 12hr In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:08:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:08:24 +0000 Subject: [Koha-bugs] [Bug 20115] Languages appear in a different order in the footer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20115 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:12:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:12:41 +0000 Subject: [Koha-bugs] [Bug 20083] Information disclosure when (mis)using the MARC Preview feature In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20083 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Koha security |Koha Component|Koha |Authentication Group|Koha security | CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:20:25 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20229 Blocks|20229 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229 [Bug 20229] Remove problematic SQL modes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:20:25 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:20:25 +0000 Subject: [Koha-bugs] [Bug 20229] Remove problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Depends on|17258 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:28:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:28:28 +0000 Subject: [Koha-bugs] [Bug 20229] Remove problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 [Bug 20521] dev installations should run with problematic SQL modes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:28:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:28:28 +0000 Subject: [Koha-bugs] [Bug 20521] New: dev installations should run with problematic SQL modes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Bug ID: 20521 Summary: dev installations should run with problematic SQL modes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20229 So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20229 [Bug 20229] Remove problematic SQL modes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:28:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:28:46 +0000 Subject: [Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:30:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:30:58 +0000 Subject: [Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:31:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:31:02 +0000 Subject: [Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 --- Comment #1 from Jonathan Druart --- Created attachment 73659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73659&action=edit Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:49:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:49:27 +0000 Subject: [Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:50:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:50:54 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #14 from Jonathan Druart --- These tests are constantly failing, I am going to remove them once and for all if these random failures are not fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:58:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:58:33 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73645|0 |1 is obsolete| | --- Comment #31 from Tom?s Cohen Arazi --- Created attachment 73660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73660&action=edit Bug 9302: Add ability to merge patron records It would be great if there were a merge patrons feature. If you accidentally end up with one patron with two cards it would be nice to merge their records together so that you don't lose their history or holds or anything. This patch adds a basic patron merge feature. It attempts to relink all patron related tables from the patron(s) to be merged. It does not attempt to relink librarian account related tables at this time. This feature does not attempt to automatically resolve issues such as duplicate holds. Such a feature could build upon this one though. Test Plan: 1) Apply this patch 2) Find two or more patrons 3) Perform a patron search that will bring them up on the same page of results, or add them all to a list of patrons. 4) Use the 'merge' button to begin the merging process 5) Choose a patron to keep 6) Verify the deleted patrons data ( checkouts, holds, etc ) are now linked to the kept patron Signed-off-by: Owen Leonard Signed-off-by: Ed Veal Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:58:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:58:43 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73646|0 |1 is obsolete| | --- Comment #32 from Tom?s Cohen Arazi --- Created attachment 73661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73661&action=edit Bug 9302: (QA follow-up) Copy merged patrons to deletedborrowers table Signed-off-by: Owen Leonard Signed-off-by: Ed Veal Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:58:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:58:52 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73648|0 |1 is obsolete| | --- Comment #33 from Tom?s Cohen Arazi --- Created attachment 73662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73662&action=edit Bug 9302: (QA follow-up) Merge should be a transaction Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:59:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:59:04 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73649|0 |1 is obsolete| | --- Comment #34 from Tom?s Cohen Arazi --- Created attachment 73663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73663&action=edit Bug 9302: (QA follow-up) Dumper plugin isn't used Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:59:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:59:11 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #35 from Tom?s Cohen Arazi --- Created attachment 73664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73664&action=edit Bug 9302: (QA follow-up) reverse try/catch block Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 21:59:41 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 19:59:41 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 22:37:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 20:37:16 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70406|0 |1 is obsolete| | Attachment #70407|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 73665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73665&action=edit Bug 19804: Add a 'Fine charging interval' for suspension days We already have a chargeperiod (Fine charging interval) value which is taken into account for fine ($) for not for the suspension period. This patch adds a new column suspension_chargeperiod (Fine day charging interval) to add the same behaviour when a suspension is calculated. Test plan: Add overdue item and play with the circulation rules (and the calendar). The suspension period must be correctly calculated. Please provide the different tests you made. Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 22:37:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 20:37:22 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 --- Comment #14 from Jonathan Druart --- Created attachment 73666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73666&action=edit Bug 19804: Add the new column to the circ rules interface Signed-off-by: Hugo Agud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 22:37:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 20:37:27 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 --- Comment #15 from Jonathan Druart --- Created attachment 73667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73667&action=edit Bug 19804: (follow-up) Fix wording and columns order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Apr 4 22:37:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 20:37:58 +0000 Subject: [Koha-bugs] [Bug 19804] Suspension calculation doesn't honour 'Fine charging interval' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19804 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #12) > Some tiny things: > > - number of tests needs to be 114 for them to pass Patch amended. > - the headings at the top and the bottom row of the circulation rules table > don't match up > - Maybe rename "Fine day charging interval" to "Suspension charging > interval" to match a bit more with the other related columns? Done, thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 00:43:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 22:43:56 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 --- Comment #36 from Tom?s Cohen Arazi --- Created attachment 73668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73668&action=edit Bug 9302: (QA follow-up) Consistency follow-up This patch moves the Koha::Patrons->merge method into Koha::Patron->merge_with in the line of the discussed implementation for bug 15336. I agree with that implementation so I provide this follow-up. Tests are adjusted, the controller script is adapted too. The behaviour remains. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 00:44:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Apr 2018 22:44:24 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73664|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 03:28:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 01:28:59 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #15 from M. Tompsett --- (In reply to Jonathan Druart from comment #14) > These tests are constantly failing, I am going to remove them once and for > all if these random failures are not fixed. The HTTP::OAI::Header grabs gmtime() which could change between the creation time and the call time... How about this impending counter patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 03:37:46 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 01:37:46 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #16 from M. Tompsett --- Created attachment 73669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73669&action=edit Bug 20191: Use Test::MockTime to hold time still The problem is the calls to HTTP::OAI::Header, etc. may reference gmtime which is continually changing by the second. By forcing time to lock for all the tests, except the last one, we can be assured things should not fail. TEST PLAN --------- install libtest-mocktime-perl apply only this patch restart_all in kshell, prove t/db_dependent/OAI/Server.t run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 04:02:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 02:02:02 +0000 Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72546|0 |1 is obsolete| | --- Comment #10 from M. Tompsett --- Comment on attachment 72546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72546 Bug 20103: Remove Readonly::XS from PerlDependencies Counter patch is better. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 04:41:58 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 02:41:58 +0000 Subject: [Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 04:42:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 02:42:00 +0000 Subject: [Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73659|0 |1 is obsolete| | --- Comment #2 from M. Tompsett --- Created attachment 73670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73670&action=edit Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass NOTE: The commit number was wrong. Using git log -- t/db_dependent/Koha/Biblios.t This showed bug 20176 which was 524eab678833b2719187e67128ee4f83a2a48ba4 Also dev_install was in koha_conf.xml already, so I just had to toggle 0 and 1. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 05:13:06 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 03:13:06 +0000 Subject: [Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 --- Comment #6 from M. Tompsett --- (In reply to Vitor Fernandes from comment #0) > PROBLEM 1 > > If a record as some than one ISBN, the values are recorded in database like > 'isbn1 | isbn2 | isbn3'. > > In the script the ISBN match are only checking for exact ISBN matching. This is because: 020 - International Standard Book Number (R) -- The 020 field is repeatable. This is clearly bad data, but yes, we should attempt to parse for it. I don't like the multiple likes fix provided here. I would prefer a: my @isbns = parseIsbnField($isbn_field_value); foreach my $isbn (@isbns) { search for the individual isbn ... } sub parseIsbnField { my ($isbn_data) = @_; see if we can split out some ISBNs. ... return an array of the results. } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:36:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:36:20 +0000 Subject: [Koha-bugs] [Bug 20515] "ILL Request" menu options displayed when user has no ILL permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20515 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Andrew, all good, but you don't need the superlibrarian bit - can you please remove those in a little follow up and set back to signed off? Thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:38:51 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:38:51 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:38:55 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:38:55 +0000 Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73653|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 73671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73671&action=edit Bug 20510: Remove unused sub TotalPaid from C4::Stats Test plan: 0) Do not apply the patch 1) Run git grep TotalPaid and confirm it is only defined and then used once in a test 2) Apply the patch 3) git grep TotalPaid should return nothing 4) prove t/db_dependent/Stats.t should be green Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:49:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:49:10 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:49:13 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:49:13 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73644|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 73672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73672&action=edit Bug 20516: Show patron's library in pending discharges table Test plan: 1. Enable syspref useDischarge 2. Login to OPAC and ask for a discharge (tab on the left) 3. Login to intranet, you should see a message about pending discharges, and a link. Click on the link. 4. Confirm that there is a 'Library' column in the table that is displaying the patron's library Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:49:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:49:47 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Is there a good rule about when it's better to use the class methods and when to use the TT plugin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:52:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:52:10 +0000 Subject: [Koha-bugs] [Bug 19223] Avoid encoding issues in plugins by providing helper methods to output headers correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add helper methods to |Avoid encoding issues in |plugins to output headers |plugins by providing helper |correctly |methods to output headers | |correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:54:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:54:34 +0000 Subject: [Koha-bugs] [Bug 19953] Add column for invoice in acquisition details tab In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19953 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Record page: acquisition |Add column for invoice in |details: add column for |acquisition details tab |invoice | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 07:56:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 05:56:20 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #36 from Katrin Fischer --- Thx Kyle! Do we still need QA review here? Tomas, maybe you could do it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 08:01:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 06:01:31 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 08:01:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 06:01:34 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73642|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 73673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73673&action=edit Bug 20350: Add column configuration to table of saved reports This patch makes changes to the saved reports template to enable a columns configuration button. Settings for the table have been added to columns_settings.yml. To test, apply the patch and go to Reports -> Use saved. - Confirm that there is a "Column visibility" button in the table's pagination toolbar. - Confirm that showing and hiding columns via the button is working correctly. - Confirm that the first, second, and last columns cannot be toggled. Go to Administration -> Columns settings. - Expand the "Reports" section. - Find "id=table_reports." - Make some selections to configure default settings of the reports table. - Return to reports and confirm that these defaults are applied. Signed-off-by: Jesse Maseto Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 08:02:11 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 06:02:11 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Works nicely for me, maybe a cache/Plack problem with c#4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:12:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:12:54 +0000 Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73461|0 |1 is obsolete| | --- Comment #14 from Alex Arnaud --- Created attachment 73674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73674&action=edit Bug 17373 - Elasticsearch - Authority mappings for UNIMARC - patch1 This patch starts the UNIMARC mapping for ES. It is needed to test. More patches will come. Signed-off-by: Nicolas Legrand Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:13:01 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:13:01 +0000 Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73462|0 |1 is obsolete| | --- Comment #15 from Alex Arnaud --- Created attachment 73675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73675&action=edit Bug 17373 - Add mappings for unimarc authorities - Match index Test plan: 1. apply patches 2. switch SearchEngine syspref to ElasticSearch 3. load new mapping (admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1) 4. load some unimarc authorities like the sample attached to bug 17373 5. reindex authorities (./misc/search_tools/rebuild_elastic_search.pl -d -a -v) 6. search entire notice for shalev or ??? 7. you should find stuff Signed-off-by: Nicolas Legrand Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:14:09 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:14:09 +0000 Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for UNIMARC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:23:31 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:23:31 +0000 Subject: [Koha-bugs] [Bug 20522] New: Fields with only one $9 subfield are removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20522 Bug ID: 20522 Summary: Fields with only one $9 subfield are removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org There is a sort of cleaning functionnality in Koha when saving a biblio record. If a field contains only a $9 subfield, the whole field is removed. There is a logic there since $9 is generally used in Koha for storing authority record ID. However there may exist fields perfectly valid containing only a $9 subfield. This is a case in Unimarc 010 field. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:35:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:35:48 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Axelle Aix-Marseille Universit? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:42:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:42:16 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 --- Comment #5 from Julian Maurice --- (In reply to Katrin Fischer from comment #4) > Is there a good rule about when it's better to use the class methods and > when to use the TT plugin? I suppose the TT plugin is only useful when all you have is a branchcode (not an object). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:48:37 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:48:37 +0000 Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:56:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:56:00 +0000 Subject: [Koha-bugs] [Bug 20522] Fields with only one $9 subfield are removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20522 --- Comment #1 from Fr?d?ric Demians --- Created attachment 73676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73676&action=edit Bug 20522: Fields with only one $9 subfield are removed There is a sort of cleaning functionnality in Koha when saving a biblio record. If a field contains only a $9 subfield, the whole field is removed. There is a logic there since $9 is generally used in Koha for storing authority record ID. However there may exist fields perfectly valid containing only a $9 subfield. This is a case in Unimarc 010 field. To test in Unimarc: 1. Add a $9 sufield to 010. You can name it "ISBN d'une livraison de publication en s?rie" 2. Create a new biblio record. Fill 010 $a and $9 subfields. Save the record. => Everything is fine: $a et $9 are properly stored. 3. Modify the previous record, and remove $a subield. Save the record. => 010 field is removed 4. Apply the patch. Repeat 2-3 steps. Observe that a 010 field containing only a $9 subfield can be saved properly. To test in MARC21: Replace 010 filed by any other field... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 09:56:21 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 07:56:21 +0000 Subject: [Koha-bugs] [Bug 20522] Fields with only one $9 subfield are removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20522 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 10:51:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 08:51:20 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 --- Comment #29 from Jon Knight --- Created attachment 73677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73677&action=edit Bug 19479: Display price in basket group formatted according to CurrencyFormat syspref using templates. On the page acqui/basketgroup.pl the prices of baskets should be shown formatted according to the selected CurrencyFormat syspref, with no currency symbol or code. Test plan: 1) Create a basket with items in it worth more than 1000 currency units. 2) Close the basket. 3) Go to acqui/basketgroup.pl page and check that the price format matches the current CurrencyFormat syspref. 4) Go to Administration and change CurrencyFormat syspref to one of the other available options and recheck step 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 10:52:02 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 08:52:02 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 10:52:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 08:52:22 +0000 Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479 Jon Knight changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 11:18:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 09:18:53 +0000 Subject: [Koha-bugs] [Bug 20523] New: Advanced editor - Rancor - shows nulls in fixed-width fields for empty values Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20523 Bug ID: 20523 Summary: Advanced editor - Rancor - shows nulls in fixed-width fields for empty values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at joensuu.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In the advanced MARC editor, the spaces in eg. leader and 008 are shown as "null" values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 12:07:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 10:07:22 +0000 Subject: [Koha-bugs] [Bug 19908] Password should not be mandatory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19908 Andreas Jonsson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson at kreablo.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 12:10:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 10:10:43 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 --- Comment #11 from Kyle M Hall --- (In reply to Jonathan Druart from comment #8) > (In reply to Katrin Fischer from comment #4) > > Hi Kyle, this checks out well for me and I am signing off to move this > > along. Just one question: > > > > Would it be safe to remove this warning now from the docs of > > cleanup_database? > > > > WARNING: Fees and payments may not be deleted together. This will not affect > > the account balance but may be confusing to staff. > > Kyle, ping Absolutely! I'll submit a followup right now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 12:12:59 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 10:12:59 +0000 Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does not check account_offsets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325 --- Comment #12 from Kyle M Hall --- Created attachment 73678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73678&action=edit Bug 20325: Remove warning, it is no longer true -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 12:32:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 10:32:57 +0000 Subject: [Koha-bugs] [Bug 9302] Add ability to merge patron records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73668|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall --- Created attachment 73679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73679&action=edit Bug 9302: (QA follow-up) Consistency follow-up This patch moves the Koha::Patrons->merge method into Koha::Patron->merge_with in the line of the discussed implementation for bug 15336. I agree with that implementation so I provide this follow-up. Tests are adjusted, the controller script is adapted too. The behaviour remains. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 13:19:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 11:19:33 +0000 Subject: [Koha-bugs] [Bug 20522] Fields with only one $9 subfield are removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20522 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 13:24:08 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 11:24:08 +0000 Subject: [Koha-bugs] [Bug 20524] New: Make columns of pending discharges table sortable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 Bug ID: 20524 Summary: Make columns of pending discharges table sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 13:25:05 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 11:25:05 +0000 Subject: [Koha-bugs] [Bug 20524] Make columns of pending discharges table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 --- Comment #1 from Julian Maurice --- Created attachment 73680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73680&action=edit Bug 20524: Make columns of pending discharges table sortable Test plan: 1. Enable syspref useDischarge 2. Login to OPAC and ask for a discharge (tab on the left) 3. Login to OPAC with another borrower from another library and ask for a discharge 4. Login to intranet, you should see a message about pending discharges, and a link. Click on the link. 5. Confirm that the Patron column is sortable and the Allow column is not 6. (Optional) You can apply bug 20516 and confirm that the Library column is sortable too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 13:26:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 11:26:10 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20524 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 13:26:10 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 11:26:10 +0000 Subject: [Koha-bugs] [Bug 20524] Make columns of pending discharges table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20516 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 13:26:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 11:26:38 +0000 Subject: [Koha-bugs] [Bug 20524] Make columns of pending discharges table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 13:55:18 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 11:55:18 +0000 Subject: [Koha-bugs] [Bug 20524] Make columns of pending discharges table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 Axelle Aix-Marseille Universit? changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse at univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 14:54:12 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 12:54:12 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 14:54:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 12:54:17 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73626|0 |1 is obsolete| | --- Comment #13 from Nicolas Legrand --- Created attachment 73681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73681&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand Signed-off-by: S?verine QUEUNE Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 14:54:23 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 12:54:23 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Nicolas Legrand changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73629|0 |1 is obsolete| | --- Comment #14 from Nicolas Legrand --- Created attachment 73682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73682&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 14:55:43 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 12:55:43 +0000 Subject: [Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 14:55:47 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 12:55:47 +0000 Subject: [Koha-bugs] [Bug 20521] dev installations should run with problematic SQL modes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20521 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73670|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 73683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73683&action=edit Bug 20521: Enable problematic SQL modes for dev installs So far we have bug 17258 (omnibus to list the issue we have with the new default SQL modes), bug 20144 (which fixed our test suite with these modes) and bug 20229. This last one forces the SQL modes to avoid to modify the DBMS configuration and define the SQL modes we support. We should let developers catch the issues and report/fix them. Also Jenkins must alert us if there is a regression with the test suite. I suggest to enable the problematic SQL modes on dev installs. Test plan: - Revert commit 0180524bb9b1464c441bb1b858d0d8df37524d72 - prove t/db_dependent/Koha/Biblios.t => If you have dev_install defined in your Koha config file, the test will fail with "Field 'datecreated' doesn't have a default value" => If you do not have dev_install, the tests will pass NOTE: The commit number was wrong. Using git log -- t/db_dependent/Koha/Biblios.t This showed bug 20176 which was 524eab678833b2719187e67128ee4f83a2a48ba4 Also dev_install was in koha_conf.xml already, so I just had to toggle 0 and 1. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:07:32 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:07:32 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71673|0 |1 is obsolete| | Attachment #71816|0 |1 is obsolete| | Attachment #72009|0 |1 is obsolete| | Attachment #73669|0 |1 is obsolete| | --- Comment #17 from Tom?s Cohen Arazi --- Created attachment 73684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73684&action=edit Bug 20191: Use Test::MockTime to hold time still The problem is the calls to HTTP::OAI::Header, etc. may reference gmtime which is continually changing by the second. By forcing time to lock for all the tests, except the last one, we can be assured things should not fail. TEST PLAN --------- install libtest-mocktime-perl apply the patch restart_all in kshell, prove t/db_dependent/OAI/Server.t run koha qa test tools Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:07:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:07:38 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 --- Comment #18 from Tom?s Cohen Arazi --- Created attachment 73685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73685&action=edit Bug 20191: (QA follow-up) Require Jessie's Test::MockTime Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:09:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:09:53 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |mtompset at hotmail.com Version|unspecified |master Keywords|additional_work_needed |dependency QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:10:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:10:00 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:12:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:12:00 +0000 Subject: [Koha-bugs] [Bug 20191] OAI/Server.t still fails on slow servers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20191 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Tom?s Cohen Arazi --- I tested with Mark's patch using 'stress -c 4' on a 2 cores kohadevbox (cpu load above 3). I managed to reproduce the issue without the patch, and can confirm the patch deals with the problem correctly. The solution is the right one too, one we talked about but didn't find the spot in which environment was leaking inside the tests. Good catch Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:22:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:22:24 +0000 Subject: [Koha-bugs] [Bug 20524] Make columns of pending discharges table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73680|0 |1 is obsolete| | --- Comment #2 from Julian Maurice --- Created attachment 73686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73686&action=edit Bug 20524: Make columns of pending discharges table sortable Test plan: 1. Enable syspref useDischarge 2. Login to OPAC and ask for a discharge (tab on the left) 3. Login to OPAC with another borrower from another library and ask for a discharge 4. Login to intranet, you should see a message about pending discharges, and a link. Click on the link. 5. Confirm that the Patron column is sortable and the Allow column is not 6. (Optional) You can apply bug 20516 and confirm that the Library column is sortable too Signed-off-by: Axelle Clarisse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:22:34 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:22:34 +0000 Subject: [Koha-bugs] [Bug 20524] Make columns of pending discharges table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:24:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:24:22 +0000 Subject: [Koha-bugs] [Bug 15296] MEMBER logging in action_logs does not give enough detail. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15296 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:32:36 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:32:36 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72202|0 |1 is obsolete| | --- Comment #37 from Tom?s Cohen Arazi --- Created attachment 73687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73687&action=edit Bug 20123: Allow multiple instances of Koha to have different timezones on the same server Most of Koha depends on the local timezone of the server, except for Koha::Database which support an ENV override with the key TZ. We should take this a step further. We should not only accept the TZ environment variable for all of Koha, we should really be able to set the timezone in the koha conf file as well so we don't have to pass that environment variable to things like cronjobs and one-off scripts. Test Plan: 1) Apply this patch 2) Set a timzone in your koha_conf file, that is *not* your local time zone Available timzones are listed here: https://en.wikipedia.org/wiki/List_of_tz_database_time_zones 3) Restart apache/plack 4) Perform some actions, check the timestamps in the database and in the html output, note they are for the set timezone and not the local timezone. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:32:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:32:48 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72255|0 |1 is obsolete| | --- Comment #38 from Tom?s Cohen Arazi --- Created attachment 73688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73688&action=edit Bug 20123: (QA follow-up) If tz is 'local', no need to tell database to set the timezone Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:32:56 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:32:56 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72605|0 |1 is obsolete| | --- Comment #39 from Tom?s Cohen Arazi --- Created attachment 73689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73689&action=edit Bug 20123: Add commented out example to koha-conf.xml Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:33:33 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:33:33 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:33:38 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:33:38 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 --- Comment #40 from Tom?s Cohen Arazi --- Created attachment 73690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73690&action=edit Bug 20123: Make the timezone entry empty and uncommented by default Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:48:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:48:16 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Koha now has the ability to release notes| |set times zones in Koha on | |a per-instance basis. That | |means that a single Koha | |server can support | |instances in several time | |zones simultaneously! | | | |Each | |instance's timezone can be | |set in its' koha-conf.xml | | | |See | |https://wiki.koha-community | |.org/wiki/Time_Zone_Configu | |ration for more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:53:17 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:53:17 +0000 Subject: [Koha-bugs] [Bug 20525] New: Add --timezone switch to koha-create Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525 Bug ID: 20525 Summary: Add --timezone switch to koha-create Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Now that Koha can be set a timezone on a per-instance basis (bug 20123), we should provide a way to configure it on instance creation time. It should default to empty to keep the current behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:53:24 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:53:24 +0000 Subject: [Koha-bugs] [Bug 20525] Add --timezone switch to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:53:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:53:54 +0000 Subject: [Koha-bugs] [Bug 20526] New: Show and sort by date of request in pending discharges table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20526 Bug ID: 20526 Summary: Show and sort by date of request in pending discharges table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Patrons Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, testopia at bugs.koha-community.org Depends on: 20516, 20524 I think it would make sense to have the pending discharges table sorted by default by the request date, ascending. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 [Bug 20516] Show patron's library in pending discharges table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 [Bug 20524] Make columns of pending discharges table sortable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:53:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:53:54 +0000 Subject: [Koha-bugs] [Bug 20524] Make columns of pending discharges table sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20524 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20526 [Bug 20526] Show and sort by date of request in pending discharges table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:53:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:53:54 +0000 Subject: [Koha-bugs] [Bug 20516] Show patron's library in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20516 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20526 [Bug 20526] Show and sort by date of request in pending discharges table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:58:53 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:58:53 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73549|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo --- Created attachment 73691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73691&action=edit Bug 9634: Allow for combining same paraneters in SQL reports This patch combines report paramters with the same name and data type (authorised value) This presereves the past ability to provide all parameters as 'sql_params' in order to preserve existing public report links To test: 1 - Create a report that takes multiple parameters, e.g.: SELECT <> AS one, <> AS two, <> as three, <> as four, <> as five 2 - Run this report, note you are asked for five parameters 3 - Apply patch 4 - Update database 5 - Run report, note you are asked for three params 6 - Verify the results reflect the supplied parameters 7 - Export the report and verify results 8 - Alter the URL and provide 5 params as sql_params and no param_name variables i.e. http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL 9 - Verify results come out as expected. i.e. 5 different values that are those of the URL. Signed-off-by: Victor Grousset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:59:20 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:59:20 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 15:59:30 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 13:59:30 +0000 Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:05:14 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:05:14 +0000 Subject: [Koha-bugs] [Bug 20526] Show and sort by date of request in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20526 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:05:16 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:05:16 +0000 Subject: [Koha-bugs] [Bug 20526] Show and sort by date of request in pending discharges table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20526 --- Comment #1 from Owen Leonard --- Created attachment 73692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73692&action=edit Bug 20526: Show and sort by date of request in pending discharges table This patch adds a "date requested" column to the table of pending discharges, and updates the DataTables configuration to sort by this column by default. The patch also makes some other changes: - Table information and filtering have been added. - The "Allow" link has been converted to a Bootstrap-styled buttong with an icon. To test, apply the patch and view the table of pending discharge requests. It should be sorted by default by date requested. - Confirm that date sorting is correct. - Confirm that other columns still sort correctly. - Confirm that buttons look right. - Confirm that the table information is correct. - Confirm that the table search form works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:11:48 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:11:48 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71748|0 |1 is obsolete| | Attachment #71749|0 |1 is obsolete| | Attachment #71750|0 |1 is obsolete| | Attachment #71751|0 |1 is obsolete| | Attachment #72920|0 |1 is obsolete| | --- Comment #29 from Nick Clemens --- Created attachment 73693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73693&action=edit Bug 18904 - Advanced editor - Rancor - Add authority support This patchset adds the ability to use the authorities search to select or clear fields in the advanced editor To test: 1 - Open a record in the advanced cataloging editor 2 - Press 'Ctrl+L' while in a field that shuold not be linked to authorities (300 for instance) 3 - Nothing should happen 4 - Try it in a field that should be linked 5 - You should get the authorities pop-up 6 - Values in pop-up should be populated from values in record (as appropriate for authority type) 7 - Correct authority type should be selected ( PERSO_NAME for 100, TOPIC_TERM for 650, etc.) 8 - Press 'Clear', field should be blanked 9 - Search again and select an authority 10 - Field should be correctly populated Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:11:52 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:11:52 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 --- Comment #30 from Nick Clemens --- Created attachment 73694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73694&action=edit Bug 18904: Followup - fix whitespace and don't use hardcoded path Fix whitespace/tabs use [% interface %] not intranet-tmpl Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:11:54 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:11:54 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 --- Comment #31 from Nick Clemens --- Created attachment 73695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73695&action=edit Bug 18904: Followup - Retrieve subfield in the order they are stored Use subfields in the order they are stored. This patch removes use of an intermediate hash for storing values. Order of subfields as obtained from authority is now preserved. Also removes useless code that was intended to set $2 subfields Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:11:57 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:11:57 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 --- Comment #32 from Nick Clemens --- Created attachment 73696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73696&action=edit Bug 18904 - Remove debugging code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:12:00 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:12:00 +0000 Subject: [Koha-bugs] [Bug 18904] Advanced editor - Rancor - Add authority support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18904 --- Comment #33 from Nick Clemens --- Created attachment 73697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73697&action=edit Bug 18904 (follow-up) Set indicators and correct js path TO test: 1 - Have an authority with some indicators 2 - Link a field in rancor to that authority 3 - See that you get some indicators (same in unimarc, diff in marc21) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:15:04 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:15:04 +0000 Subject: [Koha-bugs] [Bug 20525] Add --timezone switch to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:15:07 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:15:07 +0000 Subject: [Koha-bugs] [Bug 20525] Add --timezone switch to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 73698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73698&action=edit Bug 20525: Add --timezone switch to koha-create This patch adds a --timezone switch to koha-create so the timezone can be set on creation time. It defaults to empty (i.e. using the server's local time). To test: - Create an instance: $ sudo koha-create --create-db timezone1 => SUCCESS: /etc/koha/sites/timezone1/koha-conf.xml contains an empty entry. - Apply this patch - Run: $ perl misc4dev/cp_debian_files.pl - Create a new instance: $ sudo koha-create --create-db timezone2 => SUCCESS: /etc/koha/sites/timezone2/koha-conf.xml contains an empty entry (i.e. the current behaviour is preserved). - Create a new instance: $ sudo koha-create --create-db --timezone Your/Timezone timezone3 => SUCCESS: /etc/koha/sites/timezone3/koha-conf.xml contains Your/Timezone (i.e. introduced behaviour works) - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:15:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:15:28 +0000 Subject: [Koha-bugs] [Bug 20525] Add --timezone switch to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20123 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:15:28 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:15:28 +0000 Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have different timezones on the same server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20525 [Bug 20525] Add --timezone switch to koha-create -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:21:22 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:21:22 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 --- Comment #209 from Alex Arnaud --- Created attachment 73699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73699&action=edit Bug 17047 - Move mana JS and put correct subscription id when sharing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:22:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:22:27 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Apr 5 16:28:27 2018 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Apr 2018 14:28:27 +0000 Subject: [Koha-bugs] [Bug 20527] New: