---
"any permission in the acquisitions module"
So I used CAN_user_acquisition
Here is my amend:
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index f130644..9b1eb1a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -704,9 +704,13 @@
[% IF (order.invoiceid) %]
-
- [% order.invoicenumber %]
+ [% IF CAN_user_acquisition %]
+
+ [% order.invoicenumber %]
+ [% ELSE %]
+ [% order.invoicenumber %]
+ [% END %]
##########################################################
note: I haven't invalidated the sign off. (maybe I should?)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 01:24:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Mar 2018 23:24:32 +0000
Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file
with default values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #2 from Katrin Fischer ---
We tested this at the hackfest and selecting the fund on the default accounting
details should work - otherwise it would have no function. Sonia also said that
they used the feature a lot and it used to work like that.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 01:25:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Mar 2018 23:25:40 +0000
Subject: [Koha-bugs] [Bug 20423] ReservesNeedReturns allows multiple patrons
to have the same item set to 'waiting'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20423
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 01:34:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Mar 2018 23:34:19 +0000
Subject: [Koha-bugs] [Bug 19527] Alter Zebra indexing to sort by descending
document ID
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19527
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|17.05 |master
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 01:35:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 31 Mar 2018 23:35:51 +0000
Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does
not check account_offsets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|C4::Accounts::purge_zero_ba |C4::Accounts::purge_zero_ba
|lance_fees does not check |lance_fees does not check
|account_offsets. |account_offsets
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 12:36:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 10:36:56 +0000
Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does
not check account_offsets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325
--- Comment #4 from Katrin Fischer ---
Hi Kyle, this checks out well for me and I am signing off to move this along.
Just one question:
Would it be safe to remove this warning now from the docs of cleanup_database?
WARNING: Fees and payments may not be deleted together. This will not affect
the account balance but may be confusing to staff.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 12:37:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 10:37:45 +0000
Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does
not check account_offsets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 12:37:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 10:37:49 +0000
Subject: [Koha-bugs] [Bug 20325] C4::Accounts::purge_zero_balance_fees does
not check account_offsets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20325
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73350|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 73516
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73516&action=edit
Bug 20325: C4::Accounts::purge_zero_balance_fees does not check account_offsets
purge_zero_balance_fees is used in cleanup_database.pl to determine which fees
can be cleaned up.
It uses a simple SQL query to determine which rows in accountlines need to be
removed:
463 my $sth = $dbh->prepare(
464 q{
465 DELETE FROM accountlines
466 WHERE date < date_sub(curdate(), INTERVAL ? DAY)
467 AND ( amountoutstanding = 0 or amountoutstanding IS NULL );
468 }
The function comes with the following warning:
451 B Because fines and payments are not linked in accountlines, it
is
452 possible for a fine to be deleted without the accompanying payment,
453 or vise versa. This won't affect the account balance, but might be
454 confusing to staff.
This was a reasonable solution prior to the addition of account_offsets in
17.11. The problem now is that rows in accountlines which are linked as credits
in accountlines will *always* have amountoutstanding marked as 0. These are
linked to debits via account_offsets. purge_zero_balance_fees will delete
credits and leave rows in account_offsets which link to deleted credits.
Sites using the --fees option cleanup_database.pl which upgrade to 17.11 may
have all of their credits removed without warning.
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Accounts.t
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 12:47:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 10:47:59 +0000
Subject: [Koha-bugs] [Bug 19562] Inventory: How can we skip convolutes
marked as problematic with no_barcode?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19562
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #5 from Katrin Fischer ---
In German it's slightly different: Konvolut.
I think having a proper solution in Koha for these kinds of items would be
nice. EasyAnalytics is one way, but because of the way it uses fields in the
record it's not usable in our union catalog setting.
We have implemented something for the OPAC using the notes fields to create
linkings, here is an example:
https://bbf.bsz-bw.de/cgi-bin/koha/opac-detail.pl?biblionumber=22022
Note says: bound with... clicking on the search link brings up the other items,
it's bound with and that have no barcode (in this case 1, but can be many).
>From the items without barcode a link leads back to the barcode item.
Links are created by putting ## callnumber or %% callnumber into the item
notes, with the option to have specific notes before the separator.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:05:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 11:05:40 +0000
Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows
"For loan" for value 0
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131
--- Comment #9 from Katrin Fischer ---
(In reply to Fridolin SOMERS from comment #8)
> (In reply to Katrin Fischer from comment #7)
> > >8) Without patch you see "For loan" in items.notforloan for value 0
> > >9) With patch you see "Available" in items.notforloan for value 0
> >
> > Still 'For loan' for me. Please fix test plan or patch!
>
> If you have memcached and/or plack, you need to restart them when you change
> authorized values.
Hi Frido, that should not be necessary in current versions, but I am retesting
anyway.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:28:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 11:28:48 +0000
Subject: [Koha-bugs] [Bug 20131] Inventory optional filters always shows
"For loan" for value 0
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20131
--- Comment #10 from Katrin Fischer ---
Hm, ok, I might not understand the reasoning behind this patch or even the bug
it tries to fix :(
>From my testing:
6) Create in authorized values category "NFL" a value 0 with description
"Available"
7) Go to inventory /cgi-bin/koha/tools/inventory.pl
8) Without patch you see "For loan" in items.notforloan for value 0
9) With patch you see "Available" in items.notforloan for value 0
When I do that, I end up with 2 values showing on the inventory form:
For loan and Available - both actually meaning the same.
Also: On the edit item form the Available appears twice(!) in the pull down and
the X to empty the field is no longer present.
What I can see is an inconsistency on the inventory form as we only have a "0"
value for not for loan, while we don't have that for lost, withdrawn and
damaged. I'd suggest to either remove it or add an empty option for all of
them. But also not using 'for loan' - because it still might not be, but
something like 'not set'. Or: Not lost, not withdrawn, not damaged,...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:31:34 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 11:31:34 +0000
Subject: [Koha-bugs] [Bug 20127] Label Making Solution
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20127
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
This sounds like extensive functionality planned. Why a plugin and not a
solution within Koha? Because it wouldn't fit besides the existing label
editor? Maybe it could use a part of it like the batch process? We also have
the quick label printing where a little of that is possible, but not quite. But
they are formatted to be changed by CSS easily.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:34:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 11:34:04 +0000
Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have
different timezones on the same server
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123
--- Comment #29 from Katrin Fischer ---
I like the idea of a wiki page with information on how this will work and where
the limits might be. Do you need to change MySQL configuration as well or is
the koha-conf variable enough?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 13:52:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 11:52:11 +0000
Subject: [Koha-bugs] [Bug 17489] Allow Koha plugins to have translations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17489
--- Comment #3 from Katrin Fischer ---
Hi Kyle, this looks promising! I am not sure I can figure it out myself, any
chance you could spend some time on a prototype?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:02:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 12:02:19 +0000
Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an
equivalent for our historical custom syntax
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961
--- Comment #5 from Katrin Fischer ---
Added to next meeting's agenda:
https://wiki.koha-community.org/wiki/General_IRC_meeting_4_April_2018#Agenda
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:11:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 12:11:14 +0000
Subject: [Koha-bugs] [Bug 19204] Fines in days restriction calculation is
not taking calender into account
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204
--- Comment #2 from Katrin Fischer ---
useDaysMode is used for calculating the due dates and usually not involved in
the overdues process. I am not sure it's the right one.
Maybe finesCalendar would be a better fit as it's already used to count the
days overdue? So it would make sense to use it for determining the suspension
date as well. With an update to the description. We could also have a new
preference SuspensionCalendar mimicking the behaviour.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:14:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 12:14:35 +0000
Subject: [Koha-bugs] [Bug 19204] Fines in days restriction calculation is
not taking calender into account
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19204
--- Comment #3 from Katrin Fischer ---
Actually looking at Bug 13909 - Suspension days calculation doesn't honour
finesCalendar I think finesCalendar would be best. And update the description
to say: Calculate fines and suspensions based on days overdue ...
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:17:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 12:17:38 +0000
Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634
--- Comment #12 from Katrin Fischer ---
What I think is:
Don't make the option, because the chance of messing up existing reports is
very very slim.
They will remain working as they work now if parameters are named differently.
If there exist parameters who already are named the exactly same, the patch
will take effect, but then we can also assume that this is indeed the wanted
behaviour.
Of course we should add a nice note to the release notes to highlight the new
feature!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:22:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 12:22:25 +0000
Subject: [Koha-bugs] [Bug 17961] TT syntax for notices - Prove we have an
equivalent for our historical custom syntax
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19578
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578
[Bug 19578] TT syntax for notices - There is no way to pre-process DB fields
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 14:22:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 12:22:25 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
pre-process DB fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |17961
CC| |katrin.fischer at bsz-bw.de
--- Comment #11 from Katrin Fischer ---
I think it seems the safest bet to keep the current behavour and do the
processing for all fields from biblio and biblioitems.
Could you provide a test plan Jonathan? Not quite sure yet how to work with the
TT syntax in notices.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961
[Bug 17961] TT syntax for notices - Prove we have an equivalent for our
historical custom syntax
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:48:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 13:48:38 +0000
Subject: [Koha-bugs] [Bug 20123] Allow multiple instances of Koha to have
different timezones on the same server
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20123
--- Comment #30 from Tom?s Cohen Arazi ---
(In reply to Katrin Fischer from comment #29)
> I like the idea of a wiki page with information on how this will work and
> where the limits might be. Do you need to change MySQL configuration as well
> or is the koha-conf variable enough?
Only koha-conf.xml! Isn't that beautiful?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:52:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 13:52:06 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #42 from Katrin Fischer ---
There are some mostly small issues:
1) Small rebase conflict in SQL files for permissions
2) Capitalization
+Home › Circulation › Checkout Notes
2) Translatability
$("#status_" + $issue_id).text("Not seen");
$("#status_" + $issue_id).text("Seen");
3) Move JavaScript to the bottom - we are currently migrating all pages to do
that. See: Bug 17858 - Omnibus: Move staff client JavaScript to the footer
4) Missing [% VERSION %] variable for JavaScript libraries:
+
See: Bug 12904 - Force browser to load new JavaScript and CSS files after
upgrade
5) Typo:
+ ( 1, 'manage_checkout_nots', 'Mark checkout notes as seen/not seen'),
6) There are also some issues noted by the QA script:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
FAIL forbidden patterns
forbidden pattern: Include [% KOHA_VERSION %] in css paths (bug
12904) - May be false positive (line 7)
forbidden pattern: Include [% KOHA_VERSION %] in js paths (bug
12904) - May be false positive (line 76)
FAIL valid_template
parse error -
/home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/checkout-notes.tt
line 134: unexpected token ([)
[% note.patron.title [% END %]
FAIL circ/on-site_checkouts.pl
FAIL valid
Global symbol "$pending_onsite_notes" requires explicit package
name
circ/on-site_checkouts.pl had compilation errors.
I've tried to test, but I can't see the link on the circulation home page,
possibly to a problem (typo?) with the permissions. Please fix and test. Thank
you!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:54:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 13:54:38 +0000
Subject: [Koha-bugs] [Bug 19772] Wrong success message if CHECKOUT_NOTE is
not defined
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|14224 |17698
--- Comment #8 from Katrin Fischer ---
(In reply to Aleisha Amohia from comment #7)
> (In reply to Katrin Fischer from comment #6)
> > Could there be a case where a library wants to activate the feature, but use
> > it without email? We have some cases like the suggestions emails where you
> > just delete the notice in that case. Maybe we could just adapt the text a
> > little and remove the error/warning? Making the options dependent seems more
> > hassle.
>
> I'm still working on the patch for Bug 17698 where the checkout notes will
> be shown on the staff dashboard, similar to how patron modifications are
> shown. I could add a patch to this bug that depends on 17698 where, if no
> notice is defined, it will not try to send an email and instead just show
> the note on the staff dashboard? hope that makes sense.
Yep, makes sense to me! I have taken a look on bug 17698 and it looks
promising. Linking both reports now.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
[Bug 14224] patron notes about item shown at check in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
[Bug 17698] Make patron notes show up on staff dashboard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:54:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 13:54:38 +0000
Subject: [Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19772
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772
[Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 15:54:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 13:54:38 +0000
Subject: [Koha-bugs] [Bug 14224] patron notes about item shown at check in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|19772 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19772
[Bug 19772] Wrong success message if CHECKOUT_NOTE is not defined
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:00:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:00:55 +0000
Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on
source of import
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |tomascohen at gmail.com
--- Comment #67 from Katrin Fischer ---
Hi David, thx for submitting. Peeking at the code I am not quite sure how it
works, but notice it adds a lot of code to C4. Would probably need quite a bit
of work.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:13:22 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:13:22 +0000
Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest
messages per branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:13:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:13:15 +0000
Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest
messages per branch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|NEW |Needs Signoff
--- Comment #4 from Katrin Fischer ---
Hi Andreas,
thx for your patches! Some things:
1) Once you submitted your patches it's important to switch the status to
'Needs Signoff' in order to get the attention of the testers, otherwise patches
can get easily lost in the saved searches.
2) The QA test tools can help you to find problems with your code easily. For
your patches the report is:
FAIL misc/cronjobs/advance_notices.pl
OK critic
FAIL forbidden patterns
forbidden pattern: tab char (line 367)
forbidden pattern: tab char (line 479)
forbidden pattern: tab char (line 366)
forbidden pattern: tab char (line 374)
forbidden pattern: tab char (line 357)
forbidden pattern: tab char (line 373)
forbidden pattern: tab char (line 372)
forbidden pattern: tab char (line 348)
forbidden pattern: tab char (line 356)
forbidden pattern: tab char (line 350)
forbidden pattern: tab char (line 368)
forbidden pattern: tab char (line 358)
forbidden pattern: tab char (line 347)
forbidden pattern: tab char (line 349)
forbidden pattern: tab char (line 355)
forbidden pattern: tab char (line 365)
forbidden pattern: tab char (line 353)
forbidden pattern: tab char (line 369)
forbidden pattern: tab char (line 371)
forbidden pattern: tab char (line 352)
forbidden pattern: tab char (line 354)
forbidden pattern: tab char (line 364)
forbidden pattern: tab char (line 351)
forbidden pattern: tab char (line 370)
FAIL t/db_dependent/cronjobs/advance_notices_digest.t
FAIL critic
Expression form of "eval" at line 167, column 1. See page 161
of PBP.
Bareword file handle opened at line 158, column 1. See pages
202,204 of PBP.
FAIL forbidden patterns
forbidden pattern: tab char (line 67)
3) This can all be fixed, but I see another problem here: libraries are
differently organized and we support a lot of different use cases with Koha.
Some libraries want Koha to only send one email instead of many, others like
yours don't want this behaviour. So we need to find a compromise here and a way
to make this configurable. I think a system preference could work here as I
don't see how to add it to the notices configuration in a good way.
4) We usually don't test .pl files yet... but not opposed to more tsts :) Tests
are failing for me right now:
t/db_dependent/cronjobs/advance_notices_digest.t .. 1/5
# Failed test 'There are two messages in the queue'
# at t/db_dependent/cronjobs/advance_notices_digest.t line 175.
# got: '0'
# expected: '2'
# Looks like you planned 5 tests but ran 1.
# Looks like you failed 1 test of 1 run.
t/db_dependent/cronjobs/advance_notices_digest.t .. Dubious, test returned 1
(wstat 256, 0x100)
Failed 5/5 subtests
5) If you want, you could also add an individual Sponsord-By line for each
sponsoring library. It depends on how you want the output in the release notes
later on.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:27:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:27:39 +0000
Subject: [Koha-bugs] [Bug 2797] Add Summary records to represent summary
holdings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2797
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |DUPLICATE
CC| |katrin.fischer at bsz-bw.de
--- Comment #2 from Katrin Fischer ---
*** This bug has been marked as a duplicate of bug 20447 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:27:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:27:39 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--- Comment #2 from Katrin Fischer ---
*** Bug 2797 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:33:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:33:58 +0000
Subject: [Koha-bugs] [Bug 20488] Manual renewal due date ignore closed day
in calendar
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20488
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
I think a warning with the option to confirm would be good instead of
automatically moving to the next opening day.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:41:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:41:48 +0000
Subject: [Koha-bugs] [Bug 20505] New: Selenium tests fail if server not
running
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505
Bug ID: 20505
Summary: Selenium tests fail if server not running
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: chris at bigballofwax.co.nz
Reporter: mtompset at hotmail.com
QA Contact: testopia at bugs.koha-community.org
If the dependencies for the Selenium tests are installed, but the steps
recommended on https://wiki.koha-community.org/wiki/Using_Selenium_with_Koha
are not taken before running the selenium tests, they die non-gracefully. Patch
them to skip informatively.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:50:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:50:23 +0000
Subject: [Koha-bugs] [Bug 20505] Selenium tests fail if server not running
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505
--- Comment #1 from M. Tompsett ---
Created attachment 73517
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73517&action=edit
Bug 20505: Patch selenium tests to skip gracefully
TEST PLAN
---------
1) In a koha shell on kohadevbox, run
prove -v t/db_dependent/selenium
until it doesn't skip because of missing
dependencies, but rather because of not running
a selenium server.
2) apply this patch and restart_all
3) rerun the tests
-- they will skip gracefully and informatively.
4) run koha qa test tools
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 16:50:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 14:50:21 +0000
Subject: [Koha-bugs] [Bug 20505] Selenium tests fail if server not running
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:35:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 15:35:24 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #9 from M. Tompsett ---
Tested:
Staff
OPAC
Self-checkout
And fresh install
Only the fresh install allowed the system log in, as desired.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:49:18 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 15:49:18 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
--- Comment #10 from M. Tompsett ---
Attempted steps to go to urls which should trigger modified code in both logged
in and logged out states. Failures and successes as expected.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:50:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 15:50:30 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
--- Comment #11 from M. Tompsett ---
Comment on attachment 73400
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73400
Bug 20489: Prevent DB user login
Review of attachment 73400:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20489&attachment=73400)
-----------------------------------------------------------------
::: acqui/neworderempty.pl
@@ +203,5 @@
> my $order_patron = Koha::Patrons->find( $order_user_id );
> push @order_users, $order_patron if $order_patron;
> }
> + if ( $data->{subscriptionid} ) {
> + $template->param( subscriptionid => $data->{subscriptionid} );
This tweak is the one I don't understand.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:55:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 15:55:55 +0000
Subject: [Koha-bugs] [Bug 19910] Download report as 'Comma separated' is
misleading
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19910
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73494|0 |1
is obsolete| |
--- Comment #21 from Victor Grousset/tuxayo ---
Created attachment 73518
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73518&action=edit
Bug 19910 - Use the delimiter syspref to name download link
To test:
1 - Set delimiter syspref to anything but comma
2 - Download report results as comma separated text
3 - They actually follow the syspref
4 - Apply patch
5 - Download link should now match pref selection
6 - Change pref, note link changes
7 - Verify things still work as expected
Signed-off-by: Owen Leonard
Signed-off-by: Victor Grousset
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 17:58:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 15:58:46 +0000
Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve
notification if the checkout is due in the future
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014
--- Comment #9 from Katrin Fischer ---
I am not sure all libraries can generally agree to send the notice on date due,
because then the user has no way to return the item on time usually.
I think there are separate issues thinking about the notice:
- Don't send a notice every day the item is not returned, sent a notice once or
at least not too often
- Be able to inform the patrons on time before the due date so they are able to
return the item on time
- Don't inform the user weeks ahead
Could it help to set the "No renewal before" to a lower number of days? This
would prevent auto renewals from happening and together with "No automatic
renewal after" could limit the timeframe for sending the notice to a few days.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 18:19:01 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 16:19:01 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
--- Comment #8 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #7)
> Next step is to re-add the ability to "edit the manual".
> I would suggest to remove the possibility to edit the manual, but allow to
> create new pages (which will not be erased on update).
>
> I need to know what are the different use cases and needs.
Possible use cases I could see for local help files:
- Being able to explain custom fields like authorised values, patron attributes
etc.
- Being able to explain how to use collections, locations, item types
- Offer local help for cataloguing like explanations for fields and subfields,
internal standards and agreements
> We need also to think about an ergonomic way to manage these additional help
> files.
> For instance: in the top right of the staff pages we will have a "Help"
> group buttons with
> Link to the official manual | Add a new page
> And when new pages are created:
> Link to the official manual | Additional pages 1..N | Add a new page
>
> The additional pages would be linked to a specific page of the staff
> interface (see the mapping in Koha::Manual)
>
> Does it make sense? Other ideas/opinions?
That makes sense to me. I think having a HTML based editor would be better than
.rst for the local help files and that we should store them in the database.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 18:25:40 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 16:25:40 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Patch doesn't apply
--- Comment #9 from Katrin Fischer ---
Hi Jonathan, can you please rebase? I tried but it got a bit chaotic.
I think you are missing the change to
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc for the new
permission.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 18:30:20 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 16:30:20 +0000
Subject: [Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with
IFLA updates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bdiazmunoz at gmail.com,
| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
Hi Julian,
this is an interesting approach.
Are you aware that we can currently already translate the SQL files for the
frameworks using pootle?
For an example:
http://translate.koha-community.org/de/marc21/
Bernardo provides the auto-generated SQL files for creating patches for the web
installer.
Could there be a way to bring this together? Use po files to create the .yml
file?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sun Apr 1 21:51:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 01 Apr 2018 19:51:08 +0000
Subject: [Koha-bugs] [Bug 20158] add a new column in the tables of the
list's module
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20158
--- Comment #4 from Katrin Fischer ---
Hi Marjorie, I see what you mean, but I am not sure putting more and more item
information on the display is the best solution, especially as it will clutter
the display for libraries with a lot of items on some of the records.
What is your use case? Why would you want to see the barcodes?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 02:42:12 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 00:42:12 +0000
Subject: [Koha-bugs] [Bug 20428] MARC import fails on Debian Stretch
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20428
--- Comment #12 from M. Tompsett ---
Comment on attachment 73430
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73430
Bug 20428: Make Koha::UploadedFile use the new config entry for tmp files
Review of attachment 73430:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20428&attachment=73430)
-----------------------------------------------------------------
::: Koha/UploadedFile.pm
@@ +169,5 @@
> sub temporary_directory {
> my ( $class ) = @_;
> + return (C4::Context->config('upload_tmp_path'))
> + ? C4::Context->config('upload_tmp_path')
> + : File::Spec->tmpdir;
Why a trinary when a || File::Spec->tmpdir would work more nicely?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 02:46:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 00:46:47 +0000
Subject: [Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be
removed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304
--- Comment #4 from M. Tompsett ---
Comment on attachment 72272
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72272
Bug 20304: Remove warnings from cataloguing scripts
Review of attachment 72272:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20304&attachment=72272)
-----------------------------------------------------------------
::: cataloguing/additem.pl
@@ +157,5 @@
> my $temp2 = $temp->field($CNtag);
> if ($temp2) {
> + my $value = q{};
> + $value .= $temp2->subfield($CNsubfield) if $temp2->subfield($CNsubfield);
> + $value .= $temp2->subfield($CNsubfield2) if $temp2->subfield($CNsubfield2);
Where's the space gone?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 02:48:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 00:48:00 +0000
Subject: [Koha-bugs] [Bug 20505] Selenium tests fail if server not running
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|chris at bigballofwax.co.nz |mtompset at hotmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 02:48:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 00:48:13 +0000
Subject: [Koha-bugs] [Bug 20505] Selenium tests fail if server not running
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20505
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 03:32:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 01:32:25 +0000
Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889
--- Comment #7 from M. Tompsett ---
Comment on attachment 73362
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73362
Bug 18889 - Storing and display of barcode with fines in intranet
Review of attachment 73362:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18889&attachment=73362)
-----------------------------------------------------------------
::: C4/Accounts.pm
@@ +281,4 @@
> date => \'NOW()',
> amount => $amount,
> description => $desc,
> + barcode => $barcode,
Why pass barcode when the itemnumber is available?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 03:33:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 01:33:07 +0000
Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889
--- Comment #8 from M. Tompsett ---
Created attachment 73519
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73519&action=edit
Bug 18889: Simpler counter-patch
There is no need to add barcode into the accountlines
table, as a relationship via itemnumber can easily look it up.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 03:39:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 01:39:55 +0000
Subject: [Koha-bugs] [Bug 18889] Item number in biblio description in fine
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #9 from M. Tompsett ---
Counter Patch Test Plan
------------------------
1) Add a manual fine with a barcode to a member.
2) Look at the pay invoice tab.
-- no barcode shown.
3) apply counter patch only patch
-- and no updatedatabase or rebuilding tables required!
4) restart_all (silly plack caching)
5) refresh the pay invoice tab.
-- barcode now displayed.
6) run koha qa test tools.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:09:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 02:09:56 +0000
Subject: [Koha-bugs] [Bug 20419] Current location not updated correctly on
the return of an item on hold
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20419
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
Status|Needs Signoff |Failed QA
--- Comment #2 from M. Tompsett ---
Please include unit tests when modifying C4 or Koha libraries. This prevents
regression. It would be nice if they fail before the fix, and then pass after
the fix.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:18:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 02:18:42 +0000
Subject: [Koha-bugs] [Bug 20116] Cache language list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #5 from M. Tompsett ---
Comment on attachment 71098
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71098
Bug 20116: Cache language list
Review of attachment 71098:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20116&attachment=71098)
-----------------------------------------------------------------
::: C4/Languages.pm
@@ +122,3 @@
> if ($interface && $interface eq 'opac' ) {
> my $htdocs = C4::Context->config('opachtdocs');
> @languages = _get_opac_language_dirs( $htdocs, $theme );
Forgot to delete this line, I think.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:29:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 02:29:03 +0000
Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=20103
CC| |mtompset at hotmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:29:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 02:29:03 +0000
Subject: [Koha-bugs] [Bug 20103] Remove Readonly::XS
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20103
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=19735
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 04:37:00 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 02:37:00 +0000
Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066
--- Comment #17 from M. Tompsett ---
Comment on attachment 73186
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73186
Bug 19066 - Add branchcode to accountlines
Review of attachment 73186:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19066&attachment=73186)
-----------------------------------------------------------------
::: Koha/Account.pm
@@ +76,4 @@
> my $account_type = $params->{account_type};
> my $offset_type = $params->{offset_type} || $type eq 'writeoff' ? 'Writeoff' : 'Payment';
>
> + $library_id ||= C4::Context->userenv ? C4::Context->userenv->{'branch'} : undef;
why not below the $userenv below? Less referencing, shorter line, and easier to
read. :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 09:56:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 07:56:47 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
are planned only for current subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #53 from Katrin Fischer ---
Alex, should this be set back to Signed off with your follow-up?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 12:26:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 10:26:51 +0000
Subject: [Koha-bugs] [Bug 20346] Patron filtering resulting in new search
rather than filtering existing results
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20346
--- Comment #10 from Alex Buckley ---
Created attachment 73520
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73520&action=edit
Bug 20346 - Making JS strings translatable
This is based on tester feedback in comments 7 and 8
Sponsored-By: Catalyst IT
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 13:24:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 11:24:06 +0000
Subject: [Koha-bugs] [Bug 20506] New: How do I get drop menu help for
classification in koha?
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20506
Bug ID: 20506
Summary: How do I get drop menu help for classification in
koha?
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: manjunath at tapmi.edu.in
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
we have installed koha s/w in our library. we are not able to make the s/w auto
appenadable field for books, journal issues, project reports separately. we
ahave separate Accno/barcode for each item type. similarly, how do we get DDC
classno & subject help from current pool of classnos and subject headings in
the collection?. we have table of classnos and subejct headings in the book
collection. we need the selection help to avoid typo errors. can KOHA community
help us?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 13:26:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 11:26:42 +0000
Subject: [Koha-bugs] [Bug 20506] How do I get drop menu help for
classification in koha?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20506
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Resolution|--- |INVALID
Status|NEW |RESOLVED
--- Comment #1 from Katrin Fischer ---
Bugzilla is used for reporting bugs and enhancement requests, but this reads
more like a support request. Please ask your questions on the mailing list:
https://koha-community.org/support/koha-mailing-lists/
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 13:50:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 11:50:39 +0000
Subject: [Koha-bugs] [Bug 20507] New: Shelf browser does not update image
sources when paging
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20507
Bug ID: 20507
Summary: Shelf browser does not update image sources when
paging
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: nick at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
When using a cover source other than Amazon (which uses static links) the shelf
browser does not fire a call to the image sources when moving to a new page
To recreate:
Enable coce (https://coce.bywatersolutions.com) and enable all sources except
amazon
Enable shelf browser
View a title in the opac
View the shelf browser, note images load on first page
Page left or right and note images are not loaded
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:09:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:09:42 +0000
Subject: [Koha-bugs] [Bug 20116] Cache language list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #71098|0 |1
is obsolete| |
--- Comment #6 from Jonathan Druart ---
Created attachment 73521
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73521&action=edit
Bug 20116: Cache language list
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:09:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:09:59 +0000
Subject: [Koha-bugs] [Bug 20116] Cache language list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
--- Comment #7 from Jonathan Druart ---
(In reply to M. Tompsett from comment #5)
> Comment on attachment 71098 [details] [review]
> Bug 20116: Cache language list
>
> Review of attachment 71098 [details] [review]:
> -----------------------------------------------------------------
>
> ::: C4/Languages.pm
> @@ +122,3 @@
> > if ($interface && $interface eq 'opac' ) {
> > my $htdocs = C4::Context->config('opachtdocs');
> > @languages = _get_opac_language_dirs( $htdocs, $theme );
>
> Forgot to delete this line, I think.
Indeed, thanks for catching it!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:15:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:15:39 +0000
Subject: [Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be
removed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72272|0 |1
is obsolete| |
--- Comment #5 from Jonathan Druart ---
Created attachment 73522
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73522&action=edit
Bug 20304: Remove warnings from cataloguing scripts
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:16:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:16:45 +0000
Subject: [Koha-bugs] [Bug 20304] Warnings in cataloguing scripts need to be
removed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20304
--- Comment #6 from Jonathan Druart ---
(In reply to M. Tompsett from comment #4)
> Comment on attachment 72272 [details] [review]
> Bug 20304: Remove warnings from cataloguing scripts
>
> Review of attachment 72272 [details] [review]:
> -----------------------------------------------------------------
>
> ::: cataloguing/additem.pl
> @@ +157,5 @@
> > my $temp2 = $temp->field($CNtag);
> > if ($temp2) {
> > + my $value = q{};
> > + $value .= $temp2->subfield($CNsubfield) if $temp2->subfield($CNsubfield);
> > + $value .= $temp2->subfield($CNsubfield2) if $temp2->subfield($CNsubfield2);
>
> Where's the space gone?
lost, but I found it!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:26:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:26:48 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:26:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:26:52 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #69807|0 |1
is obsolete| |
Attachment #69808|0 |1
is obsolete| |
Attachment #70131|0 |1
is obsolete| |
Attachment #70132|0 |1
is obsolete| |
Attachment #70133|0 |1
is obsolete| |
--- Comment #10 from Jonathan Druart ---
Created attachment 73523
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73523&action=edit
Bug 19817: Redirect to the online manual
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:26:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:26:58 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
--- Comment #11 from Jonathan Druart ---
Created attachment 73524
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73524&action=edit
Bug 19817: Remove local help files + edit help feature
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:27:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:27:02 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
--- Comment #12 from Jonathan Druart ---
Created attachment 73525
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73525&action=edit
Bug 19817: Make the location of the manual configurable - KohaManualBaseURL
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:27:06 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:27:06 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
--- Comment #13 from Jonathan Druart ---
Created attachment 73526
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73526&action=edit
Bug 19817: Move code to Koha::Manual to make it testable and reusable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:27:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:27:11 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
--- Comment #14 from Jonathan Druart ---
Created attachment 73527
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73527&action=edit
Bug 19817: Add new permission edit_help
Change in existing behaviour!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:29:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:29:39 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
--- Comment #15 from Jonathan Druart ---
Done, note that the last patch does nothing (new permission is not used).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:35:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:35:30 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73400|0 |1
is obsolete| |
Attachment #73425|0 |1
is obsolete| |
--- Comment #12 from Jonathan Druart ---
Created attachment 73528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73528&action=edit
Bug 20489: Prevent DB user login
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:35:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:35:33 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
--- Comment #13 from Jonathan Druart ---
Created attachment 73529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73529&action=edit
Bug 20489: Remove warnings from the interface
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:36:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:36:13 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
--- Comment #14 from Jonathan Druart ---
(In reply to M. Tompsett from comment #11)
> This tweak is the one I don't understand.
It was not related to this patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:38:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:38:29 +0000
Subject: [Koha-bugs] [Bug 20077] Patroncards are printed blank
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20077
Chris Nighswonger changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |cnighswonger at foundations.ed
| |u
--- Comment #7 from Chris Nighswonger ---
(In reply to Sven H. from comment #3)
>
>
> I have a similar problem.
>
> When I try to print the patron cards, the
> /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl does not finish
> and runs with 100% CPU load.
>
> In plack-error.log I find the following lines:
> Use of uninitialized value $batch_id in concatenation (.) or string at
> /usr/share/koha/intranet/cgi-bin/patroncards/create-pdf.pl line 68.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239.
> Use of uninitialized value in addition (+) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239.
> Use of uninitialized value in addition (+) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 288.
> Use of uninitialized value in multiplication (*) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 239.
> Use of uninitialized value in addition (+) at
> /usr/share/koha/lib/C4/Patroncards/Patroncard.pm line 256.
>
> The problem first appeared in February 2018 after I started the Ubuntu
> updates. Unfortunately I don't remember what has been updated.
>
snip
>
> Unfortunately I am not able to print patron cards at the moment. It would be
> great if there was a solution for this soon.
I'm not sure what is going on in this particular instance, but taking the same
steps on my production system results in a PDF containing the expected cards
and nearly zero CPU usage.
Unless someone else can confirm the problem, I would look at something local.
Perhaps a Koha update did not apply well or some such, resulting in a script
not being updated.
Also, this appears to be a different problem than the one the OP reported. It
would be good to open a new bug for it.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:49:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:49:09 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
pre-process DB fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578
--- Comment #12 from Jonathan Druart ---
Test plan:
- Confirm that the new tests pass. That should be enough to confirm this change
make sense.
Test plan (manual):
- Create a biblio with a title ending with a punctuation (like
"with_punctuation_"), or any other fields of biblio/biblioitem
- Generate a notice which will display this field (CHECKIN for instance)
Use the historical syntax and the TT syntax, both should display the title
without the punctuation character at the end
CHECKIN historical:
The following items have been checked in:
----
<>
----
CHECKIN TT syntax:
The following items have been checked in:
----
[% biblio.title %]
----
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:50:04 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:50:04 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
pre-process DB fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_18_05_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:51:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:51:45 +0000
Subject: [Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is
impossible
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |mtompset at hotmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 16:55:54 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 14:55:54 +0000
Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #27 from Jonathan Druart ---
(In reply to Jon Knight from comment #26)
> (In reply to Katrin Fischer from comment #25)
> > Hi S?verine, there is no a setting in administration > currency for each
> > currency, where you can define if there should be a space or not.
> >
> > I am torn about seeing the currency. I think we agreed a long while ago that
> > we should not show the currency symbols in acq as long as it's the active
> > currency as it would clutter a lot of the displays, where you deal with a
> > lot of numbers and prices. Would you agree to remove the currency symbol
> > display?
> > $Price with_symbol => 1
>
> That's how I had it before Jonathan Druart asked me to put the symbols in
> place in comment #18 above. I don't mind either way as long as the QA team
> and RM can agree (or do I have to add in a syspref for this? :-) ).
>
> I'll await a decision before changing this simple patch again.
IIRC you displayed the currency code :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 17:16:55 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 15:16:55 +0000
Subject: [Koha-bugs] [Bug 20508] New: Validation for *MandatoryField and
*UnwantedField sysprefs
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20508
Bug ID: 20508
Summary: Validation for *MandatoryField and *UnwantedField
sysprefs
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Staff Client
Assignee: koha-bugs at lists.koha-community.org
Reporter: barton at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com
When any the system preferences
BorrowerMandatoryField
BorrowerUnwantedField
PatronSelfModificationBorrowerUnwantedField
PatronSelfRegistrationBorrowerMandatoryField
PatronSelfRegistrationBorrowerUnwantedField
are being populated, we should check that
a) The entered fields are columns in the borrowers table
b) Mandatory / Unwanted fields that refer to the same form
(BorrowerMandatoryField/BorrowerUnwantedField and
PatronSelfRegistrationBorrowerMandatoryField/PatronSelfRegistrationBorrowerUnwantedField)
do not contain the same fields.
c) If autoMemberNum is set, don't allow cardnumber in *MandatoryField
See also:
* Bug 17433
* Bug 19642
* Bug 19225
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 17:38:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 15:38:46 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtompset at hotmail.com
--- Comment #7 from M. Tompsett ---
https://archive.ifla.org/VI/8/projects/UNIMARC-HoldingsFormat.pdf
-- but isn't there supposed to be a 100?!
12-15 Character Set (Mandatory)
These four character positions indicate the principal graphic character sets
used in the record.
Positions 12-13 designate the G0 set and positions 14-15 designate the G1 set.
If a G1 set is
not needed, positions 14-15 contain blanks.
01 = ISO 646, IRV version (basic Latin set)
02 = ISO Registration # 37 (basic Cyrillic set)
03 = ISO 5426 (extended Latin set)
04 = ISO DIS 5427 (extended Cyrillic set)
05 = ISO 5428 (Greek set)
06 = ISO 6438 (African coded character set)
07 = ISO 10586 (Georgian set)
08 = ISO 8957 (Hebrew set) Table 1
09 = ISO 8957 (Hebrew set) Table 2
10 = [Reserved]
11 = ISO 5426-2 (Latin characters used in minor European languages and obsolete
typography)
50 = ISO 10646 Level 3 (Unicode)
Oh yuck... reading the MARC::File::XML library... it basically fakes it.
# Does the record think it is already Unicode?
if ($original_encoding ne 'a' && lc($format) !~ /^unimarc/o) {
# If not, we'll make it so
$_transcode++;
substr($ldr,9,1,'a');
$record->leader( $ldr );
}
which is why the as_xml in elsewhere does the "USMARC" thing. Okay. I'll test
this, since I'm assuming Fridolin has already tested in a UNIMARC context
before submitting this patch.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 17:57:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 15:57:23 +0000
Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file
with default values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |19453
--- Comment #3 from Jonathan Druart ---
Ha, I think I found the problem.
It has been caused by
commit b830349f45007629f141a9835e05b95f90ee4b92
Bug 19453: Incorrect jQuery selector for fund drop down validation
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453
[Bug 19453] Client side validation broken for "Fund" select
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 17:57:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 15:57:23 +0000
Subject: [Koha-bugs] [Bug 19453] Client side validation broken for "Fund"
select
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |20426
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426
[Bug 20426] Can't import all titles from a stage file with default values
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 18:04:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 16:04:10 +0000
Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file
with default values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 18:04:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 16:04:13 +0000
Subject: [Koha-bugs] [Bug 20426] Can't import all titles from a stage file
with default values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426
--- Comment #4 from Jonathan Druart ---
Created attachment 73530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73530&action=edit
Bug 20426: Fix default fund value when adding orders from iso2709 file
A new bug has been highlighted since:
commit b830349f45007629f141a9835e05b95f90ee4b92
Bug 19453: Incorrect jQuery selector for fund drop down validation
Prior to bug 19453 the check on the existence of the fund did not work
as expected, no select with name='budget_code' existed and the error was
never raised.
Now it works but expect a fund to be selected for every record to
import.
This check must only be done if there is no default value selected.
Test plan:
- Create an order from a staged file
- Do not select any funds
=> You must get a warning
- Select a specific fund for some of the records
=> You must get a warning
- Select a default fund in the last tab
=> You must not get a warning and the records must be imported and
inserted with the correct fund
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 18:55:29 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 16:55:29 +0000
Subject: [Koha-bugs] [Bug 18757] Problem when importing only items in MARC
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18757
--- Comment #8 from M. Tompsett ---
BTW, it should be noted that this same problem shows itself as an "Internal
Server Error" if one tries to manually catalogue a record in UNIMARC, and uses
something clearly bad, like "KABOOM!" in the 100$a field. :)
substr outside of string at /usr/share/perl5/MARC/File/XML.pm line 561 (#2)
(W substr)(F) You tried to reference a substr() that pointed outside of
a string. That is, the absolute value of the offset was larger than the
length of the string. See "substr" in perlfunc. This warning is fatal if
substr is used in an lvalue context (as the left hand side of an
assignment or as a subroutine argument for example).
Use of uninitialized value $enc in string eq at
/usr/share/perl5/MARC/File/XML.pm line 563 (#1)
Use of uninitialized value $enc in string eq at
/usr/share/perl5/MARC/File/XML.pm line 565 (#1)
Use of uninitialized value $enc in concatenation (.) or string at
/usr/share/perl5/MARC/File/XML.pm line 568 (#1)
Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a ->
kaboom at /usr/share/perl5/MARC/File/XML.pm line 568.
No need to make any 200 rules.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:12:11 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 17:12:11 +0000
Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually
modify the current item (cataloguing/additem.pl)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974
--- Comment #26 from Jonathan Druart ---
Created attachment 73531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73531&action=edit
Bug 19974: Make MarkLostItemsAsReturned multiple
Given the confusion regarding this behaviour it sounds better to make it
configurable.
This pref will take 4 different values, 1 per place an item can be
marked as lost.
Test plan:
Mark items as lost and confirm the item is returned or not, depending on
the value of the system preference.
- from the longoverdue cronjob (--mark-returned takes precedence if set)
- from the batch item modification tool
- when cataloguing an item
- from the items tab of the catalog module
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:14:10 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 17:14:10 +0000
Subject: [Koha-bugs] [Bug 19974] Marking an item as 'lost' will not actually
modify the current item (cataloguing/additem.pl)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19974
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |Needs Signoff
Severity|normal |major
Keywords| |rel_18_05_candidate
--- Comment #27 from Jonathan Druart ---
I have attached a patch to test, it makes the pref multiple to bring
flexibility.
We need to resolve this for 18.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:19:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 17:19:53 +0000
Subject: [Koha-bugs] [Bug 20502] Record URL broken,
when there is more than one 856 on the record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #1 from Jonathan Druart ---
We should not use biblioitems.url but GetMarcUrls instead
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:21:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 17:21:46 +0000
Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged
invoice without Invoice number
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Attachment #72969|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:21:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 17:21:51 +0000
Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged
invoice without Invoice number
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72975|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 19:30:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 17:30:39 +0000
Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged
invoice without Invoice number
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318
--- Comment #15 from Jonathan Druart ---
Created attachment 73532
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73532&action=edit
Bug 20318: Add class 'required' to the label
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:25:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:25:48 +0000
Subject: [Koha-bugs] [Bug 20392] Multiple biblio holding does not work when
patron is not set
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20392
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Passed QA |RESOLVED
--- Comment #7 from Jonathan Druart ---
*** This bug has been marked as a duplicate of bug 18474 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:25:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:25:48 +0000
Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks
when patron is searched for
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
--- Comment #11 from Jonathan Druart ---
*** Bug 20392 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:28:53 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:28:53 +0000
Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the
About Koha page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674
--- Comment #4 from M. Tompsett ---
Created attachment 73534
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73534&action=edit
Bug 18674: Follow up on missing TZ SetEnv for plack
It should also be noted that
/etc/apache2/sites-enabled/{configuration file}
should also contain:
RequestHeader add X-Koha-SetEnv "TZ {timezone}"
Where {timezone} is the desired instance timezone.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:28:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:28:48 +0000
Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the
About Koha page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #72214|0 |1
is obsolete| |
--- Comment #3 from M. Tompsett ---
Created attachment 73533
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73533&action=edit
Bug 18674: Added timezone information to about page
Before patch: No timezone section
After patch: timezone section at bottom of
Server information tab.
Actual is what is being used. Config overrides environment variables.
So if there is confusion why the environment variables aren't working,
it will be visible why.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:29:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:29:30 +0000
Subject: [Koha-bugs] [Bug 18820] The different parts in the main don't
automatically adjust with the available space
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:29:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:29:31 +0000
Subject: [Koha-bugs] [Bug 18674] Show timezone for Perl and MySQL on the
About Koha page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18674
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:30:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:30:41 +0000
Subject: [Koha-bugs] [Bug 17373] Elasticsearch - Authority mappings for
UNIMARC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
--- Comment #13 from Jonathan Druart ---
Please fix patches' author (name and email).
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:42:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:42:39 +0000
Subject: [Koha-bugs] [Bug 20509] New: Data consistency - authority types
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509
Bug ID: 20509
Summary: Data consistency - authority types
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: jonathan.druart at bugs.koha-community.org
QA Contact: testopia at bugs.koha-community.org
Depends on: 20385
>From bug 20385.
We should display a message on the about page (or a new page dedicated to data
consistency) if an authtypecode of authority records does not correspond to an
authority type defined in the system.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385
[Bug 20385] ElasticSearch authority search raises Software error
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:42:39 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:42:39 +0000
Subject: [Koha-bugs] [Bug 20385] ElasticSearch authority search raises
Software error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |20509
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20509
[Bug 20509] Data consistency - authority types
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:46:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:46:31 +0000
Subject: [Koha-bugs] [Bug 20385] ElasticSearch authority search raises
Software error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385
--- Comment #11 from Jonathan Druart ---
We really need tests for these ES methods!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:49:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:49:48 +0000
Subject: [Koha-bugs] [Bug 20282] Wrong attribute in template calls to match
holding branch when adding/editing a course reserve item
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Depends on| |15758
--- Comment #4 from Jonathan Druart ---
Caused by
commit 9b9803b69c8bde879768ccfa3cc4688ef46b7799
Bug 15758: Koha::Libraries - Remove GetBranchesLoop
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758
[Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 21:49:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 19:49:48 +0000
Subject: [Koha-bugs] [Bug 15758] Move the C4::Branch related code to
Koha::Libraries - part 4
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |20282
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282
[Bug 20282] Wrong attribute in template calls to match holding branch when
adding/editing a course reserve item
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:08:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 20:08:52 +0000
Subject: [Koha-bugs] [Bug 19479] Price display on a basketgroup
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479
--- Comment #28 from Katrin Fischer ---
> That's how I had it before Jonathan Druart asked me to put the symbols in
> place in comment #18 above. I don't mind either way as long as the QA team
> and RM can agree (or do I have to add in a syspref for this? :-) ).
>
> I'll await a decision before changing this simple patch again.
I talked to Joubu and removing the currency symbols will be safe ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:11:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 20:11:32 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
confusing and unexpected values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812
--- Comment #10 from Jonathan Druart ---
(In reply to Kyle M Hall from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > There is an access to the removed variable "holds" in the template
> > loop_order.holds
> >
> > That means we now see "Can't delete catalog record, see constraints below",
> > but without anything below...
>
> The code you are referencing is in loop_orders, but this patch only alters
> loop_received which does not have that message. I'm not sure how this patch
> could be causing that. If you can give me some line numbers I'd be happy to
> take another look!
Indeed, sounds like I mixed the 2 tables reading the code.
Something else:
1. What about comment 6?
2. "1 / 0" reads wrong, but I have no idea how it could be better.
3. line 141 $line{holds} = 0;
should be removed, right?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:42:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 20:42:15 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add index from UI
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Passed QA |Failed QA
--- Comment #8 from Jonathan Druart ---
1. What's the point of the JS function valid_line?
I think you should double-check it, it does not do what you expect it to do.
2. You are reusing code to duplicate a new mapping but for something else. You
should rename the variables to avoid confusion then.
For instance "search_fields" is not an index name
3. Bug report's title is wrong, we are not adding/removing indices
4. I did not implement that part on the original patch because it's hard to
keep an interface consistent.
For instance:
- create a new search field
=> You cannot create a new mapping, you have to save first
- create a new search field, save
=> You can delete it. So it you create a mapping using it, you can still delete
it. If you save => kaboom
=> If you have a search field already mapped and delete the mapping, you cannot
delete the search field.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:49:07 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 20:49:07 +0000
Subject: [Koha-bugs] [Bug 20329] Text input fields are wider than the
fieldset class they are inside of
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20329
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |minor
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Passed QA |Failed QA
Keywords| |rel_18_05_candidate
--- Comment #10 from Jonathan Druart ---
It is not a good idea to specify a size in px, you should use a relative lenght
instead.
We already have
div.yui-b fieldset.brief select {
width: 12em;
}
12em sounds like a good value here.
Maybe the following addition would be enough:
div.yui-b fieldset.brief input {
width: 12em;
}
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:52:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 20:52:02 +0000
Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in
circulation.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--- Comment #8 from Jonathan Druart ---
Any good reasons to use custom tag elements here?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:52:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 20:52:57 +0000
Subject: [Koha-bugs] [Bug 20343] Show number of checkouts by itemtype in
circulation.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20343
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Failed QA
--- Comment #9 from Jonathan Druart ---
Translatable strings must be put in .tt files.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 22:59:49 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 20:59:49 +0000
Subject: [Koha-bugs] [Bug 20467] Add ability to batch add items to a course
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
Status|Passed QA |Failed QA
--- Comment #11 from Jonathan Druart ---
1. Need to be patched with changes on bug 20282
2. I think you should use the TT plugin AuthorisedValues (and include file
options_for_authorised_value_categories) for CCODE and LOC
3. You should use uniq on @barcodes (and use the same split we already do in
tools/*: \s\n)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:01:33 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:01:33 +0000
Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817
--- Comment #16 from Katrin Fischer ---
Hi Jonathan,
some thoughts:
1) sub _get_base_url doesn't look quite right yet.
a) It hardcodes en. Ideally we should try to check for the existence of a
translated manual and use that, with a fallback to en. If we can't do that,
we'll maybe need to add a pref where you can add the lanugage codes to use.
b) For the local manual URL you combine:
C4::Context->preference('staffClientBaseURL') . $KohaManualBaseURL;
I think it might be good to allow for a full URL in KohaManualBaseURL. That way
you could have the help on the same server or at another location.
2) If the permission doesn't work yet, I would not include it :)
3) The manual layout doesn't work well in the small pop up. I wonder if there
is a way to leave off the side navigation, but probably we can just make the
window a bit wider.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:24 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:14:24 +0000
Subject: [Koha-bugs] [Bug 18820] The different parts in the main don't
automatically adjust with the available space
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:14:30 +0000
Subject: [Koha-bugs] [Bug 18382] action_logs entry for module HOLDS,
action SUSPEND is spammy
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18382
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #22 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:35 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:14:35 +0000
Subject: [Koha-bugs] [Bug 18474] Placing multiple holds from results breaks
when patron is searched for
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18474
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #12 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:14:15 +0000
Subject: [Koha-bugs] [Bug 18820] The different parts in the main don't
automatically adjust with the available space
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820
--- Comment #24 from Jonathan Druart ---
Patches pushed to master.
Congratulations Roch and Philippe for your first patches in!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:46 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:14:46 +0000
Subject: [Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #19 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:51 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:14:51 +0000
Subject: [Koha-bugs] [Bug 19892] Replace numbersphr variable with
Koha.Preference('OPACNumbersPreferPhrase') in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19892
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #9 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:14:57 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:14:57 +0000
Subject: [Koha-bugs] [Bug 19907] Email validation on patron add/edit not
working
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19907
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #8 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:03 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:03 +0000
Subject: [Koha-bugs] [Bug 20052] Add Reports object class
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #10 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:08 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:08 +0000
Subject: [Koha-bugs] [Bug 20282] Wrong attribute in template calls to match
holding branch when adding/editing a course reserve item
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20282
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #5 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:14 +0000
Subject: [Koha-bugs] [Bug 20291] Add a StaffLoginInstructions system
preference to add text to the staff client login box
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20291
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #14 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:17 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:17 +0000
Subject: [Koha-bugs] [Bug 19812] Holds count in "Already received" table has
confusing and unexpected values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19812
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #11 from Katrin Fischer ---
I've tested it and I think it's still a little confusing.
Right now it is: total of holds / holds on on order items
Which can lead to the 1 / 0 that Jonathan pointed out. Maybe it would make more
sense to switch the values? Or just show the total number of holds = record
level + item level on on order items?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:19 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:19 +0000
Subject: [Koha-bugs] [Bug 20318] Merge invoices can lead to an merged
invoice without Invoice number
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20318
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #16 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:25 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:25 +0000
Subject: [Koha-bugs] [Bug 20369] Analytics search is broken with
QueryAutoTruncate set to 'only if * is added'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20369
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #7 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:30 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:30 +0000
Subject: [Koha-bugs] [Bug 20385] ElasticSearch authority search raises
Software error
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20385
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #12 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:36 +0000
Subject: [Koha-bugs] [Bug 20462] Duplicate barcodes in batch item deletion
cause software error if deleting biblio records.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20462
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #4 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:42 +0000
Subject: [Koha-bugs] [Bug 20494] Remove unused code in neworderempty.pl and
addbiblio.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20494
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #4 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:15:47 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:15:47 +0000
Subject: [Koha-bugs] [Bug 20497] LibraryThing: always use https instead of
http
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20497
Jonathan Druart changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Passed QA |Pushed to Master
--- Comment #5 from Jonathan Druart ---
Pushed to master for 18.05, thanks to everybody involved!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Mon Apr 2 23:17:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 21:17:36 +0000
Subject: [Koha-bugs] [Bug 20462] Duplicate barcodes in batch item deletion
cause software error if deleting biblio records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20462
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Summary|Duplicate barcodes in batch |Duplicate barcodes in batch
|item deletion cause |item deletion cause
|software error if deleting |software error if deleting
|biblio records. |biblio records
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 22:22:02 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables
with their "alive" cousins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73091|0 |1
is obsolete| |
--- Comment #24 from Benjamin Rokseth ---
Created attachment 73535
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73535&action=edit
Bug 20271: merging delete biblio/items
NOTE: deleteditems/biblio on OAI
not sure how to test this, but the changes should be good enough
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:09 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 22:22:09 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables
with their "alive" cousins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73092|0 |1
is obsolete| |
--- Comment #25 from Benjamin Rokseth ---
Created attachment 73536
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73536&action=edit
Bug 20271 - merge deletedbiblio and -items back - add atomic update
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:14 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 22:22:14 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables
with their "alive" cousins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
Benjamin Rokseth changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73093|0 |1
is obsolete| |
--- Comment #26 from Benjamin Rokseth ---
Created attachment 73537
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73537&action=edit
Bug 20271: fix remaining tests, add checks and report in atomicupdate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:21 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 22:22:21 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables
with their "alive" cousins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #27 from Benjamin Rokseth ---
Created attachment 73538
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73538&action=edit
Bug 20271: update kohastructure.sql
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 22:22:27 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables
with their "alive" cousins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #28 from Benjamin Rokseth ---
Created attachment 73539
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73539&action=edit
Bug 20271: delete biblio and biblio_metadata in one go
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:22:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 22:22:32 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables
with their "alive" cousins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #29 from Benjamin Rokseth ---
Created attachment 73540
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73540&action=edit
Bug 20271: remove comments regarding deleteditems and -biblio*
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 00:24:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 02 Apr 2018 22:24:56 +0000
Subject: [Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables
with their "alive" cousins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271
--- Comment #30 from Benjamin Rokseth ---
rebased against master and added fixes to comments except OAI.
Ere, since you voluntered to add the neccessary fixes to OAI, I leave them to
you ;)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 03:09:45 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 01:09:45 +0000
Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on
circulation screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #65868|0 |1
is obsolete| |
--- Comment #54 from Srdjan Jankovic ---
Created attachment 73541
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73541&action=edit
bug 14803: KOHA.Checkouts js object
* Use javascript to:
- update fines/checkouts info
- show/hide checkouts form and messages
* Created svc/patron/fines
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 03:10:48 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 01:10:48 +0000
Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on
circulation screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 03:10:52 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 01:10:52 +0000
Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on
circulation screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803
Srdjan Jankovic changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #66261|0 |1
is obsolete| |
--- Comment #55 from Srdjan Jankovic ---
Created attachment 73542
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73542&action=edit
Bug 14803 follow-up: outstanding-fees-amount is a class, not id
Multiple outstanding-fees-amount displays on the page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 03:16:58 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 01:16:58 +0000
Subject: [Koha-bugs] [Bug 14803] Rental and fine fees are not updating on
circulation screen
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803
--- Comment #56 from Srdjan Jankovic ---
Rebased, and fines look fine, however I think checkouts list is somewhat broken
on the circ issuing screen. And I believe that's not to do with this patch, but
cannot be 100% sure. Can you please have a look. Thanks
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 05:57:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 03:57:41 +0000
Subject: [Koha-bugs] [Bug 16690] Remote DB installation fails
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Installing DB on remote |Remote DB installation
|server fails without GRANT |fails
|ALL, because wrong |
|permissions are checked |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 05:59:23 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 03:59:23 +0000
Subject: [Koha-bugs] [Bug 16690] Remote DB installation fails
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16690
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |major
--- Comment #10 from M. Tompsett ---
Increased importance, because I really feel the local install of the DB on the
same machine as the web server is not something larger enterprises wish to do.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 06:05:56 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 04:05:56 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73528|0 |1
is obsolete| |
--- Comment #15 from M. Tompsett ---
Created attachment 73543
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73543&action=edit
Bug 20489: Prevent DB user login
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 06:05:59 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 04:05:59 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73529|0 |1
is obsolete| |
--- Comment #16 from M. Tompsett ---
Created attachment 73544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73544&action=edit
Bug 20489: Remove warnings from the interface
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 06:06:44 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 04:06:44 +0000
Subject: [Koha-bugs] [Bug 20489] Prevent DB user login
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489
M. Tompsett changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #17 from M. Tompsett ---
See comment #9 and comment #10 for how I tested.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 07:42:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 05:42:13 +0000
Subject: [Koha-bugs] [Bug 19289] Allow configuration of the fields on the
'Catalog details' form in the acquisition baskets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #30 from Katrin Fischer ---
Hi Jonathan,
Continuing testing:
I've used the SQL from the installer file to create my ACQ framework.
1) Looking at the code, why this change on the ISBD view?
filters => 'ViewPolicy',
options => {
interface => 'intranet',
- frameworkcode => $framework
+ frameworkcode => 'ACQ'
},
2) The input fields are much shorter with the ACQ framework active. Can we
extend them a bit to be a similar size than before? Especially title and series
fields are too short.
3) The descriptions of the fields coming from the default framework are not
very nice because they are out of context without the field description. For
example 440 says title, but it's not clear it's the series title. The MARC
helps a bit.
4) I filled in title and series title and got an error on saving:
Indicator in 440 is empty at /home/vagrant/kohaclone/C4/Biblio.pm line 2294.
:13: parser error : Opening and ending tag mismatch: record line 6 and
datafield
^
:14: parser error : Opening and ending tag mismatch: collection line 2 and
record
^
:15: parser error : Extra content at the end of the document
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 07:52:36 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 05:52:36 +0000
Subject: [Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to
pre-process DB fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--- Comment #13 from Katrin Fischer ---
The tests don't pass for me :(
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Letters/TemplateToolkit.t
t/db_dependent/Letters/TemplateToolkit.t .. ERROR PROCESSING TEMPLATE: plugin
error - Remove_MARC_punctuation: plugin not found at
t/db_dependent/Letters/TemplateToolkit.t line 104.
# Looks like your test exited with 2 before it could output anything.
t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 2 (wstat
512, 0x200)
Failed 18/18 subtests
Test Summary Report
-------------------
t/db_dependent/Letters/TemplateToolkit.t (Wstat: 512 Tests: 0 Failed: 0)
Non-zero exit status: 2
Parse errors: Bad plan. You planned 18 tests but ran 0.
FAIL C4/Letters.pm
OK critic
OK forbidden patterns
OK git manipulation
FAIL pod
empty =head3
*** ERROR:
in file C4/Letters.pm
FAIL pod coverage
POD is missing for add_tt_filters
POD is missing for getletter
OK spelling
OK valid
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:08:16 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 06:08:16 +0000
Subject: [Koha-bugs] [Bug 18725] Process_message_queue sends duplicate
emails if message_queue is not writable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Process_message_queue sends |Process_message_queue sends
|duplicate emails if |duplicate emails if
|message_queue is not |message_queue is not
|writable. |writable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:24:31 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 06:24:31 +0000
Subject: [Koha-bugs] [Bug 20510] New: Remove unused sub TotalPaid from
C4::Stats
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510
Bug ID: 20510
Summary: Remove unused sub TotalPaid from C4::Stats
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: josef.moravec at gmail.com
QA Contact: testopia at bugs.koha-community.org
The sub TotalPaid from module C4::Stats is not used anywhere and it should be
removed.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:27:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 06:27:41 +0000
Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:28:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 06:28:41 +0000
Subject: [Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when
series title ends with semicolon preceded by space.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716
--- Comment #28 from Ere Maijala ---
Katrin, my patch is alternative to the other ones and in my opinion the correct
way to fix this and related encoding issues once and for all. But as I
mentioned it's not complete yet and I'd like to have some feedback before I go
through the trouble of completing it since it's a bit of tedious work.
Kyle's version of url encoding would be fine otherwise, but it will only work
for basic latin characters, and the current practice of shoving unencoded stuff
into url's is simply wrong and only works because browsers are forgiving in the
handling of most characters.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:33:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 06:33:02 +0000
Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 08:33:05 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 06:33:05 +0000
Subject: [Koha-bugs] [Bug 20510] Remove unused sub TotalPaid from C4::Stats
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20510
--- Comment #1 from Josef Moravec ---
Created attachment 73545
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73545&action=edit
Bug 20510: Remove unused sub TotalPaid from C4::Stats
Test plan:
0) Do not apply the patch
1) Run git grep TotalPaid and confirm it is only defined and then used once in
a test
2) Apply the patch
3) git grep TotalPaid should return nothing
4) prove t/db_dependent/Stats.t should be green
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 10:01:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 08:01:26 +0000
Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #56 from Victor Grousset/tuxayo ---
Created attachment 73546
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73546&action=edit
Bug 12310 : Decimal separator issues: some fixes in fines
The main goal is to prevent
- x100 or /100 of the amounts
- decimal part truncation
Fixes Bug 19521 - Partial fine payment is not working with comma decimal
separator
Bonuses:
- Gets rid of the spaces, currency symbols, names (EUR)
There is nothing specific about currency symbols is this patch.
It just removes everything that is not a digit a minus or a separator.
It handles:
- by default comma and dot as decimal separators on the same instance
- dot or comma as thousands separators if choose to use only one of them
as decimal separator. See DigitSeparator syspref.
- minuses, doesn't remove them
== Test plan ==
1. Use a translation of the staff interface if possible.
2. When you pay an existing fine (more details in the next steps if needed).
Check that you can't enter any string except like "XX.XX" (examples in
Annex 1) without having an issue after validation. (x100,
trucation, etc)
3. Apply this patch
4. run ~/src/installer/data/mysql/updatedatabase.pl
5. In the manual invoice (cgi-bin/koha/members/maninvoice.pl)
6. Apply the annex 1 to the "Amount" field
7. When paying a fine (cgi-bin/koha/members/paycollect.pl)
8. Click on "Pay amount" to go to the page to pay all fines
9. Apply the annex 1 to the "Collect from patron" field
10. Click on "Pay" to go to the page to pay fine
11. Apply the annex 1 to the "Collect from patron" field
12. Go to "Create manual credit" (staff://cgi-bin/koha/members/mancredit.pl)
13. Apply the annex 1 to the "Amount" field
14. If you have ideas of stuff to try to find *regressions* from the previous
versions, then try. You might spare librarian tears by finding something
before it's released. (and prevent me from having bounty on my head)
15. Express your happiness. This is important, otherwise the sign off spell
won't
work! The details of expressing your happiness depend on your culture and
habits.
=== Annex 1: Subpart for each concerned page ===
1. Set DecimalSeparators syspref to ",."
2. Input "12,34"
3. Press the "Tab/Tabulation" key. It will unfocus the field and trigger the
conversion. Validating the form does the same but it's a trick to test
more
quickly by not switching to another page.
4. The value should have been converted to 12.34
5. What follows is just a list of examples. They don't have to be tried on each
field.
6. Do the same with "12,34 EUR" and ensure that it's converted to "12,34"
7. Same with "EUR 12.34" -> "12.34"
8. "EUR 12.34?hi lyonthree" -> "12.34"
9. "123 456,7" -> "123456.7"
10. "2" -> "2"
11. "2,0" -> "2.0"
12. "-1'345.95" -> "-1345.95"
13. ",1234" -> ".1234"
14. Set DecimalSeparators syspref to ","
15. Reload the page with the form
16. "1.000" -> "1000"
17. "1.000.000,10" -> "1000000.10"
18. Set DecimalSeparators syspref to "."
19. Reload the page with the form
20. "1,000" -> "1000"
21. "1,000,000.10" -> "1000000.10"
22. Validate the form and check that the final value with the dot was
well handled.
23. Think about Koalas and smile. ???
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 10:16:02 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 08:16:02 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
are planned only for current subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #54 from Josef Moravec ---
(In reply to Alex Arnaud from comment #51)
> (In reply to Josef Moravec from comment #49)
> > (In reply to Alex Arnaud from comment #46)
> > > (In reply to Josef Moravec from comment #44)
> > > > Comment on attachment 70336 [details] [review] [review] [review] [review]
> > > > Bug 17656 - Update irregularities on subscription renewals
> > > >
> > > > Review of attachment 70336 [details] [review] [review] [review] [review]:
> > > > -----------------------------------------------------------------
> > > >
> > > >
> > > > Better to add new subs just to Koha namespace... but I understand it here -
> > > > we do not have all the objects needed for serials management (frequencies
> > > > and number patterns are missing) and calling C4 subs from Koha namespace is
> > > > not good idea... If you are not willing to add needed objects, we could just
> > > > fill a bug for now...
> > >
> > > Don't understand. You mean create Koha::Subscription->GuessEnddate?
> >
> > Yes, that is what I ment.
>
> I see one obstacle. GuessEnddate is used with the subscription's data itself
> in subscription-renew.pl and with data coming from the html form in
> subscription-add.pl. So method calls will be:
>
> $subscription_object->GuessEnddate() in the first case,
> and
> $subscription_object->GuessEnddate($firstacquidate, $periodicity, ...) in
> the second one
>
> Quite tricky no?
Not that tricky I think, you should use it like this:
my $subscription_object = Koha::Subscription->new( { firstacquidate => "....",
periodicity => "....", ... });
my $enddate = $subscription_object->guess_end_date;
the call is always the same. It doesn't matter if it is in the database or not.
If you wan't to save it to db, use ->store, but it is not an obligation.
Also, please consider to change ->irregularities and ->permanent_irregularities
to be getter and setter.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 10:16:41 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 08:16:41 +0000
Subject: [Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern
are planned only for current subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656
--- Comment #55 from Josef Moravec ---
It also will need rebase again, sorry.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 10:54:32 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 08:54:32 +0000
Subject: [Koha-bugs] [Bug 18820] The different parts in the main don't
automatically adjust with the available space
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820
Nicolas Legrand changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73509|0 |1
is obsolete| |
--- Comment #25 from Nicolas Legrand ---
Created attachment 73547
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73547&action=edit
Bug 18820: Main block size now adjust to OpacNavRight like it would for
opacuserlogin
Test plans :
- "beforepatch.png" shows the result you get when OpacNavRight and opacnav are
set to false.
- "opacuserlogin=f_opacnav=f.png" shows the result with the patch and
OpacNavRight and opacnav set to false
- "opacuserlogin=t_opacnav=f.png" shows the result with the patch and
OpacNavRight set to true and opacnav set to false
Applied patch, can confirm it functions as expected.
Signed-off-by: Dilan Johnpull?
Signed-off-by: Katrin Fischer
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 11:53:15 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 09:53:15 +0000
Subject: [Koha-bugs] [Bug 12310] Accept different monetary formats as input
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73215|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:37:27 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 10:37:27 +0000
Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #70735|0 |1
is obsolete| |
Attachment #70736|0 |1
is obsolete| |
--- Comment #13 from Nick Clemens ---
Created attachment 73548
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73548&action=edit
Bug 9634: Allow for combining same paraneters in SQL reports
This patch combines report paramters with the same name and data type
(authorised value)
This presereves the past ability to provide all parameters as
'sql_params' in order to preserve existing public report links
To test:
1 - Create a report that takes multiple parameters, e.g.:
SELECT <> AS one, <> AS two, <> as three,
<> as four, <> as five
2 - Run this report, note you are asked for five parameters
3 - Apply patch
4 - Update database
5 - Run report, note you are asked for three params
6 - Verify the results reflect the supplied parameters
7 - Export the report and verify results
8 - Alter the URL and provide 5 params as sql_params and no param_name
variables i.e.
http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run+this+report&sql_params=Banana&sql_params=CPL&sql_params=0&sql_params=Orange&sql_params=LPL
9 - Verify results come out as expected
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:39:26 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 10:39:26 +0000
Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634
--- Comment #14 from Nick Clemens ---
Needs to be rebased on bug 20052 - adding get_prepped_report method to
Koha/Report.pm and covering with tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:42:13 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 10:42:13 +0000
Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634
--- Comment #15 from Nick Clemens ---
(In reply to Nick Clemens from comment #14)
> Needs to be rebased on bug 20052 - adding get_prepped_report method to
> Koha/Report.pm and covering with tests
Nvm, I didn't add this method - will be a future enh, but out of scope here
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:43:38 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 10:43:38 +0000
Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Tue Apr 3 12:43:42 2018
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 03 Apr 2018 10:43:42 +0000
Subject: [Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #73548|0 |1
is obsolete| |
--- Comment #16 from Nick Clemens ---
Created attachment 73549
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73549&action=edit
Bug 9634: Allow for combining same paraneters in SQL reports
This patch combines report paramters with the same name and data type
(authorised value)
This presereves the past ability to provide all parameters as
'sql_params' in order to preserve existing public report links
To test:
1 - Create a report that takes multiple parameters, e.g.:
SELECT <> AS one, <> AS two, < |