[Koha-bugs] [Bug 18677] issue_id is not added to accountlines for lost item fees

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18677

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Comment on attachment 74022
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74022
Bug 18677: issue_id is not added to accountlines for lost item fees

Review of attachment 74022:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18677&attachment=74022)
-----------------------------------------------------------------

::: t/db_dependent/Accounts.t
@@ -528,2 @@
>      $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'L' });
> -    $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber1, accounttype => 'PF' });

This seems like an accidental deletion.

@@ -599,3 @@
>      $lostfine = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'L' });
>      $procfee  = Koha::Account::Lines->find({ borrowernumber => $cli_borrowernumber, itemnumber => $cli_itemnumber2, accounttype => 'PF' });
> -    is( $lostfine->amount, "6.120000" , "Lost fine equals replacementcost when pref on and default set");

This seems like an accidental deletion.
Also, I prefer the more format agnostic +0 forced typecast.

-- 
You are receiving this mail because:
You are watching all bug changes.