[Koha-bugs] [Bug 22046] New: Simplify C4::Matcher->get_matches

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22046

            Bug ID: 22046
           Summary: Simplify C4::Matcher->get_matches
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

Currently we process things separately for ES and Zebra

For ES we get the results:
get the biblionumber field using GetMarcFromKohaField
extract the biblionumber from the record, save as id
store the record in a hash like:
$matches->{$id}->{record} = $matched

For zebra:
we use the xml record from zebra $matched as the id
store it in a hash like
$matches->{$id}->{record} = $matched
$id and $matched are both the full xml of the record

For both:
We then convert the record into a Marc::Record
Call C4::Biblio::TransformMarcToKoha - this gets all the koha fields
Use only the biblionumber to return results


It would be simpler to follow the ES pattern for both and avoid the
TranformMarcToKoha call

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.