[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #22)
> QA tools pass.
> 
> Some first notes from reading the code:
> 
> 1)
> installer/data/mysql/en/marcflavour/marc21/mandatory/
> marc21_framework_DEFAULT.sql
> 
> It looks like the code makes some assumptions about
> biblioitems.publicationyear. There is something you will not like about this
> field: It's only used by UNIMARC by default. MARC21 installations safe that
> information to biblio.copyrightdate. Both use cases need to be supported.

It is the current behaviour, neworderempty.tt displays
biblioitems.publicationyear.
If it is an existing bug it needs to be fixed on a separate bug report.

> 2) Only en and fr-FR installers are changed?

Yes, what I wrote in the first commit message "Other frameworks will be updated
before to be pushed, to avoid unecessary rebases"
Same changes will be copied/pasted to other installer files before push.


> 3) Atomicupdate doesn't include changes for creating the ACQ framework.

ACQ framework was added by bug 3841 for new installation. I do not think we
should deal with existing installation (what about those having already the
framework?)

> 3) koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
> A lot of FIXMEs in this code?

It is to highlight the fact that the default values defined in ACQ will not be
taken into account. I can remove it if you think it is confusing.

-- 
You are receiving this mail because:
You are watching all bug changes.