[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> ---
Hi Alex,

Here are a few things you need to change:
1. Remove all occurences of onboardingrequired, it's stored in a bad place,
it's badly used and you don't need it (explanation below:)
  a. userflags contain name and description of user permissions, it's not a
place to store arbitrary flags (despite its name)
  b. if we decide to skip the onboarding tool, the first time the DB user logs
in they are not redirected to the onboarding tool because onboardingrequired's
value is 0 (it's set to 1 only at this moment), so the user need to reload the
page to be redirected to the onboarding tool. Moreover onboardingrequired is
still equals to 1 after the onboarding process
  c. you don't need it because you have another check that is (IMO) enough : if
there is at least one user that have permission superlibrarian, it means that
someone is gone through the onboarding process (or someone has manually
configured Koha, which means the onboarding process is not needed)

2. check_if_patrons_have_flags is not needed: you can replace it by
Koha::Patrons->search({flags => { '!=' => undef }}) (and anyway the previous
check is enough IMO, so it could be completely removed)

3. I think that changes in installer/onboarding.pl are not needed:
  a. you changed the redirection to installer/install.pl to mainpage.pl, which
then redirects to installer/install.pl, so it adds one more redirection for the
same result
  b. there seems to be no scenario where $op == 'skip', can you confirm that ?

Now that's a personal opinion but I believe that a warning message would be
better than an automatic redirect. There might be some cases where I don't want
to go through the onboarding process at all and this redirect could become
annoying

-- 
You are receiving this mail because:
You are watching all bug changes.