[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jan 17 08:59:30 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #48 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 70430
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70430
Bug 17656 - Fix QA comments  - Make day and month names translatable,  - Update
unit tests,  - Fix a typo in C4/Serials.pm (GessEndDate),  - rename subtype
subroutine to lengthtype  - DB Change: add changes in kohastructure.sql and
Bug_17656-add-permanent

Review of attachment 70430:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17656&attachment=70430)
-----------------------------------------------------------------

:::
koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc
@@ +4,2 @@
>  </em></p>
>  [% daily_choice = [ {name => 'monday', desc => 'Monday', value => 1}, {name => 'tuesday', desc => 'Tuesday', value => 2}, {name => 'wednesday', desc => 'Wednesday', value => 3}, {name => 'thursday', desc => 'Thursday', value => 4}, {name => 'friday', desc => 'Friday', value => 5}, {name => 'saturday', desc => 'Saturday', value => 6}, {name => 'sunday', desc => 'Sunday', value => 7} ] %]

Looks like you do not need the "desc" values here now, is that true?

:::
koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_monthly_choice.inc
@@ +4,2 @@
>  </em></p>
>  [% monthly_choice = [ {name => 'january', desc => 'January', value => 1}, {name => 'february', desc => 'February', value => 2}, {name => 'march', desc => 'March', value => 3}, {name => 'april', desc => 'April', value => 4}, {name => 'may', desc => 'May', value => 5}, {name => 'june', desc => 'June', value => 6}, {name => 'july', desc => 'July', value => 7}, {name => 'august', desc => 'August', value => 8}, {name => 'september', desc => 'September', value => 9}, {name => 'october', desc => 'October', value => 10}, {name => 'november', desc => 'November', value => 11}, {name => 'december', desc => 'December', value =>12} ] %]

Looks like you do not need the "desc" values here now, is that true?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list