[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Katrin Fischer from comment #5)
> If you think my request is so silly, maybe you should epxlain it anyway.

Sure :)
As mentioned in comment1 Owen got an error. And you and I did not (see also
commit message). The error comes from a missing module; might be a devbox
config issue for Owen.
But the script itself calls C4::Letters but does not load it. So it depends on
implicit loading by one of the other modules or deeper down the chain. We
should not assume it will be loaded. If one day Letters is removed elsewhere,
the script does not compile. So what does this oneliner do: add the missing
module for that reason. Which is indeed stated ultra compact in the commit msg.
No test plan needed. Back to SO.

-- 
You are receiving this mail because:
You are watching all bug changes.