[Koha-bugs] [Bug 11943] Koha::Virtualshelfshare duplicates rows for the same list

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11943

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Prevent double accepts in   |Koha::Virtualshelfshare
                   |Koha::Virtualshelfshare     |duplicates rows for the
                   |                            |same list

--- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Jonathan Druart from comment #19)

> The user click on a link and... nothing happens?

No, that is a misunderstanding. He clicks on the link and he is redirected to
view this shared list. The behavior interface-wise is exactly the same with and
without this patch. The only difference this bugfix makes is that the shared is
not duplicated.

> Should not we display a message to explain that the list is already shared?

I thought about it too. Strictly speaking, this bugfix can still be pushed
without string changes. And adding a message could be considered as an
enhancement for a new report. Opened bug 20753 for it.

In view of the above I am renaming/narrowing down the bug title. I will also
look at the commit message in that sense.

-- 
You are receiving this mail because:
You are watching all bug changes.