[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893

--- Comment #190 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Comment on attachment 81284
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81284
Bug 19893: Add pods, remove syspref, add tests for serialization format

Review of attachment 81284:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19893&attachment=81284)
-----------------------------------------------------------------

::: Koha/SearchEngine/Elasticsearch.pm
@@ +310,5 @@
>      return $self->_sort_fields_accessor();
>  }
>  
> +=head2 _process_mappings($mappings, $data, $record_document)
> +

Missing example usage

@@ +480,4 @@
>      return \@record_documents;
>  }
>  
> +=head2 _field_mappings($facet, $suggestible, $sort, $target_name, $target_type, $range)

This POD is missing example usage:

my @mappings = $self->_field_mappings($facet, $suggestible, $sort,
$target_name, $target_type, $range)

This will be somewhat useful to know what the function returns.

-- 
You are receiving this mail because:
You are watching all bug changes.