[Koha-bugs] [Bug 21079] Unify metadata schema across backends

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21079

--- Comment #11 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #10)
> This adds Try::Tiny to the updatedatabase, I think this is okay and there
> seems to be agreement polling the QA team.

There will have been some logic behind taking this approach, though I can't
remember what it was now. Investigating, the common approach in the DBI
community appears to be to "eval" the contents of what I've got inside my "try"
block, then test for "$@" to determine an error. I'm happy to switch to that
approach if it would make people happier?

> The AutoCommit and RaiseError flags need to be reset after the attempt.

Good spot! Thanks.

> It appears the version is set even if the update fails, is this intentional?

Nope, an error, thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.