[Koha-bugs] [Bug 21787] New: GetHardDueDate.t has a silly test

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21787

            Bug ID: 21787
           Summary: GetHardDueDate.t has a silly test
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: ASSIGNED
          Severity: normal
          Priority: P5 - low
         Component: Test Suite
          Assignee: jonathan.druart at bugs.koha-community.org
          Reporter: jonathan.druart at bugs.koha-community.org
        QA Contact: testopia at bugs.koha-community.org

When a new column is added to the issuingrules table, one of the test from
GetHardDueDate.t is failing. As it does not test anything useful we should
remove it instead of fixing it.

See
commit face7819393b17a3fb4bab6f8c2ff26cc9a450d8
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Thu Nov 8 11:15:04 2018 -0300

    Bug 12365: Fix GetHardDueDate.t test

diff --git a/t/db_dependent/Circulation/GetHardDueDate.t
b/t/db_dependent/Circulation/GetHardDueDate.t
index a50e06b..bfb624d 100644
--- a/t/db_dependent/Circulation/GetHardDueDate.t
+++ b/t/db_dependent/Circulation/GetHardDueDate.t
@@ -148,6 +148,7 @@ my $sampleissuingrule1 = {
     no_auto_renewal_after_hard_limit => undef,
     suspension_chargeperiod => 1,
     holds_per_day => undef,
+    note => undef,
 };
 my $sampleissuingrule2 = {
     branchcode         => $samplebranch2->{branchcode},

commit 1ce984ea1dd12391d39507cd21c4d3813eab9754
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Wed Oct 24 17:08:05 2018 -0300

    Bug 15486: Fix failing test in GetHardDueDate.t

    Signed-off-by: Nick Clemens <nick at bywatersolutions.com>

diff --git a/t/db_dependent/Circulation/GetHardDueDate.t
b/t/db_dependent/Circulation/GetHardDueDate.t
index b39c32c..a50e06b 100644
--- a/t/db_dependent/Circulation/GetHardDueDate.t
+++ b/t/db_dependent/Circulation/GetHardDueDate.t
@@ -147,6 +147,7 @@ my $sampleissuingrule1 = {
     no_auto_renewal_after => undef,
     no_auto_renewal_after_hard_limit => undef,
     suspension_chargeperiod => 1,
+    holds_per_day => undef,
 };
 my $sampleissuingrule2 = {
     branchcode         => $samplebranch2->{branchcode},

commit f32cf00e132c747a008163e5f40810d4a47bff58
Author: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Date:   Mon Apr 9 17:33:37 2018 -0300

    Bug 19804: Fix test in GetHardDueDate.t

    Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

diff --git a/t/db_dependent/Circulation/GetHardDueDate.t
b/t/db_dependent/Circulation/GetHardDueDate.t
index b5a571b..b39c32c 100644
--- a/t/db_dependent/Circulation/GetHardDueDate.t
+++ b/t/db_dependent/Circulation/GetHardDueDate.t
@@ -146,6 +146,7 @@ my $sampleissuingrule1 = {
     article_requests   => 'yes',
     no_auto_renewal_after => undef,
     no_auto_renewal_after_hard_limit => undef,
+    suspension_chargeperiod => 1,
 };
 my $sampleissuingrule2 = {
     branchcode         => $samplebranch2->{branchcode},

-- 
You are receiving this mail because:
You are watching all bug changes.