[Koha-bugs] [Bug 21745] Checkin of withdrawn items marked successful via SIP2 when BlockReturnOfWithdrawnItems is enabled

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Nov 19 13:56:22 CET 2018


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21745

--- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
The intention in the code is unclear. we copy all of messages to
error_messages, but only ever are interested in one value in it. Then in ILS do
the weird unexplained test that this is the only message. Its unclear whats
going on here, and that what the case is. I dont think this is maintainable
code. Could we set a flag rather than flinging a hashref around and set it
using clearer criteria?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list