[Koha-bugs] [Bug 21876] Untracked changes prevent building

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21876

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 82620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82620&action=edit
Bug 21876: tweak the build script

While trying to build following the instructions on the wiki,
error after error was encountered, and frustration rose.
Eventually, tcohen mentioned untracked files. So, all untracked
files were purposefully deleted all, and then building succeeded
again.

To this end, the build script wa tweaked.

1) Sorry, a bunch of perlcritic things to get it
   perlcritic -2 clear were done. :)

Proof:
perlcritic -1 debian/build-git-snapshot
-- fear the long scrolly output
apply the patch
repeat
-- much shorter, and who cares about the print return value!
perlcritic -2 debian/build-git-snapshot
-- OK. YAY!

2) everything_is_committed was broken. It would always
   return 1 and keep going.

Proof:
touch foobar.
add a blank line to Koha.pm
now try to build. It will spend minutes and die miserably at the end.

To address this, it was tweaked to check for two cases:
uncommitted and untracked. You can test this with a combination
of touch foobar and blank line to Koha.pm to see.

3) While not a huge issue, the version should be better determined
   rather than hard coded as 16.06~git. Logic was added to
   better determine something based on Koha.pm through grep'ing,
   so as to not need PERL5LIB set.

Proof:
Try checking out 17.11.x
apply this patch (hopefully it does)
try to build without a -v parameter.
-- it should generate 17.11~git
Feel free to repeat with 18.05 and master
they should generate 18.05~git and 18.06~git

As always run the qa test tools. ;)
Oh wait, they don't run unless you rename this to a .pl file.
I guess that's another bug. And if you do rename to test,
it should only complain about Robin's last name.

-- 
You are receiving this mail because:
You are watching all bug changes.