[Koha-bugs] [Bug 20548] Remove copyright clearance workflow from staff created ILL requests

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |nick at bywatersolutions.com

--- Comment #11 from Nick Clemens <nick at bywatersolutions.com> ---
please add unit tests to cover this change. After applying:

vagrant at kohadevbox:kohaclone(master)$ prove
/home/vagrant/kohaclone/t/db_dependent/Illrequests.t
/home/vagrant/kohaclone/t/db_dependent/Illrequests.t .. 4/11 Use of
uninitialized value $backend_dir in join or string at
/home/vagrant/kohaclone/Koha/Illrequest.pm line 665.

    #   Failed test 'Backend create: copyright clearance.'
    #   at /home/vagrant/kohaclone/t/db_dependent/Illrequests.t line 412.
    #     Structures begin differing at:
    #          $got->{value} = Does not exist
    #     $expected->{value} = HASH(0x971d1e0)

    #   Failed test 'Backend create: arbitrary stage.'
    #   at /home/vagrant/kohaclone/t/db_dependent/Illrequests.t line 426.
    #     Structures begin differing at:
    #          $got->{stage} = 'commit'
    #     $expected->{stage} = 'bar'
Use of uninitialized value $stage in string eq at
/home/vagrant/kohaclone/Koha/Illrequest.pm line 630.
Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/Koha/Illrequest.pm line 666.
Use of uninitialized value in concatenation (.) or string at
/home/vagrant/kohaclone/Koha/Illrequest.pm line 668.

    #   Failed test 'Backend create: arbitrary stage, permitted.'
    #   at /home/vagrant/kohaclone/t/db_dependent/Illrequests.t line 444.
    #     Structures begin differing at:
    #          $got->{permitted} = Does not exist
    #     $expected->{permitted} = '1'
    # Looks like you failed 3 tests of 18.

#   Failed test 'Backend core methods'
#   at /home/vagrant/kohaclone/t/db_dependent/Illrequests.t line 534.
# Looks like you failed 1 test of 11.
/home/vagrant/kohaclone/t/db_dependent/Illrequests.t .. Dubious, test returned
1 (wstat 256, 0x100)
Failed 1/11 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.