[Koha-bugs] [Bug 22739] Self check in module JS breaks if SelfCheckInTimeout is unset
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Apr 24 17:19:30 CEST 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22739
Kyle M Hall <kyle at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88635|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 88636
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88636&action=edit
Bug 22739: Test SelfCheckInTimeout <> 0, not just defined
On sci-main.pl the preference value is tested for 'defined'. This patch
tests it is different than empty string too. This was causing a
JavaScript syntax error, that made it display a wrong message.
To test:
1 - Blank the syspref SelfCheckInTimeout
2 - Attempt to checkin something via sci
=> FAIL: The 'Your request included no check-ins.' message is printed.
3 - Apply this patch, reload the sci-main.pl page
4 - Attempt to checkin something via sci
=> SUCCESS: The UI correctly stacks the scanned barcodes
5 - Sign off :-D
Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list