[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253

--- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Tomas has corrected the config on the koha-testing-docker side to silence the
warnings for us during testing now :).

However, I asked Colin to take a look at these patches one last time whilst
it's on the edge of being pushed again.

He noted:
1) The followup actually breaks the SIPServer (simple fix, we're missing export
from the newly introduced SIP::Logger.pm)
2) It looks like we're still initialising syslogd so there's a somewhat erratic
behaviour as to where log messages are being directed.
3) It's a bit misleading having a 'syslog' call that doesn't actually go to
syslog.. I personally would rather go through the code in a followup and
clarify that method name to not match one that many people know and assume goes
to the system syslogs ;)
4) The new format is great, but it's also considerably different and so any
monitoring scripts already out there in the wild will need to be completely
re-written.
5) Net::Server has a bunch of internal logging which could be passed a Log4Perl
logger but we're not doing that here so that logging is not being included
6) You could configure logging via the sipserver config file before.. and it
looks like you still can, but that's very confusing

Colins working on a followup for me to correct the export and is quickly
investigating the config side to see if we can reduce some of the impacts
above.

I'm keen to see this continue working it way through though so please don't
read all the above as a blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.