[Koha-bugs] [Bug 22786] Can create new funds for locked budgets
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue Aug 27 04:17:59 CEST 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22786
Hayley Mapley <hayleymapley at catalyst.net.nz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #92479|0 |1
is obsolete| |
--- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
Created attachment 92480
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92480&action=edit
Bug 22786: Prevent fund creation for locked budgets
If a budget is locked, there is a "New fund for $budget" link that is
disabled but clickable.
We should ensure that the link is not clickable and prevent it at
controller level (do we need it at module level, ie.
Koha::Acquisition::Fund->store?)
Test plan:
- Create a budget, lock it
- Go to /cgi-bin/koha/admin/aqbudgetperiods.pl
- Click on the name of the budget you just created
=> The "New > New fund for $budget_name" button should be disabled
- Click it anyway
=> Without this patch the form to add a new fund is displayed
=> With this patch applied nothing happens
- Hit /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=XXX
With XXX the budget's id
=> Without this patch the form is displayed
=> With this patch applied you get a message:
"The budget is locked, fund creation is not possible."
And you are not able to create a new fund
QA notes:
1. See description
2. The add_validate op can still be forced, let trust librarians with
administration permissions for now.
Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list