[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Dec 13 15:25:22 CET 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94526|0 |1
is obsolete| |
Attachment #94527|0 |1
is obsolete| |
Attachment #94528|0 |1
is obsolete| |
Attachment #94556|0 |1
is obsolete| |
Attachment #94557|0 |1
is obsolete| |
Attachment #94558|0 |1
is obsolete| |
--- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 96247
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96247&action=edit
Bug 23233: AllowItemsOnHoldCheckout is misnamed and does not indicate it is for
SIP-based checkouts only
The system preference AllowItemsOnHoldCheckout only affects SIP based
checkouts. I believe we should rename it AllowItemsOnHoldCheckoutSIP so it
matches AllowItemsOnHoldCheckoutSCO. We should also update the description as
well.
As far as I know AllowItemsOnHoldCheckout has never affected anything except
SIP traffic. That does not preclude the addition of another
AllowItemsOnHoldCheckout syspref that would affect the staff interface, but
that would be an enhancement and is outside the scope of this bug report.
Test Plan:
1) Test AllowItemsOnHoldCheckout via SIP
2) Apply this patch
3) Test AllowItemsOnHoldCheckoutSIP via SIP
4) Note there is no difference!
5) Note the syspref description has been update to mention SIP
Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list