[Koha-bugs] [Bug 22193] Mana - share comments about reports

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Feb 2 10:15:02 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22193

--- Comment #6 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 84650
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84650
Bug 22193: Code refactoring/improvments

Review of attachment 84650:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22193&attachment=84650)
-----------------------------------------------------------------

::: Koha/SharedContent.pm
@@ +141,5 @@
> +sub get_entity_comments {
> +    my ($resource, $id) = @_;
> +
> +    unless ($id) {
> +        return [];

I would like to see here an implicit undef, so just 'return;'

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list