[Koha-bugs] [Bug 7088] Cannot renew items on hold even with override

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #28 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
(In reply to Katrin Fischer from comment #24)

> 4) I'd also have expected the renewal to be locked initially and the
> checkbox to unlock it. Reasoning: Renewing an item with a hold should always
> be an exception. The way it's now a "renew all" checked on top will also
> check the "on hold" ones which might be easily missed. We could relabel the
> checkbox and use it for both: Allow override of renewal restrictions?

Hi Katrin

I've just attached a patch that addresses this. The on hold items now behave in
the same way as items that have reached their renewal limit, they are not
selectable until the checkbox is checked. Speaking of which, I've re-labelled
the checkbox from "Override renewal limit" to "Override renewal restrictions"
as per you suggestion. So now, "Select all" and "Renew all" will not act upon
the on hold items unless the override is checked.

I'm not familiar with the process when a UI label is changed, is there any
maintenance work that needs to happen so translations don't break?

>3) I don't understand the new entry form for the hold due date. My feeling is that we should use the one existing already for entering the new due date for any override. Having 2 forms seems confusing.

We discussed this internally at great length when speccing out the development.
It was felt by both our customers and us that having two date selection boxes
made most sense since it's conceivable that the user may wish to have different
due dates for on hold items and non-on hold items. The fact that the "On hold
due date" date input doesn't appear until an on hold item is checked for
renewal (if you're not seeing this behaviour, rebuild your CSS) reinforces it's
purpose.

I'm going to set this back to Signed off as I believe it's ready for another QA
run :) Thanks for your feedback!

-- 
You are receiving this mail because:
You are watching all bug changes.