[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 68249
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68249
Patch for misc/stage_file.pl script to provide for MARC modification template
support.

Review of attachment 68249:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19164&attachment=68249)
-----------------------------------------------------------------

I don't believe this patch as a whole is signed off yet, but I've done an
initial QA run on it anyway. Please see the code comments.

::: misc/stage_file.pl
@@ +74,5 @@
> +       if($this_template->{'name'} eq $marc_mod_template) {
> +	   $marc_mod_template_id = $this_template->{'template_id'};
> +	   last;
> +       }
> +       if($this_template->{'name'} eq $marc_mod_template) {

This block can never be reached as the code stands...

@@ +149,5 @@
> +        BatchStageMarcRecords(
> +	    $record_type, $params->{encoding}, 
> +	    $marc_records, $params->{input_file}, 
> +	    $params->{'marc_mod_template_id'}, 
> +	    $params->{batch_comment}, '', 

Minor whitespace error introductions in the above four lines.

-- 
You are receiving this mail because:
You are watching all bug changes.