[Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872

--- Comment #37 from David Gustafsson <glasklas at gmail.com> ---
(In reply to Ere Maijala from comment #33)
> David Gustafsson, what do you think about the latest one?

Hello! Sorry about the late reply. I have been a little bit buried in non-Koha
related work the last few months. I think it looks good. I first found it a
little bit hardcore with a low-level fork implementation, but since there is no
need to spawn and wait for workers more than once when using several long lived
threads equal to the concurrency level, the code is simple enough to
understand. 

If I may make a suggestion I think starting the slice index on 0 instead of 1
and assign index using "$slice_index = $proc - 1" in the process dispatch loop
would get rid of the "$slice_modulo = 0 if ($slice_modulo == $slice_count);"
condition in the iterator.

I think I will be able to test the patch tomorrow and can provide a patch for
this change.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.