[Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #64 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Andrew, getting started with this one.

1) QA script: 
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/ill/log/status_change.tt
   FAIL   filters
                missing_filter at line 10 (from "[% display_before
%]")
   FAIL   forbidden patterns
                forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 5)
                forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 13)
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   FAIL   valid_template
                : filter not found

2) I am wondering a bit about the date operations in the Logger module,
get_epoch  especially.

3) This doesn't need to be part of the installer outside the sysprefs.sql file. 
Files ill_logging_pref.txt and ill_logging_pref.sql can be removed.
sysprefs.sql will always be run during installation, installing all prefs. 

4) I wonder if we should set the logger to off by default for updated
installations and allow people to turn it on themselves.

5) For translations it's always nice to be specific. 'request' is a very
general term that appears in multiple contexts. I am suggesting 'Display
request log' > "ILL request log" (it being a button kind of transports the
display part :) )

6) In the log viewer, could we make the visibility of the ILL parts depend on
the system preference? I think this would make it a little less confusing for
people without the ILL module activated.

7) Just using this for a teaching moment :) <b>Status changed </b> will be
turned into Status changed with a space at the end on translations, which will
do nothing in this case, but can be a bit tedious. In other cases forgetting
the space will be bad for display, so translators have to always look for
those.

8) Tests are failing for me:
kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove
t/db_dependent/Illrequests.t
t/db_dependent/Illrequests.t .. 1/11 
    #   Failed test 'Status_alias getter works.'
    #   at t/db_dependent/Illrequests.t line 66.
    #          got: undef
    #     expected: 'gCXbRHL2vgImhl1lv0AsoWfYj15fmIgBiFT9i_fmMnIzh1laXf'
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
    # Looks like you failed 1 test of 25.
t/db_dependent/Illrequests.t .. 3/11 
#   Failed test 'Basic object tests'
#   at t/db_dependent/Illrequests.t line 117.
t/db_dependent/Illrequests.t .. 5/11 no query in themelanguage at
/home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
t/db_dependent/Illrequests.t .. 7/11 no query in themelanguage at
/home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
t/db_dependent/Illrequests.t .. 10/11 no query in themelanguage at
/home/vagrant/kohaclone/C4/Templates.pm line 266.
no query in themelanguage at /home/vagrant/kohaclone/C4/Templates.pm line 266.
# Looks like you failed 1 test of 11.
t/db_dependent/Illrequests.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/11 subtests 

Test Summary Report
-------------------
t/db_dependent/Illrequests.t (Wstat: 256 Tests: 11 Failed: 1)
  Failed test:  3
  Non-zero exit status: 1

-- 
You are receiving this mail because:
You are watching all bug changes.