[Koha-bugs] [Bug 22336] New: Better conversion from illrequestattributes to HTML attributes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22336

            Bug ID: 22336
           Summary: Better conversion from illrequestattributes to HTML
                    attributes
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: ILL
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: magnus at libriotech.no
  Target Milestone: ---

The illrequestattributes table can hold any kind of attribute for an ILL
request. Which attributes are displayed in the ILL detail view (both OPAC and
Intranet) are determined by the per backend "metadata" sub, which can also
assign labels to each attribute. So if you have an attribute called
"lending_library" with a value of "LibraryX", you can call it "Lending library"
and make it display as:

  Lending library: LibraryX

To make things stylable the label of the attribute is turned into an HTML ID or
class. In the OPAC:

  <div class="requestattr-Lending library"><span class="label">Lending
library:</span>LibraryX</div>

In the staff client:

  <li class="requestmeta-Lending_library"><span class="label">Lending
library:</span>LibraryX</li>

We should be a bit more careful about how we use the labels in HTML attributes:
- Avoid spaces and other illegal characters (ISBN/ISSN is currently turned into
"requestmeta-ISBN/ISSN")
- Maybe lowercase it? 
- Be consistent between OPAC and staff client

Perhaps it would be an alternative to just use the attribute name from the
database? ("requestmeta-lending_library" in this example)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.